[OpenSIPS-Devel] [OpenSIPS/opensips] aa7f3d: uac: the RR dependency is not conditional on resto...

[Bogdan Andrei IANCU]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: aa7f3da830e1d1d297a7d48957fd845847606869
      https://github.com/OpenSIPS/opensips/commit/aa7f3da830e1d1d297a7d48957fd845847606869
  Author: Denys Ivonenko <denys.i at didww.com>
  Date:   2026-09-03 (Thu, 03 Sep 2026)

  Changed paths:
    M modules/uac/README.md

  Log Message:
  -----------
  uac: the RR dependency is not conditional on restore_mode [skip ci]

The Dependencies section says RR is needed "only if restore mode for
FROM URI is set to auto".  It is also needed, unconditionally, whenever
uac_auth() appears in the script: mod_init() takes that branch on
is_script_func_used("uac_auth", -1) and requires append_fromtag there
without testing restore_mode (uac.c:308-326).

The section also never mentions append_fromtag, which both paths
require.  Its default is 1, but etc/opensips.cfg - the file installed
as /etc/opensips/opensips.cfg - and every script under
examples/templates/ set it to 0, so the common starting point fails:

    ERROR:uac:mod_init: 'append_fromtag' RR param is not enabled!
                        - required by uac_auth() restore mode
    ERROR:core:main: failed to initialize modules!

while opensips -C on the same file reports "config file ok".

The reason the dependency exists is taken from #773, where it was
established and then closed as invalid.  This puts it in the
documentation.  No behaviour change.


  Commit: 753818ad943db6568fbd4681fc6354e03bcb7672
      https://github.com/OpenSIPS/opensips/commit/753818ad943db6568fbd4681fc6354e03bcb7672
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2026-09-04 (Fri, 04 Sep 2026)

  Changed paths:
    M modules/uac/README.md

  Log Message:
  -----------
  Merge pull request #4239 from denys-i-didww/docs/uac-rr-dependency-is-not-conditional

uac: the RR dependency is not conditional on restore_mode


Compare: https://github.com/OpenSIPS/opensips/compare/33f6bdf2e221...753818ad943d

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications