[OpenSIPS-Devel] [OpenSIPS/opensips] 4a58c0: stun: Fix regression in 'use_listeners_as_primary'...

[Liviu Chircu]

  Branch: refs/heads/3.5
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4a58c0a0a6047f5f0688615dc5778a7df08bbf79
      https://github.com/OpenSIPS/opensips/commit/4a58c0a0a6047f5f0688615dc5778a7df08bbf79
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2025-09-17 (Wed, 17 Sep 2025)

  Changed paths:
    M modules/stun/stun.c
    M modules/stun/stun.h

  Log Message:
  -----------
  stun: Fix regression in 'use_listeners_as_primary' feature

In commit 8e6000d5f0d8d, it was missed that FD_SET(fd_x...) calls are
idempotent, while reactor_add_reader(fd_x...) calls are not. So when you
perform them multiple times (which the 'use_listeners_as_primary'
feature MAY do), OpenSIPS startup would now ERROR and abort.

Many thanks to Bernard Buitenhuis for an accurate report and sponsoring
the fix!

(cherry picked from commit 561a15515fd1bfac942c34bdbb8d9ce3c0c3ea3a)



To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications