[OpenSIPS-Devel] proto_ipsec, Refcounters and recent (breaking) changes

[Larry Laffer]

Hi,

First of all thank you, for all thank you for your effort on making
OpenSIPS an exciting project. I find especially the recent, IMS related
extensions exciting. I really appreciate the approach of using
standard/common modules for the IMS use-case rather than customized modules
as in other projects.

I would have loved to join you in Amsterdam for the Summit, but it did not
work out this time for various reasons. I hope you are enjoying the event,
I am following on YouTube.

I've found a few topics with the "proto_ipsec" module:

1) The Refcounter of the "ipsec_ctx" is occasionally incorrect. I've
noticed, that during the registration process it is finally at a counter of
"1", which seems correct to me. However, since we save multiple entries in
the location-DB (for the IMPI and the associated URI's). the usrloc
callbacks are executed per location entry and each time the refcounter is
decreased, finally ending in an invalid state. If the data is overwritten
(since the shmem is free'd, this leads occasionally to a crash).
I've temporarily fixed this in my config by only storing one entry in the
location/usrloc DB (and storing the associated URIs in a cache), in which
case the ref-counter counts correctly.
(also created an issue here:
https://github.com/OpenSIPS/opensips/issues/3657)

2) Recent changes break the proto_ipsec module?!??

Each time, I attempt a call to a subscriber (Network => UE), the inbound
call fails with the following warning:

May 28 17:57:04 [54] NOTICE:[tiPeQZeN3tfdVrNtNvWXgN37] Relaying INVITE to
sip:10.46.0.206:55805/<null> (Socket tcp:10.0.0.6:6100)
May 28 17:57:04 [54] WARNING:core:get_send_socket: not listening on the
requested socket, no fork mode?
May 28 17:57:04 [54] CRITICAL:core:su_setport: unknown address family 0

This only happens with latest master, If I go back to the version as of
early may, everything is fine - in between there was the commit regarding
the new "sockets_mgm" module. Maybe that broke something (@Razvan)?

Thanks,
Larry

P.S.: Any update on my PR https://github.com/OpenSIPS/opensips/pull/3608?
It's open since march... - no issues, just a small ping!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20250528/29444d42/attachment.html>