[OpenSIPS-Devel] [OpenSIPS/opensips] db782c: dispatcher: Fix rare crash with 'pvar_algo_pattern...

[Liviu Chircu]

  Branch: refs/heads/3.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: db782c477ec42703486c963ade65473915e9b205
      https://github.com/OpenSIPS/opensips/commit/db782c477ec42703486c963ade65473915e9b205
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2025-05-13 (Tue, 13 May 2025)

  Changed paths:
    M modules/dispatcher/dispatch.c
    M modules/dispatcher/dispatch.h
    M modules/statistics/statistics.c

  Log Message:
  -----------
  dispatcher: Fix rare crash with 'pvar_algo_pattern' (part 2)

Commit fe1a50d251 was a quick-fix attempt, but the race condition was
still there, and continuing to cause rare crashes during 'ds_reload' if
using the 'pvar_algo_pattern' feature.

Long story short: pv_get_spec_value() on SHM-allocated structs has a
high risk of running into concurrency issues, depending on the spec in
use.  Here, the issue happened to be with the $stat(xxx) algo pattern,
where 2 or more SIP workers performed concurrent READ/WRITE on it,
leading to a crash.

Many thanks to Eric Tamme from Five9 for reporting & testing!

(cherry picked from commit 063435dfefb229703b06bf2c22ca8e159d166def)



To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications