[OpenSIPS-Devel] [OpenSIPS/opensips] 1f4ee2: Fixed test over the IO flags when removing a fd fr...

Bogdan Andrei IANCU noreply at github.com
Tue Jul 23 13:03:08 UTC 2024


  Branch: refs/heads/3.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1f4ee25b586a5e86f0605ac5c17f08480d30c843
      https://github.com/OpenSIPS/opensips/commit/1f4ee25b586a5e86f0605ac5c17f08480d30c843
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M io_wait.h

  Log Message:
  -----------
  Fixed test over the IO flags when removing a fd from reactor

ignore the internal flags during the test

(cherry picked from commit 5e11c80de870f22bca3aae85e88ef8b8b57c0f93)


  Commit: bbb65c2f1ada78d21eb1053cf748bd053501c426
      https://github.com/OpenSIPS/opensips/commit/bbb65c2f1ada78d21eb1053cf748bd053501c426
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M io_wait.h

  Log Message:
  -----------
  [I/O reactor] do sanity check on the provided fd index

On del operation, if an index (in the fd_array) is provided, check its consistency, to avoid corrupting the reactor's data.
Upon corruption, do a backtrace and force recovery by resetting the index to -1

IMPORTANT: this is not a fix, but a detection and recovery, hoping to help identifing bad ops over the reactor's fds.
(cherry picked from commit c15bd04aa47843147427fd56f427152addda8e93)


  Commit: ff816876a4690022f850006e26b4367e855dc0fe
      https://github.com/OpenSIPS/opensips/commit/ff816876a4690022f850006e26b4367e855dc0fe
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2024-07-23 (Tue, 23 Jul 2024)

  Changed paths:
    M io_wait.h

  Log Message:
  -----------
  [IO reactor] added an enhanced logging when detecting a reactor data corruption

Use a basic/simple array to store logs to be eventually dump later if a corruption of the reactor data is detected after an io_wait_del() operation.
This is debugging only, with the intention of helping the troubleshooting some ongoing investigations.

(cherry picked from commit a28e500a0bffa9fcdf1a6223d94bbfe465135228)


Compare: https://github.com/OpenSIPS/opensips/compare/722547d43176...ff816876a469

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications



More information about the Devel mailing list