[OpenSIPS-Devel] [OpenSIPS/opensips] ac1e2f: topology_hiding: fix encoded Contact length calcul...

Bogdan Andrei IANCU noreply at github.com
Tue Feb 13 15:50:01 UTC 2024


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ac1e2f3d89210b623337d0e9477d7a19581aef00
      https://github.com/OpenSIPS/opensips/commit/ac1e2f3d89210b623337d0e9477d7a19581aef00
  Author: James Stanley <james at incoherency.co.uk>
  Date:   2023-12-01 (Fri, 01 Dec 2023)

  Changed paths:
    M modules/topology_hiding/topo_hiding_logic.c

  Log Message:
  -----------
  topology_hiding: fix encoded Contact length calculation

This leads to segfaults (and probable vulnerabilities) when the allocated buffer
is not long enough to contain its contents.

This bug was introduced in
https://github.com/OpenSIPS/opensips/commit/e23be5d19a4865083971d17dc719a4d4d3436a24
presumably as a copy-and-paste mistake.


  Commit: da20b2259fd3f96a7530bfd72753a8338e3c4212
      https://github.com/OpenSIPS/opensips/commit/da20b2259fd3f96a7530bfd72753a8338e3c4212
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M modules/topology_hiding/topo_hiding_logic.c

  Log Message:
  -----------
  Merge pull request #3262 from jes/jes/topology-hiding-fix

topology_hiding: fix encoded Contact length calculation


Compare: https://github.com/OpenSIPS/opensips/compare/edf21b1b9957...da20b2259fd3



More information about the Devel mailing list