[OpenSIPS-Devel] [OpenSIPS/opensips] 02c4d1: clusterer: Fix a subtle subtraction bug

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 02c4d14d79ff6cfd76b4220cdece80c0853e4e1f
      https://github.com/OpenSIPS/opensips/commit/02c4d14d79ff6cfd76b4220cdece80c0853e4e1f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M modules/clusterer/topology.c

  Log Message:
  -----------
  clusterer: Fix a subtle subtraction bug

The "--node->no_ping_retries" operation is bogus, because that field
is only written during DB reload, or when dynamically learning a new
node.  This can lead to the following state, where a node's link flips
between ON/OFF on each ping attempt:

[Nov 29 20:23:15] INFO:clusterer:do_action_trans_2: Ping reply not received, node [2] is down
[Nov 29 20:23:15] INFO:clusterer:handle_pong: Node [2] is UP
[Nov 29 20:23:42] INFO:clusterer:do_action_trans_2: Ping reply not received, node [2] is down
[Nov 29 20:23:42] INFO:clusterer:handle_pong: Node [2] is UP
[Nov 29 20:24:30] INFO:clusterer:do_action_trans_2: Ping reply not received, node [2] is down
[Nov 29 20:24:30] INFO:clusterer:handle_pong: Node [2] is UP


  Commit: 5eae5fb1580feb512cc9a065c558a72d85405afb
      https://github.com/OpenSIPS/opensips/commit/5eae5fb1580feb512cc9a065c558a72d85405afb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2024-12-04 (Wed, 04 Dec 2024)

  Changed paths:
    M modules/clusterer/Makefile
    M modules/clusterer/clusterer.h
    M modules/clusterer/topology.c

  Log Message:
  -----------
  clusterer: Add some dev debugging logs


Compare: https://github.com/OpenSIPS/opensips/compare/8631e9835bef...5eae5fb1580f

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSIPS/opensips/settings/notifications