[OpenSIPS-Devel] [OpenSIPS/opensips] 312cdd: b2b_logic: fix crash when sending NOTIFY for local...

Vlad Pătrașcu noreply at github.com
Thu Mar 30 09:15:29 UTC 2023


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 312cdd4da1a1a23429b7e2a47c0889795c50c8a3
      https://github.com/OpenSIPS/opensips/commit/312cdd4da1a1a23429b7e2a47c0889795c50c8a3
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M modules/b2b_entities/dlg.c

  Log Message:
  -----------
  b2b_logic: fix crash when sending NOTIFY for local timeout

This commit fixes a crash when using the 'n' flag of the b2b_bridge()
function, and a local timeout occurs. The crash was caused by improperly
setting the first line of the the dummy SIP message built by the b2b_entities
module.


  Commit: 266e5524ad11732912d6e990d499aedf25ea1eed
      https://github.com/OpenSIPS/opensips/commit/266e5524ad11732912d6e990d499aedf25ea1eed
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M modules/b2b_logic/bridging.c

  Log Message:
  -----------
  b2b_logic: fix a bridging issue when using the 'peer' identifier

Don't fail the bridging action when using the 'peer' identifier for the
b2b_bridge() function and the current entity is already deleted.


  Commit: a72cfbeda919eca0020d34e33c844cc3b49a3b71
      https://github.com/OpenSIPS/opensips/commit/a72cfbeda919eca0020d34e33c844cc3b49a3b71
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2023-03-30 (Thu, 30 Mar 2023)

  Changed paths:
    M modules/b2b_logic/bridging.c
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b_logic: ignore replies to NOTIFYs sent while bridging

This will get rid of the races between the processing of the replies for the
NOTIFY and the subsequent BYE sent to the bridge initiator. The entity
might be already deleted as a result of handling the 200 OK for the BYE
before we try to do a lookup again for handling the NOTIFY reply. These
races would not produce any significant negative effects but OpenSIPS
would log unnecessary 'No b2b_key match found' errors.


Compare: https://github.com/OpenSIPS/opensips/compare/89b7c8d5c84b...a72cfbeda919



More information about the Devel mailing list