[OpenSIPS-Devel] [OpenSIPS/opensips] 4a4e7f: b2b_entities: properly handle BYE while another re...

[Vlad Pătrașcu]

  Branch: refs/heads/3.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4a4e7f5ef1d64ab51fea60fbe360985b544f4b33
      https://github.com/OpenSIPS/opensips/commit/4a4e7f5ef1d64ab51fea60fbe360985b544f4b33
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M modules/b2b_entities/b2be_load.h
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/logic.c
    M modules/b2b_logic/records.h

  Log Message:
  -----------
  b2b_entities: properly handle BYE while another request is pending

Instead of rejecting the BYE with 491, first complete the transactions on the
UAS side with 200 OK for the BYE and 487 for the other pending transaction.
Also, mark the tuple for deletion at b2b_logic level and send a BYE to
the peer entity after completing any UAC transcations on this side.

Credits to David Escartin from Sonoc for reporting.

(cherry picked from commit da6975f065ad848ceb8d8f65b0f09d1efc2bca37)


  Commit: 80b28ae71ba817b3af0d2a772dcd0d5544e3e137
      https://github.com/OpenSIPS/opensips/commit/80b28ae71ba817b3af0d2a772dcd0d5544e3e137
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M modules/b2b_entities/dlg.c

  Log Message:
  -----------
  b2b_entities: fix crashes after running the script request route

After releasing the lock and running the script request route, check
if the dialog has not been deleted in the meantime.

Credits to David Escartin from Sonoc for reporting.

(cherry picked from commit 65a8da41f58ba3179c62c83a2d710651c97b36ca)


  Commit: 19fa678ff13095e7177565820a7805d854c2e2b2
      https://github.com/OpenSIPS/opensips/commit/19fa678ff13095e7177565820a7805d854c2e2b2
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2023-02-06 (Mon, 06 Feb 2023)

  Changed paths:
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b_logic: fix crashes due to dangling tuple pointer

Make sure to not access a tuple that might have been freed while not
holding the lock.

Many thanks to David Escartin from Sonoc for the help in troubleshooting
this issue!

(cherry picked from commit 1225b0191afdf0a36e14bf47f5cac908e5af5603)


Compare: https://github.com/OpenSIPS/opensips/compare/224da225d693...19fa678ff130