[OpenSIPS-Devel] [OpenSIPS/opensips] 118810: dialog: Fix shtag restoration when loading from DB

[Liviu Chircu]

  Branch: refs/heads/3.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 11881028694bc1f52caf181b8835b7842a276a26
      https://github.com/OpenSIPS/opensips/commit/11881028694bc1f52caf181b8835b7842a276a26
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2022-10-27 (Thu, 27 Oct 2022)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: Fix shtag restoration when loading from DB

This fixes a hanging dialog profiles bug on the backup box (NULL shtag),
in specific scenarios with dialogs + sharing tags, profiles with
value and dialog + profile replication clusters (whole enchilada).

In such cases, after restarting the backup box with active dialogs in
the DB, it would end up with forever-hanging dialog profiles in memory,
which would be continuously broadcasted to all cluster nodes,
effectively adding (doubling) unnecessary counters to the overall limit.

Credits to Vlad Pătrașcu for helping troubleshoot this bug!

(cherry picked from commit d77a9c52c2becdd451ef19ec9b586d7152aa8884)
(cherry picked from commit ab1e5d4a31e5a4d601ea1a7cef7a427d7e508ccf)