[OpenSIPS-Devel] [OpenSIPS/opensips] d77a9c: dialog: Fix shtag restoration when loading from DB

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d77a9c52c2becdd451ef19ec9b586d7152aa8884
      https://github.com/OpenSIPS/opensips/commit/d77a9c52c2becdd451ef19ec9b586d7152aa8884
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2022-10-27 (Thu, 27 Oct 2022)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: Fix shtag restoration when loading from DB

This fixes a hanging dialog profiles bug on the backup box (NULL shtag),
in specific scenarios with dialogs + sharing tags, profiles with
value and dialog + profile replication clusters (whole enchilada).

In such cases, after restarting the backup box with active dialogs in
the DB, it would end up with forever-hanging dialog profiles in memory,
which would be continuously broadcasted to all cluster nodes,
effectively adding (doubling) unnecessary counters to the overall limit.

Credits to Vlad Pătrașcu for helping troubleshoot this bug!