[OpenSIPS-Devel] [OpenSIPS/opensips] 578fc2: next_branches(): Fix bugs leading to READ on freed...

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 578fc2907374477449313c36e4fc3287701de800
      https://github.com/OpenSIPS/opensips/commit/578fc2907374477449313c36e4fc3287701de800
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2022-11-17 (Thu, 17 Nov 2022)

  Changed paths:
    M serialize.c

  Log Message:
  -----------
  next_branches(): Fix bugs leading to READ on freed shared memory

This patch fixes two code paths leading to the @avp pointer being freed,
after which the dangling pointer is read afterwards by the
search_next_avp() function at the "done" goto label.  This will work
99% of the time, until the 1% where it won't (crash and burn!).

Many thanks to Richard Revels (@rrevels-bw) and Sebastien Couture for
an accurate report, as well as their involvement in troubleshooting!

Fixes #2446
Fixes #2950