[OpenSIPS-Devel] [OpenSIPS/opensips] 81cb09: b2b_entities: properly handle unexpected ACKs

[Vlad Pătrașcu]

  Branch: refs/heads/3.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 81cb0903aedd2271e9a93789e83e1d96e28352f1
      https://github.com/OpenSIPS/opensips/commit/81cb0903aedd2271e9a93789e83e1d96e28352f1
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M modules/b2b_entities/dlg.c

  Log Message:
  -----------
  b2b_entities: properly handle unexpected ACKs

Fixes an issue where a 487 reply is not relayed after an unexpected ACK is
received following a CANCEL.

Thanks to David Escartin from Sonoc for reporting.


  Commit: e8df85a64a3b8095cd95c0b2d9254de605b61384
      https://github.com/OpenSIPS/opensips/commit/e8df85a64a3b8095cd95c0b2d9254de605b61384
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M modules/b2b_entities/dlg.c

  Log Message:
  -----------
  b2b_entities: properly handle negative replies to reINVITEs

Do not change the dialog state to terminated as a result of a sending a
negative reply to a reINVITE. This would have prevented the forwarding of
further requests.

Thanks to David Escartin from Sonoc for reporting and testing the fix.


  Commit: ff646336e82ce1bdea56156c826520090c9786ad
      https://github.com/OpenSIPS/opensips/commit/ff646336e82ce1bdea56156c826520090c9786ad
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M modules/b2b_entities/b2b_common.h
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b_logic: prevent possible crashes when accessing $b2b_logic vars

Make sure to always search in the hash for the current tuple instead of relying
on a pointer saved in the b2b context. There might be races between processing
BYEs and deleting the tuple and running a b2b_logic reply route where we access
a $b2b_logic variable.

Thanks to David Escartin from Sonoc for reporting.


  Commit: c7a5f41754c03fa20921e86a7ff25d2f0b0abf76
      https://github.com/OpenSIPS/opensips/commit/c7a5f41754c03fa20921e86a7ff25d2f0b0abf76
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M modules/b2b_entities/dlg.c

  Log Message:
  -----------
  b2b_entities: fix possible shm memory leaks

Fix leaking transactions when deleting an entity without sending a final reply.

Thanks to David Escartin from Sonoc for reporting.


  Commit: fa2145b12cb6590e4366cb8a2659b7b79813b374
      https://github.com/OpenSIPS/opensips/commit/fa2145b12cb6590e4366cb8a2659b7b79813b374
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2022-06-25 (Sat, 25 Jun 2022)

  Changed paths:
    M modules/b2b_logic/records.c

  Log Message:
  -----------
  b2b_logic: fix possible crash when init_callid_hdr param is set

The crash would occur if the Call-ID header name is received in compact
form("i" instead of "Call-ID").

Thanks to David Escartin from Sonoc for reporting.


Compare: https://github.com/OpenSIPS/opensips/compare/082379771325...fa2145b12cb6