[OpenSIPS-Devel] [OpenSIPS/opensips] dc1276: proto_tls/wss: fix crashes when dumping the openss...

[Vlad Pătrașcu]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: dc1276fbe83226fd628e1ea86c1885af2b97de43
      https://github.com/OpenSIPS/opensips/commit/dc1276fbe83226fd628e1ea86c1885af2b97de43
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-03-16 (Tue, 16 Mar 2021)

  Changed paths:
    M modules/proto_tls/Makefile
    M modules/proto_tls/proto_tls.c
    M modules/proto_wss/Makefile
    M modules/proto_wss/proto_wss.c
    M modules/tls_mgm/tls_conn_ops.h
    M modules/tls_mgm/tls_conn_server.h

  Log Message:
  -----------
  proto_tls/wss: fix crashes when dumping the openssl error stack

This commit serializes the execution of openssl's connect/accept/read/write
operations in order to prevent adding/removing entries concurrently to/from
the openssl error stack. If the performance penalty is deemed too high, the
NO_SSL_GLOBAL_LOCK compilation flag can be used to disable this behavior and
retain the risk of crashes.

Reported in #2362
Credits to Alexey Vasilyev for helping troubleshoot this.

(cherry picked from commit b6b7520024561c3cc65d272e038992adc0825fc7)
(cherry picked from commit 00090791c7101d5c7e4499df16d54eba91c7cfda)


  Commit: e3c231093572d85d598c8952a1df11fc1e294fd1
      https://github.com/OpenSIPS/opensips/commit/e3c231093572d85d598c8952a1df11fc1e294fd1
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-03-16 (Tue, 16 Mar 2021)

  Changed paths:
    M modules/proto_tls/proto_tls.c
    M modules/proto_wss/proto_wss.c
    M modules/tls_mgm/api.h
    M modules/tls_mgm/tls_conn_ops.h
    M modules/tls_mgm/tls_conn_server.h
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  proto_tls/wss: complete fix in commit b6b7520

(cherry picked from commit dac973404b43b148f91d7fae66417d864f3c047d)
(cherry picked from commit 5897b2294fb9cba16fb6c9590ccee5a3c4c1351c)


Compare: https://github.com/OpenSIPS/opensips/compare/9f7b25ba9233...e3c231093572