[OpenSIPS-Devel] [OpenSIPS/opensips] 68ddee: b2b_entities/logic: properly reply to canceled/exp...

[Vlad Pătrașcu]

  Branch: refs/heads/3.1
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 68ddeed6108cb7a2f444f7a38d1ff83b7ab155e8
      https://github.com/OpenSIPS/opensips/commit/68ddeed6108cb7a2f444f7a38d1ff83b7ab155e8
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-07-29 (Thu, 29 Jul 2021)

  Changed paths:
    M modules/b2b_entities/b2be_load.h
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/b2b_logic.h
    M modules/b2b_logic/logic.c
    M modules/media_exchange/media_exchange.c
    M modules/siprec/siprec_logic.c

  Log Message:
  -----------
  b2b_entities/logic: properly reply to canceled/expired entities

Generate a 487 reply from opensips to the server entity if:
* no final reply from the client entity received and the tuple
  expires after a CANCEL request has been received;
* a 200 OK has be received after a previous CANCEL request.

Also, reply with 408 to the server entity if the tuple expires and no
final reply from the client entity has been received.

Credits to David Escartin from Sonoc for reporting and testing the
fixes.

(cherry picked from commit 3261d2cb59f4477495cb770af6e3489ce186bc6b)


  Commit: 19a50a190fb4df534129cfc9973c87c9ef981a52
      https://github.com/OpenSIPS/opensips/commit/19a50a190fb4df534129cfc9973c87c9ef981a52
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-07-30 (Fri, 30 Jul 2021)

  Changed paths:
    M modules/b2b_entities/b2be_load.h
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b_entities/logic: fix a race condition with simultaneous reINVITEs

Fix behavior when receiving reINVITES from the connected entities at the
same time, one replied with 491 and the other with 200OK. The 200 OK
would not be passed to the other entity and the tuple would never be
deleted in this case.

Thanks to David Escartin from Sonoc for reporting and testing the fix.

(cherry picked from commit 9c9ab8f948be65dc6a99024f901e748d629f8e56)


Compare: https://github.com/OpenSIPS/opensips/compare/985bdfa3d009...19a50a190fb4