[OpenSIPS-Devel] [OpenSIPS/opensips] 944002: b2b_entities/logic: properly reply to canceled/exp...

Vlad Pătrașcu noreply at github.com
Wed Jul 21 11:16:42 EST 2021


  Branch: refs/heads/3.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 944002af587a75d183859160e24be2a81188852a
      https://github.com/OpenSIPS/opensips/commit/944002af587a75d183859160e24be2a81188852a
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M modules/b2b_entities/b2be_load.h
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/b2b_logic.h
    M modules/b2b_logic/logic.c
    M modules/b2b_logic/records.h
    M modules/media_exchange/media_exchange.c
    M modules/siprec/siprec_logic.c

  Log Message:
  -----------
  b2b_entities/logic: properly reply to canceled/expired entities

Generate a 487 reply from opensips to the server entity if:
* no final reply from the client entity received and the tuple
  expires after a CANCEL request has been received;
* a 200 OK has be received after a previous CANCEL request.

Also, reply with 408 to the server entity if the tuple expires and no
final reply from the client entity has been received.

Credits to David Escartin from Sonoc for reporting and testing the
fixes.

(cherry picked from commit 3261d2cb59f4477495cb770af6e3489ce186bc6b)


  Commit: 802ce9d2ad39a1738dc9bd36e227409d1ceed222
      https://github.com/OpenSIPS/opensips/commit/802ce9d2ad39a1738dc9bd36e227409d1ceed222
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M modules/b2b_entities/b2be_load.h
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b_entities/logic: fix a race condition with simultaneous reINVITEs

Fix behavior when receiving reINVITES from the connected entities at the
same time, one replied with 491 and the other with 200OK. The 200 OK
would not be passed to the other entity and the tuple would never be
deleted in this case.

Thanks to David Escartin from Sonoc for reporting and testing the fix.

(cherry picked from commit 9c9ab8f948be65dc6a99024f901e748d629f8e56)


  Commit: 125b2af25c7d68b0b6f40e29e0e818de8e85be37
      https://github.com/OpenSIPS/opensips/commit/125b2af25c7d68b0b6f40e29e0e818de8e85be37
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-07-21 (Wed, 21 Jul 2021)

  Changed paths:
    M modules/b2b_logic/b2b_logic.h
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b_logic: fix crash when receiving an INFO or unsupported method

Thanks to David Escartin from Sonoc for reporting.

(cherry picked from commit b59a436cb12854105f379512f32758987b911f47)


Compare: https://github.com/OpenSIPS/opensips/compare/9112ad6bdac5...125b2af25c7d



More information about the Devel mailing list