[OpenSIPS-Devel] [OpenSIPS/opensips] 9cf484: Add immutable version of the struct str - str_cons...

Maksym Sobolyev noreply at github.com
Thu Jan 21 22:26:57 EST 2021


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9cf4843401ceca9e11744b323f793cca4bf3abec
      https://github.com/OpenSIPS/opensips/commit/9cf4843401ceca9e11744b323f793cca4bf3abec
  Author: Maksym Sobolyev <sobomax at sippysoft.com>
  Date:   2021-01-21 (Thu, 21 Jan 2021)

  Changed paths:
    M str.h

  Log Message:
  -----------
  Add immutable version of the struct str - str_const and associated
helper macros (STR_NULL_const, str_const_init() and str2const()).


  Commit: 985f1e6b5cf48b19db96c47ccfa32a8782284fa6
      https://github.com/OpenSIPS/opensips/commit/985f1e6b5cf48b19db96c47ccfa32a8782284fa6
  Author: Maksym Sobolyev <sobomax at sippysoft.com>
  Date:   2021-01-21 (Thu, 21 Jan 2021)

  Changed paths:
    M flags.c
    M flags.h
    M modules/acc/acc_vars.c
    M modules/acc/acc_vars.h
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic_xml/b2b_logic.c
    M modules/cfgutils/env_var.c
    M modules/cfgutils/env_var.h
    M modules/cfgutils/shvar.c
    M modules/cfgutils/shvar.h
    M modules/cgrates/cgrates.c
    M modules/clusterer/sharing_tags.c
    M modules/clusterer/sharing_tags.h
    M modules/dialog/dlg_vals.c
    M modules/dialog/dlg_vals.h
    M modules/json/json.c
    M modules/nat_traversal/nat_traversal.c
    M modules/presence_dfks/presence_dfks.c
    M modules/ratelimit/ratelimit.c
    M modules/rtpengine/rtpengine.c
    M modules/sip_i/sip_i.c
    M modules/sipcapture/sipcapture.c
    M modules/sql_cacher/sql_cacher.c
    M modules/statistics/statistics.c
    M modules/stir_shaken/stir_shaken.c
    M modules/xml/xml.c
    M pvar.c
    M pvar.h
    M script_var.c
    M script_var.h
    M statistics.c
    M statistics.h
    M usr_avp.c
    M usr_avp.h
    M ut.h
    M xlog.c
    M xlog.h

  Log Message:
  -----------
  Cleanup pvar.c code a bit:

o mark bunch of functions not used anywhere else static;

o make lots of str * arguments "const" (overflows to some modules).
  Two modules in particular abused API by writing into str *in
  directly:

   modules/sipcapture/sipcapture.c
   modules/acc/acc_vars.c

o make some of pv_spec_p arguments "const";

o make _pv_names_table[] const.


Compare: https://github.com/OpenSIPS/opensips/compare/0625fa0dfd10...985f1e6b5cf4



More information about the Devel mailing list