[OpenSIPS-Devel] [OpenSIPS/opensips] b6b752: proto_tls/wss: fix crashes when dumping the openss...

Vlad Pătrașcu noreply at github.com
Thu Feb 11 22:19:27 EST 2021


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b6b7520024561c3cc65d272e038992adc0825fc7
      https://github.com/OpenSIPS/opensips/commit/b6b7520024561c3cc65d272e038992adc0825fc7
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2021-02-12 (Fri, 12 Feb 2021)

  Changed paths:
    M Makefile.openssl
    M modules/proto_tls/proto_tls.c
    M modules/proto_wss/proto_wss.c
    M modules/tls_mgm/tls_conn_ops.h
    M modules/tls_mgm/tls_conn_server.h

  Log Message:
  -----------
  proto_tls/wss: fix crashes when dumping the openssl error stack

This commit serializes the execution of openssl's connect/accept/read/write
operations in order to prevent adding/removing entries concurrently to/from
the openssl error stack. If the performance penalty is deemed too high, the
NO_SSL_GLOBAL_LOCK compilation flag can be used to disable this behavior and
retain the risk of crashes.

Reported in #2362
Credits to Alexey Vasilyev for helping troubleshoot this.





More information about the Devel mailing list