[OpenSIPS-Devel] [OpenSIPS/opensips] 1db73b: stir_shaken(): Fix too relaxed E.164 conditions; A...

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1db73b68023bc33c1d27e8ae95a3a85d96d7131a
      https://github.com/OpenSIPS/opensips/commit/1db73b68023bc33c1d27e8ae95a3a85d96d7131a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
    M modules/stir_shaken/stir_shaken.c

  Log Message:
  -----------
  stir_shaken(): Fix too relaxed E.164 conditions; Add number checks

Commit 8c842cc33d made it such that any string is accepted as valid
STIR/SHAKEN identity, in "loose mode".  For example,
"From: sip:foobar at test.com" would pass as valid CLI and "foobar" would
get written in the PASSporT, which cannot be OK.

This commit also makes it so the new "e164_strict_mode" modparam makes
the leading "+" mandatory in the From/To URIs.  Otherwise, the "+" is
optional and will get discarded if necessary.

Moreover, by moving the number checks around a bit, this commit also
fixes a bug where the opensips.cfg inputted orig/dest numbers are never
checked.  For example, if the developer were to have a bug where some
$var(cli) contains a SIP URI and gets passed to stir_shaken as
originator, the module would happily write the URI into the PASSporT as
"orig" and return success.

(cherry picked from commit 140e4c0ef810bd75fbbc4cbbfb1a80c72da67271)


  Commit: 91eca076ccc9c8741f7e871c658365ac2efb6fa1
      https://github.com/OpenSIPS/opensips/commit/91eca076ccc9c8741f7e871c658365ac2efb6fa1
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
    M modules/stir_shaken/stir_shaken.c

  Log Message:
  -----------
  stir_shaken: Several logging improvements

* add better separation between server-side / client-side errors,
    throughout both of the orig / dest telephony number extraction and
    validation phases.
* bump client-side errors from INFO to NOTICE, for better visibility.
* add extra logging details (phone numbers, timeouts, etc.)

(cherry picked from commit b3f511f7bc2fa2fdb78f0c005abcd295af2e4176)


  Commit: afae3363ef901dff9711b540072b3266d7865167
      https://github.com/OpenSIPS/opensips/commit/afae3363ef901dff9711b540072b3266d7865167
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2021-04-12 (Mon, 12 Apr 2021)

  Changed paths:
    M modules/stir_shaken/stir_shaken.c
    M modules/stir_shaken/stir_shaken.h

  Log Message:
  -----------
  stir_shaken: Fix several unset code/reason output vars on error cases

Also add new 400 and 500 SIP retcodes to signify client / server errors.

(cherry picked from commit 7cff7b60ce74e2a652d984b87a3ea5ec3847a3eb)


Compare: https://github.com/OpenSIPS/opensips/compare/ab447c15a477...afae3363ef90