[OpenSIPS-Devel] [OpenSIPS/opensips] 50858e: dialog: update contact on TMCB_RESPONSE_FWDED

[Răzvan Crainea]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 50858e8aa823f9f4b4ff3bd0b8f069d1df3d25c8
      https://github.com/OpenSIPS/opensips/commit/50858e8aa823f9f4b4ff3bd0b8f069d1df3d25c8
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2021-04-05 (Mon, 05 Apr 2021)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: update contact on TMCB_RESPONSE_FWDED

Before this change, the contact was updated on the RESPONSE_OUT callback
- the problem is that in that callback, when using topology hiding, you
wouldn't know the actual Contact advertised (or fixed) by the client,
because you would only see the topology hiding's advertised Contact.
Thus, on replies, we couldn't update the remote's target properly.
Moving the update logic on TMCB_RESPONSE_FWDED exposes the right
Contact.
Credits go to John Burke (@john08burke) for documenting this in
ticket #2444.