[OpenSIPS-Devel] [OpenSIPS/opensips] 9dcff6: Clean up UAS auth code a bit before I dive into RF...

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9dcff69df77aee4a3167d0ed8d2dc052740312ee
      https://github.com/OpenSIPS/opensips/commit/9dcff69df77aee4a3167d0ed8d2dc052740312ee
  Author: Maksym Sobolyev <sobomax at sippysoft.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M modules/auth/challenge.c
    M modules/auth/common.c
    M modules/auth/common.h

  Log Message:
  -----------
  Clean up UAS auth code a bit before I dive into RFC8760 rework.

o Get rid of the XYZ_LEN constants;

o normalize parameters to not pass char * + len, pass str * instead;

o add const where appropriate;

o GC stale _PRINT_MD5 section, it's going to be replaced with the
  new code really soon;

o avoid calling strlen() when the string lenth is well known.

No functional changes (I hope).


  Commit: 36e0281b7309e2be39e478c96575cadf9a35260b
      https://github.com/OpenSIPS/opensips/commit/36e0281b7309e2be39e478c96575cadf9a35260b
  Author: Maksym Sobolyev <sobomax at sippysoft.com>
  Date:   2020-10-06 (Tue, 06 Oct 2020)

  Changed paths:
    M str.h

  Log Message:
  -----------
  Extend STR_NULL and str_init() to set a type explicitly. This
allows those macros to be used elsewhere in the function body,
not only in variable declaration(s), i.e.:

void foobar(int baz)
{
    str localstr;

    if (random() == 42) {
       localstr = str_init(I_STR LUCKY_STR FIN_STR);
    } else {
        localstr = str_init(I_STR UNLUCKY_STR FIN_STR);
    }
    some_api(&localstr);
}


  Commit: c9e0f70e8cc9f86552a82dacde5349ddf803fc7b
      https://github.com/OpenSIPS/opensips/commit/c9e0f70e8cc9f86552a82dacde5349ddf803fc7b
  Author: Maksym Sobolyev <sobomax at sippysoft.com>
  Date:   2020-10-08 (Thu, 08 Oct 2020)

  Changed paths:
    M modules/signaling/signaling.c
    M modules/signaling/signaling.h
    M modules/sl/sl_api.h
    M modules/sl/sl_funcs.c
    M modules/sl/sl_funcs.h
    M modules/tm/t_reply.c
    M modules/tm/t_reply.h
    M msg_translator.c
    M msg_translator.h

  Log Message:
  -----------
  Mark "text", i.e. status message argument of the
build_res_buf_from_sip_req() as "const *" and propagate it
into relevant functions of tm, sl and signalling modules.


  Commit: e8dd676f9693b25defe00076720cd5d5563cbc63
      https://github.com/OpenSIPS/opensips/commit/e8dd676f9693b25defe00076720cd5d5563cbc63
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-10-09 (Fri, 09 Oct 2020)

  Changed paths:
    M modules/auth/challenge.c
    M modules/auth/common.c
    M modules/auth/common.h
    M modules/signaling/signaling.c
    M modules/signaling/signaling.h
    M modules/sl/sl_api.h
    M modules/sl/sl_funcs.c
    M modules/sl/sl_funcs.h
    M modules/tm/t_reply.c
    M modules/tm/t_reply.h
    M msg_translator.c
    M msg_translator.h
    M str.h

  Log Message:
  -----------
  Merge pull request #2277 from sippy/pr_str_improve2

Clean up UAS auth code a bit before I dive into RFC8760 rework.


Compare: https://github.com/OpenSIPS/opensips/compare/899a89f52282...e8dd676f9693