[OpenSIPS-Devel] [OpenSIPS/opensips] 4dcaf5: Add missing typedef keyword

Liviu Chircu noreply at github.com
Mon May 11 11:45:19 EST 2020


  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4dcaf5fc3ec25a671052e61afae9805bca5c0fd5
      https://github.com/OpenSIPS/opensips/commit/4dcaf5fc3ec25a671052e61afae9805bca5c0fd5
  Author: Peter Lemenkov <lemenkov at gmail.com>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M modules/cachedb_local/cachedb_local_replication.h
    M modules/usrloc/ul_mod.h
    M modules/usrloc/usrloc.h

  Log Message:
  -----------
  Add missing typedef keyword

Without this keyword these struct definitions are considered by GCC as a
variable definition.

This was catched because there is a more strict check about these
variable definitions since GCC 10:

* https://gcc.gnu.org/gcc-10/porting_to.html#common

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
(cherry picked from commit 242903711399ccb4eafeac614129424ffddb0e1b)


  Commit: 298b0901188ecaf970abe0656f07f7d441b2519a
      https://github.com/OpenSIPS/opensips/commit/298b0901188ecaf970abe0656f07f7d441b2519a
  Author: Peter Lemenkov <lemenkov at gmail.com>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M mem/hp_malloc.c
    M mi/mi_trace.c
    M mi/mi_trace.h
    M modules/b2b_entities/b2b_entities.c
    M modules/b2b_entities/dlg.h
    M modules/b2b_logic/b2b_logic.h
    M modules/dispatcher/dispatch.h
    M modules/emergency/emergency_methods.c
    M modules/emergency/emergency_methods.h
    M modules/emergency/http_emergency.h
    M modules/emergency/report_emergency.h
    M modules/emergency/sip_emergency.c
    M modules/emergency/subscriber_emergency.h
    M modules/emergency/xml_parser.h
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/mangler/mangler.c
    M modules/mangler/sdp_mangler.h
    M modules/permissions/permissions.h
    M modules/pua_dialoginfo/pua_dialoginfo.c
    M modules/pua_dialoginfo/pua_dialoginfo.h
    M modules/pua_usrloc/pua_usrloc.c
    M modules/pua_usrloc/pua_usrloc.h
    M modules/ratelimit/ratelimit_helper.c
    M modules/registrar/reg_mod.c
    M modules/registrar/reg_mod.h
    M modules/sms/libsms_modem.c
    M modules/sms/libsms_putsms.c
    M modules/sms/sms_funcs.c
    M sr_module.h
    M ut.c
    M ut.h

  Log Message:
  -----------
  Fix building with gcc 10

GCC 10 started to use -no-common by default. Here is an official
explanation:

* https://gcc.gnu.org/gcc-10/porting_to.html#common

We have to mark all the declarations of global variables with extern
keyword and put the definitions into a proper file.

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
(cherry picked from commit 7b59ee14e95ea3500dd8c3368b081404b9731c9b)


  Commit: eb249d816436c83a3a032bd3b3e3393f0113ce8c
      https://github.com/OpenSIPS/opensips/commit/eb249d816436c83a3a032bd3b3e3393f0113ce8c
  Author: Peter Lemenkov <lemenkov at gmail.com>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M modules/rtpengine/rtpengine.h

  Log Message:
  -----------
  rtpengine: Remove unused struct fields

These two fields were copied directly from rtpproxy module but never
used by this module.

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>
(cherry picked from commit fd8262cee78a67e1dcca7f487f919239d0f13f33)


  Commit: b3f95b7bf78614da094ff7a65c3ce10180b628b2
      https://github.com/OpenSIPS/opensips/commit/b3f95b7bf78614da094ff7a65c3ce10180b628b2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-05-11 (Mon, 11 May 2020)

  Changed paths:
    M Makefile.defs

  Log Message:
  -----------
  make: Prepare for upcoming gcc 10 (use -fno-common)

Per https://gcc.gnu.org/gcc-10/porting_to.html#common, -fno-common will
become a default in gcc 10, so variables defined within .h files will no
longer be allowed!

Thanks to Peter Lemenkov for the suggestion!

(cherry picked from commit b864b2915551fc25509a54eaf30df0cedbe1643f)


Compare: https://github.com/OpenSIPS/opensips/compare/20754ac348d5...b3f95b7bf786



More information about the Devel mailing list