[OpenSIPS-Devel] [OpenSIPS/opensips] 994ab6: Fixed uac_auth() on sequential requests in dialogs...

[Bogdan Andrei IANCU]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 994ab68ffccc28a8cb0cd03bc586570ad8bc5dba
      https://github.com/OpenSIPS/opensips/commit/994ab68ffccc28a8cb0cd03bc586570ad8bc5dba
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-06-30 (Tue, 30 Jun 2020)

  Changed paths:
    M modules/uac/auth.c

  Log Message:
  -----------
  Fixed uac_auth() on sequential requests in dialogs were uac_auth() was already used

The fix solves the conflict between the changes over the cseq value coming from (1) dialog module, trying to increment the cseq to compensate the cseq change during INVITE auth and (2) the uac module incrementing the cseq again because of auth'ing a sequential request.

The solution was to first indetify such case in uac_auth() and to use a larger delete lump (when replacing the cseq) in uac_auth(). Such a larger/wider delete lump will invalidate the lump added by the dialog module.

This is a follow up on #1969

Credits to Ben Newlin for reporting and assisting with the testing