[OpenSIPS-Devel] [OpenSIPS/opensips] 770108: rtpengine: fix offer vs answer detection for replies

[Răzvan Crainea]

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 770108af0a081fd6c37a2bd5f19f952a4eb16410
      https://github.com/OpenSIPS/opensips/commit/770108af0a081fd6c37a2bd5f19f952a4eb16410
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/rtpengine/doc/rtpengine_admin.xml
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: fix offer vs answer detection for replies

When late negociation is not used, rtpengine_manage() should send an
answer command, not an offer one.


  Commit: 62c7274b28de9d938ec78ffa7dcc0d4a1936b2f7
      https://github.com/OpenSIPS/opensips/commit/62c7274b28de9d938ec78ffa7dcc0d4a1936b2f7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/rtpengine/rtpengine.c
    M parser/msg_parser.h

  Log Message:
  -----------
  rtpengine: fix late negociation detection of rtpengine_manage()

When a reply is received, do not look into the request if it has body,
since that could lead to headers parsing in pkg - that might leak.
Thanks go to @bogdan-iancu for spotting the issue


  Commit: 0246c846fe280897b952212d24c2f4c6e878cbf4
      https://github.com/OpenSIPS/opensips/commit/0246c846fe280897b952212d24c2f4c6e878cbf4
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/tm/cluster.c
    M receive.c

  Log Message:
  -----------
  tm: use msg_flags to indicate message is replicated


  Commit: 43a3828de86f50fe5ab2d4272ebec061614f7337
      https://github.com/OpenSIPS/opensips/commit/43a3828de86f50fe5ab2d4272ebec061614f7337
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M time_rec.c

  Log Message:
  -----------
  time_rec: use safe localtime_r function instead of localtime


  Commit: fe836d4da411e13daea9a102e7870ab334e1fc18
      https://github.com/OpenSIPS/opensips/commit/fe836d4da411e13daea9a102e7870ab334e1fc18
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M statistics.c

  Log Message:
  -----------
  statistics: rework internal functions to use str instead of char *


  Commit: b5d51b2aeb3e98e1287d1d0b6f0a06b3335eda38
      https://github.com/OpenSIPS/opensips/commit/b5d51b2aeb3e98e1287d1d0b6f0a06b3335eda38
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    A .lgtm.yml

  Log Message:
  -----------
  add lgtm file


  Commit: e250c47a31a0c30b3c25213ce58152df0eb8795b
      https://github.com/OpenSIPS/opensips/commit/e250c47a31a0c30b3c25213ce58152df0eb8795b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/carrierroute/route_fifo.c

  Log Message:
  -----------
  carrieroute: fix possible buffer overflow

Fixes Coverity CID #40876


  Commit: 948c42dd9b2d3072dc1348014334615b7bd95029
      https://github.com/OpenSIPS/opensips/commit/948c42dd9b2d3072dc1348014334615b7bd95029
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/presence_xml/notify_body.c

  Log Message:
  -----------
  presence_xml: fix possible buffer overflow

Fixes Coverity CID #40877


  Commit: bb284f110e2ed61d487ef6ad40f962b8a89b2b72
      https://github.com/OpenSIPS/opensips/commit/bb284f110e2ed61d487ef6ad40f962b8a89b2b72
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/ldap/iniparser.c

  Log Message:
  -----------
  ldap: prevent possible buffer overflow

Fixes Coverity CID #40879


  Commit: 8b410a7395cea35bc2479ea0f56e4a796e6b0d55
      https://github.com/OpenSIPS/opensips/commit/8b410a7395cea35bc2479ea0f56e4a796e6b0d55
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/permissions/parse_config.c

  Log Message:
  -----------
  permissions: fix possible buffer overflow

Fixes Coverity CID #40880


  Commit: ca75dae838e3395326bd6a03e8132b07b81fd10c
      https://github.com/OpenSIPS/opensips/commit/ca75dae838e3395326bd6a03e8132b07b81fd10c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/cpl_c/cpl_nonsig.c

  Log Message:
  -----------
  cpl_c: prevent possible buffer overflow

Fixes Coverity CID #40882


  Commit: 2552ade170ef09d28d2f1cb954aaafe601244f60
      https://github.com/OpenSIPS/opensips/commit/2552ade170ef09d28d2f1cb954aaafe601244f60
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-21 (Tue, 21 Jul 2020)

  Changed paths:
    M modules/carrierroute/route_func.c
    M modules/jabber/xjab_wlist.c
    M modules/media_exchange/media_utils.c
    M modules/mi_fifo/fifo_fnc.c
    M modules/sipmsgops/sipmsgops.c
    M modules/snmpstats/openserSIPRegUserLookupTable.c
    M modules/snmpstats/openserSIPStatusCodesTable.c

  Log Message:
  -----------
  fix some unused values

Fixes Coverity CID #40940, #40943, #40944, #40947, #40948, #211385,
    #211395, #211382


Compare: https://github.com/OpenSIPS/opensips/compare/20d589318d8e...2552ade170ef