[OpenSIPS-Devel] [OpenSIPS/opensips] 9fa878: db_text: Fix Coverity warning (bad 'switch' fallth...

Liviu Chircu noreply at github.com
Fri Jul 17 15:46:32 EST 2020 

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9fa8785610b46a71f1430bb2c9ba267aaf8883e4
      https://github.com/OpenSIPS/opensips/commit/9fa8785610b46a71f1430bb2c9ba267aaf8883e4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_lib.c

  Log Message:
  -----------
  db_text: Fix Coverity warning (bad 'switch' fallthrough)

Thanks to Răzvan Crainea for the help!

(cherry picked from commit 6b56ca5fa1163bc290a4c01f554e07cae860fa8c)
(cherry picked from commit 8b9307f2ec54a0f1551599254d1afbc6e0f7799b)


  Commit: b593fd7268c792d10f8ccddb10a484fc7a826fbb
      https://github.com/OpenSIPS/opensips/commit/b593fd7268c792d10f8ccddb10a484fc7a826fbb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix uninitialized variable

Although the severity is low, this code path could be triggered by a
bogus downstream registrar which returns a 200 OK without the Contact
advertised by the mid-registrar in its REGISTER request.

Fixes CID #200051

(cherry picked from commit a4684d54f1d32088936a345afa36cb66bbf53727)
(cherry picked from commit df197a285b7b6d3c751dce42a65f69a7d5abe68b)


  Commit: 59e1c65d67439785b02feeb9545e976353b0c39e
      https://github.com/OpenSIPS/opensips/commit/59e1c65d67439785b02feeb9545e976353b0c39e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/usrloc/dlist.c

  Log Message:
  -----------
  usrloc: Fix unitialized variable

CID #199971

(cherry picked from commit 5f03b8556bf241336795ba8ca517c982d732dd4a)
(cherry picked from commit 96428bcf3e5f849486862f6f4a481674e1d6fed3)


  Commit: e6a86b62287dd1101f2e624b543b6223b5b0dc10
      https://github.com/OpenSIPS/opensips/commit/e6a86b62287dd1101f2e624b543b6223b5b0dc10
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/freeswitch/esl/src/esl.c

  Log Message:
  -----------
  freeswitch: Fix a rare memleak

CID #164007

(cherry picked from commit 2a9824cdc955eb783e08f88906b70d337dbdebe9)
(cherry picked from commit 2aa619c00666e85631cd687f243d05585ac1478f)


  Commit: bd2b1510d747775567d0ac3f6fcc601075044d4c
      https://github.com/OpenSIPS/opensips/commit/bd2b1510d747775567d0ac3f6fcc601075044d4c
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M mem/hp_malloc.c

  Log Message:
  -----------
  HP_MALLOC status logging: Fix incorrect bitwise shift

CID #200101

(cherry picked from commit fcdd224a5c8638a28e3be10e4028c27aa404a637)


  Commit: ec827ab0ea0b3b25788efb500ed77e095d1261f5
      https://github.com/OpenSIPS/opensips/commit/ec827ab0ea0b3b25788efb500ed77e095d1261f5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M statistics.h

  Log Message:
  -----------
  statistics macros: Avoid unsigned integer comparisons against 0

CID #199900, #199913, #199923, #199934, #199941, #199964, #199998,
 #200032, #200049, #200074, #200096.

(cherry picked from commit 39fc05ec0ff2122dd79ec5582ac020c999c11c30)
(cherry picked from commit b497af00652cac0421f9e316bec4d5d12bb9ede3)


  Commit: d4751c61ff92775f8613c09e5fa518566077d6ca
      https://github.com/OpenSIPS/opensips/commit/d4751c61ff92775f8613c09e5fa518566077d6ca
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Remove unnecessary check

CID #199954

(cherry picked from commit 7a638403ee648ba629fd1f6f4a17bdea091da16d)
(cherry picked from commit c34e15660de83681a16c84ec61b96a85ec460e5d)


  Commit: a0d885d8380f24249aac03d86f1a6af5c4fb1edb
      https://github.com/OpenSIPS/opensips/commit/a0d885d8380f24249aac03d86f1a6af5c4fb1edb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/usrloc/ucontact.c

  Log Message:
  -----------
  usrloc: Remove unnecessary NULL check

CID #200086

(cherry picked from commit f305fa88f9341f37eb95bf88980e974723b57e94)
(cherry picked from commit 42b71cf855efa610c1c408caea7c3e54c039aa3f)


  Commit: 16a048a2f35ad269dfa6297461493cffca1972ed
      https://github.com/OpenSIPS/opensips/commit/16a048a2f35ad269dfa6297461493cffca1972ed
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Add paranoid safety check

This extra check doesn't fix anything right now, but at least it makes
Coverity happy.

CID #200020

(cherry picked from commit 2e60b50228a80c1e9629e43670a8cbcc5f71839c)
(cherry picked from commit 85464ef2a96f9a3b4665f8ddbeea3292149eac79)


  Commit: 1a0f6ce13b9ecd1d994caf64239389b6376a4677
      https://github.com/OpenSIPS/opensips/commit/1a0f6ce13b9ecd1d994caf64239389b6376a4677
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M sr_module.c

  Log Message:
  -----------
  sanitize mpath length

Fix Coverity #199897

(cherry picked from commit 587316afc6032142c96077e3efac8029d7fa8355)
(cherry picked from commit 4f3ed1239338e0c647bb387dcf5acdb51a6f3162)


  Commit: c753e447cde518c6b51f2871d5b88783e2878f69
      https://github.com/OpenSIPS/opensips/commit/c753e447cde518c6b51f2871d5b88783e2878f69
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M net/net_tcp.c
    M sr_module.c

  Log Message:
  -----------
  mpath: Fix possible buffer underrun

Also attempt to mask the false positive in CID #200070.

CID #211377

(cherry picked from commit 7f244f17a54833c6bb3f9ea58aa4afd855774ce1)
(cherry picked from commit 0108f2e7cba7e596b8f2ab20e0e176cbc9720744)


  Commit: e719be7ef19995a8dadbbb59c5c07fe684ce4693
      https://github.com/OpenSIPS/opensips/commit/e719be7ef19995a8dadbbb59c5c07fe684ce4693
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/drouting/routing.c

  Log Message:
  -----------
  drouting: Always NULL-terminate the GW buffer

While this doesn't immediately fix any bug, it should make Coverity
happy.

CID #200062

(cherry picked from commit df2ce6d826587f1130c5928b0815bd10ed2957f1)
(cherry picked from commit 2a8008ac6280059b9ba5548e7d856db7e0953ffb)


  Commit: 8e004981ac19130f18de250318a69d22166b19b8
      https://github.com/OpenSIPS/opensips/commit/8e004981ac19130f18de250318a69d22166b19b8
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/exec/exec.c

  Log Message:
  -----------
  exec: Always NULL-terminate the read buffer

CID #200052

(cherry picked from commit 0230f9c9032bd01661c6c7c197965528507e3f2c)
(cherry picked from commit 5ff4861e836cd97889c831c5f3533a985fb19d5e)


  Commit: 3cc0667696065aaa8bbd1f6f682a2be75cd72b94
      https://github.com/OpenSIPS/opensips/commit/3cc0667696065aaa8bbd1f6f682a2be75cd72b94
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/mi_datagram/datagram_fnc.c
    M modules/mi_datagram/mi_datagram.c

  Log Message:
  -----------
  mi_datagram: Minor improvements

    * always NULL-terminate the read buffer (CID #200029).  Doesn't fix
      any known bug, just a good practice
    * avoid redundant memset(65535) on each read
    * improve startup error log

(cherry picked from commit 0eee2119991270bd23a6279e6b1a825586f2d227)
(cherry picked from commit a2ae1349a19b2fc79d1893bef96d7f01434020cf)


  Commit: 2c10e899da817d303fc2cb393854933a38673028
      https://github.com/OpenSIPS/opensips/commit/2c10e899da817d303fc2cb393854933a38673028
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-17 (Fri, 17 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_res.c
    M modules/db_text/dbt_tb.c

  Log Message:
  -----------
  db_text: Complete 65b18091

(cherry picked from commit 673cf7f9eb3e5bd3a8da805483885e049bddc873)
(cherry picked from commit 11205ebef3ec4f207f33f01afe209518a0ed4453)


Compare: https://github.com/OpenSIPS/opensips/compare/3b93b691dd33...2c10e899da81

More information about the Devel mailing list