[OpenSIPS-Devel] [OpenSIPS/opensips] c7f724: proto_ws: make sure we have destination to connect to
Liviu Chircu
noreply at github.com
Fri Jul 17 13:05:17 EST 2020
Branch: refs/heads/coverity_scan
Home: https://github.com/OpenSIPS/opensips
Commit: c7f72410f68770fd3956cdd0d1e97c2add276a78
https://github.com/OpenSIPS/opensips/commit/c7f72410f68770fd3956cdd0d1e97c2add276a78
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/proto_ws/proto_ws.c
Log Message:
-----------
proto_ws: make sure we have destination to connect to
Fixes Coverity CID #58340
Commit: e22045c93926d80fef94aa940b0dadf0f9972ef9
https://github.com/OpenSIPS/opensips/commit/e22045c93926d80fef94aa940b0dadf0f9972ef9
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/proto_smpp/db.c
Log Message:
-----------
proto_smpp: skip entries with bad IP
Fixes Coverity CID #200075
Commit: 31899c1c724f7a44ef425b2f148528289d5cf7a0
https://github.com/OpenSIPS/opensips/commit/31899c1c724f7a44ef425b2f148528289d5cf7a0
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/proto_smpp/smpp.c
Log Message:
-----------
proto_smpp: prevent NULL deref in case of bogus input
Fixes coverity CID #199973 and #199931
Commit: 20736cc65ab6facc099b1422de4271c24fb4fcdb
https://github.com/OpenSIPS/opensips/commit/20736cc65ab6facc099b1422de4271c24fb4fcdb
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/proto_hep/hep.c
Log Message:
-----------
proto_hep: remove useless NULL check
Fixes Coverity CID #163991
Commit: 58df2d1f4e3c92400a02e96e58dd5c733f40f91b
https://github.com/OpenSIPS/opensips/commit/58df2d1f4e3c92400a02e96e58dd5c733f40f91b
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/proto_wss/proto_wss.c
Log Message:
-----------
proto_wss: add fall through indication
Fixes Coverity CID #58373
Commit: 6169e1b7f620e994d80fdc2d03828a3b5b838071
https://github.com/OpenSIPS/opensips/commit/6169e1b7f620e994d80fdc2d03828a3b5b838071
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/proto_tls/proto_tls.c
Log Message:
-----------
proto_tls: make sure we have destination to connect to
Fixes Coverity CID #58361
Commit: 4d5465e5765a0804dfac696af653cd77cd651b9b
https://github.com/OpenSIPS/opensips/commit/4d5465e5765a0804dfac696af653cd77cd651b9b
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/b2b_entities/dlg.c
M modules/b2b_logic/b2b_logic.c
M modules/b2b_logic/entity_storage.c
M modules/b2b_logic/logic.c
M modules/b2b_logic/records.c
M modules/b2b_sca/sca_logic.c
Log Message:
-----------
b2b_logic: fix coverity errors
Fixes CID #200000, #211411, #211412, #211413, #211414, #211362, #40885,
#40835, #40827, #40826, #40825, #40703, #40704
Commit: c447ea3370d6be7d49304a90a92780cc428d93aa
https://github.com/OpenSIPS/opensips/commit/c447ea3370d6be7d49304a90a92780cc428d93aa
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/db_text/dbt_file.c
Log Message:
-----------
db_text: complete coverity CID #200093
Commit: 87a1f31d20c54733a8ad8eaab33244ef9785dba1
https://github.com/OpenSIPS/opensips/commit/87a1f31d20c54733a8ad8eaab33244ef9785dba1
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M modules/compression/gz_helpers.c
M modules/cpl_c/cpl_parser.c
M modules/db_berkeley/bdb_lib.c
M modules/h350/h350_exp_fn.c
M modules/jabber/jabber.c
M modules/rabbitmq/rmq_servers.c
M modules/rabbitmq_consumer/rmq_connection.c
M modules/tls_mgm/tls_conn_ops.h
M modules/tls_mgm/tls_conn_server.h
Log Message:
-----------
fix more switch fall through
Coverity CID #199932, #199927, #164020, #164013, #150486, #58380,
#58379, #58375, #58374, #40705, #40700, #40701
Commit: 65b18091482db08a67dbb5195385511384116d54
https://github.com/OpenSIPS/opensips/commit/65b18091482db08a67dbb5195385511384116d54
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-10 (Fri, 10 Jul 2020)
Changed paths:
M db/db_ut.c
M db/db_ut.h
M modules/db_berkeley/bdb_res.c
M modules/db_berkeley/bdb_res.h
M modules/db_berkeley/db_berkeley.c
M modules/db_text/dbt_base.c
M modules/db_text/dbt_lib.c
M modules/db_text/dbt_lib.h
M modules/db_text/dbt_res.c
M modules/db_text/dbt_tb.c
Log Message:
-----------
db: merge db_is_neq_type() in db_ut
Fix coverity CID #40717, #40718, #40719, #40720, #40721, #40722
Commit: 673cf7f9eb3e5bd3a8da805483885e049bddc873
https://github.com/OpenSIPS/opensips/commit/673cf7f9eb3e5bd3a8da805483885e049bddc873
Author: Liviu Chircu <liviu at opensips.org>
Date: 2020-07-11 (Sat, 11 Jul 2020)
Changed paths:
M modules/db_text/dbt_res.c
M modules/db_text/dbt_tb.c
Log Message:
-----------
db_text: Complete 65b18091
Commit: 0d6f7beb997a02f5cec82e7f32221e8e2332b9cf
https://github.com/OpenSIPS/opensips/commit/0d6f7beb997a02f5cec82e7f32221e8e2332b9cf
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/presence/publish.c
Log Message:
-----------
[presence] use the right event type.
Use the event type corresponding to the handled presentity.
Reported by covrity in CID 199919.
Commit: 86158c895e695c7289874f84fddfef7154f1ec00
https://github.com/OpenSIPS/opensips/commit/86158c895e695c7289874f84fddfef7154f1ec00
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/call_center/call_center.c
Log Message:
-----------
[call_center] Fix ETA when no agents are logged
Reported by coverity CID 211393
Commit: f564faa0d51fe2a1e7625656cd597c5bb24b9033
https://github.com/OpenSIPS/opensips/commit/f564faa0d51fe2a1e7625656cd597c5bb24b9033
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M socket_info.c
Log Message:
-----------
[core] log error if add_alias() fails
Reported by coverity CID 211363
Commit: e43b6e52e1f41b841e2b1d5bf11747f07d7bcd99
https://github.com/OpenSIPS/opensips/commit/e43b6e52e1f41b841e2b1d5bf11747f07d7bcd99
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M core_cmds.c
Log Message:
-----------
[core] do not use LM_xxx if log_level is NULL
This may never happen, but as LM_xxx is testing the log_level value, it is not wise to use it to report that log_level is NULL
Reported by coverity CID 207925
Commit: 259e6f3a3f7d2fc131a7cbf787f3cd5c7b98c161
https://github.com/OpenSIPS/opensips/commit/259e6f3a3f7d2fc131a7cbf787f3cd5c7b98c161
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M action.c
Log Message:
-----------
[core] Fix printing the async cmd name in error log
Reported by coverity CID 199935
Commit: b805adcc81878a1ed316def5961be5245939fa1e
https://github.com/OpenSIPS/opensips/commit/b805adcc81878a1ed316def5961be5245939fa1e
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/rls/resource_notify.c
Log Message:
-----------
rls: release memory in case of error
Fixes Coverity CID #199983
Commit: 24aea8e634a1261b60bbf2a4a15218eece0bee46
https://github.com/OpenSIPS/opensips/commit/24aea8e634a1261b60bbf2a4a15218eece0bee46
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/pua_xmpp/simple2xmpp.c
Log Message:
-----------
pua_xmpp: release memory in case of error
Fixes Coverity CID #199967
Commit: a094bbc346c364cfc4d2bd75cc751375784d5a0d
https://github.com/OpenSIPS/opensips/commit/a094bbc346c364cfc4d2bd75cc751375784d5a0d
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/pua_dialoginfo/pua_dialoginfo.c
Log Message:
-----------
pua_dialoginfo: always parse callid
Fixes coverity CID #199930
Commit: 3b20c9db07ea88bd84609676f2657011588b8b41
https://github.com/OpenSIPS/opensips/commit/3b20c9db07ea88bd84609676f2657011588b8b41
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/registrar/save.c
Log Message:
-----------
[registrar] Proper init of delete_nh_he variable
The logic may end up to free_hostent(delete_nh_he) without actually using the delete_nh_he, leading to freeing so random pointers.
Reported by coverity CID 199942
Commit: 3112b5942636ad281783a5ba0ec13992e0c78693
https://github.com/OpenSIPS/opensips/commit/3112b5942636ad281783a5ba0ec13992e0c78693
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/xml/xml.c
Log Message:
-----------
xml: properly handle oom when extending $xml result buffer
Fixes Coverity CID #200068
Commit: b0135bb010c119328e9fb1ebb88f3f24c43fa27e
https://github.com/OpenSIPS/opensips/commit/b0135bb010c119328e9fb1ebb88f3f24c43fa27e
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/drouting/drouting.c
Log Message:
-----------
[drouting] Avoid handling a NULL 'gw' upon bogus function call
Reported by coverity CID 211365
Commit: a682789d58bc175ac3780e1ddae0b8b9eee9a32f
https://github.com/OpenSIPS/opensips/commit/a682789d58bc175ac3780e1ddae0b8b9eee9a32f
Author: Razvan Crainea <razvan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/rtpproxy/rtpproxy.c
Log Message:
-----------
rtpproxy: ignore unknown payload type media streams
Thanks go to @wangduanduan for reporting and providing troubleshoot info
Commit: 44abb30bbebcb701bd4b351b68b1a8e919d07abe
https://github.com/OpenSIPS/opensips/commit/44abb30bbebcb701bd4b351b68b1a8e919d07abe
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/tls_mgm/tls_mgm.c
Log Message:
-----------
tls_mgm: fix uninitialized variable
Fixes Coverity CID #199976
Commit: c489f462d236fddb883e64a6cde7b04929a76191
https://github.com/OpenSIPS/opensips/commit/c489f462d236fddb883e64a6cde7b04929a76191
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M net/net_tcp.c
Log Message:
-----------
[core] proper checking on return code for getsockname()
Reported by coverity CID 200064
Commit: 596c572da62169d453fface97d13ec557d200561
https://github.com/OpenSIPS/opensips/commit/596c572da62169d453fface97d13ec557d200561
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/event_flatstore/event_flatstore.c
Log Message:
-----------
event_flatstore: prevent NULL deref in case of bogus param
Fixes Coverity CID #207918
Commit: f3530c10adc1d2a5b01340a9823f84db61c98e72
https://github.com/OpenSIPS/opensips/commit/f3530c10adc1d2a5b01340a9823f84db61c98e72
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/pua_dialoginfo/pua_dialoginfo.c
Log Message:
-----------
[pua_dialoginfo] Fix bad test on resolving flag name
get_flag_id_by_name() may also return other negative codes than -1
Reported by coverity CID 207914
Commit: 11e63b35941766c09810aceb48ed300c808a1ef1
https://github.com/OpenSIPS/opensips/commit/11e63b35941766c09810aceb48ed300c808a1ef1
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/presence/subscribe.c
Log Message:
-----------
[presence] Proper testing for the return code of get_body()
Reported by coverity CID 207911
Commit: ab7d4430941263d20acd1f45bbbbf09c80a5040f
https://github.com/OpenSIPS/opensips/commit/ab7d4430941263d20acd1f45bbbbf09c80a5040f
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/drouting/drouting.c
Log Message:
-----------
[drouting] removed useless code
Makes no sense to select the table at db_con init time, as various queries (from various modules) may set and use different tables.
Related to coverity report CID 58405
Commit: e001abe34b2405ef31d7d3c616e18cc3551e5764
https://github.com/OpenSIPS/opensips/commit/e001abe34b2405ef31d7d3c616e18cc3551e5764
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/pua_dialoginfo/pua_dialoginfo.c
Log Message:
-----------
[pua_dialoginfo] Fix condition on empty "callee" string
Commit: 249b80741ddbb0952c7f737af2a7c2473f05eacf
https://github.com/OpenSIPS/opensips/commit/249b80741ddbb0952c7f737af2a7c2473f05eacf
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/nathelper/nathelper.c
Log Message:
-----------
[nathelper] Fix bad test on resolving flag name
get_flag_id_by_name() may also return other negative codes than -1
Reported by coverity CID 200026, 200005, 199906
Commit: b1d796344aa674e25fc4408bda5d336bce2bc605
https://github.com/OpenSIPS/opensips/commit/b1d796344aa674e25fc4408bda5d336bce2bc605
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/nathelper/sip_pinger.h
Log Message:
-----------
[nathelper] Proper testing upon extracting hash value
Be sure it is valid hexa and it it within the correct range. The lack of these tests may open the gate for some nasty exploits.
Reported by coverity CID 199958
Commit: d4abd53b202eeb5d0cd932fb6fa59e0074f3848e
https://github.com/OpenSIPS/opensips/commit/d4abd53b202eeb5d0cd932fb6fa59e0074f3848e
Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/presence/presence.c
Log Message:
-----------
[presence] fix ugly copy-paste error in MI output
Reported by coverity CID 200057
Commit: 4a18ce89c89b4f9831ff748bfa75e2aa5db1b303
https://github.com/OpenSIPS/opensips/commit/4a18ce89c89b4f9831ff748bfa75e2aa5db1b303
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/tls_mgm/tls.h
M modules/tls_mgm/tls_mgm.c
Log Message:
-----------
tls_mgm: set the TLS session id context with the proper length
Fixes Coverity CID #207904
Commit: 9bac91d5583ba8d640ca26d940e0d4e10f847a28
https://github.com/OpenSIPS/opensips/commit/9bac91d5583ba8d640ca26d940e0d4e10f847a28
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-15 (Wed, 15 Jul 2020)
Changed paths:
M modules/tm/mi.c
Log Message:
-----------
tm: fix bad string in the MI output of t_uac_dlg
Fixes Coverity CID #199965, #199943
Commit: 67ce5cab174ec6e285f2a763b387adad7d6b99d5
https://github.com/OpenSIPS/opensips/commit/67ce5cab174ec6e285f2a763b387adad7d6b99d5
Author: Vlad Paiu <vladpaiu at opensips.org>
Date: 2020-07-16 (Thu, 16 Jul 2020)
Changed paths:
M modules/rate_cacher/rate_cacher.c
Log Message:
-----------
Fix excluding vendors with no price
Closes #2169
Commit: dca4868a04b050fa54ea94a4e3a3bf0915b951ed
https://github.com/OpenSIPS/opensips/commit/dca4868a04b050fa54ea94a4e3a3bf0915b951ed
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-16 (Thu, 16 Jul 2020)
Changed paths:
M modules/rabbitmq_consumer/rmq_connection.c
Log Message:
-----------
rabbitmq_consumer: suppress coverity warning
Fixes Coverity CID #199947
Commit: 1319c4722ed9119e2dbedd4497598c1059a44342
https://github.com/OpenSIPS/opensips/commit/1319c4722ed9119e2dbedd4497598c1059a44342
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-16 (Thu, 16 Jul 2020)
Changed paths:
M modules/lua/sipstate.c
Log Message:
-----------
lua: remove an useless null check
Fixes Coverity CID # 199899
Commit: e7ba585438ff0f62feef5c0f6285adee1ace325c
https://github.com/OpenSIPS/opensips/commit/e7ba585438ff0f62feef5c0f6285adee1ace325c
Author: Vlad Patrascu <vladp at opensips.org>
Date: 2020-07-16 (Thu, 16 Jul 2020)
Changed paths:
M modules/rabbitmq/rmq_servers.c
Log Message:
-----------
rabbitmq: fix crash in case of bad parameter for rmq_publish
Fixes Coverity CID #199894
Commit: 58fa56c6eda2b4fe067bfe7a83b6a8aaba13bacb
https://github.com/OpenSIPS/opensips/commit/58fa56c6eda2b4fe067bfe7a83b6a8aaba13bacb
Author: Liviu Chircu <liviu at opensips.org>
Date: 2020-07-17 (Fri, 17 Jul 2020)
Changed paths:
M modules/registrar/save.c
Log Message:
-----------
registrar: Fix possible crash with no Contact
CID #211379
Commit: 82dfe4c408e614750c819e0a566a7312b96ec02a
https://github.com/OpenSIPS/opensips/commit/82dfe4c408e614750c819e0a566a7312b96ec02a
Author: Liviu Chircu <liviu at opensips.org>
Date: 2020-07-17 (Fri, 17 Jul 2020)
Changed paths:
M modules/tracer/tracer.c
Log Message:
-----------
tracer: Fix unchecked return codes
CID #200092, #200088
Commit: 374fde456c1f713a3cea29c90ccfb3d3d4de8ede
https://github.com/OpenSIPS/opensips/commit/374fde456c1f713a3cea29c90ccfb3d3d4de8ede
Author: Liviu Chircu <liviu at opensips.org>
Date: 2020-07-17 (Fri, 17 Jul 2020)
Changed paths:
M modules/rest_client/rest_methods.c
Log Message:
-----------
rest_client: Mask Coverity false positive
It is fine to push a stack pointer into libcurl during a sync transfer,
since the control flow never leaves the original function before it is
completely done with the library.
CID #200078
Commit: 1b4fcc06af59e479547d348935300949f0dfb70d
https://github.com/OpenSIPS/opensips/commit/1b4fcc06af59e479547d348935300949f0dfb70d
Author: Liviu Chircu <liviu at opensips.org>
Date: 2020-07-17 (Fri, 17 Jul 2020)
Changed paths:
M modules/tracer/tracer.c
Log Message:
-----------
tracer: Fix possible crash on NULL context
CID #200069
Commit: 908d362ecd2836e5d01885848c384ed3e9f4307a
https://github.com/OpenSIPS/opensips/commit/908d362ecd2836e5d01885848c384ed3e9f4307a
Author: Liviu Chircu <liviu at opensips.org>
Date: 2020-07-17 (Fri, 17 Jul 2020)
Changed paths:
M action.c
M core_cmds.c
M modules/call_center/call_center.c
M modules/db_text/dbt_res.c
M modules/db_text/dbt_tb.c
M modules/drouting/drouting.c
M modules/event_flatstore/event_flatstore.c
M modules/lua/sipstate.c
M modules/nathelper/nathelper.c
M modules/nathelper/sip_pinger.h
M modules/presence/presence.c
M modules/presence/publish.c
M modules/presence/subscribe.c
M modules/pua_dialoginfo/pua_dialoginfo.c
M modules/rabbitmq/rmq_servers.c
M modules/rabbitmq_consumer/rmq_connection.c
M modules/rate_cacher/rate_cacher.c
M modules/registrar/save.c
M modules/rest_client/rest_methods.c
M modules/rtpproxy/rtpproxy.c
M modules/tls_mgm/tls.h
M modules/tls_mgm/tls_mgm.c
M modules/tm/mi.c
M modules/tracer/tracer.c
M modules/xml/xml.c
M net/net_tcp.c
M socket_info.c
Log Message:
-----------
Merge branch 'master' into coverity_scan
Compare: https://github.com/OpenSIPS/opensips/compare/e6b63a2a9001...908d362ecd28
More information about the Devel
mailing list