[OpenSIPS-Devel] [OpenSIPS/opensips] 3340ea: pua: Fix some list management bugs; Improve code

Liviu Chircu noreply at github.com
Wed Jul 15 08:34:44 EST 2020


  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3340eae1eefa74191f282b03047c0d50ebb8c2b8
      https://github.com/OpenSIPS/opensips/commit/3340eae1eefa74191f282b03047c0d50ebb8c2b8
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-15 (Wed, 15 Jul 2020)

  Changed paths:
    M modules/pua/uri_list.h

  Log Message:
  -----------
  pua: Fix some list management bugs; Improve code

    * do not use strncmp() to compare "str" structs, since it may lead
      to false positives (e.g. strncmp("foobar", "foo", 3) == 0).  Use
      str_match() or str_strcmp() instead.

    * do not read memory after pkg_free() (severity: low, since it's PKG
      memory, so reading "invalid" heap memory works anyway...)

    * simplify list_pop() and list_free() code

(cherry picked from commit 5df8b636a15a799b5f1ab7a58ebe1c208ce49d2d)





More information about the Devel mailing list