[OpenSIPS-Devel] [OpenSIPS/opensips] f213a2: prevent leak in case of oom

Fri Jul 10 13:41:52 EST 2020

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f213a24a1a060134e130976108662b713c12077d
      https://github.com/OpenSIPS/opensips/commit/f213a24a1a060134e130976108662b713c12077d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  prevent leak in case of oom

Fixes Coverity #211383


  Commit: 439e4d41a3b7af6a4329dc57e529f06059b698e0
      https://github.com/OpenSIPS/opensips/commit/439e4d41a3b7af6a4329dc57e529f06059b698e0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M lib/reg/common.c

  Log Message:
  -----------
  fix tcp_persistent_flag when list is not defined properly

Fixes Coverity #211381


  Commit: 0983847c90cacd3ccd9e5a0d4185cf6dbfe108e2
      https://github.com/OpenSIPS/opensips/commit/0983847c90cacd3ccd9e5a0d4185cf6dbfe108e2
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/b2b_sca/sca_db_handler.c
    M modules/proto_ws/proto_ws.c
    M modules/speeddial/sdlookup.c
    M modules/tm/sip_msg.c
    M modules/tm/t_fifo.c
    M parser/parse_disposition.c
    M parser/parse_hname2.c
    M parser/parse_to.c
    M parser/parse_via.c
    M ut.c

  Log Message:
  -----------
  comment fall through switches

Fixes Coverity #40710, #211397, #40716, #40726, #40727, #40728, #40730,
    #40732, #58373, #58381, #199975, #200059, #200094, #211380, #211372,
    #211359


  Commit: c8afa69ccf6ce443a8e9f9f171c5599937f01066
      https://github.com/OpenSIPS/opensips/commit/c8afa69ccf6ce443a8e9f9f171c5599937f01066
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: fix several coverity issues

CID #211388, #211360, #211378, #211373, #211369


  Commit: 306f9e20a47cd0589bf8f3bfe4bc8ee09ce6f0a2
      https://github.com/OpenSIPS/opensips/commit/306f9e20a47cd0589bf8f3bfe4bc8ee09ce6f0a2
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: fix some coverity warnings

CID #211356 and #199981


  Commit: c63f262003c20c1fbd05eda35b6f7e9d04b3eda6
      https://github.com/OpenSIPS/opensips/commit/c63f262003c20c1fbd05eda35b6f7e9d04b3eda6
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/rtpproxy/notification_process.c

  Log Message:
  -----------
  rtpproxy: fix coverity issues

CID #207908, #207917, #150494, #40688


  Commit: 03ad3337ef89947facec95ea8e20216c2e945ff4
      https://github.com/OpenSIPS/opensips/commit/03ad3337ef89947facec95ea8e20216c2e945ff4
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: fix coverity issues

CID #40640, #40494, #199944, #211361, #211358, #150473, #40673


  Commit: 2bc8ff22b73b6c47a2147fe74d9cdfc1a1c9094a
      https://github.com/OpenSIPS/opensips/commit/2bc8ff22b73b6c47a2147fe74d9cdfc1a1c9094a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M evi/evi_params.h

  Log Message:
  -----------
  evi: annotate evi_param_set_int to fix Coverity

Fixes several Coverity alarms


  Commit: fe07e5de7ede080b96de47fea2ba72ce0e66b087
      https://github.com/OpenSIPS/opensips/commit/fe07e5de7ede080b96de47fea2ba72ce0e66b087
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: fix coverity CID #211388, #211360, #211369


  Commit: f02101aee6d321dbcd6f1d9c6f30422db35396dc
      https://github.com/OpenSIPS/opensips/commit/f02101aee6d321dbcd6f1d9c6f30422db35396dc
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: rework coverity CID #211369


  Commit: e3ca30ec98eae5dd344f7c5b75ca72ca3b3bcebc
      https://github.com/OpenSIPS/opensips/commit/e3ca30ec98eae5dd344f7c5b75ca72ca3b3bcebc
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: rework coverity fix CID #40640


  Commit: ec67fe3bfd0b122db6134c54df4152791fc2f9be
      https://github.com/OpenSIPS/opensips/commit/ec67fe3bfd0b122db6134c54df4152791fc2f9be
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/dialog/dialog.c

  Log Message:
  -----------
  dialog: fix coverity CID #40494


  Commit: 22df0da6f8628d6232832d3671b1dac3592f384e
      https://github.com/OpenSIPS/opensips/commit/22df0da6f8628d6232832d3671b1dac3592f384e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: use correct dialog for sync (fix CID #40673)


  Commit: 633822eafa09b941034493c43461c0bf8605b22e
      https://github.com/OpenSIPS/opensips/commit/633822eafa09b941034493c43461c0bf8605b22e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M evi/evi_params.h
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  rework some annotations to make coverity happy


  Commit: e68afc6281505fa90e79fbbcc0c61cc3bd64c471
      https://github.com/OpenSIPS/opensips/commit/e68afc6281505fa90e79fbbcc0c61cc3bd64c471
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: initialize dummy value to sink CID #199944


  Commit: 6326acd76a4c260f9077a84c44f70455b870c7a6
      https://github.com/OpenSIPS/opensips/commit/6326acd76a4c260f9077a84c44f70455b870c7a6
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: correctly handle str2int return code (CID #150473)


  Commit: 99f06ba10f4a15e049cdb4e246c3e69a99176acc
      https://github.com/OpenSIPS/opensips/commit/99f06ba10f4a15e049cdb4e246c3e69a99176acc
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/tracer/tracer.c

  Log Message:
  -----------
  tracer: make sure vars are initialized

Fixes Coverity CID #200098


  Commit: 395bfdc0c0ebe84a65d41f5827e965fd6dec676a
      https://github.com/OpenSIPS/opensips/commit/395bfdc0c0ebe84a65d41f5827e965fd6dec676a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: prevent buffer overflow

Fixes Coverity CID #200093


  Commit: 5fea3d3c89edbd41b174a61eea76ba3852671b7a
      https://github.com/OpenSIPS/opensips/commit/5fea3d3c89edbd41b174a61eea76ba3852671b7a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/mi_html/http_fnc.c

  Log Message:
  -----------
  mi_html: fix improper free on error

Fixes Coverity CID #200040


  Commit: 4ad1ce95978ddddaf8d99852bff24277d9b79803
      https://github.com/OpenSIPS/opensips/commit/4ad1ce95978ddddaf8d99852bff24277d9b79803
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/drouting/drouting.c
    M modules/drouting/prefix_tree.c
    M modules/freeswitch/esl/src/esl.c
    M modules/mi_html/http_fnc.c
    M modules/rate_cacher/rate_cacher.c

  Log Message:
  -----------
  remove dead code

Fixes Coverity CID #163971, #40603, #163958, #163961, #200036, #211354,
      #211370, #211394


  Commit: 574276035b182cabe81f040016b6b3ba70a3be47
      https://github.com/OpenSIPS/opensips/commit/574276035b182cabe81f040016b6b3ba70a3be47
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/qos/qos_ctx_helpers.c

  Log Message:
  -----------
  qos: fix getting SDP


  Commit: ce03fc2b7c23a899157ca81bd1bb66599df2bd83
      https://github.com/OpenSIPS/opensips/commit/ce03fc2b7c23a899157ca81bd1bb66599df2bd83
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M parser/parse_to.c

  Log Message:
  -----------
  parse_to: add fallthrough comments/indications for coverity CID #200094


  Commit: 4a3dbd9df79595a36bef638b6a49665f60419c97
      https://github.com/OpenSIPS/opensips/commit/4a3dbd9df79595a36bef638b6a49665f60419c97
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/tm/cluster.c

  Log Message:
  -----------
  tm: cleanup replicated cancel msg

Fixes Coverity CID #200031


  Commit: 6c4da323a3eb5916a06c6fe169935ea3a2296994
      https://github.com/OpenSIPS/opensips/commit/6c4da323a3eb5916a06c6fe169935ea3a2296994
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/db_text/dbt_file.c

  Log Message:
  -----------
  db_text: fix no-op code

fixes Coverity CID #200004


  Commit: 1b1dcaf3bcba6e0f79f8aaad38549ebf07df7951
      https://github.com/OpenSIPS/opensips/commit/1b1dcaf3bcba6e0f79f8aaad38549ebf07df7951
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: smpp_bind_transceiver_resp_t system id

Reported by Coverity CID #199918


  Commit: ac23294748b4c8cba1ea05b6dfcdca64a8894b07
      https://github.com/OpenSIPS/opensips/commit/ac23294748b4c8cba1ea05b6dfcdca64a8894b07
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-10 (Fri, 10 Jul 2020)

  Changed paths:
    M parser/sdp/sdp_helpr_funcs.c
    M xlog.c

  Log Message:
  -----------
  fix coverity detected false positives

CID #40557, #211391


Compare: https://github.com/OpenSIPS/opensips/compare/33a0d617d4bc...ac23294748b4