[OpenSIPS-Devel] [OpenSIPS/opensips] 0d069a: callops: fix several coverity issues

[Liviu Chircu]

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0d069a15f0309691ee78a65381ac7747c2f103b0
      https://github.com/OpenSIPS/opensips/commit/0d069a15f0309691ee78a65381ac7747c2f103b0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/callops/callops.c

  Log Message:
  -----------
  callops: fix several coverity issues

CID #211388, #211360, #211378, #211373, #211369


  Commit: f38267881330b323d1c60c93bdae48025e89fbf3
      https://github.com/OpenSIPS/opensips/commit/f38267881330b323d1c60c93bdae48025e89fbf3
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: fix some coverity warnings

CID #211356 and #199981


  Commit: 346d4a30d2fd9f942f152bd7d929fcc985766462
      https://github.com/OpenSIPS/opensips/commit/346d4a30d2fd9f942f152bd7d929fcc985766462
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/rtpproxy/notification_process.c

  Log Message:
  -----------
  rtpproxy: fix coverity issues

CID #207908, #207917, #150494, #40688


  Commit: 3e455a051411e6ebad58cf43ff5dee5512ec3a52
      https://github.com/OpenSIPS/opensips/commit/3e455a051411e6ebad58cf43ff5dee5512ec3a52
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: fix coverity issues

CID #40640, #40494, #199944, #211361, #211358, #150473, #40673


  Commit: 1f764638e47585968c7ba0e499ac0895d40d17e2
      https://github.com/OpenSIPS/opensips/commit/1f764638e47585968c7ba0e499ac0895d40d17e2
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M evi/evi_params.h

  Log Message:
  -----------
  evi: annotate evi_param_set_int to fix Coverity

Fixes several Coverity alarms


  Commit: 993a5ecb4d12613ebf4da0eaca202ad7b218855f
      https://github.com/OpenSIPS/opensips/commit/993a5ecb4d12613ebf4da0eaca202ad7b218855f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/pua/uri_list.h

  Log Message:
  -----------
  pua: Fix some list management bugs; Improve code

    * do not use strncmp() to compare "str" structs, since it may lead
      to false positives (e.g. strncmp("foobar", "foo", 3) == 0).  Use
      str_match() or str_strcmp() instead.

    * do not read memory after pkg_free() (severity: low, since it's PKG
      memory, so reading "invalid" heap memory works anyway...)

    * simplify list_pop() and list_free() code


  Commit: 3ca8ac01745e3209745577f1679ab0fbd8a4cd21
      https://github.com/OpenSIPS/opensips/commit/3ca8ac01745e3209745577f1679ab0fbd8a4cd21
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M lib/reg/lookup.c
    M modules/mid_registrar/lookup.c

  Log Message:
  -----------
  mid_registrar: Simplify lookup() code


  Commit: 74e82f42d370b6b5ae142ce3f53dcbfcd194a79a
      https://github.com/OpenSIPS/opensips/commit/74e82f42d370b6b5ae142ce3f53dcbfcd194a79a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M ut.h

  Log Message:
  -----------
  stop_expire_timer(): Fix uninitialized memory access

The severity is low, however, since uninitialized integer math is still
safe (from a stability PoV), with the resulting value being ignored
anyway.

Fixes CID #199911, #199922, #199926, #199966, #199987, #199990, #200085,
 #200054.


  Commit: 3cdacb8a9ccbd4b381e26254fadfe8000e00fb04
      https://github.com/OpenSIPS/opensips/commit/3cdacb8a9ccbd4b381e26254fadfe8000e00fb04
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/mid_registrar/save.c

  Log Message:
  -----------
  mid_registrar: Fix uninitialized variable

Although the severity is low, this code path could be triggered by a
bogus downstream registrar which returns a 200 OK without the Contact
advertised by the mid-registrar in its REGISTER request.

Fixes CID #200051


  Commit: 6b9d45fa7dadca6bb28a03c4733072e1baa89343
      https://github.com/OpenSIPS/opensips/commit/6b9d45fa7dadca6bb28a03c4733072e1baa89343
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  preprocessor: Fix memleak on preprocessing failure

Fixes CID #200047


  Commit: 01f2d9d5ad7bd8c18c38fec54c83bc4793cf916b
      https://github.com/OpenSIPS/opensips/commit/01f2d9d5ad7bd8c18c38fec54c83bc4793cf916b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/usrloc/dlist.c

  Log Message:
  -----------
  usrloc: Fix unitialized variable

CID #199971


  Commit: 02b5df40351ece367c0afcc46520f757d00bd99e
      https://github.com/OpenSIPS/opensips/commit/02b5df40351ece367c0afcc46520f757d00bd99e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-07-09 (Thu, 09 Jul 2020)

  Changed paths:
    M modules/freeswitch/esl/src/esl.c

  Log Message:
  -----------
  freeswitch: Fix a rare memleak

CID #164007


Compare: https://github.com/OpenSIPS/opensips/compare/7cce0d6d1d8f...02b5df40351e