[OpenSIPS-Devel] [OpenSIPS/opensips] 3e8b54: Refactor signaling, sl & tm APIs to add gen_totag()

[Bogdan Andrei IANCU]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3e8b549d7b20c4219c78e0769f4a010168e2d72e
      https://github.com/OpenSIPS/opensips/commit/3e8b549d7b20c4219c78e0769f4a010168e2d72e
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M modules/lua/sipluafunc.c
    M modules/script_helper/script_helper.c
    M modules/signaling/signaling.c
    M modules/signaling/signaling.h
    M modules/sl/sl.c
    M modules/sl/sl_api.h
    M modules/sl/sl_funcs.c
    M modules/sl/sl_funcs.h
    M modules/tm/t_reply.c
    M modules/tm/t_reply.h
    M modules/tm/tm.c
    M modules/tm/tm_load.h

  Log Message:
  -----------
  Refactor signaling, sl & tm APIs to add gen_totag()

This is a new function to generate the To-tag (which is msg specific and computed in a deterministic way) whitout actually sending a reply.

First stage of a fix for #1722

(cherry picked from commit 666e811eb42d367d823e252f329d89eb58fab822)


  Commit: ed455e2ea6923ff0420c9c1a40f22a97e9a95202
      https://github.com/OpenSIPS/opensips/commit/ed455e2ea6923ff0420c9c1a40f22a97e9a95202
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M modules/presence/hash.c
    M modules/presence/hash.h
    M modules/presence/subscribe.c

  Log Message:
  -----------
  Proper error handling in handle_subscribe

1) be sure we send back a 500 reply in all error cases
2) detect the cases of subscription session overlapping (see #1722)

This is based on ec1889638a9d43280ba1362f6108a175efd4a854, with the update of the generation of the To-tag before the subscription check/reply

(cherry picked from commit 4918544248c495b1099a54326f97a82df97bbe76)
(cherry picked from commit b4facfbec60783ac313c3c099451f4a850f315b4)


  Commit: 29f8b303d2219a4bc557c8b67d7ce9f098cda9e2
      https://github.com/OpenSIPS/opensips/commit/29f8b303d2219a4bc557c8b67d7ce9f098cda9e2
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  Proper handling of subscription session overlapping

1) be sure we send back a 500 reply in all error cases
2) detect the cases of subscription session overlapping (see #1722)

Similar to 4918544248c495b1099a54326f97a82df97bbe76

(cherry picked from commit 8f3e58938568d18a375e1eacba608795f7df59dd)


  Commit: d7849e457f78b20696eb0c90c08bbdc90e314aee
      https://github.com/OpenSIPS/opensips/commit/d7849e457f78b20696eb0c90c08bbdc90e314aee
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2020-01-10 (Fri, 10 Jan 2020)

  Changed paths:
    M modules/presence/subscribe.c

  Log Message:
  -----------
  Improve/clean logging on expire notifications

Credits go to @wdoekes / Walter Doekes
Related to #1722

(cherry picked from commit f12a53907d9829a949a9ca62a5a6d0e63695d2e9)
(cherry picked from commit 0260c9b32b95c83c0c03892cbdb95a8701cca98c)


Compare: https://github.com/OpenSIPS/opensips/compare/8179e1f8d9d5...d7849e457f78