[OpenSIPS-Devel] [OpenSIPS/opensips] 4ffe53: drouting: Fix an SHM leak with "acc_call_params_avp"

Liviu Chircu noreply at github.com
Wed Feb 26 12:30:00 EST 2020


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4ffe53608dfd95940a81f8638b79ec539452d23f
      https://github.com/OpenSIPS/opensips/commit/4ffe53608dfd95940a81f8638b79ec539452d23f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-02-26 (Wed, 26 Feb 2020)

  Changed paths:
    M modules/drouting/drouting.c
    M usr_avp.c

  Log Message:
  -----------
  drouting: Fix an SHM leak with "acc_call_params_avp"

Do NOT store an SHM pointer into an AVP, as you have a minimal chance of
somehow getting invoked so you can properly free it!  The solution is to
store the entire struct into the AVP, as a (char *) buffer -- the tm
module will properly free the whole AVP (including this buffer)
afterwards.

Thanks to Răzvan for the tip!





More information about the Devel mailing list