[OpenSIPS-Devel] [OpenSIPS/opensips] 242903: Add missing typedef keyword

Liviu Chircu noreply at github.com
Mon Feb 10 12:18:37 EST 2020


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 242903711399ccb4eafeac614129424ffddb0e1b
      https://github.com/OpenSIPS/opensips/commit/242903711399ccb4eafeac614129424ffddb0e1b
  Author: Peter Lemenkov <lemenkov at gmail.com>
  Date:   2020-02-08 (Sat, 08 Feb 2020)

  Changed paths:
    M modules/cachedb_local/cachedb_local_replication.h
    M modules/usrloc/ul_mod.h
    M modules/usrloc/usrloc.h

  Log Message:
  -----------
  Add missing typedef keyword

Without this keyword these struct definitions are considered by GCC as a
variable definition.

This was catched because there is a more strict check about these
variable definitions since GCC 10:

* https://gcc.gnu.org/gcc-10/porting_to.html#common

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>


  Commit: 7b59ee14e95ea3500dd8c3368b081404b9731c9b
      https://github.com/OpenSIPS/opensips/commit/7b59ee14e95ea3500dd8c3368b081404b9731c9b
  Author: Peter Lemenkov <lemenkov at gmail.com>
  Date:   2020-02-08 (Sat, 08 Feb 2020)

  Changed paths:
    M mem/hp_malloc.c
    M mi/mi_trace.c
    M mi/mi_trace.h
    M modules/b2b_entities/b2b_entities.c
    M modules/b2b_entities/dlg.h
    M modules/b2b_logic/b2b_logic.h
    M modules/dispatcher/dispatch.h
    M modules/emergency/emergency_methods.c
    M modules/emergency/emergency_methods.h
    M modules/emergency/http_emergency.h
    M modules/emergency/report_emergency.h
    M modules/emergency/sip_emergency.c
    M modules/emergency/subscriber_emergency.h
    M modules/emergency/xml_parser.h
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/mangler/mangler.c
    M modules/mangler/sdp_mangler.h
    M modules/permissions/permissions.h
    M modules/pua_dialoginfo/pua_dialoginfo.c
    M modules/pua_dialoginfo/pua_dialoginfo.h
    M modules/pua_usrloc/pua_usrloc.c
    M modules/pua_usrloc/pua_usrloc.h
    M modules/ratelimit/ratelimit_helper.c
    M modules/registrar/reg_mod.c
    M modules/registrar/reg_mod.h
    M obsolete_modules/sms/libsms_modem.c
    M obsolete_modules/sms/libsms_putsms.c
    M obsolete_modules/sms/sms_funcs.c
    M sr_module.h
    M ut.c
    M ut.h

  Log Message:
  -----------
  Fix building with gcc 10

GCC 10 started to use -no-common by default. Here is an official
explanation:

* https://gcc.gnu.org/gcc-10/porting_to.html#common

We have to mark all the declarations of global variables with extern
keyword and put the definitions into a proper file.

Signed-off-by: Peter Lemenkov <lemenkov at gmail.com>


  Commit: d986b8c09adc26fc818ba6aa1796991e40f0b20f
      https://github.com/OpenSIPS/opensips/commit/d986b8c09adc26fc818ba6aa1796991e40f0b20f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M mem/hp_malloc.c
    M mi/mi_trace.c
    M mi/mi_trace.h
    M modules/b2b_entities/b2b_entities.c
    M modules/b2b_entities/dlg.h
    M modules/b2b_logic/b2b_logic.h
    M modules/cachedb_local/cachedb_local_replication.h
    M modules/dispatcher/dispatch.h
    M modules/emergency/emergency_methods.c
    M modules/emergency/emergency_methods.h
    M modules/emergency/http_emergency.h
    M modules/emergency/report_emergency.h
    M modules/emergency/sip_emergency.c
    M modules/emergency/subscriber_emergency.h
    M modules/emergency/xml_parser.h
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/mangler/mangler.c
    M modules/mangler/sdp_mangler.h
    M modules/permissions/permissions.h
    M modules/pua_dialoginfo/pua_dialoginfo.c
    M modules/pua_dialoginfo/pua_dialoginfo.h
    M modules/pua_usrloc/pua_usrloc.c
    M modules/pua_usrloc/pua_usrloc.h
    M modules/ratelimit/ratelimit_helper.c
    M modules/registrar/reg_mod.c
    M modules/registrar/reg_mod.h
    M modules/usrloc/ul_mod.h
    M modules/usrloc/usrloc.h
    M obsolete_modules/sms/libsms_modem.c
    M obsolete_modules/sms/libsms_putsms.c
    M obsolete_modules/sms/sms_funcs.c
    M sr_module.h
    M ut.c
    M ut.h

  Log Message:
  -----------
  Merge branch 'gcc10_no_common' of https://github.com/lemenkov/opensips into lemenkov-gcc10_no_common


  Commit: afbf2871a144466a16534db8c86d7d0377077e17
      https://github.com/OpenSIPS/opensips/commit/afbf2871a144466a16534db8c86d7d0377077e17
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M modules/dispatcher/dispatch.c
    M modules/emergency/sip_emergency.c

  Log Message:
  -----------
  dispatcher:  Fix missing "tmb" definition


  Commit: b864b2915551fc25509a54eaf30df0cedbe1643f
      https://github.com/OpenSIPS/opensips/commit/b864b2915551fc25509a54eaf30df0cedbe1643f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2020-02-10 (Mon, 10 Feb 2020)

  Changed paths:
    M Makefile.defs

  Log Message:
  -----------
  make: Prepare for upcoming gcc 10 (use -fno-common)

Per https://gcc.gnu.org/gcc-10/porting_to.html#common, -fno-common will
become a default in gcc 10, so variables defined within .h files will no
longer be allowed!

Thanks to Peter Lemenkov for the suggestion!


Compare: https://github.com/OpenSIPS/opensips/compare/52f3fe21801d...b864b2915551



More information about the Devel mailing list