[OpenSIPS-Devel] [OpenSIPS/opensips] 688473: dialog: Fix unsafe profile list iteration

Liviu Chircu noreply at github.com
Mon Sep 30 11:43:27 EDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 688473a60e617ff3147dae4bc6cec641ca62cab9
      https://github.com/OpenSIPS/opensips/commit/688473a60e617ff3147dae4bc6cec641ca62cab9
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-09-30 (Mon, 30 Sep 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: Fix unsafe profile list iteration

The dialog->profile_links list _must always_ be walked after first
grabbing the dialog's lock, regardless of the current ref count.
Failing to do so may lead to invalid memory access, as the list
elements may get freed from other processes.

Many thanks to 46Labs for supporting this fix

(cherry picked from commit 5613922793b2b332354da30ab54b4e56f276bbda)
(cherry picked from commit 0877fac687faa4b1e6dc36edab2ee61f669ce556)





More information about the Devel mailing list