[OpenSIPS-Devel] [OpenSIPS/opensips] da1dac: usrloc: Fix a replicated AoR label matching bug

[Liviu Chircu]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: da1dac8f41b199dae0028546bd1e547e8ddef922
      https://github.com/OpenSIPS/opensips/commit/da1dac8f41b199dae0028546bd1e547e8ddef922
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-09-11 (Wed, 11 Sep 2019)

  Changed paths:
    M bin_interface.h
    M modules/dialog/dlg_replication.h
    M modules/usrloc/dlist.h
    M modules/usrloc/udomain.c
    M modules/usrloc/ul_cluster.c
    M modules/usrloc/ul_cluster.h

  Log Message:
  -----------
  usrloc: Fix a replicated AoR label matching bug

This patch makes it so the AoR label gets included in the "AoR created"
replication packets and mirrored in the receiver instance.  This
prevents a series of bugs where the usrloc API fails to match a contact
by its contact ID, e.g.:

    * nathelper being unable to delete dead TCP/TLS contacts after a
      restart + usrloc cluster sync

    * mid-registrar (mode 1) being unable to look up a contact by
      contact ID after a restart + usrloc cluster sync

Reported by @vasilevalex

Fixes #1492