[OpenSIPS-Devel] [OpenSIPS/opensips] 98636d: Fix #1804 - mid_registrar_save() should save new c...

Liviu Chircu noreply at github.com
Mon Sep 9 06:42:57 EDT 2019


  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 98636d41de9ee631e838df348c9ea2a0735cd1c2
      https://github.com/OpenSIPS/opensips/commit/98636d41de9ee631e838df348c9ea2a0735cd1c2
  Author: Aron Podrigal <aronp at guaranteedplus.com>
  Date:   2019-08-16 (Fri, 16 Aug 2019)

  Changed paths:
    M modules/usrloc/urecord.c

  Log Message:
  -----------
  Fix #1804 - mid_registrar_save() should save new contact from register following an unregister.

When using `sql_mode` is set to `SQL_WRITE_BACK` and  `rr_persist` is `RRP_LOAD_FROM_SQL` contacts are not
immediately deleted from memory, contacts are marked `expires = UL_EXPIRED_TIME`. So when a `REGISTER` request
is received following an UNREGISTER, do not return the previous contact marked for deletion.

Returning the previous contact record, could have potentially lead to a crash, if opensips would free the contact
record while mid_registrar would retreive that using `get_ucontact()`.


  Commit: 74e847af7469752802d6d4729bde6210512ea0c3
      https://github.com/OpenSIPS/opensips/commit/74e847af7469752802d6d4729bde6210512ea0c3
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-09-09 (Mon, 09 Sep 2019)

  Changed paths:
    M modules/usrloc/urecord.c

  Log Message:
  -----------
  Merge pull request #1805 from ar45/fix_1804_mis_registrar_save

Fix #1804 - mid_registrar_save() should save new contact from registeā€¦


Compare: https://github.com/OpenSIPS/opensips/compare/91210a9feee1...74e847af7469



More information about the Devel mailing list