[OpenSIPS-Devel] [OpenSIPS/opensips] 319b1b: load statistics: Fix a bunch of integer overflow bugs

Liviu Chircu noreply at github.com
Thu May 30 21:33:56 EDT 2019


  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 319b1ba229dc25ec3ac903d3659a8e98dd85a0a2
      https://github.com/OpenSIPS/opensips/commit/319b1ba229dc25ec3ac903d3659a8e98dd85a0a2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-05-31 (Fri, 31 May 2019)

  Changed paths:
    M pt_load.c

  Log Message:
  -----------
  load statistics: Fix a bunch of integer overflow bugs

Most of the summed up load statistics were skewed by a factor of 10, due
to a series of integer multiplications which was overflowing the 32-bit
result holder.

load, load1m, load10m before this patch (16 processes, 3 fully loaded):
12 99 9
12 99 9
12 101 10
13 103 10
13 104 10
12 106 10

... and after:

12 9 0
11 10 1
12 10 1
13 10 1

Fixes #1650

(cherry picked from commit 7f14b6a30a79e6156ae732d1cbb8f1e3f102e3d3)





More information about the Devel mailing list