[OpenSIPS-Devel] OpenSIPS/master is broken since 2 days ago

[Răzvan Crainea]

Hi, Maxim!

You're absolutely right, the bc9423713 commit is the one that broke 
OpenSIPS. I'll fix it right away, thanks for pointing it out!

Best regards,
Răzvan

On 6/27/19 6:58 AM, Maxim Sobolev wrote:
> Hi,
> 
> I've noticed that OpenSIPS/master is now crashing during our voiptests 
> run since about 2 days ago with the following message:
> 
> Jun 26 23:50:33 [22691] CRITICAL:core:qm_debug_frag:  qm_*: prev. fragm. 
> tail overwritten(646573755f78616d, 
> abcdef657a69735f)[0x7f2eb37a3b30:0x7f2eb37a3b60] (register_stat2, 
> statistics.c:407)!
> Aborted (core dumped)
> 
> I have not got time to dissect it down to a specific commit, but maybe 
> it's something obvious. Builds are triggered by cron, not by a specific 
> commit. The last known successful run was revision f682abe530, the first 
> know bad revision was 82c446d2922f, so the issue in question has been 
> introduced somewhere in between those two. Possible culprits are:
> 
> commit 82c446d2922fca59942e8b7835516486d8771fb4
> Author: Vlad Patrascu <vladp at opensips.org <mailto:vladp at opensips.org>>
> Date:   Tue Jun 25 17:55:33 2019 +0300
> 
>      sql_cacher: fix crashes when failing to validate db connections
> 
>      Fixes: #1734
> 
> commit 1f7af0bdc9021f369e4234cf14eb16ecc1c4dfee
> Author: Razvan Crainea <razvan at opensips.org <mailto:razvan at opensips.org>>
> Date:   Tue Jun 25 18:24:04 2019 +0300
> 
>      fix various LGTM warnings
> 
> commit d27a802f7b681fae3ebba0d643d7aa5f623b84b7
> Author: Razvan Crainea <razvan at opensips.org <mailto:razvan at opensips.org>>
> Date:   Tue Jun 25 18:09:36 2019 +0300
> 
>      net: handle new WRITE_ASYNC2 in main as well
> 
> commit bc94237132a93b0e3990382ebedc2eafe066f787
> Author: Razvan Crainea <razvan at opensips.org <mailto:razvan at opensips.org>>
> Date:   Tue Jun 25 17:35:13 2019 +0300
> 
>      replace ctime and localtime with safe functions
> 
>      replace ctime and localtime with ctime_r and localtime_r functions
> 
> commit 26ba59cb85e7952230672745c29dba443dafa040
> Author: Razvan Crainea <razvan at opensips.org <mailto:razvan at opensips.org>>
> Date:   Tue Jun 25 12:19:20 2019 +0300
> 
>      topo_hiding: warn when a generated message is malformed
> 
>      Close #1148
> 
> Just by looking at git logs the most suspicious commit is bc9423713, but 
> it could be something else. Full failed test log can be found here:
> 
> https://travis-ci.org/sippy/voiptests/jobs/550553513
> 
> Thanks!
> 
> -Max
> 

-- 
Răzvan Crainea
OpenSIPS Core Developer
   http://www.opensips-solutions.com