[OpenSIPS-Devel] [OpenSIPS/opensips] 590308: Script: Fix binary string comparisons

Liviu Chircu noreply at github.com
Fri Jun 21 11:40:19 EDT 2019


  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 590308e5dfa1399b392b7becde70bf6721ba3204
      https://github.com/OpenSIPS/opensips/commit/590308e5dfa1399b392b7becde70bf6721ba3204
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-06-21 (Fri, 21 Jun 2019)

  Changed paths:
    M route.c
    M ut.h

  Log Message:
  -----------
  Script: Fix binary string comparisons

Addresses the following:

$var(ip_1_s) = "[2001:6c8:5e00:1::249]";
$var(ip_1_b) = $(var(ip_1_s){ip.pton}); # Save binary IP to variable
$var(ip_2_s) = "[2001:6c8:5e00:1::24a]";
$var(ip_2_b) = $(var(ip_2_s){ip.pton}); # Save binary IP to variable
if ($var(ip_1_b) == $var(ip_2_b)) {
    xlog("Variable saved Binary addresses are EQUAL");
} else {
    xlog("Variable saved Binary addresses are DIFFERENT");
}

Correct result: DIFFERENT.  Maybe this should be a unit test somehow.

Reported by @vasilevalex
Related to #1568

(cherry picked from commit dee8a6a37577a5aa1c1621ba66acebfe7f47e3f4)


  Commit: d34d7eb57978413a6de92dd82fe1a5f4a777b7ce
      https://github.com/OpenSIPS/opensips/commit/d34d7eb57978413a6de92dd82fe1a5f4a777b7ce
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-06-21 (Fri, 21 Jun 2019)

  Changed paths:
    M db/db_id.c

  Log Message:
  -----------
  DB URL parser: Avoid double free on missing URL DB

On URLs such as:
    mysql://opensips:opensipsrw@master.naudb.service.consul

... the DB URL parser would perform a double free within the error
handling code.

Reported by Kirill Galinurov

(cherry picked from commit cba99632f18259f8e194246678793fa6e1723c3f)


Compare: https://github.com/OpenSIPS/opensips/compare/afcfc054735d...d34d7eb57978



More information about the Devel mailing list