[OpenSIPS-Devel] [OpenSIPS/opensips] 1ca050: Refactored presence/rls configuration for specifyi...

[Dan Pascu]

On a side note, there are 3 more modules that use the same server_address parameter to statically define the contact in the configuration: b2b_logic, pua_bla and pua_xmpp

Somebody who is familiar with them / uses them, should take a look and adjust them to do the same thing that this patch did in the presence and rls modules.

On 8 Jul 2019, at 7:44, Dan Pascu wrote:

>  Branch: refs/heads/master
>  Home:   https://github.com/OpenSIPS/opensips
>  Commit: 1ca0501eb2d8c4d9566b56a4baf7ffb6b0687361
>      https://github.com/OpenSIPS/opensips/commit/1ca0501eb2d8c4d9566b56a4baf7ffb6b0687361
>  Author: Dan Pascu <dan at ag-projects.com>
>  Date:   2019-07-08 (Mon, 08 Jul 2019)
> 
>  Changed paths:
>    M modules/presence/doc/presence_admin.xml
>    M modules/presence/presence.c
>    M modules/presence/presence.h
>    M modules/presence/subscribe.c
>    M modules/presence/subscribe.h
>    M modules/rls/doc/rls_admin.xml
>    M modules/rls/notify.c
>    M modules/rls/rls.c
>    M modules/rls/rls.h
>    M modules/rls/subscribe.c
> 
>  Log Message:
>  -----------
>  Refactored presence/rls configuration for specifying the Contact URI
> 
> Removed the server_address modparam and replaced it with contact_user.
> The server_address was used to specify the URI for the Contact header
> and it was optional for presence but mandatory for rls.
> 
> The idea of manually locking the Contact URI to a fixed value that is
> specified in the configuration is non-functional in any setup that
> involves the proxy listening on more than 1 IP/port/transport combo.
> 
> In the new model, the only configurable part of the Contact URI is the
> username part, that can be specified through the contact_user modparam,
> while the rest of the elements of the URI are automatically determined
> from the interface where the request was recevied or sent from.
> 
> 
> 
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


--
Dan