From dan at ag-projects.com  Mon Jul  1 07:20:39 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 1 Jul 2019 14:20:39 +0300
Subject: [OpenSIPS-Devel] Crash in latest opensips
Message-ID: <46125BCD-E5BA-4669-A2AA-00336D0C8E2C@ag-projects.com>

This crash happens with the latest git source as of today, at version b367b7c5d.

I had this crash happen twice in a few hours after running the same environment for more than a month without any change, so I guess it's not easy to reproduce.

The first time it crashed I got these entries in syslog for the process that crashed:

----------------------
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:send_fd: sendmsg failed on 172: Bad file descriptor
Jun 30 02:29:10 node15 ./opensips[3573]: ERROR:core:send2worker: send_fd failed
Jun 30 02:29:10 node15 ./opensips[3573]: ERROR:core:handle_tcpconn_ev: no TCP workers available
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del: [TCP_main] check failed after successful fd del (fd=221,flags=0, sflags=1) over map (fd=-1,type=0,data=(nil),flags=536870912) erase=1
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add: [TCP_main] check failed after successful fd add (fd=222,type=19,data=0x7ff16c0da018,flags=1) already=0
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del: [TCP_main] check failed after successful fd del (fd=222,flags=16, sflags=3) over map (fd=-1,type=0,data=(nil),flags=0) erase=1
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add: [TCP_main] check failed after failed fd add (fd=220,type=19,data=0x7ff16c1042a8,flags=1) already=-1
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add: [TCP_main] check failed after successful fd add (fd=222,type=19,data=0x7ff16c1042a8,flags=1) already=0
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del: [TCP_main] check failed after successful fd del (fd=222,flags=16, sflags=3) over map (fd=-1,type=0,data=(nil),flags=0) erase=1
Jun 30 02:29:14 node15 ./opensips[3573]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff16c1042a8), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: child process 3573 exited by a signal 6
----------------------

and the backtrace reads:

(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ff18de72535 in __GI_abort () at abort.c:79
#2  0x000056070c29962f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
    func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
#3  0x000056070c4b34ee in _shm_free (file=0x56070c6485a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
    ptr=0x7ff16c1042a8) at net/../mem/shm_mem.h:448
#4  _tcpconn_rm (c=c at entry=0x7ff16c1042a8) at net/net_tcp.c:747
#5  0x000056070c4d221e in __tcpconn_lifetime (force=0) at net/net_tcp.c:1608
#6  tcp_main_server () at net/net_tcp.c:1695
#7  0x000056070c4dc41a in tcp_start_listener () at net/net_tcp.c:2114
#8  0x000056070bfb5eba in main_loop () at main.c:813
#9  main (argc=<optimized out>, argv=<optimized out>) at main.c:1480


At the same time a second process crashed with the following in syslog (this looks like the main process trying to do cleanup):

-----------------------
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: child process 3573 exited by a signal 6
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: core was generated
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: terminating due to SIGCHLD
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 1(3554) [JSON-RPC sender] terminated, still waiting for 15 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 2(3555) [MI Datagram] terminated, still waiting for 14 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 3(3556) [MI FIFO] terminated, still waiting for 13 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 4(3557) [time_keeper] terminated, still waiting for 12 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 5(3558) [timer] terminated, still waiting for 11 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 12(3565) [TCP receiver] terminated, still waiting for 10 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 13(3566) [TCP receiver] terminated, still waiting for 9 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 11(3564) [TCP receiver] terminated, still waiting for 8 more
Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 15(3570) [TCP receiver] terminated, still waiting for 7 more
Jun 30 02:29:19 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 9(3562) [SIP receiver udp:81.23.228.160:5060] terminated, still waiting for 6 more
Jun 30 02:29:21 node15 ./opensips[3552]: INFO:core:cleanup: cleanup
Jun 30 02:29:21 node15 ./opensips[3552]: INFO:db_mysql:switch_state_to_disconnected: disconnect event for 0x60b00000b9e0
Jun 30 02:29:21 node15 ./opensips[3552]: INFO:db_mysql:reset_all_statements: resetting all statements on connection: (0x60d000005b40) 0x60b00000b9e0
Jun 30 02:29:21 node15 ./opensips[3552]: INFO:db_mysql:connect_with_retry: re-connected successful for 0x60b00000b9e0
Jun 30 02:29:21 node15 ./opensips[3552]: NOTICE:presence:destroy: destroy module ...
Jun 30 02:29:21 node15 ./opensips[3552]: NOTICE:event_jsonrpc:destroy: destroy module ...
Jun 30 02:29:21 node15 ./opensips[3552]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff16c10a6f0), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
-----------------------

and this backtrace:

(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ff18de72535 in __GI_abort () at abort.c:79
#2  0x000056070c29962f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
    func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
#3  0x000056070c4b34ee in _shm_free (file=0x56070c6485a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
    ptr=0x7ff16c10a6f0) at net/../mem/shm_mem.h:448
#4  _tcpconn_rm (c=0x7ff16c10a6f0) at net/net_tcp.c:747
#5  0x000056070c4d5f12 in __tcpconn_lifetime (force=1) at net/net_tcp.c:1608
#6  tcp_destroy () at net/net_tcp.c:1811
#7  0x000056070c1e551a in cleanup (show_status=show_status at entry=1) at main.c:360
#8  0x000056070c1e69aa in shutdown_opensips (status=status at entry=134) at main.c:522
#9  0x000056070c1e7ca0 in handle_sigs () at main.c:605
#10 0x000056070bfb65fe in main_loop () at main.c:867
#11 main (argc=<optimized out>, argv=<optimized out>) at main.c:1480


The second time syslog didn't have much detail except the critical double free error. This time it also had 2 crashed processes. The first one had this:

------------------------
Jun 30 03:11:47 node15 ./opensips[18284]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff8ed303b38), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
------------------------

and backtrace:

(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ff90f1f2535 in __GI_abort () at abort.c:79
#2  0x00005584676ff62f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
    func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
#3  0x00005584679194ee in _shm_free (file=0x558467aae5a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
    ptr=0x7ff8ed303b38) at net/../mem/shm_mem.h:448
#4  _tcpconn_rm (c=c at entry=0x7ff8ed303b38) at net/net_tcp.c:747
#5  0x0000558467919d4a in tcpconn_destroy (tcpconn=0x7ff8ed303b38) at net/net_tcp.c:1005
#6  0x000055846792a707 in handle_tcp_worker (fd_i=<optimized out>, tcp_c=0x6160000039c8) at net/net_tcp.c:1335
#7  handle_io (fm=<optimized out>, idx=idx at entry=22, event_type=event_type at entry=1) at net/net_tcp.c:1525
#8  0x0000558467937831 in io_wait_loop_epoll (h=<optimized out>, t=5, repeat=0) at net/../io_wait_loop.h:280
#9  tcp_main_server () at net/net_tcp.c:1695
#10 0x000055846794241a in tcp_start_listener () at net/net_tcp.c:2114
#11 0x000055846741beba in main_loop () at main.c:813
#12 main (argc=<optimized out>, argv=<optimized out>) at main.c:1480


and the main process had:

---------------------
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:handle_sigs: child process 18284 exited by a signal 6
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:handle_sigs: core was generated
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:handle_sigs: terminating due to SIGCHLD
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 2(18258) [MI Datagram] terminated, still waiting for 15 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 1(18257) [JSON-RPC sender] terminated, still waiting for 14 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 12(18273) [TCP receiver] terminated, still waiting for 13 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 14(18278) [TCP receiver] terminated, still waiting for 12 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 3(18259) [MI FIFO] terminated, still waiting for 11 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 4(18260) [time_keeper] terminated, still waiting for 10 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 13(18276) [TCP receiver] terminated, still waiting for 9 more
Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 5(18261) [timer] terminated, still waiting for 8 more
Jun 30 03:11:54 node15 ./opensips[18255]: INFO:core:cleanup: cleanup
Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:switch_state_to_disconnected: disconnect event for 0x60b00002fed0
Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:reset_all_statements: resetting all statements on connection: (0x60d000005b40) 0x60b00002fed0
Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:connect_with_retry: re-connected successful for 0x60b00002fed0
Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:db_mysql_do_prepared_query: reconnected to mysql server -> re-init the statement
Jun 30 03:11:56 node15 ./opensips[18255]: NOTICE:presence:destroy: destroy module ...
Jun 30 03:11:56 node15 ./opensips[18255]: NOTICE:event_jsonrpc:destroy: destroy module ...
Jun 30 03:11:56 node15 ./opensips[18255]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff8ed31b098), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
---------------------

and backtrace:

(gdb) bt
#0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
#1  0x00007ff90f1f2535 in __GI_abort () at abort.c:79
#2  0x00005584676ff62f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
    func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
#3  0x00005584679194ee in _shm_free (file=0x558467aae5a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
    ptr=0x7ff8ed31b098) at net/../mem/shm_mem.h:448
#4  _tcpconn_rm (c=0x7ff8ed31b098) at net/net_tcp.c:747
#5  0x000055846793bf12 in __tcpconn_lifetime (force=1) at net/net_tcp.c:1608
#6  tcp_destroy () at net/net_tcp.c:1811
#7  0x000055846764b51a in cleanup (show_status=show_status at entry=1) at main.c:360
#8  0x000055846764c9aa in shutdown_opensips (status=status at entry=134) at main.c:522
#9  0x000055846764dca0 in handle_sigs () at main.c:605
#10 0x000055846741c5fe in main_loop () at main.c:867
#11 main (argc=<optimized out>, argv=<optimized out>) at main.c:1480

--
Dan






From dan at ag-projects.com  Mon Jul  1 07:24:45 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 1 Jul 2019 14:24:45 +0300
Subject: [OpenSIPS-Devel] TCP connections
Message-ID: <CDF3338D-0092-4933-81BC-A580E08DDE8F@ag-projects.com>


When I list the tcp connections through the MI interface I see the entry below:

        {
            "ID": 792633175,
            "Type": "tcp",
            "State": -1,
            "Remote": "xx.xx.xx.xx:5060",
            "Local": "yy.yy.yy.yy:44511",
            "Lifetime": "2019-06-30 08:32:22"
        },

The sampling was done on 2019-07-30 13:23:36, so this entry looks like it was expired for more than 24 hours yet still not removed from the list.

--
Dan






From dan at ag-projects.com  Mon Jul  1 07:27:16 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 1 Jul 2019 14:27:16 +0300
Subject: [OpenSIPS-Devel] TCP connections
In-Reply-To: <CDF3338D-0092-4933-81BC-A580E08DDE8F@ag-projects.com>
References: <CDF3338D-0092-4933-81BC-A580E08DDE8F@ag-projects.com>
Message-ID: <710AF046-517B-4551-8906-40A8BBF248DF@ag-projects.com>


On 1 Jul 2019, at 14:24, Dan Pascu wrote:

> 
> When I list the tcp connections through the MI interface I see the entry below:
> 
>        {
>            "ID": 792633175,
>            "Type": "tcp",
>            "State": -1,
>            "Remote": "xx.xx.xx.xx:5060",
>            "Local": "yy.yy.yy.yy:44511",
>            "Lifetime": "2019-06-30 08:32:22"
>        },
> 
> The sampling was done on 2019-07-30 13:23:36, so this entry looks like it was expired for more than 24 hours yet still not removed from the list.

Sorry I mistyped this, I meant 2019-07-01 (i.e. today)

--
Dan






From noreply at github.com  Mon Jul  1 07:29:42 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Mon, 01 Jul 2019 04:29:42 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3ddae4: dialog: load dialogs
	on child init
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/42f65b-3ddae4@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3ddae43445cd6f3e3f6d4e9480f1e8c35801d008
      https://github.com/OpenSIPS/opensips/commit/3ddae43445cd6f3e3f6d4e9480f1e8c35801d008
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-01 (Mon, 01 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h

  Log Message:
  -----------
  dialog: load dialogs on child init




From noreply at github.com  Tue Jul  2 07:14:14 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Tue, 02 Jul 2019 04:14:14 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 88b84e: Fixed missing reset of
 current transaction holder
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/7daac5-88b84e@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 88b84e90145b7582be85793b47b7d0456b98831d
      https://github.com/OpenSIPS/opensips/commit/88b84e90145b7582be85793b47b7d0456b98831d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M modules/tm/tm.c

  Log Message:
  -----------
  Fixed missing reset of current transaction holder

The missing reset could lead to wrong access to old transactions when running more than one notification route, one after each other.

Credits for reporting and helping with testing go to Ivailo Dobrev




From noreply at github.com  Tue Jul  2 07:15:49 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Tue, 02 Jul 2019 04:15:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2bad50: Fixed missing reset of
 current transaction holder
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/ee3bd4-2bad50@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2bad502a87cb03d286aaa6f8e9bcae59b86b60af
      https://github.com/OpenSIPS/opensips/commit/2bad502a87cb03d286aaa6f8e9bcae59b86b60af
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M modules/tm/tm.c

  Log Message:
  -----------
  Fixed missing reset of current transaction holder

The missing reset could lead to wrong access to old transactions when running more than one notification route, one after each other.

Credits for reporting and helping with testing go to Ivailo Dobrev

(cherry picked from commit 88b84e90145b7582be85793b47b7d0456b98831d)




From noreply at github.com  Tue Jul  2 07:16:39 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Tue, 02 Jul 2019 04:16:39 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b9bcc8: Fixed missing reset of
 current transaction holder
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/3ddae4-b9bcc8@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b9bcc83903a88ce459688e433f63743631ebc3a8
      https://github.com/OpenSIPS/opensips/commit/b9bcc83903a88ce459688e433f63743631ebc3a8
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M modules/tm/tm.c

  Log Message:
  -----------
  Fixed missing reset of current transaction holder

The missing reset could lead to wrong access to old transactions when running more than one notification route, one after each other.

Credits for reporting and helping with testing go to Ivailo Dobrev

(cherry picked from commit 88b84e90145b7582be85793b47b7d0456b98831d)




From Ben.Newlin at genesys.com  Tue Jul  2 20:17:58 2019
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Wed, 3 Jul 2019 00:17:58 +0000
Subject: [OpenSIPS-Devel] Erroneous Retransmissions
In-Reply-To: <DEFED803-1DB5-489C-B03A-E2AD2876004E@genesys.com>
References: <038A054B-48FF-4CBA-9DF4-5543D6C8095D@genesys.com>
 <4CD67E78-F4A4-4CE6-B189-67D9E9CCE3A5@genesys.com>
 <D971C178-7D3F-464D-A2B6-631960129C86@genesys.com>
 <83f7d17e-692a-0b3d-b0e1-d0703de9da8d@opensips.org>
 <DEFED803-1DB5-489C-B03A-E2AD2876004E@genesys.com>
Message-ID: <2453866F-C561-48C4-99EF-F412ED67D089@genesys.com>

Hello,

This issue has not gotten a lot of response, but after upgrading to the latest 2.4 branch, we are still seeing cases where OpenSIPS retransmits a message even though a response has been received and processed already. In this case the retransmission occurred across a second boundary, so the timestamps in OpenSIPS' logs clearly show the retransmission was after successful processing of the first reply.

Latest example here: https://pastebin.com/9R47gN4W

In this example, you can see process 333 receives a REFER message at 19:28:51 and forwards it on to the next server. Following that process 331 receives a 405 response, also at 19:28:51. The response is processed and relayed back to the originator. But then at 19:28:52, the retransmission timer kicks anyway and process 327 retransmits the REFER. This causes another 405 response which is received by process 330 and relayed again.

I have logs, packet captures, and anything else necessary to debug this issue. I can reproduce it very easily.

Ben Newlin 

On 5/20/19, 8:50 AM, "Devel on behalf of Ben Newlin" <devel-bounces at lists.opensips.org on behalf of Ben.Newlin at genesys.com> wrote:

    Razvan,
    
    I realize the microsecond stamp is not on each line, but I don't think that means this trace is not proving the issue. You can clearly see that the time between the last ms stamp before the timer is set (2019-05-17T13:48:10.440789Z) to the next stamp after the retransmission has occurred (2019-05-17T13:48:10.557105Z) is only 117ms, and this includes a lot of processing time after the retransmission was sent. I think that pretty clearly shows the issue.
    
    I would love to get more exact granularity for the logs, but OpenSIPS does not provide that. We are not using syslog; the timestamps on the OpenSIPS logs are coming from OpenSIPS directly, as are the prefixed stamps on my logs. I'm not aware of any way to instruct OpenSIPS to increase the granularity of that timestamp, so I'm not sure how to get you what you want.
    
    In addition, the numerous other traces I have provided clearly show retransmissions being sent after replies for the request have already been processed. No time stamps are necessary to see that; the retransmission logs are printing after the reply processing logs. It is very clear.
    
    Ben Newlin 
    
    On 5/20/19, 3:51 AM, "Devel on behalf of Răzvan Crainea" <devel-bounces at lists.opensips.org on behalf of razvan at opensips.org> wrote:
    
        Hi, Ben!
        
        You are right, we are pretty busy trying to complete the 3.0 release, 
        that's why we are pushing back some of the reports.
        I did check the logs that you have sent, and it doesn't seem to prove 
        the issue, as the microsec timestamp is not logged by each line. It 
        would be more helpful if you could also configure syslog to log the 
        microseconds.
        
        Best regards,
        Răzvan
        
        On 5/17/19 9:20 PM, Ben Newlin wrote:
        > Hello,
        > 
        > I know you guys are probably heads down trying to get 3.0 out the door. 
        > I’m hoping that’s why this issue hasn’t gotten any traction. However, 
        > I’m continuing to see poor retransmission behavior from OpenSIPS. Traces 
        > from the most recent example are here: https://pastebin.com/4Lam9FaZ.
        > 
        > In this trace I’ve left in some of our proprietary tracing that show a 
        > more detailed timestamp. OpenSIPS is receiving a BYE request and sets a 
        > retransmission timer for 500ms, the standard time. However, the timer 
        > popped after only ~124ms and a retransmission of the BYE was triggered. 
        > I have tcpdump traces confirming the retransmission of the BYE actually 
        > occurred at 124ms, this is not just an issue internal to OpenSIPS.
        > 
        > Any insight our troubleshooting assistance with these issues would be 
        > greatly appreciated. This issue reproduces very regularly.
        > 
        > Ben Newlin
        > 
        > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin 
        > <Ben.Newlin at genesys.com>
        > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
        > *Date: *Wednesday, May 8, 2019 at 3:13 PM
        > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
        > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
        > 
        > Has anyone had a chance to look into this issue? I was able to mitigate 
        > by inserting small delays in my test clients, but now I am running into 
        > an issue where responses from one OpenSIPS to another are being sent 
        > quickly enough to cause this problem. Making changes in my testbed is 
        > one thing, but I really don’t want to start injecting delays into my 
        > processing script to work around this issue.
        > 
        > The issue is that final responses to a transaction that are received 
        > within a few milliseconds of the transaction being sent are not stopping 
        > the retransmission timer. The response is handled properly by OpenSIPS, 
        > but approximately 500ms later OpenSIPS will retransmit the request 
        > anyway. I can reproduce it very regularly in our testbed and it should 
        > also be easily reproducible with a simple SIPp scenario.
        > 
        > Trace from the latest occurrence is here: https://pastebin.com/YAXFwNLb
        > 
        > I’d be happy to open an issue on Github as well if that is desired.
        > 
        > Ben Newlin
        > 
        > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin 
        > <Ben.Newlin at genesys.com>
        > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
        > *Date: *Thursday, April 25, 2019 at 11:46 AM
        > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
        > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
        > 
        > I have found that this issue seems to only occur when the responses are 
        > received immediately after the request has been sent; within a few 
        > milliseconds. Inserting a delay in the response seems to have made the 
        > erroneous retransmissions stop. This does not make it any less of a bug, 
        > but does seem to be a workaround.
        > 
        > Ben Newlin
        > 
        > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin 
        > <Ben.Newlin at genesys.com>
        > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
        > *Date: *Friday, April 19, 2019 at 8:47 AM
        > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
        > *Subject: *[OpenSIPS-Devel] Erroneous Retransmissions
        > 
        > Resending the issue described below to the devel mailing list as I 
        > believe this is a bug, not a configuration issue.
        > 
        > Ben Newlin
        > 
        > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin 
        > <Ben.Newlin at genesys.com>
        > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
        > *Date: *Monday, April 15, 2019 at 7:20 PM
        > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
        > *Subject: *Re: [OpenSIPS-Users] Erroneous Retransmissions
        > 
        > Just wanted to bump this to see if anyone has had a chance to take a 
        > look. We are continuing to see this failing our tests intermittently. I 
        > have a new example here: https://pastebin.com/kQJSGE56.
        > 
        > In this example you can see that the retransmission of the INVITE is 
        > occurring not just after the 100 Trying has been received, but also 
        > after a 500 final response has already been received and is being 
        > processed, but the INVITE is still retransmitted!
        > 
        > Any help on this would be greatly appreciated.
        > 
        > # opensips -V
        > 
        > version: opensips 2.4.5 (x86_64/linux)
        > 
        > flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, 
        > F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
        > 
        > ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
        > MAX_URI_SIZE 1024, BUF_SIZE 65535
        > 
        > poll method support: poll, epoll, sigio_rt, select.
        > 
        > git revision: d025b4f61
        > 
        > main.c compiled on 21:18:18 Apr 12 2019 with gcc 7
        > 
        > Ben Newlin
        > 
        > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin 
        > <Ben.Newlin at genesys.com>
        > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
        > *Date: *Thursday, April 4, 2019 at 3:10 PM
        > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
        > *Subject: *[OpenSIPS-Users] Erroneous Retransmissions
        > 
        > Hello,
        > 
        > We are seeing an issue which is causing our tests to fail 
        > intermittently. It appears that sometimes OpenSIPS will retransmit a 
        > relayed INVITE request, even though a 100 Trying response has already 
        > been received and processed. This only happens intermittently.
        > 
        > I have captured debug logs for the scenario: 
        > https://pastebin.com/bHcBJmtv. In the log, you can see the 100 Trying 
        > response is received on line 707 and it appears to be matched to the 
        > correct transaction on line 729. However then on line 774 you can see 
        > the retransmission of the INVITE anyway.
        > 
        > I have verified using tcpdump that the INVITE is being retransmitted; it 
        > is not just a log error. And our tests are failing due to the unexpected 
        > extra 100 Trying response to the retransmission.
        > 
        > Can anyone explain why this would occur?
        > 
        > Ben Newlin
        > 
        > 
        > _______________________________________________
        > Devel mailing list
        > Devel at lists.opensips.org
        > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
        > 
        
        -- 
        Răzvan Crainea
        OpenSIPS Core Developer
           http://www.opensips-solutions.com
        Meet the OpenSIPS team at the next OpenSIPS Summit:
           https://www.opensips.org/events
        
        _______________________________________________
        Devel mailing list
        Devel at lists.opensips.org
        http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
        
        
    
    _______________________________________________
    Devel mailing list
    Devel at lists.opensips.org
    http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
    


From noreply at github.com  Wed Jul  3 03:19:53 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:19:53 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d8c03f: acc: fix leak
 generated by dialog replicated update
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/b9bcc8-a9b238@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d8c03f325993e59242f156de01dffa60cc8324b4
      https://github.com/OpenSIPS/opensips/commit/d8c03f325993e59242f156de01dffa60cc8324b4
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h

  Log Message:
  -----------
  acc: fix leak generated by dialog replicated update


  Commit: 0d31e6bd038ae6cfed130e421bb5afbcaa8b5f15
      https://github.com/OpenSIPS/opensips/commit/0d31e6bd038ae6cfed130e421bb5afbcaa8b5f15
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M mem/hp_malloc_stats.c
    M mem/hp_malloc_stats.h

  Log Message:
  -----------
  fix stats decremented with unsigned values

Reported by Coverity CID #200104, #200030, #200096, #200091, #200090,
 #200074, #200073, #200049, #200039, #200035, #200032, #200009,
 #200003, #199998, #199996, #199991, #199988, #199986, #199985,
 #199982, #199977, #199970, #199964, #199963, #199960, #199952,
 #199948, #199945, #199941, #199938, #199934, #199923, #199920
 #199913, #199900, #199896


  Commit: 9db6556a7fb1221ffa061fde0bef0a65d5e89c27
      https://github.com/OpenSIPS/opensips/commit/9db6556a7fb1221ffa061fde0bef0a65d5e89c27
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M mem/hp_malloc_dyn.h

  Log Message:
  -----------
  mem/hp: remove useless debugging


  Commit: a9b238fcbe1c41337f0b46af855b78cbfc08f335
      https://github.com/OpenSIPS/opensips/commit/a9b238fcbe1c41337f0b46af855b78cbfc08f335
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M mem/rpm_mem.c

  Log Message:
  -----------
  mem/rpm: fix double close

Reported by Coverity CID #199936


Compare: https://github.com/OpenSIPS/opensips/compare/b9bcc83903a8...a9b238fcbe1c


From noreply at github.com  Wed Jul  3 03:20:39 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:20:39 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 98e294: Add {ip.isip4} and
 {ip.isip6} convenience transfor...
Message-ID: <OpenSIPS/opensips/push/refs/heads/coverity_scan/37018b-8313f6@github.com>

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 98e29442d8c14127614b979169996281f2f7917d
      https://github.com/OpenSIPS/opensips/commit/98e29442d8c14127614b979169996281f2f7917d
  Author: Ryan Bullock <rrb3942 at gmail.com>
  Date:   2019-06-25 (Tue, 25 Jun 2019)

  Changed paths:
    M transformations.c
    M transformations.h

  Log Message:
  -----------
  Add {ip.isip4} and {ip.isip6} convenience transformations for quickly checking if the provided string parses to a valid ipv4/ipv6 network address


  Commit: 5ca43f4cc188b21e1039058b31b9bc4865d4ec03
      https://github.com/OpenSIPS/opensips/commit/5ca43f4cc188b21e1039058b31b9bc4865d4ec03
  Author: Ryan Bullock <rrb3942 at gmail.com>
  Date:   2019-06-25 (Tue, 25 Jun 2019)

  Changed paths:
    M net/net_tcp.c
    M timer.c

  Log Message:
  -----------
  Only report status if in forking daemon mode


  Commit: a4dfbf5a9aa9b3ea9d256ceb34620e2e6411a3ae
      https://github.com/OpenSIPS/opensips/commit/a4dfbf5a9aa9b3ea9d256ceb34620e2e6411a3ae
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2019-06-26 (Wed, 26 Jun 2019)

  Changed paths:
    M net/net_tcp.c
    M timer.c

  Log Message:
  -----------
  Merge pull request #1744 from rrb3942/nofork_daemon_error

Only report status if in forking daemon mode


  Commit: 18307225468617272633524ab3985340e711067b
      https://github.com/OpenSIPS/opensips/commit/18307225468617272633524ab3985340e711067b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-06-27 (Thu, 27 Jun 2019)

  Changed paths:
    M statistics.c

  Log Message:
  -----------
  statistics: alocating enough mem for stat name

Commit bc9423713 broke statistics because it was no longer alocating
space for the name of the statistics. This commit fixes the issue.

Thanks go to Maxim Sobolev for reporting this and pointing out the issue!


  Commit: 71d40f9198f83b6f310dcd9e9c5dc11a0b085a3b
      https://github.com/OpenSIPS/opensips/commit/71d40f9198f83b6f310dcd9e9c5dc11a0b085a3b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-06-27 (Thu, 27 Jun 2019)

  Changed paths:
    M modules/rest_client/doc/rest_client_admin.xml

  Log Message:
  -----------
  rest_client: Document the TCP connection reusage behavior


  Commit: 7f226176422c660eb4359171a350161186082d22
      https://github.com/OpenSIPS/opensips/commit/7f226176422c660eb4359171a350161186082d22
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-06-27 (Thu, 27 Jun 2019)

  Changed paths:
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: Fixed bug where domain filters were shown under ip address filters


  Commit: b105886f65b434602ecabac5a4c06de0cce7f4b9
      https://github.com/OpenSIPS/opensips/commit/b105886f65b434602ecabac5a4c06de0cce7f4b9
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-06-27 (Thu, 27 Jun 2019)

  Changed paths:
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: Fixed bug where client domains where missing in tls_list MI output


  Commit: b814fe9152a67d0911ec1732dda80f6ecdc59eea
      https://github.com/OpenSIPS/opensips/commit/b814fe9152a67d0911ec1732dda80f6ecdc59eea
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-06-28 (Fri, 28 Jun 2019)

  Changed paths:
    M modules/b2b_entities/b2be_db.c

  Log Message:
  -----------
  [b2b_entitites] Fix crash on empty To display name.

As the To display name may be empty and the DB does not enforce a not NULL, better be ready to read a NULL.
This happens when using db_cachedb + cachedb_mongodb as backend
Closes #1606

(cherry picked from commit 68aaa20113dcbb12c3123108fbe2cbc11f5e7b82)


  Commit: 7fd7f4b5044c3cf649dd8252899d6cc1d6cbdbce
      https://github.com/OpenSIPS/opensips/commit/7fd7f4b5044c3cf649dd8252899d6cc1d6cbdbce
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2019-06-28 (Fri, 28 Jun 2019)

  Changed paths:
    M transformations.c
    M transformations.h

  Log Message:
  -----------
  Merge pull request #1743 from rrb3942/isip

Add {ip.isip4} and {ip.isip6} convenience transformations


  Commit: 0e116487262b8b53001e5a499e8087311b905a41
      https://github.com/OpenSIPS/opensips/commit/0e116487262b8b53001e5a499e8087311b905a41
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2019-06-28 (Fri, 28 Jun 2019)

  Changed paths:
    M modules/rr/record.c

  Log Message:
  -----------
  Merge pull request #1738 from varghesepaul/2.4

Do not simply link the buffered lumps, but better clone them -> this …
(cherry picked from commit 08d869bf819d77f5cd18c9eb33330c0afd6d86ec)


  Commit: fa2ceb52b5b2513bedf16df6eaedec7cb1e34755
      https://github.com/OpenSIPS/opensips/commit/fa2ceb52b5b2513bedf16df6eaedec7cb1e34755
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-06-28 (Fri, 28 Jun 2019)

  Changed paths:
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  Fixed handling depth issue for certificate chains that are too long


  Commit: b367b7c5db91851b90ae8e5ec13a92ca0c850d16
      https://github.com/OpenSIPS/opensips/commit/b367b7c5db91851b90ae8e5ec13a92ca0c850d16
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-06-28 (Fri, 28 Jun 2019)

  Changed paths:
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: Streamlined reporting of certificate verification errors


  Commit: 42f65b1ca6cb0acaba41a1391c4027bdb922261c
      https://github.com/OpenSIPS/opensips/commit/42f65b1ca6cb0acaba41a1391c4027bdb922261c
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-06-30 (Sun, 30 Jun 2019)

  Changed paths:
    M modules/b2b_entities/README
    M modules/b2b_entities/doc/contributors.xml
    M modules/cpl_c/README
    M modules/cpl_c/doc/contributors.xml
    M modules/db_berkeley/README
    M modules/db_berkeley/doc/contributors.xml
    M modules/db_http/README
    M modules/db_http/doc/contributors.xml
    M modules/db_mysql/README
    M modules/db_mysql/doc/contributors.xml
    M modules/db_oracle/README
    M modules/db_oracle/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/emergency/README
    M modules/emergency/doc/contributors.xml
    M modules/event_virtual/README
    M modules/event_virtual/doc/contributors.xml
    M modules/mi_html/README
    M modules/mi_html/doc/contributors.xml
    M modules/msilo/README
    M modules/msilo/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/python/README
    M modules/python/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rr/README
    M modules/rr/doc/contributors.xml
    M modules/snmpstats/README
    M modules/snmpstats/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml
    M modules/topology_hiding/README
    M modules/topology_hiding/doc/contributors.xml
    M modules/uac_registrant/README
    M modules/uac_registrant/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation


  Commit: 3ddae43445cd6f3e3f6d4e9480f1e8c35801d008
      https://github.com/OpenSIPS/opensips/commit/3ddae43445cd6f3e3f6d4e9480f1e8c35801d008
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-01 (Mon, 01 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h

  Log Message:
  -----------
  dialog: load dialogs on child init


  Commit: b9bcc83903a88ce459688e433f63743631ebc3a8
      https://github.com/OpenSIPS/opensips/commit/b9bcc83903a88ce459688e433f63743631ebc3a8
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M modules/tm/tm.c

  Log Message:
  -----------
  Fixed missing reset of current transaction holder

The missing reset could lead to wrong access to old transactions when running more than one notification route, one after each other.

Credits for reporting and helping with testing go to Ivailo Dobrev

(cherry picked from commit 88b84e90145b7582be85793b47b7d0456b98831d)


  Commit: d8c03f325993e59242f156de01dffa60cc8324b4
      https://github.com/OpenSIPS/opensips/commit/d8c03f325993e59242f156de01dffa60cc8324b4
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h

  Log Message:
  -----------
  acc: fix leak generated by dialog replicated update


  Commit: 0d31e6bd038ae6cfed130e421bb5afbcaa8b5f15
      https://github.com/OpenSIPS/opensips/commit/0d31e6bd038ae6cfed130e421bb5afbcaa8b5f15
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M mem/hp_malloc_stats.c
    M mem/hp_malloc_stats.h

  Log Message:
  -----------
  fix stats decremented with unsigned values

Reported by Coverity CID #200104, #200030, #200096, #200091, #200090,
 #200074, #200073, #200049, #200039, #200035, #200032, #200009,
 #200003, #199998, #199996, #199991, #199988, #199986, #199985,
 #199982, #199977, #199970, #199964, #199963, #199960, #199952,
 #199948, #199945, #199941, #199938, #199934, #199923, #199920
 #199913, #199900, #199896


  Commit: 9db6556a7fb1221ffa061fde0bef0a65d5e89c27
      https://github.com/OpenSIPS/opensips/commit/9db6556a7fb1221ffa061fde0bef0a65d5e89c27
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M mem/hp_malloc_dyn.h

  Log Message:
  -----------
  mem/hp: remove useless debugging


  Commit: a9b238fcbe1c41337f0b46af855b78cbfc08f335
      https://github.com/OpenSIPS/opensips/commit/a9b238fcbe1c41337f0b46af855b78cbfc08f335
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-02 (Tue, 02 Jul 2019)

  Changed paths:
    M mem/rpm_mem.c

  Log Message:
  -----------
  mem/rpm: fix double close

Reported by Coverity CID #199936


  Commit: 8313f6d1c577044cb63bf80fba4674b00c00a66d
      https://github.com/OpenSIPS/opensips/commit/8313f6d1c577044cb63bf80fba4674b00c00a66d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M mem/hp_malloc_dyn.h
    M mem/hp_malloc_stats.c
    M mem/hp_malloc_stats.h
    M mem/rpm_mem.c
    M modules/acc/acc.c
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h
    M modules/b2b_entities/README
    M modules/b2b_entities/b2be_db.c
    M modules/b2b_entities/doc/contributors.xml
    M modules/cpl_c/README
    M modules/cpl_c/doc/contributors.xml
    M modules/db_berkeley/README
    M modules/db_berkeley/doc/contributors.xml
    M modules/db_http/README
    M modules/db_http/doc/contributors.xml
    M modules/db_mysql/README
    M modules/db_mysql/doc/contributors.xml
    M modules/db_oracle/README
    M modules/db_oracle/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h
    M modules/dialog/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/emergency/README
    M modules/emergency/doc/contributors.xml
    M modules/event_virtual/README
    M modules/event_virtual/doc/contributors.xml
    M modules/mi_html/README
    M modules/mi_html/doc/contributors.xml
    M modules/msilo/README
    M modules/msilo/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/python/README
    M modules/python/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rest_client/doc/rest_client_admin.xml
    M modules/rr/README
    M modules/rr/doc/contributors.xml
    M modules/rr/record.c
    M modules/snmpstats/README
    M modules/snmpstats/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/tls_mgm/tls_mgm.c
    M modules/tm/README
    M modules/tm/doc/contributors.xml
    M modules/tm/tm.c
    M modules/topology_hiding/README
    M modules/topology_hiding/doc/contributors.xml
    M modules/uac_registrant/README
    M modules/uac_registrant/doc/contributors.xml
    M net/net_tcp.c
    M statistics.c
    M timer.c
    M transformations.c
    M transformations.h

  Log Message:
  -----------
  Merge branch 'master' into coverity_scan


Compare: https://github.com/OpenSIPS/opensips/compare/37018bec5028...8313f6d1c577


From noreply at github.com  Wed Jul  3 03:21:48 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:21:48 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 065c92: acc: fix leak
 generated by dialog replicated update
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/2bad50-68fe59@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 065c92442276c7720dae2b4b56883c0ca2c4da1c
      https://github.com/OpenSIPS/opensips/commit/065c92442276c7720dae2b4b56883c0ca2c4da1c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h

  Log Message:
  -----------
  acc: fix leak generated by dialog replicated update

(cherry picked from commit d8c03f325993e59242f156de01dffa60cc8324b4)


  Commit: d14a4ac098db844a822735e92a079a555762afae
      https://github.com/OpenSIPS/opensips/commit/d14a4ac098db844a822735e92a079a555762afae
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M mem/hp_malloc_stats.c
    M mem/hp_malloc_stats.h

  Log Message:
  -----------
  fix stats decremented with unsigned values

Reported by Coverity CID #200104, #200030, #200096, #200091, #200090,
 #200074, #200073, #200049, #200039, #200035, #200032, #200009,
 #200003, #199998, #199996, #199991, #199988, #199986, #199985,
 #199982, #199977, #199970, #199964, #199963, #199960, #199952,
 #199948, #199945, #199941, #199938, #199934, #199923, #199920
 #199913, #199900, #199896

(cherry picked from commit 0d31e6bd038ae6cfed130e421bb5afbcaa8b5f15)


  Commit: 253d14614f92aeb12be088e357b4e287bfa0252e
      https://github.com/OpenSIPS/opensips/commit/253d14614f92aeb12be088e357b4e287bfa0252e
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M mem/hp_malloc_dyn.h

  Log Message:
  -----------
  mem/hp: remove useless debugging

(cherry picked from commit 9db6556a7fb1221ffa061fde0bef0a65d5e89c27)


  Commit: 68fe595989efadfac3a1d0818785f03b174cd3bc
      https://github.com/OpenSIPS/opensips/commit/68fe595989efadfac3a1d0818785f03b174cd3bc
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M mem/rpm_mem.c

  Log Message:
  -----------
  mem/rpm: fix double close

Reported by Coverity CID #199936

(cherry picked from commit a9b238fcbe1c41337f0b46af855b78cbfc08f335)


Compare: https://github.com/OpenSIPS/opensips/compare/2bad502a87cb...68fe595989ef


From noreply at github.com  Wed Jul  3 03:23:08 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:23:08 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b9f026: dialog: load dialogs
	on child init
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/68fe59-b9f026@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b9f0265a06b60ff62b5bc50d0db7eb81cb9b0f4d
      https://github.com/OpenSIPS/opensips/commit/b9f0265a06b60ff62b5bc50d0db7eb81cb9b0f4d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h

  Log Message:
  -----------
  dialog: load dialogs on child init

(cherry picked from commit 3ddae43445cd6f3e3f6d4e9480f1e8c35801d008)




From noreply at github.com  Wed Jul  3 03:23:17 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:23:17 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 483faf: acc: fix leak
 generated by dialog replicated update
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/88b84e-a98ee6@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 483faf834d47d8c45884e98e9c553eb785c82e1d
      https://github.com/OpenSIPS/opensips/commit/483faf834d47d8c45884e98e9c553eb785c82e1d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc_logic.c
    M modules/acc/acc_logic.h

  Log Message:
  -----------
  acc: fix leak generated by dialog replicated update


  Commit: a98ee6294cb4af6466100bd221dd8dfb2cc9f476
      https://github.com/OpenSIPS/opensips/commit/a98ee6294cb4af6466100bd221dd8dfb2cc9f476
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h

  Log Message:
  -----------
  dialog: load dialogs on child init


Compare: https://github.com/OpenSIPS/opensips/compare/88b84e90145b...a98ee6294cb4


From noreply at github.com  Wed Jul  3 03:50:14 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:50:14 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8e9a47: dialog: fix rpc
	dispatching for 2.4
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/a98ee6-8e9a47@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8e9a47293762c793284e673fc9b562a677983618
      https://github.com/OpenSIPS/opensips/commit/8e9a47293762c793284e673fc9b562a677983618
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c

  Log Message:
  -----------
  dialog: fix rpc dispatching for 2.4




From noreply at github.com  Wed Jul  3 03:54:31 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 00:54:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 04cc11: Revert "dialog: fix
 rpc dispatching for 2.4"
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/8e9a47-2279c1@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 04cc11297bd9ad2e116d591bf80370f141f9d373
      https://github.com/OpenSIPS/opensips/commit/04cc11297bd9ad2e116d591bf80370f141f9d373
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c

  Log Message:
  -----------
  Revert "dialog: fix rpc dispatching for 2.4"

This reverts commit 8e9a47293762c793284e673fc9b562a677983618.


  Commit: 2279c1cf365f35e6740f588bc6d1d71d014e289d
      https://github.com/OpenSIPS/opensips/commit/2279c1cf365f35e6740f588bc6d1d71d014e289d
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c

  Log Message:
  -----------
  just include ipc header, as rpc_dispatch exists


Compare: https://github.com/OpenSIPS/opensips/compare/8e9a47293762...2279c1cf365f


From noreply at github.com  Wed Jul  3 05:05:17 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 02:05:17 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b07a82: sql_cacher: nr_columns
 limitation is 64, not 8
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/a9b238-b07a82@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b07a82d62e500c3b28016842100f0c0210fb1a96
      https://github.com/OpenSIPS/opensips/commit/b07a82d62e500c3b28016842100f0c0210fb1a96
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: nr_columns limitation is 64, not 8

Fix limitation when the number of columns was wrongfuly limited to 8,
instead of 64, preventing loading more than 8 columns

Thanks go to Bogdan Iancu for spotting this and suggesting the fix




From noreply at github.com  Wed Jul  3 05:05:31 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 02:05:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 465650: sql_cacher: nr_columns
 limitation is 64, not 8
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/b9f026-465650@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4656508c4c46ca208fb147d111c70f89e218e982
      https://github.com/OpenSIPS/opensips/commit/4656508c4c46ca208fb147d111c70f89e218e982
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: nr_columns limitation is 64, not 8

Fix limitation when the number of columns was wrongfuly limited to 8,
instead of 64, preventing loading more than 8 columns

Thanks go to Bogdan Iancu for spotting this and suggesting the fix

(cherry picked from commit b07a82d62e500c3b28016842100f0c0210fb1a96)




From noreply at github.com  Wed Jul  3 05:07:53 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 02:07:53 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 66fdb7: sql_cacher: nr_columns
 limitation is 64, not 8
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/2279c1-66fdb7@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 66fdb79e53163744c1ba9e79d41791432664833b
      https://github.com/OpenSIPS/opensips/commit/66fdb79e53163744c1ba9e79d41791432664833b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: nr_columns limitation is 64, not 8

Fix limitation when the number of columns was wrongfuly limited to 8,
instead of 64, preventing loading more than 8 columns

Thanks go to Bogdan Iancu for spotting this and suggesting the fix

(cherry picked from commit b07a82d62e500c3b28016842100f0c0210fb1a96)




From noreply at github.com  Wed Jul  3 07:28:30 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 03 Jul 2019 04:28:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 056e43: debian: encourage
 using MaxMindDB, rather than geoip
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/b07a82-056e43@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 056e43020315a5beaf8df2002c6b4b7af97baa54
      https://github.com/OpenSIPS/opensips/commit/056e43020315a5beaf8df2002c6b4b7af97baa54
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M packaging/debian/control

  Log Message:
  -----------
  debian: encourage using MaxMindDB, rather than geoip

This way whoever builds the package can choose which lib to install, and
the appropriate version of the mmgeoip module will be built.

Addresses issue #1618




From noreply at github.com  Wed Jul  3 13:43:32 2019
From: noreply at github.com (Nick Altmann)
Date: Wed, 03 Jul 2019 10:43:32 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 21f3bd: redhat_fedora: specify
 cfg_target when installing
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/056e43-83e2ed@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 21f3bdb6ec7f491f41f14b18dd4aedd1036ecd64
      https://github.com/OpenSIPS/opensips/commit/21f3bdb6ec7f491f41f14b18dd4aedd1036ecd64
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M packaging/redhat_fedora/opensips.spec

  Log Message:
  -----------
  redhat_fedora: specify cfg_target when installing

When installing osipsconsole, we need to know the `cfg_target` to be
able to retrieve it later, otherwise it will default to
`/usr/etc/opensips.cfg`, which is broken.

This addresses #1676


  Commit: 83e2ed6e700e08cf3b590b4b299e542adf743753
      https://github.com/OpenSIPS/opensips/commit/83e2ed6e700e08cf3b590b4b299e542adf743753
  Author: Nick Altmann <nikbyte at users.noreply.github.com>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M packaging/redhat_fedora/opensips.spec

  Log Message:
  -----------
  Merge pull request #1751 from razvancrainea/master

redhat_fedora: specify cfg_target when installing

Thanks Razvan Crainea for patch


Compare: https://github.com/OpenSIPS/opensips/compare/056e43020315...83e2ed6e700e


From noreply at github.com  Wed Jul  3 13:46:35 2019
From: noreply at github.com (Nick Altmann)
Date: Wed, 03 Jul 2019 10:46:35 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 479079: Merge pull request
 #1751 from razvancrainea/master
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/66fdb7-479079@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 47907930afc0aeea7b3b741d6f8fe24df8632d88
      https://github.com/OpenSIPS/opensips/commit/47907930afc0aeea7b3b741d6f8fe24df8632d88
  Author: Nick Altmann <nikbyte at users.noreply.github.com>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M packaging/redhat_fedora/opensips.spec

  Log Message:
  -----------
  Merge pull request #1751 from razvancrainea/master

redhat_fedora: specify cfg_target when installing

Thanks Razvan Crainea for patch




From noreply at github.com  Wed Jul  3 13:46:45 2019
From: noreply at github.com (Nick Altmann)
Date: Wed, 03 Jul 2019 10:46:45 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 263f5d: Merge pull request
 #1751 from razvancrainea/master
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/465650-263f5d@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 263f5da85785d5215ca1b5e85b0aa1f56344d8ed
      https://github.com/OpenSIPS/opensips/commit/263f5da85785d5215ca1b5e85b0aa1f56344d8ed
  Author: Nick Altmann <nikbyte at users.noreply.github.com>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M packaging/redhat_fedora/opensips.spec

  Log Message:
  -----------
  Merge pull request #1751 from razvancrainea/master

redhat_fedora: specify cfg_target when installing

Thanks Razvan Crainea for patch




From noreply at github.com  Thu Jul  4 00:12:13 2019
From: noreply at github.com (Dan Pascu)
Date: Wed, 03 Jul 2019 21:12:13 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1f8f12: Fixed comment
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/83e2ed-720cf8@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1f8f12c4152d278018abc26669097931b3d0550b
      https://github.com/OpenSIPS/opensips/commit/1f8f12c4152d278018abc26669097931b3d0550b
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M socket_info.h

  Log Message:
  -----------
  Fixed comment


  Commit: fa135cf493c88341848f98d71a36d07187db16d8
      https://github.com/OpenSIPS/opensips/commit/fa135cf493c88341848f98d71a36d07187db16d8
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M socket_info.h

  Log Message:
  -----------
  Compacted declaration


  Commit: 720cf839b4e6277e73b82a3ad5f324b3722b3876
      https://github.com/OpenSIPS/opensips/commit/720cf839b4e6277e73b82a3ad5f324b3722b3876
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M socket_info.h

  Log Message:
  -----------
  Fixed test for socket str length


Compare: https://github.com/OpenSIPS/opensips/compare/83e2ed6e700e...720cf839b4e6


From noreply at github.com  Thu Jul  4 00:14:57 2019
From: noreply at github.com (Dan Pascu)
Date: Wed, 03 Jul 2019 21:14:57 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f1d3b5: Fixed comment
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/263f5d-7feafb@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f1d3b5cffa9794b258a7ffa7a7e349e0ba60fc34
      https://github.com/OpenSIPS/opensips/commit/f1d3b5cffa9794b258a7ffa7a7e349e0ba60fc34
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M socket_info.h

  Log Message:
  -----------
  Fixed comment

(cherry picked from commit 1f8f12c4152d278018abc26669097931b3d0550b)


  Commit: 5b3a15ae1f9029b9fcd59e5b0159f7baffe28ed5
      https://github.com/OpenSIPS/opensips/commit/5b3a15ae1f9029b9fcd59e5b0159f7baffe28ed5
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M socket_info.h

  Log Message:
  -----------
  Compacted declaration

(cherry picked from commit fa135cf493c88341848f98d71a36d07187db16d8)


  Commit: 7feafb75d0581836d6a824ee8f757be0f999df6c
      https://github.com/OpenSIPS/opensips/commit/7feafb75d0581836d6a824ee8f757be0f999df6c
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M socket_info.h

  Log Message:
  -----------
  Fixed test for socket str length

(cherry picked from commit 720cf839b4e6277e73b82a3ad5f324b3722b3876)


Compare: https://github.com/OpenSIPS/opensips/compare/263f5da85785...7feafb75d058


From noreply at github.com  Thu Jul  4 00:41:13 2019
From: noreply at github.com (Dan Pascu)
Date: Wed, 03 Jul 2019 21:41:13 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d894c5: Refactored
 get_local_contact to accept an optional...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/720cf8-d894c5@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d894c547144b3f5859f9f5c62b57eb581444715b
      https://github.com/OpenSIPS/opensips/commit/d894c547144b3f5859f9f5c62b57eb581444715b
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/b2b_logic/logic.c
    M modules/b2b_logic/records.c
    M modules/osp/cnam.c
    M modules/presence/subscribe.c
    M modules/presence/utils_func.h

  Log Message:
  -----------
  Refactored get_local_contact to accept an optional username argument




From noreply at github.com  Thu Jul  4 03:32:30 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 04 Jul 2019 00:32:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 44afc4: cgrates: allow setting
	NULL variables
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/479079-44afc4@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 44afc4a159517568007bda25418c80a82e501363
      https://github.com/OpenSIPS/opensips/commit/44afc4a159517568007bda25418c80a82e501363
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/cgrates/cgrates.c

  Log Message:
  -----------
  cgrates: allow setting NULL variables

Close #1750
Thanks go to Vasilios Tzanoudakis for reporting this!




From noreply at github.com  Thu Jul  4 03:32:48 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 04 Jul 2019 00:32:48 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 82dd26: cgrates: allow setting
	NULL variables
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/7feafb-82dd26@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 82dd2632e4594e1d63199d111e37902e1205a262
      https://github.com/OpenSIPS/opensips/commit/82dd2632e4594e1d63199d111e37902e1205a262
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/cgrates/cgrates.c

  Log Message:
  -----------
  cgrates: allow setting NULL variables

Close #1750
Thanks go to Vasilios Tzanoudakis for reporting this!

(cherry picked from commit 44afc4a159517568007bda25418c80a82e501363)




From noreply at github.com  Thu Jul  4 03:33:38 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 04 Jul 2019 00:33:38 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2074d7: cgrates: allow setting
	NULL variables
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/d894c5-2074d7@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2074d7cebe74b2a62693362c7e6d5ac222606a30
      https://github.com/OpenSIPS/opensips/commit/2074d7cebe74b2a62693362c7e6d5ac222606a30
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/cgrates/cgrates.c

  Log Message:
  -----------
  cgrates: allow setting NULL variables

Close #1750
Thanks go to Vasilios Tzanoudakis for reporting this!

(cherry picked from commit 44afc4a159517568007bda25418c80a82e501363)




From noreply at github.com  Thu Jul  4 07:08:49 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 04 Jul 2019 04:08:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 40b742: clusterer: improve
 performance of replication pack...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/2074d7-40b742@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 40b742256aa5ea390efbe3949343abf57e555fd3
      https://github.com/OpenSIPS/opensips/commit/40b742256aa5ea390efbe3949343abf57e555fd3
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/clusterer/clusterer.c
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h

  Log Message:
  -----------
  clusterer: improve performance of replication packets processing

Dispatch through IPC the actual processing of the received replication packets.
This prevents bottelnecks in a single TCP process that receives all the BIN
packets in high traffic scenarios.




From noreply at github.com  Thu Jul  4 07:42:58 2019
From: noreply at github.com (Dan Pascu)
Date: Thu, 04 Jul 2019 04:42:58 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 23abe4: presence: Normalized
 spacing in a few places
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/40b742-23abe4@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 23abe46bc9eb59eaeb4319f68556e360f527d828
      https://github.com/OpenSIPS/opensips/commit/23abe46bc9eb59eaeb4319f68556e360f527d828
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/presence/presence.c
    M modules/presence/subscribe.c
    M modules/presence/subscribe.h

  Log Message:
  -----------
  presence: Normalized spacing in a few places




From noreply at github.com  Thu Jul  4 07:45:21 2019
From: noreply at github.com (Dan Pascu)
Date: Thu, 04 Jul 2019 04:45:21 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 11e949: presence: Normalized
 spacing in a few places
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/82dd26-11e949@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 11e949e92e4379d043deeba0489b7a5f858f6dfc
      https://github.com/OpenSIPS/opensips/commit/11e949e92e4379d043deeba0489b7a5f858f6dfc
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/presence/presence.c
    M modules/presence/subscribe.c
    M modules/presence/subscribe.h

  Log Message:
  -----------
  presence: Normalized spacing in a few places

(cherry picked from commit 23abe46bc9eb59eaeb4319f68556e360f527d828)




From noreply at github.com  Thu Jul  4 07:51:31 2019
From: noreply at github.com (Dan Pascu)
Date: Thu, 04 Jul 2019 04:51:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d4a331: presence: Removed
	unnecessary goto
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/23abe4-d4a331@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d4a33111e286aa0edb509800ae6a69739cf058ae
      https://github.com/OpenSIPS/opensips/commit/d4a33111e286aa0edb509800ae6a69739cf058ae
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/presence/subscribe.c

  Log Message:
  -----------
  presence: Removed unnecessary goto




From noreply at github.com  Thu Jul  4 07:53:03 2019
From: noreply at github.com (Dan Pascu)
Date: Thu, 04 Jul 2019 04:53:03 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] aac5ab: presence: Removed
	unnecessary goto
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/11e949-aac5ab@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: aac5abe43beed8e9b498be69d856fb6779a430ac
      https://github.com/OpenSIPS/opensips/commit/aac5abe43beed8e9b498be69d856fb6779a430ac
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/presence/subscribe.c

  Log Message:
  -----------
  presence: Removed unnecessary goto

(cherry picked from commit d4a33111e286aa0edb509800ae6a69739cf058ae)




From noreply at github.com  Thu Jul  4 08:01:32 2019
From: noreply at github.com (Dan Pascu)
Date: Thu, 04 Jul 2019 05:01:32 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 39afa5: rls: Normalized some
 spacing (use TABs to indent)
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/d4a331-39afa5@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 39afa59111605119e2a625e1f694337ad6d36c51
      https://github.com/OpenSIPS/opensips/commit/39afa59111605119e2a625e1f694337ad6d36c51
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/rls/rls.c

  Log Message:
  -----------
  rls: Normalized some spacing (use TABs to indent)




From noreply at github.com  Thu Jul  4 08:02:27 2019
From: noreply at github.com (Dan Pascu)
Date: Thu, 04 Jul 2019 05:02:27 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 661b71: rls: Normalized some
 spacing (use TABs to indent)
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/aac5ab-661b71@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 661b712d4482ecde4e23b680cc704d85c9da3b7d
      https://github.com/OpenSIPS/opensips/commit/661b712d4482ecde4e23b680cc704d85c9da3b7d
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/rls/rls.c

  Log Message:
  -----------
  rls: Normalized some spacing (use TABs to indent)

(cherry picked from commit 39afa59111605119e2a625e1f694337ad6d36c51)




From noreply at github.com  Thu Jul  4 09:53:36 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 06:53:36 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8076cd: [pua_dialoginfo] Fixed
 nopublish_flag modparam
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/39afa5-8076cd@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8076cdbdfb18f07d8fbbabbc6eda506345c806dd
      https://github.com/OpenSIPS/opensips/commit/8076cdbdfb18f07d8fbbabbc6eda506345c806dd
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  [pua_dialoginfo] Fixed nopublish_flag modparam

It seems the parameter (a msg flag) was not migrated to string format.
Also the actual test of the flag got lost somewhere during the rework




From noreply at github.com  Thu Jul  4 09:54:38 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 06:54:38 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] db57a9: [pua_dialoginfo] Fixed
 nopublish_flag modparam
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/661b71-db57a9@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: db57a992cacacf38ae922b6ae7af838667ae1a79
      https://github.com/OpenSIPS/opensips/commit/db57a992cacacf38ae922b6ae7af838667ae1a79
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  [pua_dialoginfo] Fixed nopublish_flag modparam

It seems the parameter (a msg flag) was not migrated to string format.
Also the actual test of the flag got lost somewhere during the rework

(cherry picked from commit 8076cdbdfb18f07d8fbbabbc6eda506345c806dd)




From noreply at github.com  Thu Jul  4 10:04:45 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 07:04:45 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a34243: [pua_dialoginfo] Fixed
 nopublish_flag modparam
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/44afc4-a34243@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a34243576603a6506b0c827056e56c42012de4fe
      https://github.com/OpenSIPS/opensips/commit/a34243576603a6506b0c827056e56c42012de4fe
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/pua_dialoginfo/pua_dialoginfo.c

  Log Message:
  -----------
  [pua_dialoginfo] Fixed nopublish_flag modparam

It seems the parameter (a msg flag) was not migrated to string format.




From noreply at github.com  Thu Jul  4 11:06:10 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 08:06:10 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 18c7aa: Fixed missing error
	reporting.
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/8076cd-18c7aa@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 18c7aad4accbc4801fdea443747227274eb11bc3
      https://github.com/OpenSIPS/opensips/commit/18c7aad4accbc4801fdea443747227274eb11bc3
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M route.c

  Log Message:
  -----------
  Fixed missing error reporting.




From noreply at github.com  Thu Jul  4 11:08:11 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 08:08:11 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 857d76: Fixed missing error
	reporting.
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/db57a9-857d76@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 857d766f55d70de1549368bf1a8f580863bc8862
      https://github.com/OpenSIPS/opensips/commit/857d766f55d70de1549368bf1a8f580863bc8862
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M route.c

  Log Message:
  -----------
  Fixed missing error reporting.

(cherry picked from commit 18c7aad4accbc4801fdea443747227274eb11bc3)




From noreply at github.com  Thu Jul  4 11:10:47 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 08:10:47 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b02f5d: Fixed missing error
	reporting.
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/a34243-b02f5d@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b02f5d12b5211abe53b79f9b314e47be3ce9e970
      https://github.com/OpenSIPS/opensips/commit/b02f5d12b5211abe53b79f9b314e47be3ce9e970
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M route.c

  Log Message:
  -----------
  Fixed missing error reporting.

(cherry picked from commit 18c7aad4accbc4801fdea443747227274eb11bc3)




From noreply at github.com  Thu Jul  4 11:29:55 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 04 Jul 2019 08:29:55 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 668fcb: bin interface: lower
 level of irrelevant log messa...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/18c7aa-668fcb@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 668fcbd8c085cac0afa714353d61f825b74afd31
      https://github.com/OpenSIPS/opensips/commit/668fcbd8c085cac0afa714353d61f825b74afd31
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M bin_interface.c

  Log Message:
  -----------
  bin interface: lower level of irrelevant log message to DBG




From noreply at github.com  Thu Jul  4 11:30:25 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 04 Jul 2019 08:30:25 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 108676: bin interface: lower
 level of irrelevant log messa...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/857d76-108676@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 10867622124a02bf88b71bbdaa4a48b05afa68e0
      https://github.com/OpenSIPS/opensips/commit/10867622124a02bf88b71bbdaa4a48b05afa68e0
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M bin_interface.c

  Log Message:
  -----------
  bin interface: lower level of irrelevant log message to DBG

(cherry picked from commit 668fcbd8c085cac0afa714353d61f825b74afd31)




From noreply at github.com  Thu Jul  4 11:32:22 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 04 Jul 2019 08:32:22 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b46fd5: bin interface: lower
 level of irrelevant log messa...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/b02f5d-b46fd5@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b46fd5224a460f924ea3b8d897b88cb5a9fdbe01
      https://github.com/OpenSIPS/opensips/commit/b46fd5224a460f924ea3b8d897b88cb5a9fdbe01
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M bin_interface.c

  Log Message:
  -----------
  bin interface: lower level of irrelevant log message to DBG

(cherry picked from commit 668fcbd8c085cac0afa714353d61f825b74afd31)




From noreply at github.com  Thu Jul  4 11:37:09 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 04 Jul 2019 08:37:09 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a105be: acc: store ctx in
 dialog when starting accounting
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/668fcb-c29a0d@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a105be21ba27d9e796e6a158b30278777c656ca8
      https://github.com/OpenSIPS/opensips/commit/a105be21ba27d9e796e6a158b30278777c656ca8
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/acc/acc.c
    M modules/acc/acc.h
    M modules/acc/acc_logic.c

  Log Message:
  -----------
  acc: store ctx in dialog when starting accounting


  Commit: c29a0d09eefc6aec34b838028a7ae5d328ff18b3
      https://github.com/OpenSIPS/opensips/commit/c29a0d09eefc6aec34b838028a7ae5d328ff18b3
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: fix broken error check in load_dlg_db


Compare: https://github.com/OpenSIPS/opensips/compare/668fcbd8c085...c29a0d09eefc


From noreply at github.com  Thu Jul  4 11:37:34 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 04 Jul 2019 08:37:34 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 202406: dialog: fix broken
 error check in load_dlg_db
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/108676-202406@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2024061e97c9c0b02aa27b0df5ef3bc467d38bca
      https://github.com/OpenSIPS/opensips/commit/2024061e97c9c0b02aa27b0df5ef3bc467d38bca
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: fix broken error check in load_dlg_db

(cherry picked from commit c29a0d09eefc6aec34b838028a7ae5d328ff18b3)




From noreply at github.com  Thu Jul  4 11:37:48 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 04 Jul 2019 08:37:48 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 45ea33: dialog: fix broken
 error check in load_dlg_db
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/b46fd5-45ea33@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 45ea334223ee54b000fbda8725c5aaf97f43758c
      https://github.com/OpenSIPS/opensips/commit/45ea334223ee54b000fbda8725c5aaf97f43758c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: fix broken error check in load_dlg_db

(cherry picked from commit c29a0d09eefc6aec34b838028a7ae5d328ff18b3)




From noreply at github.com  Thu Jul  4 11:39:40 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 08:39:40 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d949a7: [pua_dialoginfo] fix
 docs for nopublish_flag
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/c29a0d-d949a7@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d949a7a7be402ae9505483322cde27a54f25d163
      https://github.com/OpenSIPS/opensips/commit/d949a7a7be402ae9505483322cde27a54f25d163
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml

  Log Message:
  -----------
  [pua_dialoginfo] fix docs for nopublish_flag




From noreply at github.com  Thu Jul  4 11:40:40 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 08:40:40 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] df0591: [pua_dialoginfo] fix
 docs for nopublish_flag
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/202406-df0591@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: df0591ea32b2bf0289852bc51b96e6131e23862d
      https://github.com/OpenSIPS/opensips/commit/df0591ea32b2bf0289852bc51b96e6131e23862d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml

  Log Message:
  -----------
  [pua_dialoginfo] fix docs for nopublish_flag

(cherry picked from commit d949a7a7be402ae9505483322cde27a54f25d163)




From noreply at github.com  Thu Jul  4 11:41:31 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 04 Jul 2019 08:41:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 28bd16: [pua_dialoginfo] fix
 docs for nopublish_flag
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/45ea33-28bd16@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 28bd16d92012835e5874ed89583081f1fb43e57c
      https://github.com/OpenSIPS/opensips/commit/28bd16d92012835e5874ed89583081f1fb43e57c
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/pua_dialoginfo/doc/pua_dialoginfo_admin.xml

  Log Message:
  -----------
  [pua_dialoginfo] fix docs for nopublish_flag

(cherry picked from commit d949a7a7be402ae9505483322cde27a54f25d163)




From noreply at github.com  Thu Jul  4 11:45:33 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 04 Jul 2019 08:45:33 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] aa2f53: dialog: Fix broken
 stats after a restart+reload
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/d949a7-aa2f53@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: aa2f534e18dc0830a160bb90d4cc3a116386953d
      https://github.com/OpenSIPS/opensips/commit/aa2f534e18dc0830a160bb90d4cc3a116386953d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken stats after a restart+reload

    * the "active_dialogs" and "early_dialogs" stats were broken along
      with the data reloading move to child_init()

    * the global helper counters, "active_dlgs_cnt" and "early_dlgs_cnt"
      are no longer needed




From noreply at github.com  Thu Jul  4 11:45:47 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 04 Jul 2019 08:45:47 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2e3db3: dialog: Fix broken
 stats after a restart+reload
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/df0591-2e3db3@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2e3db36efb00d8215e72690976c88c0129c3a141
      https://github.com/OpenSIPS/opensips/commit/2e3db36efb00d8215e72690976c88c0129c3a141
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken stats after a restart+reload

    * the "active_dialogs" and "early_dialogs" stats were broken along
      with the data reloading move to child_init()

    * the global helper counters, "active_dlgs_cnt" and "early_dlgs_cnt"
      are no longer needed

(cherry picked from commit aa2f534e18dc0830a160bb90d4cc3a116386953d)




From noreply at github.com  Thu Jul  4 11:45:58 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 04 Jul 2019 08:45:58 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 190e1d: dialog: Fix broken
 stats after a restart+reload
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/28bd16-190e1d@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 190e1d3ff3ae5df7fd4d5455d76b621ae63a9595
      https://github.com/OpenSIPS/opensips/commit/190e1d3ff3ae5df7fd4d5455d76b621ae63a9595
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-04 (Thu, 04 Jul 2019)

  Changed paths:
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken stats after a restart+reload

    * the "active_dialogs" and "early_dialogs" stats were broken along
      with the data reloading move to child_init()

    * the global helper counters, "active_dlgs_cnt" and "early_dlgs_cnt"
      are no longer needed

(cherry picked from commit aa2f534e18dc0830a160bb90d4cc3a116386953d)




From noreply at github.com  Fri Jul  5 02:25:37 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 04 Jul 2019 23:25:37 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 477d0f: lib/csv.h: Add an RFC
	4180 CSV parser
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/aa2f53-394f57@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 477d0f67861a6f494902846a574507d9087e87b4
      https://github.com/OpenSIPS/opensips/commit/477d0f67861a6f494902846a574507d9087e87b4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M lib/csv.c
    M lib/csv.h
    M lib/url.c
    M modules/freeswitch_scripting/fss_db.c
    M modules/mmgeoip/geoip2.c
    M modules/nathelper/nathelper.c
    M modules/presence/clustering.c
    M modules/rabbitmq_consumer/rmq_connection.c
    M modules/tls_mgm/tls_domain.c
    M str.h
    M test/unit_tests.c

  Log Message:
  -----------
  lib/csv.h: Add an RFC 4180 CSV parser

    * also invert the CSV_SIMPLE flag into CSV_RFC_4180
    * adjust all calling code to use the new set of parsing flags


  Commit: 769ddedf3990028f8650d436798f9a52e1d8883b
      https://github.com/OpenSIPS/opensips/commit/769ddedf3990028f8650d436798f9a52e1d8883b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M Makefile.test
    A lib/test/test_csv.c
    A lib/test/test_csv.h

  Log Message:
  -----------
  lib/csv.h: Full unit test coverage


  Commit: 394f57a8da54de0161eafee643e7def4db2d74ed
      https://github.com/OpenSIPS/opensips/commit/394f57a8da54de0161eafee643e7def4db2d74ed
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M transformations.c

  Log Message:
  -----------
  {csv.} transformation: Use the lib/csv.h parser

Fixes #1220
Closes #1416


Compare: https://github.com/OpenSIPS/opensips/compare/aa2f534e18dc...394f57a8da54


From noreply at github.com  Fri Jul  5 04:13:42 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 05 Jul 2019 01:13:42 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] cae826: lib/csv.h: Add an RFC
	4180 CSV parser
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/2e3db3-a9249c@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: cae8264a79db7ce35788448d84b47abf9a567a7b
      https://github.com/OpenSIPS/opensips/commit/cae8264a79db7ce35788448d84b47abf9a567a7b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M lib/csv.c
    M lib/csv.h
    M lib/url.c
    M modules/freeswitch_scripting/fss_db.c
    M modules/mmgeoip/geoip2.c
    M modules/nathelper/nathelper.c
    M modules/presence/clustering.c
    M modules/rabbitmq_consumer/rmq_connection.c
    M modules/tls_mgm/tls_domain.c
    M str.h
    M test/unit_tests.c

  Log Message:
  -----------
  lib/csv.h: Add an RFC 4180 CSV parser

    * also invert the CSV_SIMPLE flag into CSV_RFC_4180
    * adjust all calling code to use the new set of parsing flags

(cherry picked from commit 477d0f67861a6f494902846a574507d9087e87b4)


  Commit: 674b6767c2166d11ac4539d4f73b85bb3655fdab
      https://github.com/OpenSIPS/opensips/commit/674b6767c2166d11ac4539d4f73b85bb3655fdab
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M Makefile.test
    A lib/test/test_csv.c
    A lib/test/test_csv.h

  Log Message:
  -----------
  lib/csv.h: Full unit test coverage

(cherry picked from commit 769ddedf3990028f8650d436798f9a52e1d8883b)


  Commit: a9249c4896ca0a746bab10c2df72b1f0b0c1bc5a
      https://github.com/OpenSIPS/opensips/commit/a9249c4896ca0a746bab10c2df72b1f0b0c1bc5a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M transformations.c

  Log Message:
  -----------
  {csv.} transformation: Use the lib/csv.h parser

Fixes #1220
Closes #1416

(cherry picked from commit 394f57a8da54de0161eafee643e7def4db2d74ed)


Compare: https://github.com/OpenSIPS/opensips/compare/2e3db36efb00...a9249c4896ca


From noreply at github.com  Fri Jul  5 04:15:35 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 05 Jul 2019 01:15:35 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8177e2: lib/csv.h: Add an RFC
	4180 CSV parser
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/190e1d-600df4@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8177e21d0b86673980822ceefb84ae498708da71
      https://github.com/OpenSIPS/opensips/commit/8177e21d0b86673980822ceefb84ae498708da71
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M lib/csv.c
    M lib/csv.h
    M lib/url.c
    M modules/freeswitch_scripting/fss_db.c
    M modules/mmgeoip/geoip2.c
    M modules/nathelper/nathelper.c
    M modules/presence/clustering.c
    M str.h
    M test/unit_tests.c

  Log Message:
  -----------
  lib/csv.h: Add an RFC 4180 CSV parser

    * also invert the CSV_SIMPLE flag into CSV_RFC_4180
    * adjust all calling code to use the new set of parsing flags

(cherry picked from commit 477d0f67861a6f494902846a574507d9087e87b4)


  Commit: b31872339fe6a9dda4e6e16ed3f94b300fe4e7d7
      https://github.com/OpenSIPS/opensips/commit/b31872339fe6a9dda4e6e16ed3f94b300fe4e7d7
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M Makefile.test
    A lib/test/test_csv.c
    A lib/test/test_csv.h

  Log Message:
  -----------
  lib/csv.h: Full unit test coverage

(cherry picked from commit 769ddedf3990028f8650d436798f9a52e1d8883b)


  Commit: 600df4c92b96df6e46458acbaf51530cc057cacd
      https://github.com/OpenSIPS/opensips/commit/600df4c92b96df6e46458acbaf51530cc057cacd
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M transformations.c

  Log Message:
  -----------
  {csv.} transformation: Use the lib/csv.h parser

Fixes #1220
Closes #1416

(cherry picked from commit 394f57a8da54de0161eafee643e7def4db2d74ed)


Compare: https://github.com/OpenSIPS/opensips/compare/190e1d3ff3ae...600df4c92b96


From noreply at github.com  Fri Jul  5 04:58:10 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 05 Jul 2019 01:58:10 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ca81c5: cachedb_local: Improve
 'cache_collections' parser
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/394f57-ca81c5@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ca81c501f7fcaca32fae6235b2489933f2efefd3
      https://github.com/OpenSIPS/opensips/commit/ca81c501f7fcaca32fae6235b2489933f2efefd3
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local.c
    M modules/cachedb_local/doc/cachedb_local_admin.xml

  Log Message:
  -----------
  cachedb_local: Improve 'cache_collections' parser

The 'cache_collections' modparam parser is now fully tolerant to any
kind of whitespace present in the string.

Fixes #1424




From noreply at github.com  Fri Jul  5 05:00:32 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 05 Jul 2019 02:00:32 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0ae84a: cachedb_local: Improve
 'cache_collections' parser
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/a9249c-0ae84a@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0ae84a0e420c9e8a988dc3e7d3cff4181fc73bd9
      https://github.com/OpenSIPS/opensips/commit/0ae84a0e420c9e8a988dc3e7d3cff4181fc73bd9
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local.c
    M modules/cachedb_local/doc/cachedb_local_admin.xml

  Log Message:
  -----------
  cachedb_local: Improve 'cache_collections' parser

The 'cache_collections' modparam parser is now fully tolerant to any
kind of whitespace present in the string.

Fixes #1424

(cherry picked from commit ca81c501f7fcaca32fae6235b2489933f2efefd3)




From noreply at github.com  Fri Jul  5 05:02:30 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 05 Jul 2019 02:02:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 989106: cachedb_local: Improve
 'cache_collections' parser
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/600df4-989106@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 989106ec1f73c5faaef5df8c621ff413b4fb4254
      https://github.com/OpenSIPS/opensips/commit/989106ec1f73c5faaef5df8c621ff413b4fb4254
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local.c
    M modules/cachedb_local/doc/cachedb_local_admin.xml

  Log Message:
  -----------
  cachedb_local: Improve 'cache_collections' parser

The 'cache_collections' modparam parser is now fully tolerant to any
kind of whitespace present in the string.

Fixes #1424

(cherry picked from commit ca81c501f7fcaca32fae6235b2489933f2efefd3)




From noreply at github.com  Fri Jul  5 06:08:20 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 05 Jul 2019 03:08:20 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ab063d: proto_smpp: add unbind
	handler
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ca81c5-ab063d@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ab063d32e10c2c0a81319ace5bb724a085bb3f85
      https://github.com/OpenSIPS/opensips/commit/ab063d32e10c2c0a81319ace5bb724a085bb3f85
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: add unbind handler

Thanks go to Slava Bendersky for reporting this in ticket #1728




From noreply at github.com  Fri Jul  5 06:08:50 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 05 Jul 2019 03:08:50 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 279013: proto_smpp: add unbind
	handler
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/0ae84a-279013@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2790130c84ff078b40776e1627e411acc5a633d5
      https://github.com/OpenSIPS/opensips/commit/2790130c84ff078b40776e1627e411acc5a633d5
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: add unbind handler

Thanks go to Slava Bendersky for reporting this in ticket #1728

(cherry picked from commit ab063d32e10c2c0a81319ace5bb724a085bb3f85)




From noreply at github.com  Fri Jul  5 06:24:53 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 05 Jul 2019 03:24:53 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 31b2c8: proto_smsc: rebind
	connection when lost
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ab063d-31b2c8@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 31b2c83533d7631506a80ffdfb6b09226c83e8d3
      https://github.com/OpenSIPS/opensips/commit/31b2c83533d7631506a80ffdfb6b09226c83e8d3
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smsc: rebind connection when lost

Thanks go to Slava Bendersky for reporting this in ticket #1728




From noreply at github.com  Fri Jul  5 06:25:04 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 05 Jul 2019 03:25:04 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a17f35: proto_smsc: rebind
	connection when lost
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/279013-a17f35@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a17f35eadd5e1eeda0068d0b557bcd5cc6110adf
      https://github.com/OpenSIPS/opensips/commit/a17f35eadd5e1eeda0068d0b557bcd5cc6110adf
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smsc: rebind connection when lost

Thanks go to Slava Bendersky for reporting this in ticket #1728

(cherry picked from commit 31b2c83533d7631506a80ffdfb6b09226c83e8d3)




From noreply at github.com  Fri Jul  5 08:02:55 2019
From: noreply at github.com (Dan Pascu)
Date: Fri, 05 Jul 2019 05:02:55 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] eec488: Fixed indentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/31b2c8-eec488@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: eec488d82116963d7b326f372f2d99f8b37d8ff8
      https://github.com/OpenSIPS/opensips/commit/eec488d82116963d7b326f372f2d99f8b37d8ff8
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/rls/notify.c
    M modules/rls/resource_notify.c
    M modules/rls/rls.c
    M modules/rls/subscribe.c

  Log Message:
  -----------
  Fixed indentation




From noreply at github.com  Fri Jul  5 08:03:47 2019
From: noreply at github.com (Dan Pascu)
Date: Fri, 05 Jul 2019 05:03:47 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b0caa0: Fixed indentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/a17f35-b0caa0@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b0caa06c05710c283795c54cd04676902e4ae2bd
      https://github.com/OpenSIPS/opensips/commit/b0caa06c05710c283795c54cd04676902e4ae2bd
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/rls/notify.c
    M modules/rls/resource_notify.c
    M modules/rls/rls.c
    M modules/rls/subscribe.c

  Log Message:
  -----------
  Fixed indentation

(cherry picked from commit eec488d82116963d7b326f372f2d99f8b37d8ff8)




From razvan at opensips.org  Fri Jul  5 09:10:32 2019
From: razvan at opensips.org (=?UTF-8?Q?R=c4=83zvan_Crainea?=)
Date: Fri, 5 Jul 2019 16:10:32 +0300
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 183072: statistics:
 alocating enough mem for stat name
In-Reply-To: <B78C9F69-A512-4D18-B8BB-D018DDEB094F@ag-projects.com>
References: <OpenSIPS/opensips/push/refs/heads/master/a4dfbf-183072@github.com>
 <B78C9F69-A512-4D18-B8BB-D018DDEB094F@ag-projects.com>
Message-ID: <2599619a-4e2d-83e8-bdef-71425cfa2edb@opensips.org>

Hi, Dan!

Apologies for the late reply, I do have a huge backlog on the devel list.
I totally agree with you, the naming of the flags should be more 
meaningful, or at least better documented. I'll put this on my list of 
TODO, thanks for pointing it out!

Best regards,
Răzvan

On 6/27/19 1:22 PM, Dan Pascu wrote:
> In actuality it was commit 1f7af0bdc that broke it not bc9423713, but I guess now it's too late to change the commit message.
> 
> On a different note I find the way the register_stat2 function treats the flags to be confusing and counter intuitive. It allocates space for name if the STAT_SHM_NAME flag is not set and it allocates memory if STAT_NO_ALLOC is set. The only flag in there that seems to behave as expected is STAT_IS_FUNC. Maybe some better names for the flags would help. Like for example maybe STAT_NO_ALLOC is in fact STAT_NOT_ALLOCATED?
> 
> On 27 Jun 2019, at 10:38, Răzvan Crainea wrote:
> 
>>   Branch: refs/heads/master
>>   Home:   https://github.com/OpenSIPS/opensips
>>   Commit: 18307225468617272633524ab3985340e711067b
>>       https://github.com/OpenSIPS/opensips/commit/18307225468617272633524ab3985340e711067b
>>   Author: Razvan Crainea <razvan at opensips.org>
>>   Date:   2019-06-27 (Thu, 27 Jun 2019)
>>
>>   Changed paths:
>>     M statistics.c
>>
>>   Log Message:
>>   -----------
>>   statistics: alocating enough mem for stat name
>>
>> Commit bc9423713 broke statistics because it was no longer alocating
>> space for the name of the statistics. This commit fixes the issue.
>>
>> Thanks go to Maxim Sobolev for reporting this and pointing out the issue!
>>
>>
>>
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
> 
> 
> --
> Dan
> 
> 
> 
> 
> 
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
> 

-- 
Răzvan Crainea
OpenSIPS Core Developer
   http://www.opensips-solutions.com


From noreply at github.com  Fri Jul  5 11:16:18 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 05 Jul 2019 08:16:18 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 18f871: proto_smpp: make sure
 to properly reconnect session
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/eec488-18f871@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 18f8714f2ca9d8d4e4192279de2464e6245481aa
      https://github.com/OpenSIPS/opensips/commit/18f8714f2ca9d8d4e4192279de2464e6245481aa
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: make sure to properly reconnect session

Addresses ticket #1728




From noreply at github.com  Fri Jul  5 11:16:34 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 05 Jul 2019 08:16:34 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 52b4e7: proto_smpp: make sure
 to properly reconnect session
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/b0caa0-52b4e7@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 52b4e78276328ff6c4cab061be9e8dd3fc17aeda
      https://github.com/OpenSIPS/opensips/commit/52b4e78276328ff6c4cab061be9e8dd3fc17aeda
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  proto_smpp: make sure to properly reconnect session

Addresses ticket #1728

(cherry picked from commit 18f8714f2ca9d8d4e4192279de2464e6245481aa)




From noreply at github.com  Fri Jul  5 13:39:55 2019
From: noreply at github.com (Ovidiu Sas)
Date: Fri, 05 Jul 2019 10:39:55 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0a7b4f: Makefile.defs:
 increase version to 3.1.0-dev
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/18f871-0a7b4f@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0a7b4fc3ed5b8db8a593e0a4bf5c8730623419a1
      https://github.com/OpenSIPS/opensips/commit/0a7b4fc3ed5b8db8a593e0a4bf5c8730623419a1
  Author: Ovidiu Sas <osas at voipembedded.com>
  Date:   2019-07-05 (Fri, 05 Jul 2019)

  Changed paths:
    M Makefile.defs

  Log Message:
  -----------
  Makefile.defs: increase version to 3.1.0-dev




From noreply at github.com  Sat Jul  6 11:36:43 2019
From: noreply at github.com (Dan Pascu)
Date: Sat, 06 Jul 2019 08:36:43 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 569250: rls: Fixed memory leak
 in rls_handle_subscribe
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/0a7b4f-569250@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5692501f8ce3eda41872e4d5996d701bc804408e
      https://github.com/OpenSIPS/opensips/commit/5692501f8ce3eda41872e4d5996d701bc804408e
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-06 (Sat, 06 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Fixed memory leak in rls_handle_subscribe




From noreply at github.com  Sat Jul  6 11:38:53 2019
From: noreply at github.com (Dan Pascu)
Date: Sat, 06 Jul 2019 08:38:53 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a72132: rls: Report the actual
 code that was used in reply
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/569250-a72132@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a72132832f0835d815fdc9488d80df684eb2dbde
      https://github.com/OpenSIPS/opensips/commit/a72132832f0835d815fdc9488d80df684eb2dbde
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-06 (Sat, 06 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Report the actual code that was used in reply




From noreply at github.com  Sat Jul  6 11:58:40 2019
From: noreply at github.com (Dan Pascu)
Date: Sat, 06 Jul 2019 08:58:40 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] be0d3b: rls: Cleanup spacing
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/a72132-be0d3b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: be0d3b7bb3b2e956b783623df417f48582aadc5a
      https://github.com/OpenSIPS/opensips/commit/be0d3b7bb3b2e956b783623df417f48582aadc5a
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-06 (Sat, 06 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Cleanup spacing




From noreply at github.com  Sat Jul  6 12:01:08 2019
From: noreply at github.com (Dan Pascu)
Date: Sat, 06 Jul 2019 09:01:08 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1fa5a0: rls: Fixed memory leak
 in rls_handle_subscribe
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/52b4e7-58e469@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1fa5a067ac6c7c32580ce233da438cde3f82f80a
      https://github.com/OpenSIPS/opensips/commit/1fa5a067ac6c7c32580ce233da438cde3f82f80a
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-06 (Sat, 06 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Fixed memory leak in rls_handle_subscribe

(cherry picked from commit 5692501f8ce3eda41872e4d5996d701bc804408e)


  Commit: 11afeaf72e9bffc5c56063f734d0b41444f935db
      https://github.com/OpenSIPS/opensips/commit/11afeaf72e9bffc5c56063f734d0b41444f935db
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-06 (Sat, 06 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Report the actual code that was used in reply

(cherry picked from commit a72132832f0835d815fdc9488d80df684eb2dbde)


  Commit: 58e469b71875c852876ffd4c87f3f7f074aeb858
      https://github.com/OpenSIPS/opensips/commit/58e469b71875c852876ffd4c87f3f7f074aeb858
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-06 (Sat, 06 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Cleanup spacing

(cherry picked from commit be0d3b7bb3b2e956b783623df417f48582aadc5a)


Compare: https://github.com/OpenSIPS/opensips/compare/52b4e7827632...58e469b71875


From noreply at github.com  Sun Jul  7 15:29:41 2019
From: noreply at github.com (opensips-github)
Date: Sun, 07 Jul 2019 12:29:41 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e02dd3: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/989106-e02dd3@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e02dd3a797505c29bcdf4c22adc0e520e5380bd2
      https://github.com/OpenSIPS/opensips/commit/e02dd3a797505c29bcdf4c22adc0e520e5380bd2
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-07 (Sun, 07 Jul 2019)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cgrates/README
    M modules/cgrates/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/freeswitch_scripting/README
    M modules/freeswitch_scripting/doc/contributors.xml
    M modules/mmgeoip/README
    M modules/mmgeoip/doc/contributors.xml
    M modules/nathelper/README
    M modules/nathelper/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/pua_dialoginfo/README
    M modules/pua_dialoginfo/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul  7 15:42:08 2019
From: noreply at github.com (opensips-github)
Date: Sun, 07 Jul 2019 12:42:08 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d5434d: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/58e469-d5434d@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d5434d0dcb68c6cfcf3b8f2f379a0448041b0893
      https://github.com/OpenSIPS/opensips/commit/d5434d0dcb68c6cfcf3b8f2f379a0448041b0893
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-07 (Sun, 07 Jul 2019)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cgrates/README
    M modules/cgrates/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/freeswitch_scripting/README
    M modules/freeswitch_scripting/doc/contributors.xml
    M modules/mmgeoip/README
    M modules/mmgeoip/doc/contributors.xml
    M modules/nathelper/README
    M modules/nathelper/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/proto_smpp/README
    M modules/proto_smpp/doc/contributors.xml
    M modules/pua_dialoginfo/README
    M modules/pua_dialoginfo/doc/contributors.xml
    M modules/rabbitmq_consumer/README
    M modules/rabbitmq_consumer/doc/contributors.xml
    M modules/rls/README
    M modules/rls/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul  7 15:55:03 2019
From: noreply at github.com (opensips-github)
Date: Sun, 07 Jul 2019 12:55:03 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 52949f: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/be0d3b-52949f@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 52949f490d2dbf67dcf5ef1b37f537e2e0d16d27
      https://github.com/OpenSIPS/opensips/commit/52949f490d2dbf67dcf5ef1b37f537e2e0d16d27
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-07 (Sun, 07 Jul 2019)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/b2b_logic/README
    M modules/b2b_logic/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cgrates/README
    M modules/cgrates/doc/contributors.xml
    M modules/clusterer/README
    M modules/clusterer/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/freeswitch_scripting/README
    M modules/freeswitch_scripting/doc/contributors.xml
    M modules/mmgeoip/README
    M modules/mmgeoip/doc/contributors.xml
    M modules/nathelper/README
    M modules/nathelper/doc/contributors.xml
    M modules/osp/README
    M modules/osp/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/proto_smpp/README
    M modules/proto_smpp/doc/contributors.xml
    M modules/pua_dialoginfo/README
    M modules/pua_dialoginfo/doc/contributors.xml
    M modules/rabbitmq_consumer/README
    M modules/rabbitmq_consumer/doc/contributors.xml
    M modules/rls/README
    M modules/rls/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul  7 23:13:44 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 20:13:44 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 61debb: Fixed variable name in
	function call
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/52949f-61debb@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 61debb3891462e15bd62223cc5bdb776c172b207
      https://github.com/OpenSIPS/opensips/commit/61debb3891462e15bd62223cc5bdb776c172b207
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M socket_info.c

  Log Message:
  -----------
  Fixed variable name in function call




From noreply at github.com  Sun Jul  7 23:15:05 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 20:15:05 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 36b4be: Properly set the
 SI_IS_LO flag on interfaces speci...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/61debb-36b4be@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 36b4be98794bfac120c345f70db3ad8a94a8ffef
      https://github.com/OpenSIPS/opensips/commit/36b4be98794bfac120c345f70db3ad8a94a8ffef
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M socket_info.c

  Log Message:
  -----------
  Properly set the SI_IS_LO flag on interfaces specified using IPs/hostnames




From noreply at github.com  Sun Jul  7 23:17:21 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 20:17:21 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 378db3: Fixed variable name in
	function call
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/d5434d-378db3@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 378db31288674862b7d5661558e095d4c5f36e3e
      https://github.com/OpenSIPS/opensips/commit/378db31288674862b7d5661558e095d4c5f36e3e
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M socket_info.c

  Log Message:
  -----------
  Fixed variable name in function call

(cherry picked from commit 61debb3891462e15bd62223cc5bdb776c172b207)




From noreply at github.com  Sun Jul  7 23:17:38 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 20:17:38 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7f0556: Properly set the
 SI_IS_LO flag on interfaces speci...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/378db3-7f0556@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7f0556104d5664c4f17bb9597abfece290124710
      https://github.com/OpenSIPS/opensips/commit/7f0556104d5664c4f17bb9597abfece290124710
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M socket_info.c

  Log Message:
  -----------
  Properly set the SI_IS_LO flag on interfaces specified using IPs/hostnames

(cherry picked from commit 36b4be98794bfac120c345f70db3ad8a94a8ffef)




From noreply at github.com  Sun Jul  7 23:20:39 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 20:20:39 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f90f19: Properly set the
 SI_IS_LO flag on interfaces speci...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/e02dd3-f90f19@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f90f19ab5305ba31f350c20ded3be28664ee2a2a
      https://github.com/OpenSIPS/opensips/commit/f90f19ab5305ba31f350c20ded3be28664ee2a2a
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M socket_info.c

  Log Message:
  -----------
  Properly set the SI_IS_LO flag on interfaces specified using IPs/hostnames

(cherry picked from commit 36b4be98794bfac120c345f70db3ad8a94a8ffef)




From noreply at github.com  Mon Jul  8 00:24:28 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 21:24:28 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0cdaff: Renamed
 refreshWatchers to refresh_watchers in doc...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/36b4be-0cdaff@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0cdaff16717aacd543de1b46e62b690d03832945
      https://github.com/OpenSIPS/opensips/commit/0cdaff16717aacd543de1b46e62b690d03832945
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/presence/doc/presence_admin.xml

  Log Message:
  -----------
  Renamed refreshWatchers to refresh_watchers in documentation




From noreply at github.com  Mon Jul  8 00:26:05 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 21:26:05 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5e117c: Renamed
 refreshWatchers to refresh_watchers in doc...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/7f0556-5e117c@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5e117c1c4df485a00c6a35741d0590055579b231
      https://github.com/OpenSIPS/opensips/commit/5e117c1c4df485a00c6a35741d0590055579b231
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/presence/doc/presence_admin.xml

  Log Message:
  -----------
  Renamed refreshWatchers to refresh_watchers in documentation

(cherry picked from commit 0cdaff16717aacd543de1b46e62b690d03832945)




From noreply at github.com  Mon Jul  8 00:44:15 2019
From: noreply at github.com (Dan Pascu)
Date: Sun, 07 Jul 2019 21:44:15 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1ca050: Refactored
 presence/rls configuration for specifyi...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/0cdaff-1ca050@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1ca0501eb2d8c4d9566b56a4baf7ffb6b0687361
      https://github.com/OpenSIPS/opensips/commit/1ca0501eb2d8c4d9566b56a4baf7ffb6b0687361
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/presence/doc/presence_admin.xml
    M modules/presence/presence.c
    M modules/presence/presence.h
    M modules/presence/subscribe.c
    M modules/presence/subscribe.h
    M modules/rls/doc/rls_admin.xml
    M modules/rls/notify.c
    M modules/rls/rls.c
    M modules/rls/rls.h
    M modules/rls/subscribe.c

  Log Message:
  -----------
  Refactored presence/rls configuration for specifying the Contact URI

Removed the server_address modparam and replaced it with contact_user.
The server_address was used to specify the URI for the Contact header
and it was optional for presence but mandatory for rls.

The idea of manually locking the Contact URI to a fixed value that is
specified in the configuration is non-functional in any setup that
involves the proxy listening on more than 1 IP/port/transport combo.

In the new model, the only configurable part of the Contact URI is the
username part, that can be specified through the contact_user modparam,
while the rest of the elements of the URI are automatically determined
from the interface where the request was recevied or sent from.




From bogdan at opensips.org  Mon Jul  8 07:36:56 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 8 Jul 2019 14:36:56 +0300
Subject: [OpenSIPS-Devel] Configuration issue with modparam syntax
In-Reply-To: <6BBE80DE-A6FB-43AC-9831-433E60D5D1C9@ag-projects.com>
References: <6BBE80DE-A6FB-43AC-9831-433E60D5D1C9@ag-projects.com>
Message-ID: <e776fce4-abf9-cd15-5cf5-5fd3fb95f4fd@opensips.org>

HI Dan,

Thanks for the report, but could you please open a bug report on the 
tracker - is is the easiest way for use to track and work with all the 
reports in a centralized way.

Thanks,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 06/26/2019 06:24 PM, Dan Pascu wrote:
> It seems that at least the ca_list modparam in tls_mgm doesn't accept a dash in filenames. If I have a modparam like:
>
> modparam("tls_mgm", "ca_list", "[default]/etc/opensips/tls/ca-list.pem")
>
> then checking the configuration fails with some obscure error that some source_ip element is not defined in acc_extra (way later in some route in the script).
>
> However if I replace the same with a filename without a dash in it like:
>
> modparam("tls_mgm", "ca_list", "[default]/etc/opensips/tls/calist.pem")
>
> Then the error goes away and opensips is able to start. Not sure if this limitation affects other modparams that specify filenames.
>
> --
> Dan
>
>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



From bogdan at opensips.org  Mon Jul  8 07:41:56 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 8 Jul 2019 14:41:56 +0300
Subject: [OpenSIPS-Devel] Erroneous Retransmissions
In-Reply-To: <2453866F-C561-48C4-99EF-F412ED67D089@genesys.com>
References: <038A054B-48FF-4CBA-9DF4-5543D6C8095D@genesys.com>
 <4CD67E78-F4A4-4CE6-B189-67D9E9CCE3A5@genesys.com>
 <D971C178-7D3F-464D-A2B6-631960129C86@genesys.com>
 <83f7d17e-692a-0b3d-b0e1-d0703de9da8d@opensips.org>
 <DEFED803-1DB5-489C-B03A-E2AD2876004E@genesys.com>
 <2453866F-C561-48C4-99EF-F412ED67D089@genesys.com>
Message-ID: <341ddd0b-43f1-954a-d647-7499e906c189@opensips.org>

Hi Ben,

What I see form the logs is a race between the process sending out the 
request (and adding the transaction to the retransmission timer) and the 
process receiving the reply (and removing the transaction from the 
retransmission timer).

The order is:
     [333] sends the request out
     [331] reply is received
     [331] trans out from retransmission list (actually not even there)
     [333] adds (after sending) the transaction to the timer

This probably happen due a fast reply, maybe in combination with a slow 
process re-scheduling (maybe OpenSIPS running on a VM?) .

Best Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 07/03/2019 03:17 AM, Ben Newlin wrote:
> Hello,
>
> This issue has not gotten a lot of response, but after upgrading to the latest 2.4 branch, we are still seeing cases where OpenSIPS retransmits a message even though a response has been received and processed already. In this case the retransmission occurred across a second boundary, so the timestamps in OpenSIPS' logs clearly show the retransmission was after successful processing of the first reply.
>
> Latest example here: https://pastebin.com/9R47gN4W
>
> In this example, you can see process 333 receives a REFER message at 19:28:51 and forwards it on to the next server. Following that process 331 receives a 405 response, also at 19:28:51. The response is processed and relayed back to the originator. But then at 19:28:52, the retransmission timer kicks anyway and process 327 retransmits the REFER. This causes another 405 response which is received by process 330 and relayed again.
>
> I have logs, packet captures, and anything else necessary to debug this issue. I can reproduce it very easily.
>
> Ben Newlin
>
> On 5/20/19, 8:50 AM, "Devel on behalf of Ben Newlin" <devel-bounces at lists.opensips.org on behalf of Ben.Newlin at genesys.com> wrote:
>
>      Razvan,
>      
>      I realize the microsecond stamp is not on each line, but I don't think that means this trace is not proving the issue. You can clearly see that the time between the last ms stamp before the timer is set (2019-05-17T13:48:10.440789Z) to the next stamp after the retransmission has occurred (2019-05-17T13:48:10.557105Z) is only 117ms, and this includes a lot of processing time after the retransmission was sent. I think that pretty clearly shows the issue.
>      
>      I would love to get more exact granularity for the logs, but OpenSIPS does not provide that. We are not using syslog; the timestamps on the OpenSIPS logs are coming from OpenSIPS directly, as are the prefixed stamps on my logs. I'm not aware of any way to instruct OpenSIPS to increase the granularity of that timestamp, so I'm not sure how to get you what you want.
>      
>      In addition, the numerous other traces I have provided clearly show retransmissions being sent after replies for the request have already been processed. No time stamps are necessary to see that; the retransmission logs are printing after the reply processing logs. It is very clear.
>      
>      Ben Newlin
>      
>      On 5/20/19, 3:51 AM, "Devel on behalf of Răzvan Crainea" <devel-bounces at lists.opensips.org on behalf of razvan at opensips.org> wrote:
>      
>          Hi, Ben!
>          
>          You are right, we are pretty busy trying to complete the 3.0 release,
>          that's why we are pushing back some of the reports.
>          I did check the logs that you have sent, and it doesn't seem to prove
>          the issue, as the microsec timestamp is not logged by each line. It
>          would be more helpful if you could also configure syslog to log the
>          microseconds.
>          
>          Best regards,
>          Răzvan
>          
>          On 5/17/19 9:20 PM, Ben Newlin wrote:
>          > Hello,
>          >
>          > I know you guys are probably heads down trying to get 3.0 out the door.
>          > I’m hoping that’s why this issue hasn’t gotten any traction. However,
>          > I’m continuing to see poor retransmission behavior from OpenSIPS. Traces
>          > from the most recent example are here: https://pastebin.com/4Lam9FaZ.
>          >
>          > In this trace I’ve left in some of our proprietary tracing that show a
>          > more detailed timestamp. OpenSIPS is receiving a BYE request and sets a
>          > retransmission timer for 500ms, the standard time. However, the timer
>          > popped after only ~124ms and a retransmission of the BYE was triggered.
>          > I have tcpdump traces confirming the retransmission of the BYE actually
>          > occurred at 124ms, this is not just an issue internal to OpenSIPS.
>          >
>          > Any insight our troubleshooting assistance with these issues would be
>          > greatly appreciated. This issue reproduces very regularly.
>          >
>          > Ben Newlin
>          >
>          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
>          > <Ben.Newlin at genesys.com>
>          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>          > *Date: *Wednesday, May 8, 2019 at 3:13 PM
>          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>          > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
>          >
>          > Has anyone had a chance to look into this issue? I was able to mitigate
>          > by inserting small delays in my test clients, but now I am running into
>          > an issue where responses from one OpenSIPS to another are being sent
>          > quickly enough to cause this problem. Making changes in my testbed is
>          > one thing, but I really don’t want to start injecting delays into my
>          > processing script to work around this issue.
>          >
>          > The issue is that final responses to a transaction that are received
>          > within a few milliseconds of the transaction being sent are not stopping
>          > the retransmission timer. The response is handled properly by OpenSIPS,
>          > but approximately 500ms later OpenSIPS will retransmit the request
>          > anyway. I can reproduce it very regularly in our testbed and it should
>          > also be easily reproducible with a simple SIPp scenario.
>          >
>          > Trace from the latest occurrence is here: https://pastebin.com/YAXFwNLb
>          >
>          > I’d be happy to open an issue on Github as well if that is desired.
>          >
>          > Ben Newlin
>          >
>          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
>          > <Ben.Newlin at genesys.com>
>          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>          > *Date: *Thursday, April 25, 2019 at 11:46 AM
>          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>          > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
>          >
>          > I have found that this issue seems to only occur when the responses are
>          > received immediately after the request has been sent; within a few
>          > milliseconds. Inserting a delay in the response seems to have made the
>          > erroneous retransmissions stop. This does not make it any less of a bug,
>          > but does seem to be a workaround.
>          >
>          > Ben Newlin
>          >
>          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
>          > <Ben.Newlin at genesys.com>
>          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>          > *Date: *Friday, April 19, 2019 at 8:47 AM
>          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>          > *Subject: *[OpenSIPS-Devel] Erroneous Retransmissions
>          >
>          > Resending the issue described below to the devel mailing list as I
>          > believe this is a bug, not a configuration issue.
>          >
>          > Ben Newlin
>          >
>          > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin
>          > <Ben.Newlin at genesys.com>
>          > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
>          > *Date: *Monday, April 15, 2019 at 7:20 PM
>          > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
>          > *Subject: *Re: [OpenSIPS-Users] Erroneous Retransmissions
>          >
>          > Just wanted to bump this to see if anyone has had a chance to take a
>          > look. We are continuing to see this failing our tests intermittently. I
>          > have a new example here: https://pastebin.com/kQJSGE56.
>          >
>          > In this example you can see that the retransmission of the INVITE is
>          > occurring not just after the 100 Trying has been received, but also
>          > after a 500 final response has already been received and is being
>          > processed, but the INVITE is still retransmitted!
>          >
>          > Any help on this would be greatly appreciated.
>          >
>          > # opensips -V
>          >
>          > version: opensips 2.4.5 (x86_64/linux)
>          >
>          > flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC,
>          > F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
>          >
>          > ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16,
>          > MAX_URI_SIZE 1024, BUF_SIZE 65535
>          >
>          > poll method support: poll, epoll, sigio_rt, select.
>          >
>          > git revision: d025b4f61
>          >
>          > main.c compiled on 21:18:18 Apr 12 2019 with gcc 7
>          >
>          > Ben Newlin
>          >
>          > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin
>          > <Ben.Newlin at genesys.com>
>          > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
>          > *Date: *Thursday, April 4, 2019 at 3:10 PM
>          > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
>          > *Subject: *[OpenSIPS-Users] Erroneous Retransmissions
>          >
>          > Hello,
>          >
>          > We are seeing an issue which is causing our tests to fail
>          > intermittently. It appears that sometimes OpenSIPS will retransmit a
>          > relayed INVITE request, even though a 100 Trying response has already
>          > been received and processed. This only happens intermittently.
>          >
>          > I have captured debug logs for the scenario:
>          > https://pastebin.com/bHcBJmtv. In the log, you can see the 100 Trying
>          > response is received on line 707 and it appears to be matched to the
>          > correct transaction on line 729. However then on line 774 you can see
>          > the retransmission of the INVITE anyway.
>          >
>          > I have verified using tcpdump that the INVITE is being retransmitted; it
>          > is not just a log error. And our tests are failing due to the unexpected
>          > extra 100 Trying response to the retransmission.
>          >
>          > Can anyone explain why this would occur?
>          >
>          > Ben Newlin
>          >
>          >
>          > _______________________________________________
>          > Devel mailing list
>          > Devel at lists.opensips.org
>          > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>          >
>          
>          --
>          Răzvan Crainea
>          OpenSIPS Core Developer
>             http://www.opensips-solutions.com
>          Meet the OpenSIPS team at the next OpenSIPS Summit:
>             https://www.opensips.org/events
>          
>          _______________________________________________
>          Devel mailing list
>          Devel at lists.opensips.org
>          http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>          
>          
>      
>      _______________________________________________
>      Devel mailing list
>      Devel at lists.opensips.org
>      http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>      
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



From bogdan at opensips.org  Mon Jul  8 07:45:12 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 8 Jul 2019 14:45:12 +0300
Subject: [OpenSIPS-Devel] Crash in latest opensips
In-Reply-To: <46125BCD-E5BA-4669-A2AA-00336D0C8E2C@ag-projects.com>
References: <46125BCD-E5BA-4669-A2AA-00336D0C8E2C@ag-projects.com>
Message-ID: <d955ab30-c7a3-6b20-f874-f5ab362978dc@opensips.org>

Hi Dan,

Please open a bug report on the GITHUB tracker.

Thanks & Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 07/01/2019 02:20 PM, Dan Pascu wrote:
> This crash happens with the latest git source as of today, at version b367b7c5d.
>
> I had this crash happen twice in a few hours after running the same environment for more than a month without any change, so I guess it's not easy to reproduce.
>
> The first time it crashed I got these entries in syslog for the process that crashed:
>
> ----------------------
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:send_fd: sendmsg failed on 172: Bad file descriptor
> Jun 30 02:29:10 node15 ./opensips[3573]: ERROR:core:send2worker: send_fd failed
> Jun 30 02:29:10 node15 ./opensips[3573]: ERROR:core:handle_tcpconn_ev: no TCP workers available
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del: [TCP_main] check failed after successful fd del (fd=221,flags=0, sflags=1) over map (fd=-1,type=0,data=(nil),flags=536870912) erase=1
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add: [TCP_main] check failed after successful fd add (fd=222,type=19,data=0x7ff16c0da018,flags=1) already=0
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del: [TCP_main] check failed after successful fd del (fd=222,flags=16, sflags=3) over map (fd=-1,type=0,data=(nil),flags=0) erase=1
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add: [TCP_main] check failed after failed fd add (fd=220,type=19,data=0x7ff16c1042a8,flags=1) already=-1
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_add: [TCP_main] check failed after successful fd add (fd=222,type=19,data=0x7ff16c1042a8,flags=1) already=0
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del:
> Jun 30 02:29:10 node15 ./opensips[3573]: CRITICAL:core:io_watch_del: [TCP_main] check failed after successful fd del (fd=222,flags=16, sflags=3) over map (fd=-1,type=0,data=(nil),flags=0) erase=1
> Jun 30 02:29:14 node15 ./opensips[3573]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff16c1042a8), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: child process 3573 exited by a signal 6
> ----------------------
>
> and the backtrace reads:
>
> (gdb) bt
> #0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007ff18de72535 in __GI_abort () at abort.c:79
> #2  0x000056070c29962f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
>      func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
> #3  0x000056070c4b34ee in _shm_free (file=0x56070c6485a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
>      ptr=0x7ff16c1042a8) at net/../mem/shm_mem.h:448
> #4  _tcpconn_rm (c=c at entry=0x7ff16c1042a8) at net/net_tcp.c:747
> #5  0x000056070c4d221e in __tcpconn_lifetime (force=0) at net/net_tcp.c:1608
> #6  tcp_main_server () at net/net_tcp.c:1695
> #7  0x000056070c4dc41a in tcp_start_listener () at net/net_tcp.c:2114
> #8  0x000056070bfb5eba in main_loop () at main.c:813
> #9  main (argc=<optimized out>, argv=<optimized out>) at main.c:1480
>
>
> At the same time a second process crashed with the following in syslog (this looks like the main process trying to do cleanup):
>
> -----------------------
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: child process 3573 exited by a signal 6
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: core was generated
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:handle_sigs: terminating due to SIGCHLD
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 1(3554) [JSON-RPC sender] terminated, still waiting for 15 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 2(3555) [MI Datagram] terminated, still waiting for 14 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 3(3556) [MI FIFO] terminated, still waiting for 13 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 4(3557) [time_keeper] terminated, still waiting for 12 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 5(3558) [timer] terminated, still waiting for 11 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 12(3565) [TCP receiver] terminated, still waiting for 10 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 13(3566) [TCP receiver] terminated, still waiting for 9 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 11(3564) [TCP receiver] terminated, still waiting for 8 more
> Jun 30 02:29:16 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 15(3570) [TCP receiver] terminated, still waiting for 7 more
> Jun 30 02:29:19 node15 ./opensips[3552]: INFO:core:shutdown_opensips: process 9(3562) [SIP receiver udp:81.23.228.160:5060] terminated, still waiting for 6 more
> Jun 30 02:29:21 node15 ./opensips[3552]: INFO:core:cleanup: cleanup
> Jun 30 02:29:21 node15 ./opensips[3552]: INFO:db_mysql:switch_state_to_disconnected: disconnect event for 0x60b00000b9e0
> Jun 30 02:29:21 node15 ./opensips[3552]: INFO:db_mysql:reset_all_statements: resetting all statements on connection: (0x60d000005b40) 0x60b00000b9e0
> Jun 30 02:29:21 node15 ./opensips[3552]: INFO:db_mysql:connect_with_retry: re-connected successful for 0x60b00000b9e0
> Jun 30 02:29:21 node15 ./opensips[3552]: NOTICE:presence:destroy: destroy module ...
> Jun 30 02:29:21 node15 ./opensips[3552]: NOTICE:event_jsonrpc:destroy: destroy module ...
> Jun 30 02:29:21 node15 ./opensips[3552]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff16c10a6f0), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
> -----------------------
>
> and this backtrace:
>
> (gdb) bt
> #0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007ff18de72535 in __GI_abort () at abort.c:79
> #2  0x000056070c29962f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
>      func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
> #3  0x000056070c4b34ee in _shm_free (file=0x56070c6485a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
>      ptr=0x7ff16c10a6f0) at net/../mem/shm_mem.h:448
> #4  _tcpconn_rm (c=0x7ff16c10a6f0) at net/net_tcp.c:747
> #5  0x000056070c4d5f12 in __tcpconn_lifetime (force=1) at net/net_tcp.c:1608
> #6  tcp_destroy () at net/net_tcp.c:1811
> #7  0x000056070c1e551a in cleanup (show_status=show_status at entry=1) at main.c:360
> #8  0x000056070c1e69aa in shutdown_opensips (status=status at entry=134) at main.c:522
> #9  0x000056070c1e7ca0 in handle_sigs () at main.c:605
> #10 0x000056070bfb65fe in main_loop () at main.c:867
> #11 main (argc=<optimized out>, argv=<optimized out>) at main.c:1480
>
>
> The second time syslog didn't have much detail except the critical double free error. This time it also had 2 crashed processes. The first one had this:
>
> ------------------------
> Jun 30 03:11:47 node15 ./opensips[18284]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff8ed303b38), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
> ------------------------
>
> and backtrace:
>
> (gdb) bt
> #0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007ff90f1f2535 in __GI_abort () at abort.c:79
> #2  0x00005584676ff62f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
>      func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
> #3  0x00005584679194ee in _shm_free (file=0x558467aae5a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
>      ptr=0x7ff8ed303b38) at net/../mem/shm_mem.h:448
> #4  _tcpconn_rm (c=c at entry=0x7ff8ed303b38) at net/net_tcp.c:747
> #5  0x0000558467919d4a in tcpconn_destroy (tcpconn=0x7ff8ed303b38) at net/net_tcp.c:1005
> #6  0x000055846792a707 in handle_tcp_worker (fd_i=<optimized out>, tcp_c=0x6160000039c8) at net/net_tcp.c:1335
> #7  handle_io (fm=<optimized out>, idx=idx at entry=22, event_type=event_type at entry=1) at net/net_tcp.c:1525
> #8  0x0000558467937831 in io_wait_loop_epoll (h=<optimized out>, t=5, repeat=0) at net/../io_wait_loop.h:280
> #9  tcp_main_server () at net/net_tcp.c:1695
> #10 0x000055846794241a in tcp_start_listener () at net/net_tcp.c:2114
> #11 0x000055846741beba in main_loop () at main.c:813
> #12 main (argc=<optimized out>, argv=<optimized out>) at main.c:1480
>
>
> and the main process had:
>
> ---------------------
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:handle_sigs: child process 18284 exited by a signal 6
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:handle_sigs: core was generated
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:handle_sigs: terminating due to SIGCHLD
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 2(18258) [MI Datagram] terminated, still waiting for 15 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 1(18257) [JSON-RPC sender] terminated, still waiting for 14 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 12(18273) [TCP receiver] terminated, still waiting for 13 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 14(18278) [TCP receiver] terminated, still waiting for 12 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 3(18259) [MI FIFO] terminated, still waiting for 11 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 4(18260) [time_keeper] terminated, still waiting for 10 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 13(18276) [TCP receiver] terminated, still waiting for 9 more
> Jun 30 03:11:49 node15 ./opensips[18255]: INFO:core:shutdown_opensips: process 5(18261) [timer] terminated, still waiting for 8 more
> Jun 30 03:11:54 node15 ./opensips[18255]: INFO:core:cleanup: cleanup
> Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:switch_state_to_disconnected: disconnect event for 0x60b00002fed0
> Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:reset_all_statements: resetting all statements on connection: (0x60d000005b40) 0x60b00002fed0
> Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:connect_with_retry: re-connected successful for 0x60b00002fed0
> Jun 30 03:11:56 node15 ./opensips[18255]: INFO:db_mysql:db_mysql_do_prepared_query: reconnected to mysql server -> re-init the statement
> Jun 30 03:11:56 node15 ./opensips[18255]: NOTICE:presence:destroy: destroy module ...
> Jun 30 03:11:56 node15 ./opensips[18255]: NOTICE:event_jsonrpc:destroy: destroy module ...
> Jun 30 03:11:56 node15 ./opensips[18255]: CRITICAL:core:fm_free_dbg: freeing already freed shm pointer (0x7ff8ed31b098), first free: net/net_tcp.c: _tcpconn_rm(747) - aborting!
> ---------------------
>
> and backtrace:
>
> (gdb) bt
> #0  __GI_raise (sig=sig at entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007ff90f1f2535 in __GI_abort () at abort.c:79
> #2  0x00005584676ff62f in fm_free_dbg (fm=<optimized out>, p=<optimized out>, file=<optimized out>,
>      func=<optimized out>, line=<optimized out>) at mem/f_malloc_dyn.h:221
> #3  0x00005584679194ee in _shm_free (file=0x558467aae5a0 "net/net_tcp.c", line=747, function=<synthetic pointer>,
>      ptr=0x7ff8ed31b098) at net/../mem/shm_mem.h:448
> #4  _tcpconn_rm (c=0x7ff8ed31b098) at net/net_tcp.c:747
> #5  0x000055846793bf12 in __tcpconn_lifetime (force=1) at net/net_tcp.c:1608
> #6  tcp_destroy () at net/net_tcp.c:1811
> #7  0x000055846764b51a in cleanup (show_status=show_status at entry=1) at main.c:360
> #8  0x000055846764c9aa in shutdown_opensips (status=status at entry=134) at main.c:522
> #9  0x000055846764dca0 in handle_sigs () at main.c:605
> #10 0x000055846741c5fe in main_loop () at main.c:867
> #11 main (argc=<optimized out>, argv=<optimized out>) at main.c:1480
>
> --
> Dan
>
>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



From bogdan at opensips.org  Mon Jul  8 07:46:24 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 8 Jul 2019 14:46:24 +0300
Subject: [OpenSIPS-Devel] TCP connections
In-Reply-To: <710AF046-517B-4551-8906-40A8BBF248DF@ag-projects.com>
References: <CDF3338D-0092-4933-81BC-A580E08DDE8F@ag-projects.com>
 <710AF046-517B-4551-8906-40A8BBF248DF@ag-projects.com>
Message-ID: <e03d4a9e-b0e4-0f23-2af9-0130b3247eed@opensips.org>

Hi Dan,

Was the connection ever removed ? Can you reproduce this sticky connection ?

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 07/01/2019 02:27 PM, Dan Pascu wrote:
> On 1 Jul 2019, at 14:24, Dan Pascu wrote:
>
>> When I list the tcp connections through the MI interface I see the entry below:
>>
>>         {
>>             "ID": 792633175,
>>             "Type": "tcp",
>>             "State": -1,
>>             "Remote": "xx.xx.xx.xx:5060",
>>             "Local": "yy.yy.yy.yy:44511",
>>             "Lifetime": "2019-06-30 08:32:22"
>>         },
>>
>> The sampling was done on 2019-07-30 13:23:36, so this entry looks like it was expired for more than 24 hours yet still not removed from the list.
> Sorry I mistyped this, I meant 2019-07-01 (i.e. today)
>
> --
> Dan
>
>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



From bogdan at opensips.org  Mon Jul  8 08:21:13 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 8 Jul 2019 15:21:13 +0300
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1fa5a0: rls: Fixed memory
 leak in rls_handle_subscribe
In-Reply-To: <OpenSIPS/opensips/push/refs/heads/3.0/52b4e7-58e469@github.com>
References: <OpenSIPS/opensips/push/refs/heads/3.0/52b4e7-58e469@github.com>
Message-ID: <738a03e0-eb13-b72c-546c-fb1675f98b24@opensips.org>

Hi Dan,

Great fixes - shouldn't they be backported to 2.4 also ?

Thanks,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 07/06/2019 07:01 PM, Dan Pascu wrote:
>    Branch: refs/heads/3.0
>    Home:   https://github.com/OpenSIPS/opensips
>    Commit: 1fa5a067ac6c7c32580ce233da438cde3f82f80a
>        https://github.com/OpenSIPS/opensips/commit/1fa5a067ac6c7c32580ce233da438cde3f82f80a
>    Author: Dan Pascu <dan at ag-projects.com>
>    Date:   2019-07-06 (Sat, 06 Jul 2019)
>
>    Changed paths:
>      M modules/rls/subscribe.c
>
>    Log Message:
>    -----------
>    rls: Fixed memory leak in rls_handle_subscribe
>
> (cherry picked from commit 5692501f8ce3eda41872e4d5996d701bc804408e)
>
>
>    Commit: 11afeaf72e9bffc5c56063f734d0b41444f935db
>        https://github.com/OpenSIPS/opensips/commit/11afeaf72e9bffc5c56063f734d0b41444f935db
>    Author: Dan Pascu <dan at ag-projects.com>
>    Date:   2019-07-06 (Sat, 06 Jul 2019)
>
>    Changed paths:
>      M modules/rls/subscribe.c
>
>    Log Message:
>    -----------
>    rls: Report the actual code that was used in reply
>
> (cherry picked from commit a72132832f0835d815fdc9488d80df684eb2dbde)
>
>
>    Commit: 58e469b71875c852876ffd4c87f3f7f074aeb858
>        https://github.com/OpenSIPS/opensips/commit/58e469b71875c852876ffd4c87f3f7f074aeb858
>    Author: Dan Pascu <dan at ag-projects.com>
>    Date:   2019-07-06 (Sat, 06 Jul 2019)
>
>    Changed paths:
>      M modules/rls/subscribe.c
>
>    Log Message:
>    -----------
>    rls: Cleanup spacing
>
> (cherry picked from commit be0d3b7bb3b2e956b783623df417f48582aadc5a)
>
>
> Compare: https://github.com/OpenSIPS/opensips/compare/52b4e7827632...58e469b71875
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



From Ben.Newlin at genesys.com  Mon Jul  8 08:31:28 2019
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Mon, 8 Jul 2019 12:31:28 +0000
Subject: [OpenSIPS-Devel] Erroneous Retransmissions
In-Reply-To: <341ddd0b-43f1-954a-d647-7499e906c189@opensips.org>
References: <038A054B-48FF-4CBA-9DF4-5543D6C8095D@genesys.com>
 <4CD67E78-F4A4-4CE6-B189-67D9E9CCE3A5@genesys.com>
 <D971C178-7D3F-464D-A2B6-631960129C86@genesys.com>
 <83f7d17e-692a-0b3d-b0e1-d0703de9da8d@opensips.org>
 <DEFED803-1DB5-489C-B03A-E2AD2876004E@genesys.com>
 <2453866F-C561-48C4-99EF-F412ED67D089@genesys.com>
 <341ddd0b-43f1-954a-d647-7499e906c189@opensips.org>
Message-ID: <2910C4A5-9495-44B2-8AD6-2591AA169A1D@genesys.com>

Bogdan,

Yes, a race condition is what I suspected as well. In these cases OpenSIPS is running in Docker.

Ben Newlin 

On 7/8/19, 7:42 AM, "Bogdan-Andrei Iancu" <bogdan at opensips.org> wrote:

    Hi Ben,
    
    What I see form the logs is a race between the process sending out the 
    request (and adding the transaction to the retransmission timer) and the 
    process receiving the reply (and removing the transaction from the 
    retransmission timer).
    
    The order is:
         [333] sends the request out
         [331] reply is received
         [331] trans out from retransmission list (actually not even there)
         [333] adds (after sending) the transaction to the timer
    
    This probably happen due a fast reply, maybe in combination with a slow 
    process re-scheduling (maybe OpenSIPS running on a VM?) .
    
    Best Regards,
    
    Bogdan-Andrei Iancu
    
    OpenSIPS Founder and Developer
       https://www.opensips-solutions.com
    OpenSIPS Summit 2019
       https://www.opensips.org/events/Summit-2019Amsterdam/
    
    On 07/03/2019 03:17 AM, Ben Newlin wrote:
    > Hello,
    >
    > This issue has not gotten a lot of response, but after upgrading to the latest 2.4 branch, we are still seeing cases where OpenSIPS retransmits a message even though a response has been received and processed already. In this case the retransmission occurred across a second boundary, so the timestamps in OpenSIPS' logs clearly show the retransmission was after successful processing of the first reply.
    >
    > Latest example here: https://pastebin.com/9R47gN4W
    >
    > In this example, you can see process 333 receives a REFER message at 19:28:51 and forwards it on to the next server. Following that process 331 receives a 405 response, also at 19:28:51. The response is processed and relayed back to the originator. But then at 19:28:52, the retransmission timer kicks anyway and process 327 retransmits the REFER. This causes another 405 response which is received by process 330 and relayed again.
    >
    > I have logs, packet captures, and anything else necessary to debug this issue. I can reproduce it very easily.
    >
    > Ben Newlin
    >
    > On 5/20/19, 8:50 AM, "Devel on behalf of Ben Newlin" <devel-bounces at lists.opensips.org on behalf of Ben.Newlin at genesys.com> wrote:
    >
    >      Razvan,
    >      
    >      I realize the microsecond stamp is not on each line, but I don't think that means this trace is not proving the issue. You can clearly see that the time between the last ms stamp before the timer is set (2019-05-17T13:48:10.440789Z) to the next stamp after the retransmission has occurred (2019-05-17T13:48:10.557105Z) is only 117ms, and this includes a lot of processing time after the retransmission was sent. I think that pretty clearly shows the issue.
    >      
    >      I would love to get more exact granularity for the logs, but OpenSIPS does not provide that. We are not using syslog; the timestamps on the OpenSIPS logs are coming from OpenSIPS directly, as are the prefixed stamps on my logs. I'm not aware of any way to instruct OpenSIPS to increase the granularity of that timestamp, so I'm not sure how to get you what you want.
    >      
    >      In addition, the numerous other traces I have provided clearly show retransmissions being sent after replies for the request have already been processed. No time stamps are necessary to see that; the retransmission logs are printing after the reply processing logs. It is very clear.
    >      
    >      Ben Newlin
    >      
    >      On 5/20/19, 3:51 AM, "Devel on behalf of Răzvan Crainea" <devel-bounces at lists.opensips.org on behalf of razvan at opensips.org> wrote:
    >      
    >          Hi, Ben!
    >          
    >          You are right, we are pretty busy trying to complete the 3.0 release,
    >          that's why we are pushing back some of the reports.
    >          I did check the logs that you have sent, and it doesn't seem to prove
    >          the issue, as the microsec timestamp is not logged by each line. It
    >          would be more helpful if you could also configure syslog to log the
    >          microseconds.
    >          
    >          Best regards,
    >          Răzvan
    >          
    >          On 5/17/19 9:20 PM, Ben Newlin wrote:
    >          > Hello,
    >          >
    >          > I know you guys are probably heads down trying to get 3.0 out the door.
    >          > I’m hoping that’s why this issue hasn’t gotten any traction. However,
    >          > I’m continuing to see poor retransmission behavior from OpenSIPS. Traces
    >          > from the most recent example are here: https://pastebin.com/4Lam9FaZ.
    >          >
    >          > In this trace I’ve left in some of our proprietary tracing that show a
    >          > more detailed timestamp. OpenSIPS is receiving a BYE request and sets a
    >          > retransmission timer for 500ms, the standard time. However, the timer
    >          > popped after only ~124ms and a retransmission of the BYE was triggered.
    >          > I have tcpdump traces confirming the retransmission of the BYE actually
    >          > occurred at 124ms, this is not just an issue internal to OpenSIPS.
    >          >
    >          > Any insight our troubleshooting assistance with these issues would be
    >          > greatly appreciated. This issue reproduces very regularly.
    >          >
    >          > Ben Newlin
    >          >
    >          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
    >          > <Ben.Newlin at genesys.com>
    >          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
    >          > *Date: *Wednesday, May 8, 2019 at 3:13 PM
    >          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
    >          > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
    >          >
    >          > Has anyone had a chance to look into this issue? I was able to mitigate
    >          > by inserting small delays in my test clients, but now I am running into
    >          > an issue where responses from one OpenSIPS to another are being sent
    >          > quickly enough to cause this problem. Making changes in my testbed is
    >          > one thing, but I really don’t want to start injecting delays into my
    >          > processing script to work around this issue.
    >          >
    >          > The issue is that final responses to a transaction that are received
    >          > within a few milliseconds of the transaction being sent are not stopping
    >          > the retransmission timer. The response is handled properly by OpenSIPS,
    >          > but approximately 500ms later OpenSIPS will retransmit the request
    >          > anyway. I can reproduce it very regularly in our testbed and it should
    >          > also be easily reproducible with a simple SIPp scenario.
    >          >
    >          > Trace from the latest occurrence is here: https://pastebin.com/YAXFwNLb
    >          >
    >          > I’d be happy to open an issue on Github as well if that is desired.
    >          >
    >          > Ben Newlin
    >          >
    >          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
    >          > <Ben.Newlin at genesys.com>
    >          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
    >          > *Date: *Thursday, April 25, 2019 at 11:46 AM
    >          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
    >          > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
    >          >
    >          > I have found that this issue seems to only occur when the responses are
    >          > received immediately after the request has been sent; within a few
    >          > milliseconds. Inserting a delay in the response seems to have made the
    >          > erroneous retransmissions stop. This does not make it any less of a bug,
    >          > but does seem to be a workaround.
    >          >
    >          > Ben Newlin
    >          >
    >          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
    >          > <Ben.Newlin at genesys.com>
    >          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
    >          > *Date: *Friday, April 19, 2019 at 8:47 AM
    >          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
    >          > *Subject: *[OpenSIPS-Devel] Erroneous Retransmissions
    >          >
    >          > Resending the issue described below to the devel mailing list as I
    >          > believe this is a bug, not a configuration issue.
    >          >
    >          > Ben Newlin
    >          >
    >          > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin
    >          > <Ben.Newlin at genesys.com>
    >          > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
    >          > *Date: *Monday, April 15, 2019 at 7:20 PM
    >          > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
    >          > *Subject: *Re: [OpenSIPS-Users] Erroneous Retransmissions
    >          >
    >          > Just wanted to bump this to see if anyone has had a chance to take a
    >          > look. We are continuing to see this failing our tests intermittently. I
    >          > have a new example here: https://pastebin.com/kQJSGE56.
    >          >
    >          > In this example you can see that the retransmission of the INVITE is
    >          > occurring not just after the 100 Trying has been received, but also
    >          > after a 500 final response has already been received and is being
    >          > processed, but the INVITE is still retransmitted!
    >          >
    >          > Any help on this would be greatly appreciated.
    >          >
    >          > # opensips -V
    >          >
    >          > version: opensips 2.4.5 (x86_64/linux)
    >          >
    >          > flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC,
    >          > F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
    >          >
    >          > ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16,
    >          > MAX_URI_SIZE 1024, BUF_SIZE 65535
    >          >
    >          > poll method support: poll, epoll, sigio_rt, select.
    >          >
    >          > git revision: d025b4f61
    >          >
    >          > main.c compiled on 21:18:18 Apr 12 2019 with gcc 7
    >          >
    >          > Ben Newlin
    >          >
    >          > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin
    >          > <Ben.Newlin at genesys.com>
    >          > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
    >          > *Date: *Thursday, April 4, 2019 at 3:10 PM
    >          > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
    >          > *Subject: *[OpenSIPS-Users] Erroneous Retransmissions
    >          >
    >          > Hello,
    >          >
    >          > We are seeing an issue which is causing our tests to fail
    >          > intermittently. It appears that sometimes OpenSIPS will retransmit a
    >          > relayed INVITE request, even though a 100 Trying response has already
    >          > been received and processed. This only happens intermittently.
    >          >
    >          > I have captured debug logs for the scenario:
    >          > https://pastebin.com/bHcBJmtv. In the log, you can see the 100 Trying
    >          > response is received on line 707 and it appears to be matched to the
    >          > correct transaction on line 729. However then on line 774 you can see
    >          > the retransmission of the INVITE anyway.
    >          >
    >          > I have verified using tcpdump that the INVITE is being retransmitted; it
    >          > is not just a log error. And our tests are failing due to the unexpected
    >          > extra 100 Trying response to the retransmission.
    >          >
    >          > Can anyone explain why this would occur?
    >          >
    >          > Ben Newlin
    >          >
    >          >
    >          > _______________________________________________
    >          > Devel mailing list
    >          > Devel at lists.opensips.org
    >          > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
    >          >
    >          
    >          --
    >          Răzvan Crainea
    >          OpenSIPS Core Developer
    >             http://www.opensips-solutions.com
    >          Meet the OpenSIPS team at the next OpenSIPS Summit:
    >             https://www.opensips.org/events
    >          
    >          _______________________________________________
    >          Devel mailing list
    >          Devel at lists.opensips.org
    >          http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
    >          
    >          
    >      
    >      _______________________________________________
    >      Devel mailing list
    >      Devel at lists.opensips.org
    >      http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
    >      
    >
    > _______________________________________________
    > Devel mailing list
    > Devel at lists.opensips.org
    > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
    
    


From noreply at github.com  Mon Jul  8 08:39:43 2019
From: noreply at github.com (Dan Pascu)
Date: Mon, 08 Jul 2019 05:39:43 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 39a1ab: rls: Fixed memory leak
 in rls_handle_subscribe
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/f90f19-6b9dec@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 39a1ab266d31cbcfbd86923dc7eb81b6d54e5598
      https://github.com/OpenSIPS/opensips/commit/39a1ab266d31cbcfbd86923dc7eb81b6d54e5598
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Fixed memory leak in rls_handle_subscribe

(cherry picked from commit 5692501f8ce3eda41872e4d5996d701bc804408e)


  Commit: 8d092353137636c36ce7044390a99a8c2ec6234f
      https://github.com/OpenSIPS/opensips/commit/8d092353137636c36ce7044390a99a8c2ec6234f
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Report the actual code that was used in reply

(cherry picked from commit a72132832f0835d815fdc9488d80df684eb2dbde)


  Commit: 6b9decce75c4b7d4f77e5714d716cfc9e40350f2
      https://github.com/OpenSIPS/opensips/commit/6b9decce75c4b7d4f77e5714d716cfc9e40350f2
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/rls/subscribe.c

  Log Message:
  -----------
  rls: Cleanup spacing

(cherry picked from commit be0d3b7bb3b2e956b783623df417f48582aadc5a)


Compare: https://github.com/OpenSIPS/opensips/compare/f90f19ab5305...6b9decce75c4


From bogdan at opensips.org  Mon Jul  8 10:39:23 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 8 Jul 2019 17:39:23 +0300
Subject: [OpenSIPS-Devel] Erroneous Retransmissions
In-Reply-To: <2910C4A5-9495-44B2-8AD6-2591AA169A1D@genesys.com>
References: <038A054B-48FF-4CBA-9DF4-5543D6C8095D@genesys.com>
 <4CD67E78-F4A4-4CE6-B189-67D9E9CCE3A5@genesys.com>
 <D971C178-7D3F-464D-A2B6-631960129C86@genesys.com>
 <83f7d17e-692a-0b3d-b0e1-d0703de9da8d@opensips.org>
 <DEFED803-1DB5-489C-B03A-E2AD2876004E@genesys.com>
 <2453866F-C561-48C4-99EF-F412ED67D089@genesys.com>
 <341ddd0b-43f1-954a-d647-7499e906c189@opensips.org>
 <2910C4A5-9495-44B2-8AD6-2591AA169A1D@genesys.com>
Message-ID: <9a572cb8-a4a2-df7c-645b-95fb4b1c97e3@opensips.org>

Yeah, that would probably explain both the fast reply (I guess for 
another container) and the slow re-scheduling.

Could you please post this as a bug report on Github, we can manage it?

Thanks and regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/

On 07/08/2019 03:31 PM, Ben Newlin wrote:
> Bogdan,
>
> Yes, a race condition is what I suspected as well. In these cases OpenSIPS is running in Docker.
>
> Ben Newlin
>
> On 7/8/19, 7:42 AM, "Bogdan-Andrei Iancu" <bogdan at opensips.org> wrote:
>
>      Hi Ben,
>      
>      What I see form the logs is a race between the process sending out the
>      request (and adding the transaction to the retransmission timer) and the
>      process receiving the reply (and removing the transaction from the
>      retransmission timer).
>      
>      The order is:
>           [333] sends the request out
>           [331] reply is received
>           [331] trans out from retransmission list (actually not even there)
>           [333] adds (after sending) the transaction to the timer
>      
>      This probably happen due a fast reply, maybe in combination with a slow
>      process re-scheduling (maybe OpenSIPS running on a VM?) .
>      
>      Best Regards,
>      
>      Bogdan-Andrei Iancu
>      
>      OpenSIPS Founder and Developer
>         https://www.opensips-solutions.com
>      OpenSIPS Summit 2019
>         https://www.opensips.org/events/Summit-2019Amsterdam/
>      
>      On 07/03/2019 03:17 AM, Ben Newlin wrote:
>      > Hello,
>      >
>      > This issue has not gotten a lot of response, but after upgrading to the latest 2.4 branch, we are still seeing cases where OpenSIPS retransmits a message even though a response has been received and processed already. In this case the retransmission occurred across a second boundary, so the timestamps in OpenSIPS' logs clearly show the retransmission was after successful processing of the first reply.
>      >
>      > Latest example here: https://pastebin.com/9R47gN4W
>      >
>      > In this example, you can see process 333 receives a REFER message at 19:28:51 and forwards it on to the next server. Following that process 331 receives a 405 response, also at 19:28:51. The response is processed and relayed back to the originator. But then at 19:28:52, the retransmission timer kicks anyway and process 327 retransmits the REFER. This causes another 405 response which is received by process 330 and relayed again.
>      >
>      > I have logs, packet captures, and anything else necessary to debug this issue. I can reproduce it very easily.
>      >
>      > Ben Newlin
>      >
>      > On 5/20/19, 8:50 AM, "Devel on behalf of Ben Newlin" <devel-bounces at lists.opensips.org on behalf of Ben.Newlin at genesys.com> wrote:
>      >
>      >      Razvan,
>      >
>      >      I realize the microsecond stamp is not on each line, but I don't think that means this trace is not proving the issue. You can clearly see that the time between the last ms stamp before the timer is set (2019-05-17T13:48:10.440789Z) to the next stamp after the retransmission has occurred (2019-05-17T13:48:10.557105Z) is only 117ms, and this includes a lot of processing time after the retransmission was sent. I think that pretty clearly shows the issue.
>      >
>      >      I would love to get more exact granularity for the logs, but OpenSIPS does not provide that. We are not using syslog; the timestamps on the OpenSIPS logs are coming from OpenSIPS directly, as are the prefixed stamps on my logs. I'm not aware of any way to instruct OpenSIPS to increase the granularity of that timestamp, so I'm not sure how to get you what you want.
>      >
>      >      In addition, the numerous other traces I have provided clearly show retransmissions being sent after replies for the request have already been processed. No time stamps are necessary to see that; the retransmission logs are printing after the reply processing logs. It is very clear.
>      >
>      >      Ben Newlin
>      >
>      >      On 5/20/19, 3:51 AM, "Devel on behalf of Răzvan Crainea" <devel-bounces at lists.opensips.org on behalf of razvan at opensips.org> wrote:
>      >
>      >          Hi, Ben!
>      >
>      >          You are right, we are pretty busy trying to complete the 3.0 release,
>      >          that's why we are pushing back some of the reports.
>      >          I did check the logs that you have sent, and it doesn't seem to prove
>      >          the issue, as the microsec timestamp is not logged by each line. It
>      >          would be more helpful if you could also configure syslog to log the
>      >          microseconds.
>      >
>      >          Best regards,
>      >          Răzvan
>      >
>      >          On 5/17/19 9:20 PM, Ben Newlin wrote:
>      >          > Hello,
>      >          >
>      >          > I know you guys are probably heads down trying to get 3.0 out the door.
>      >          > I’m hoping that’s why this issue hasn’t gotten any traction. However,
>      >          > I’m continuing to see poor retransmission behavior from OpenSIPS. Traces
>      >          > from the most recent example are here: https://pastebin.com/4Lam9FaZ.
>      >          >
>      >          > In this trace I’ve left in some of our proprietary tracing that show a
>      >          > more detailed timestamp. OpenSIPS is receiving a BYE request and sets a
>      >          > retransmission timer for 500ms, the standard time. However, the timer
>      >          > popped after only ~124ms and a retransmission of the BYE was triggered.
>      >          > I have tcpdump traces confirming the retransmission of the BYE actually
>      >          > occurred at 124ms, this is not just an issue internal to OpenSIPS.
>      >          >
>      >          > Any insight our troubleshooting assistance with these issues would be
>      >          > greatly appreciated. This issue reproduces very regularly.
>      >          >
>      >          > Ben Newlin
>      >          >
>      >          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
>      >          > <Ben.Newlin at genesys.com>
>      >          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>      >          > *Date: *Wednesday, May 8, 2019 at 3:13 PM
>      >          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>      >          > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
>      >          >
>      >          > Has anyone had a chance to look into this issue? I was able to mitigate
>      >          > by inserting small delays in my test clients, but now I am running into
>      >          > an issue where responses from one OpenSIPS to another are being sent
>      >          > quickly enough to cause this problem. Making changes in my testbed is
>      >          > one thing, but I really don’t want to start injecting delays into my
>      >          > processing script to work around this issue.
>      >          >
>      >          > The issue is that final responses to a transaction that are received
>      >          > within a few milliseconds of the transaction being sent are not stopping
>      >          > the retransmission timer. The response is handled properly by OpenSIPS,
>      >          > but approximately 500ms later OpenSIPS will retransmit the request
>      >          > anyway. I can reproduce it very regularly in our testbed and it should
>      >          > also be easily reproducible with a simple SIPp scenario.
>      >          >
>      >          > Trace from the latest occurrence is here: https://pastebin.com/YAXFwNLb
>      >          >
>      >          > I’d be happy to open an issue on Github as well if that is desired.
>      >          >
>      >          > Ben Newlin
>      >          >
>      >          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
>      >          > <Ben.Newlin at genesys.com>
>      >          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>      >          > *Date: *Thursday, April 25, 2019 at 11:46 AM
>      >          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>      >          > *Subject: *Re: [OpenSIPS-Devel] Erroneous Retransmissions
>      >          >
>      >          > I have found that this issue seems to only occur when the responses are
>      >          > received immediately after the request has been sent; within a few
>      >          > milliseconds. Inserting a delay in the response seems to have made the
>      >          > erroneous retransmissions stop. This does not make it any less of a bug,
>      >          > but does seem to be a workaround.
>      >          >
>      >          > Ben Newlin
>      >          >
>      >          > *From: *Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin
>      >          > <Ben.Newlin at genesys.com>
>      >          > *Reply-To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>      >          > *Date: *Friday, April 19, 2019 at 8:47 AM
>      >          > *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>      >          > *Subject: *[OpenSIPS-Devel] Erroneous Retransmissions
>      >          >
>      >          > Resending the issue described below to the devel mailing list as I
>      >          > believe this is a bug, not a configuration issue.
>      >          >
>      >          > Ben Newlin
>      >          >
>      >          > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin
>      >          > <Ben.Newlin at genesys.com>
>      >          > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
>      >          > *Date: *Monday, April 15, 2019 at 7:20 PM
>      >          > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
>      >          > *Subject: *Re: [OpenSIPS-Users] Erroneous Retransmissions
>      >          >
>      >          > Just wanted to bump this to see if anyone has had a chance to take a
>      >          > look. We are continuing to see this failing our tests intermittently. I
>      >          > have a new example here: https://pastebin.com/kQJSGE56.
>      >          >
>      >          > In this example you can see that the retransmission of the INVITE is
>      >          > occurring not just after the 100 Trying has been received, but also
>      >          > after a 500 final response has already been received and is being
>      >          > processed, but the INVITE is still retransmitted!
>      >          >
>      >          > Any help on this would be greatly appreciated.
>      >          >
>      >          > # opensips -V
>      >          >
>      >          > version: opensips 2.4.5 (x86_64/linux)
>      >          >
>      >          > flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC,
>      >          > F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
>      >          >
>      >          > ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16,
>      >          > MAX_URI_SIZE 1024, BUF_SIZE 65535
>      >          >
>      >          > poll method support: poll, epoll, sigio_rt, select.
>      >          >
>      >          > git revision: d025b4f61
>      >          >
>      >          > main.c compiled on 21:18:18 Apr 12 2019 with gcc 7
>      >          >
>      >          > Ben Newlin
>      >          >
>      >          > *From: *Users <users-bounces at lists.opensips.org> on behalf of Ben Newlin
>      >          > <Ben.Newlin at genesys.com>
>      >          > *Reply-To: *OpenSIPS users mailling list <users at lists.opensips.org>
>      >          > *Date: *Thursday, April 4, 2019 at 3:10 PM
>      >          > *To: *OpenSIPS users mailling list <users at lists.opensips.org>
>      >          > *Subject: *[OpenSIPS-Users] Erroneous Retransmissions
>      >          >
>      >          > Hello,
>      >          >
>      >          > We are seeing an issue which is causing our tests to fail
>      >          > intermittently. It appears that sometimes OpenSIPS will retransmit a
>      >          > relayed INVITE request, even though a 100 Trying response has already
>      >          > been received and processed. This only happens intermittently.
>      >          >
>      >          > I have captured debug logs for the scenario:
>      >          > https://pastebin.com/bHcBJmtv. In the log, you can see the 100 Trying
>      >          > response is received on line 707 and it appears to be matched to the
>      >          > correct transaction on line 729. However then on line 774 you can see
>      >          > the retransmission of the INVITE anyway.
>      >          >
>      >          > I have verified using tcpdump that the INVITE is being retransmitted; it
>      >          > is not just a log error. And our tests are failing due to the unexpected
>      >          > extra 100 Trying response to the retransmission.
>      >          >
>      >          > Can anyone explain why this would occur?
>      >          >
>      >          > Ben Newlin
>      >          >
>      >          >
>      >          > _______________________________________________
>      >          > Devel mailing list
>      >          > Devel at lists.opensips.org
>      >          > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>      >          >
>      >
>      >          --
>      >          Răzvan Crainea
>      >          OpenSIPS Core Developer
>      >             http://www.opensips-solutions.com
>      >          Meet the OpenSIPS team at the next OpenSIPS Summit:
>      >             https://www.opensips.org/events
>      >
>      >          _______________________________________________
>      >          Devel mailing list
>      >          Devel at lists.opensips.org
>      >          http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>      >
>      >
>      >
>      >      _______________________________________________
>      >      Devel mailing list
>      >      Devel at lists.opensips.org
>      >      http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>      >
>      >
>      > _______________________________________________
>      > Devel mailing list
>      > Devel at lists.opensips.org
>      > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>      
>      
>



From dan at ag-projects.com  Mon Jul  8 13:01:23 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 8 Jul 2019 20:01:23 +0300
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1ca050: Refactored
	presence/rls configuration for specifyi...
In-Reply-To: <OpenSIPS/opensips/push/refs/heads/master/0cdaff-1ca050@github.com>
References: <OpenSIPS/opensips/push/refs/heads/master/0cdaff-1ca050@github.com>
Message-ID: <FB742FFF-C5EA-4E9D-B194-D8BB80DF865E@ag-projects.com>


On a side note, there are 3 more modules that use the same server_address parameter to statically define the contact in the configuration: b2b_logic, pua_bla and pua_xmpp

Somebody who is familiar with them / uses them, should take a look and adjust them to do the same thing that this patch did in the presence and rls modules.

On 8 Jul 2019, at 7:44, Dan Pascu wrote:

>  Branch: refs/heads/master
>  Home:   https://github.com/OpenSIPS/opensips
>  Commit: 1ca0501eb2d8c4d9566b56a4baf7ffb6b0687361
>      https://github.com/OpenSIPS/opensips/commit/1ca0501eb2d8c4d9566b56a4baf7ffb6b0687361
>  Author: Dan Pascu <dan at ag-projects.com>
>  Date:   2019-07-08 (Mon, 08 Jul 2019)
> 
>  Changed paths:
>    M modules/presence/doc/presence_admin.xml
>    M modules/presence/presence.c
>    M modules/presence/presence.h
>    M modules/presence/subscribe.c
>    M modules/presence/subscribe.h
>    M modules/rls/doc/rls_admin.xml
>    M modules/rls/notify.c
>    M modules/rls/rls.c
>    M modules/rls/rls.h
>    M modules/rls/subscribe.c
> 
>  Log Message:
>  -----------
>  Refactored presence/rls configuration for specifying the Contact URI
> 
> Removed the server_address modparam and replaced it with contact_user.
> The server_address was used to specify the URI for the Contact header
> and it was optional for presence but mandatory for rls.
> 
> The idea of manually locking the Contact URI to a fixed value that is
> specified in the configuration is non-functional in any setup that
> involves the proxy listening on more than 1 IP/port/transport combo.
> 
> In the new model, the only configurable part of the Contact URI is the
> username part, that can be specified through the contact_user modparam,
> while the rest of the elements of the URI are automatically determined
> from the interface where the request was recevied or sent from.
> 
> 
> 
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


--
Dan






From dan at ag-projects.com  Mon Jul  8 13:03:29 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 8 Jul 2019 20:03:29 +0300
Subject: [OpenSIPS-Devel] TCP connections
In-Reply-To: <e03d4a9e-b0e4-0f23-2af9-0130b3247eed@opensips.org>
References: <CDF3338D-0092-4933-81BC-A580E08DDE8F@ag-projects.com>
 <710AF046-517B-4551-8906-40A8BBF248DF@ag-projects.com>
 <e03d4a9e-b0e4-0f23-2af9-0130b3247eed@opensips.org>
Message-ID: <9EEDAEE6-1FF4-4BAA-9DFE-25E757EE0627@ag-projects.com>


On 8 Jul 2019, at 14:46, Bogdan-Andrei Iancu wrote:

> Hi Dan,
> 
> Was the connection ever removed ?

Not until the server was restarted

> Can you reproduce this sticky connection ?

Not really. I've only seen it once during the time I got those crashes I reported in the other email. After the 2nd crash, I noticed this after a while. I'm not sure for how long it sit there, but it was at least a couple of days before I restarted it.

> 
> Regards,
> 
> Bogdan-Andrei Iancu
> 
> OpenSIPS Founder and Developer
>  https://www.opensips-solutions.com
> OpenSIPS Summit 2019
>  https://www.opensips.org/events/Summit-2019Amsterdam/
> 
> On 07/01/2019 02:27 PM, Dan Pascu wrote:
>> On 1 Jul 2019, at 14:24, Dan Pascu wrote:
>> 
>>> When I list the tcp connections through the MI interface I see the entry below:
>>> 
>>>        {
>>>            "ID": 792633175,
>>>            "Type": "tcp",
>>>            "State": -1,
>>>            "Remote": "xx.xx.xx.xx:5060",
>>>            "Local": "yy.yy.yy.yy:44511",
>>>            "Lifetime": "2019-06-30 08:32:22"
>>>        },
>>> 
>>> The sampling was done on 2019-07-30 13:23:36, so this entry looks like it was expired for more than 24 hours yet still not removed from the list.
>> Sorry I mistyped this, I meant 2019-07-01 (i.e. today)
>> 
>> --
>> Dan
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
> 


--
Dan






From noreply at github.com  Mon Jul  8 13:09:30 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 08 Jul 2019 10:09:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 66969b: clusterer: improve the
 seed node mechanism
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/1ca050-66969b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 66969bfcd214388c53005928505124367a9255d4
      https://github.com/OpenSIPS/opensips/commit/66969bfcd214388c53005928505124367a9255d4
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.c
    M modules/clusterer/clusterer.h
    M modules/clusterer/clusterer_mod.c
    M modules/clusterer/doc/clusterer_admin.xml
    M modules/clusterer/node_info.c
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dialog.c
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ul_cluster.c
    M modules/usrloc/ul_mi.c

  Log Message:
  -----------
  clusterer: improve the seed node mechanism

The "seed" node will now revert to a "synced" state after a configurable
interval instead of directly form startup.

Closes #1591




From noreply at github.com  Mon Jul  8 13:16:30 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 08 Jul 2019 10:16:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b6914e: cachedb_local: fix
 call to request_sync() from clu...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/66969b-b6914e@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b6914e27b37e8cf200cf6bafccdc49aebc4e5f03
      https://github.com/OpenSIPS/opensips/commit/b6914e27b37e8cf200cf6bafccdc49aebc4e5f03
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local.c

  Log Message:
  -----------
  cachedb_local: fix call to request_sync() from clusterer api




From noreply at github.com  Mon Jul  8 13:17:39 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 08 Jul 2019 10:17:39 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d80949: clusterer: improve the
 seed node mechanism
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/5e117c-d80949@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d80949d4676393e5407a17646a3924dd26ec8e49
      https://github.com/OpenSIPS/opensips/commit/d80949d4676393e5407a17646a3924dd26ec8e49
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.c
    M modules/clusterer/clusterer.h
    M modules/clusterer/clusterer_mod.c
    M modules/clusterer/doc/clusterer_admin.xml
    M modules/clusterer/node_info.c
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h

  Log Message:
  -----------
  clusterer: improve the seed node mechanism

The "seed" node will now revert to a "synced" state after a configurable
interval instead of directly form startup.

Closes #1591

(cherry picked from commit 66969bfcd214388c53005928505124367a9255d4)




From dan at ag-projects.com  Mon Jul  8 13:18:06 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 8 Jul 2019 20:18:06 +0300
Subject: [OpenSIPS-Devel] Configuration issue with modparam syntax
In-Reply-To: <e776fce4-abf9-cd15-5cf5-5fd3fb95f4fd@opensips.org>
References: <6BBE80DE-A6FB-43AC-9831-433E60D5D1C9@ag-projects.com>
 <e776fce4-abf9-cd15-5cf5-5fd3fb95f4fd@opensips.org>
Message-ID: <417793FA-C9F1-4759-9639-6561CB094550@ag-projects.com>


On 8 Jul 2019, at 14:36, Bogdan-Andrei Iancu wrote:

> HI Dan,
> 
> Thanks for the report, but could you please open a bug report on the tracker - is is the easiest way for use to track and work with all the reports in a centralized way.

It turns out the dash in the file name is not the problem. I noticed this after I changed the name of my certificates and the new ones had a dash in the name, so I thought that the cause was some problem with the configuration parser. When I removed the dash from the name the error went away so that strengthened the idea that it must be related to the dash.

What I noticed later made things much weirder, to the point that this bug now looks like something out of the twilight zone. To be honest I'm not even sure how to describe it properly.

In short I have the following facts:

1. I have a configuration file of length N that has the error. The error is something about some items in $acc_extra not being defined when used in route later in the script. With this is doesn't matter if the certificate has a dash or not in its name. All it matter is the size of the configuration file being N.
2. If I add or remove 1 character in such a way that it doesn't create a new line in the file, for example by adding one extra character in a comment line, the error disappears. This character added/removed must come before the acc_extra modparam definition for this to work.
3. Now to make things really weird, consider that the configuration file name is length M and in the error case filename length and file content length is N + M = T. If I keep this T constant, I have the problem. So if I add a character in a comment in the configuration as described above and the problem disappears, because now total length is T+1, the problem reappears if I shorten the configuration file name by 1 character so I have total length and equal with the original T : (N+1) + (M-1) = T.

> 
> Thanks,
> 
> Bogdan-Andrei Iancu
> 
> OpenSIPS Founder and Developer
>  https://www.opensips-solutions.com
> OpenSIPS Summit 2019
>  https://www.opensips.org/events/Summit-2019Amsterdam/
> 
> On 06/26/2019 06:24 PM, Dan Pascu wrote:
>> It seems that at least the ca_list modparam in tls_mgm doesn't accept a dash in filenames. If I have a modparam like:
>> 
>> modparam("tls_mgm", "ca_list", "[default]/etc/opensips/tls/ca-list.pem")
>> 
>> then checking the configuration fails with some obscure error that some source_ip element is not defined in acc_extra (way later in some route in the script).
>> 
>> However if I replace the same with a filename without a dash in it like:
>> 
>> modparam("tls_mgm", "ca_list", "[default]/etc/opensips/tls/calist.pem")
>> 
>> Then the error goes away and opensips is able to start. Not sure if this limitation affects other modparams that specify filenames.
>> 
>> --
>> Dan
>> 
>> 
>> 
>> 
>> 
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
> 


--
Dan






From noreply at github.com  Mon Jul  8 13:19:39 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 08 Jul 2019 10:19:39 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8f0cb9: clusterer: improve the
 seed node mechanism
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/6b9dec-8f0cb9@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8f0cb97e5335ac51c3475813afa06be38615912a
      https://github.com/OpenSIPS/opensips/commit/8f0cb97e5335ac51c3475813afa06be38615912a
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.c
    M modules/clusterer/clusterer.h
    M modules/clusterer/clusterer_mod.c
    M modules/clusterer/doc/clusterer_admin.xml
    M modules/clusterer/node_info.c
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h

  Log Message:
  -----------
  clusterer: improve the seed node mechanism

The "seed" node will now revert to a "synced" state after a configurable
interval instead of directly form startup.

Closes #1591

(cherry picked from commit 66969bfcd214388c53005928505124367a9255d4)




From dan at ag-projects.com  Mon Jul  8 13:27:23 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Mon, 8 Jul 2019 20:27:23 +0300
Subject: [OpenSIPS-Devel] Configuration issue with modparam syntax
In-Reply-To: <417793FA-C9F1-4759-9639-6561CB094550@ag-projects.com>
References: <6BBE80DE-A6FB-43AC-9831-433E60D5D1C9@ag-projects.com>
 <e776fce4-abf9-cd15-5cf5-5fd3fb95f4fd@opensips.org>
 <417793FA-C9F1-4759-9639-6561CB094550@ag-projects.com>
Message-ID: <0AD9F991-35EC-420F-82FE-27AB71A960BE@ag-projects.com>


On 8 Jul 2019, at 20:18, Dan Pascu wrote:

> 
> On 8 Jul 2019, at 14:36, Bogdan-Andrei Iancu wrote:
> 
>> HI Dan,
>> 
>> Thanks for the report, but could you please open a bug report on the tracker - is is the easiest way for use to track and work with all the reports in a centralized way.
> 
> It turns out the dash in the file name is not the problem. I noticed this after I changed the name of my certificates and the new ones had a dash in the name, so I thought that the cause was some problem with the configuration parser. When I removed the dash from the name the error went away so that strengthened the idea that it must be related to the dash.
> 
> What I noticed later made things much weirder, to the point that this bug now looks like something out of the twilight zone. To be honest I'm not even sure how to describe it properly.
> 
> In short I have the following facts:
> 
> 1. I have a configuration file of length N that has the error. The error is something about some items in $acc_extra not being defined when used in route later in the script. With this is doesn't matter if the certificate has a dash or not in its name. All it matter is the size of the configuration file being N.
> 2. If I add or remove 1 character in such a way that it doesn't create a new line in the file, for example by adding one extra character in a comment line, the error disappears. This character added/removed must come before the acc_extra modparam definition for this to work.
> 3. Now to make things really weird, consider that the configuration file name is length M and in the error case filename length and file content length is N + M = T. If I keep this T constant, I have the problem. So if I add a character in a comment in the configuration as described above and the problem disappears, because now total length is T+1, the problem reappears if I shorten the configuration file name by 1 character so I have total length and equal with the original T : (N+1) + (M-1) = T.

Just a side note in case it's not clear from this description. The dash in the certificate names is not an issue. I have right now a configuration that has certificates defined with dashes in the name and it works just fine. It's only that now it has a different size than the original size that triggered the error.
Also the size that triggers the error is not just some fixed number.I tried to create the simplest configuration file possible to reproduce the issue, where I loaded and defined the minimal number of things and filled the rest of it with dummy comment lines to get to size N, but I couldn't trigger the issue. The size that gives the error seems to be correlated with the rest of the content of the file.

--
Dan






From razvan at opensips.org  Tue Jul  9 05:52:51 2019
From: razvan at opensips.org (=?UTF-8?Q?R=c4=83zvan_Crainea?=)
Date: Tue, 9 Jul 2019 12:52:51 +0300
Subject: [OpenSIPS-Devel] Real-time Call Recording using OpenSIPS @ CommCon
	2019
Message-ID: <31175153-2b00-372a-8905-e862177927a9@opensips.org>

Hello everybody!

Tomorrow, 10th of July 2019, at 11:40[1], I will have a presentation 
about Real-time Call Recording using OpenSIPS[0] at the CommCon UK 2019 
conference. Make sure you do not miss it!
Live videos are available on YouTube on CommCon's official channel[2].

[0] https://2019.commcon.xyz/sessions.html#0m8ea7td
[1] 
https://www.timeanddate.com/worldclock/fixedtime.html?msg=Real-Time+Call+Recording+using+OpenSIPS+%40+CommCon+2019&iso=20190710T1140&p1=136&am=40
[2] https://www.youtube.com/channel/UCe_eAP4ToqFLSxzvkTlNzUQ

Cheers!
-- 
Răzvan Crainea
OpenSIPS Core Developer
http://www.opensips-solutions.com


From noreply at github.com  Tue Jul  9 07:57:00 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 09 Jul 2019 04:57:00 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f418c2: cachedb_local: Fix
 missing array terminator
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/b6914e-f418c2@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f418c2a15483de6908a273817b7b3cae33e71301
      https://github.com/OpenSIPS/opensips/commit/f418c2a15483de6908a273817b7b3cae33e71301
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local.c

  Log Message:
  -----------
  cachedb_local: Fix missing array terminator

Fixes #1757




From noreply at github.com  Tue Jul  9 07:57:26 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 09 Jul 2019 04:57:26 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] de4113: cachedb_local: Fix
 missing array terminator
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/d80949-de4113@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: de41131c5b36454d2d71f434b2726920b66df919
      https://github.com/OpenSIPS/opensips/commit/de41131c5b36454d2d71f434b2726920b66df919
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local.c

  Log Message:
  -----------
  cachedb_local: Fix missing array terminator

Fixes #1757

(cherry picked from commit f418c2a15483de6908a273817b7b3cae33e71301)




From noreply at github.com  Tue Jul  9 09:18:03 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Tue, 09 Jul 2019 06:18:03 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 44f52d: hp_malloc: fix
	coverity warnings
Message-ID: <OpenSIPS/opensips/push/refs/heads/coverity_scan/8313f6-44f52d@github.com>

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 44f52da465aff8ad0061b5e066e8ede75c57cc34
      https://github.com/OpenSIPS/opensips/commit/44f52da465aff8ad0061b5e066e8ede75c57cc34
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M mem/hp_malloc_stats.c
    M mem/hp_malloc_stats.h

  Log Message:
  -----------
  hp_malloc: fix coverity warnings

Fixes CID #199900, #199896, #199913




From noreply at github.com  Tue Jul  9 11:58:59 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Tue, 09 Jul 2019 08:58:59 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d15c80: tls_mgm: improve docs
 for the verify_cert and requ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/f418c2-d15c80@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d15c80e49c71a62a3df995cd2d5a747b7c75fc02
      https://github.com/OpenSIPS/opensips/commit/d15c80e49c71a62a3df995cd2d5a747b7c75fc02
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/tls_mgm/doc/tls_mgm_admin.xml

  Log Message:
  -----------
  tls_mgm: improve docs for the verify_cert and require_cert modparams




From noreply at github.com  Tue Jul  9 11:59:59 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Tue, 09 Jul 2019 08:59:59 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 93daea: tls_mgm: improve docs
 for the verify_cert and requ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/de4113-93daea@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 93daea580fcc4bfbecf959e07fcc2cbd89ebd385
      https://github.com/OpenSIPS/opensips/commit/93daea580fcc4bfbecf959e07fcc2cbd89ebd385
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/tls_mgm/doc/tls_mgm_admin.xml

  Log Message:
  -----------
  tls_mgm: improve docs for the verify_cert and require_cert modparams

(cherry picked from commit d15c80e49c71a62a3df995cd2d5a747b7c75fc02)




From noreply at github.com  Tue Jul  9 12:03:47 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Tue, 09 Jul 2019 09:03:47 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b976e2: tls_mgm: improve docs
 for the verify_cert and requ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/8f0cb9-b976e2@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b976e227975603a243dc5db5e44b8c0bdeac1b67
      https://github.com/OpenSIPS/opensips/commit/b976e227975603a243dc5db5e44b8c0bdeac1b67
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/tls_mgm/doc/tls_mgm_admin.xml

  Log Message:
  -----------
  tls_mgm: improve docs for the verify_cert and require_cert modparams

(cherry picked from commit d15c80e49c71a62a3df995cd2d5a747b7c75fc02)




From vladp at opensips.org  Tue Jul  9 12:20:33 2019
From: vladp at opensips.org (Vlad Patrascu)
Date: Tue, 9 Jul 2019 19:20:33 +0300
Subject: [OpenSIPS-Devel] TLS parameter meaning
In-Reply-To: <46CA2AD0-588D-43E7-8B16-15414224267E@ag-projects.com>
References: <46CA2AD0-588D-43E7-8B16-15414224267E@ag-projects.com>
Message-ID: <aa8cfcc4-47dc-bc95-4150-26d21c83f695@opensips.org>

Hi Dan,

The docs were outdated for these parameters so I've updated the 
explanation. You can now check out the proper one.

Regards,

Vlad Patrascu
OpenSIPS Developer
http://www.opensips-solutions.com

On 06/27/2019 03:10 PM, Dan Pascu wrote:
> The documentation on tls_mgm says this about verify_cert and require_cert:
>
> ---------------------
>
> 1.8.10. verify_cert ([domain](string) and require_cert ([domain](string)
>
> Technically, verify_cert activates SSL_VERIFY_PEER in the ssl_context. 'require_cert' does the same with SSL_VERIFY_FAIL_IF_NO_PEER_CERT, which is only possible if SSL_VERIFY_PEER is also turned on. Since version 2.1, these parameters act have been reduced to only one. The domain part represents the name of the TLS domain.
>
> These two parameters are used for incoming TLS connections, where OpenSIPS acts as server.
>
> ---------------------
>
> So what is the meaning of these options for a client domain, given that the documentation explicitly mentions that they are used for incoming connections?
>
> --
> Dan
>
>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel



From noreply at github.com  Tue Jul  9 12:26:49 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Tue, 09 Jul 2019 09:26:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ccf3c2: clusterer: fix doc
 example for cluster_send_rpl()
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/d15c80-ccf3c2@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ccf3c20da7ae4e8874f6b700fcb2185e522417ae
      https://github.com/OpenSIPS/opensips/commit/ccf3c20da7ae4e8874f6b700fcb2185e522417ae
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/clusterer/doc/clusterer_admin.xml

  Log Message:
  -----------
  clusterer: fix doc example for cluster_send_rpl()




From noreply at github.com  Tue Jul  9 12:29:49 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Tue, 09 Jul 2019 09:29:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8802e4: clusterer: fix doc
 example for cluster_send_rpl()
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/93daea-8802e4@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8802e41e98ee163953049c4a232dc3cc4948a54e
      https://github.com/OpenSIPS/opensips/commit/8802e41e98ee163953049c4a232dc3cc4948a54e
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-09 (Tue, 09 Jul 2019)

  Changed paths:
    M modules/clusterer/doc/clusterer_admin.xml

  Log Message:
  -----------
  clusterer: fix doc example for cluster_send_rpl()

(cherry picked from commit ccf3c20da7ae4e8874f6b700fcb2185e522417ae)




From Ben.Newlin at genesys.com  Tue Jul  9 17:20:03 2019
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Tue, 9 Jul 2019 21:20:03 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <94A9B09C-B8F6-4493-BD32-87D0ED3164B6@genesys.com>
References: <9A42C73B-825E-4286-9ED7-522C1800107E@genesys.com>
 <70CCAEBE-9751-4AF0-9AC9-BDBD19DDFEB4@genesys.com>
 <66379679-4b75-15fa-5fb4-98f447c0d3f1@opensips.org>
 <FAA0A90E-3BB6-41CF-ACD4-DF2634A4AE23@genesys.com>
 <15a49676-4516-bada-7781-ca6de90145fe@opensips.org>
 <22F024D2-E08B-4C18-BC12-323E33C104DD@genesys.com>
 <59ea1b3d-e640-3ca2-120b-e3c65ef6607b@opensips.org>
 <94A9B09C-B8F6-4493-BD32-87D0ED3164B6@genesys.com>
Message-ID: <34B6DBFA-04FF-4EC9-8F14-1BFB02B05F38@genesys.com>

Any updates on this? Would you like me to open a ticket or does one already exist for the issue?

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org>
Date: Wednesday, June 26, 2019 at 11:58 AM
To: Bogdan-Andrei Iancu <bogdan at opensips.org>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Bogdan,

I am glad the cause is known at least. :)

Is there a ticket I can follow for more information and to be notified of resolution?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Wednesday, June 26, 2019 at 7:37 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Thank you Ben,

This backtrace confirms the initial suspicion - I'm trying to find out a way to get it fixed in a more generic way; what you experience is just one face of the problem (with many faces :P) and there are other related reports.

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/26/2019 02:34 AM, Ben Newlin wrote:
Bogdan,

I have now been able to reproduce this crash reliably, I believe. Please see the backtrace [1]. Is there some other information you would like me to collect when this occurs?

[1] https://pastebin.com/n0Ph8XH5

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, June 7, 2019 at 9:15 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

How often/easy is to reproduce this crash (if possible) ? Brainstorming with Razvan, we suspect a race (on the msg save in shmem in transaction) between the process doing the cleanup after the async resume and the process running the failure route (due th 503).

But this is just a supposition, eventually you can validate it or not by removing the async ??

And on the double ACK - I'm not 100% it is a actually a double one, as the second has a smaller MF value (69, versus the 70 on the first ACK).

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/07/2019 03:52 PM, Ben Newlin wrote:
Bogdan,

Sorry, I should have thought to actually look at the trace and examine this call.

1) Yes
2) The Called Party is 10.32.20.60, which is another OpenSIPS instance. The crashed instance received the "503 Service Unavailable" approximately 8-10 ms after sending the INVITE.

There is a SIP trace of the exchange here: https://pastebin.com/6bttsSVD.

One oddity I saw is that the crashed process appears to send (or at least siptrace) the ACK twice.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, June 6, 2019 at 11:42 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for "another" report :).

Questions:
1) do you do any async for the INVITE in this crash ?
2) if it is an YES to (1), is the caller party generating the "503 Service Unavailable" (which triggers the crash) - 10.32.20.60 ?? - a really close (from net delay perspective) and fast to answer party ?

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/05/2019 10:02 PM, Ben Newlin wrote:
We have had another crash today.

Backtrace is here: https://pastebin.com/q4RQC7kS

I found this in the log at the time of the crash:

Jun  5 17:54:10 [4978] CRITICAL:core:sig_usr: segfault in process pid: 4978, id: 8


Please let me know if any further information can be useful.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 6:31 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

I found this in the log at the time of the crash:

kernel: opensips[5003]: segfault at 30 ip 00007fbd4c8f59d0 sp 00007ffcaa850c80 error 6 in tm.so[7fbd4c887000+8e000]

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 5:44 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: [OpenSIPS-Devel] OpenSIPS Crash

Hello,

We had a crash today of our OpenSIPS instance.

Backtrace is here: https://pastebin.com/QbRJimwx

# opensips -V
version: opensips 2.4.5 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: d025b4f61
main.c compiled on 20:58:31 May  9 2019 with gcc 7

Ben Newlin







_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel












-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190709/e5dd84f9/attachment-0001.html>

From noreply at github.com  Wed Jul 10 08:03:30 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Wed, 10 Jul 2019 05:03:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 861b49: Fix wrong internal
 mapping for "add_path_received"
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/8802e4-861b49@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 861b4911298b103a6f879922b456a18eeba8fbc7
      https://github.com/OpenSIPS/opensips/commit/861b4911298b103a6f879922b456a18eeba8fbc7
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M modules/path/path_mod.c

  Log Message:
  -----------
  Fix wrong internal mapping for "add_path_received"

The mix probably happened durring the upgrade of the module interface.
Fixes #1739




From noreply at github.com  Wed Jul 10 08:03:52 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Wed, 10 Jul 2019 05:03:52 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ef30e4: Fix wrong internal
 mapping for "add_path_received"
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ccf3c2-ef30e4@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ef30e4f44a0e02b320b7241ddd8b24f42ba1d845
      https://github.com/OpenSIPS/opensips/commit/ef30e4f44a0e02b320b7241ddd8b24f42ba1d845
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M modules/path/path_mod.c

  Log Message:
  -----------
  Fix wrong internal mapping for "add_path_received"

The mix probably happened durring the upgrade of the module interface.
Fixes #1739

(cherry picked from commit 861b4911298b103a6f879922b456a18eeba8fbc7)




From noreply at github.com  Wed Jul 10 11:15:11 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Wed, 10 Jul 2019 08:15:11 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 55233a: Fixed un-init dst_leg
	before get_dlg()
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/b976e2-55233a@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 55233a9f4037b465b81c8ced5f356f090dbcd873
      https://github.com/OpenSIPS/opensips/commit/55233a9f4037b465b81c8ced5f356f090dbcd873
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-10 (Wed, 10 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  Fixed un-init dst_leg before get_dlg()

In order to return a valid value in dst_leg after get_dlg(), the dst_leg must be initialized to -1.




From dan at ag-projects.com  Wed Jul 10 11:46:07 2019
From: dan at ag-projects.com (Dan Pascu)
Date: Wed, 10 Jul 2019 18:46:07 +0300
Subject: [OpenSIPS-Devel] Pseudo variables in failure route
Message-ID: <DEA2CF92-BEFF-4CFE-B23B-46BFDDC174CD@ag-projects.com>


Some pseudo variables do not seem to be available in the failure route, while others are.

I have a log line like this in the failure route:

x_log("L_INFO", "Call failed with $rs $rr ($ci)\n");

which always produces:

Call failed with <null> <null> (some_callid)

--
Dan






From liviu at opensips.org  Wed Jul 10 11:50:24 2019
From: liviu at opensips.org (Liviu Chircu)
Date: Wed, 10 Jul 2019 18:50:24 +0300
Subject: [OpenSIPS-Devel] Pseudo variables in failure route
In-Reply-To: <DEA2CF92-BEFF-4CFE-B23B-46BFDDC174CD@ag-projects.com>
References: <DEA2CF92-BEFF-4CFE-B23B-46BFDDC174CD@ag-projects.com>
Message-ID: <b18fdab3-f1ac-cbed-c709-34c9349d4928@opensips.org>

That's because the purpose of failure_route [1] is to give you the SIP
request which failed, so you can re-decide on how to route it (forward
the error, re-route, failover, etc.).

If you want to access the values behind those vars, you must access them
using the reply's context, with the following constructs:

xlog("L_INFO", "Call failed with $(<reply>rs) $(<reply>rr) ($ci)\n");

Cheers,

[1]: https://www.opensips.org/Documentation/Script-Routes-3-0#toc3

Liviu Chircu
OpenSIPS Developer
http://www.opensips-solutions.com

On 10.07.2019 18:46, Dan Pascu wrote:
> Some pseudo variables do not seem to be available in the failure route, while others are.
>
> I have a log line like this in the failure route:
>
> x_log("L_INFO", "Call failed with $rs $rr ($ci)\n");
>
> which always produces:
>
> Call failed with <null> <null> (some_callid)
>
> --
> Dan
>
>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


From noreply at github.com  Thu Jul 11 04:43:34 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 11 Jul 2019 01:43:34 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2c7449: Fix leak due bad free
 of temporary parsed RR hdr
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/55233a-2c7449@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2c7449091ef1920ae4d9030061c0992c27dfdb2b
      https://github.com/OpenSIPS/opensips/commit/2c7449091ef1920ae4d9030061c0992c27dfdb2b
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M parser/parse_rr.c

  Log Message:
  -----------
  Fix leak due bad free of temporary parsed RR hdr

Free the list (of RR body) starting from the original RR body, not from the iterator value (which will be NULL all the time)




From noreply at github.com  Thu Jul 11 04:44:18 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 11 Jul 2019 01:44:18 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 04808b: Fix leak due bad free
 of temporary parsed RR hdr
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/861b49-04808b@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 04808b2085a3a80c5d91874498250f38a6507d62
      https://github.com/OpenSIPS/opensips/commit/04808b2085a3a80c5d91874498250f38a6507d62
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M parser/parse_rr.c

  Log Message:
  -----------
  Fix leak due bad free of temporary parsed RR hdr

Free the list (of RR body) starting from the original RR body, not from the iterator value (which will be NULL all the time)

(cherry picked from commit 2c7449091ef1920ae4d9030061c0992c27dfdb2b)




From noreply at github.com  Thu Jul 11 04:45:43 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 11 Jul 2019 01:45:43 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 884523: Fix leak due bad free
 of temporary parsed RR hdr
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ef30e4-884523@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 88452327e470d77204825a50e18765f0cdae57de
      https://github.com/OpenSIPS/opensips/commit/88452327e470d77204825a50e18765f0cdae57de
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M parser/parse_rr.c

  Log Message:
  -----------
  Fix leak due bad free of temporary parsed RR hdr

Free the list (of RR body) starting from the original RR body, not from the iterator value (which will be NULL all the time)

(cherry picked from commit 2c7449091ef1920ae4d9030061c0992c27dfdb2b)




From noreply at github.com  Thu Jul 11 10:16:20 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 11 Jul 2019 07:16:20 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 04a56f: rest_client: Make
 async(rest_put()) do a PUT, not ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/884523-04a56f@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 04a56fbd7d51b7aee5ff8a838b1e2a83094c1c92
      https://github.com/OpenSIPS/opensips/commit/04a56fbd7d51b7aee5ff8a838b1e2a83094c1c92
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Make async(rest_put()) do a PUT, not a POST




From noreply at github.com  Thu Jul 11 10:16:31 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 11 Jul 2019 07:16:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 99dd4f: rest_client: Make
 async(rest_put()) do a PUT, not ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/04808b-99dd4f@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 99dd4faeee7c4cd8f277f2ac208c344cbca8aeef
      https://github.com/OpenSIPS/opensips/commit/99dd4faeee7c4cd8f277f2ac208c344cbca8aeef
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Make async(rest_put()) do a PUT, not a POST

(cherry picked from commit 04a56fbd7d51b7aee5ff8a838b1e2a83094c1c92)




From noreply at github.com  Thu Jul 11 10:16:44 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 11 Jul 2019 07:16:44 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a44281: rest_client: Make
 async(rest_put()) do a PUT, not ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/2c7449-a44281@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a442811d18b2b8d342012c410a1cc6c6c73284cd
      https://github.com/OpenSIPS/opensips/commit/a442811d18b2b8d342012c410a1cc6c6c73284cd
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Make async(rest_put()) do a PUT, not a POST

(cherry picked from commit 04a56fbd7d51b7aee5ff8a838b1e2a83094c1c92)




From noreply at github.com  Thu Jul 11 11:03:11 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 11 Jul 2019 08:03:11 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3b2586: rest_client: Let
 libcurl use the system malloc fu...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/04a56f-3b2586@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3b2586d64828e89525ae050897c8bd62a9c9ce92
      https://github.com/OpenSIPS/opensips/commit/3b2586d64828e89525ae050897c8bd62a9c9ce92
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/rest_client/rest_client.c

  Log Message:
  -----------
  rest_client:  Let libcurl use the system malloc functions

The fact that libcurl spawns a thread in order to perform each transfer
is well known.  Also known was the fact that by instructing libcurl to
use the pkg_*alloc() functions, an OpenSIPS worker must synchronize with
the libcurl thread before they can both manipulate the PKG pool.  Commit
900f6c996c697b was an attempt to solve this, however the fix DOES NOT
hold, as it was implemented in that commit (the curl thread is aware of
the thread lock while the original process ignores it...).

The only way we can make libcurl use the opensips pkg mem allocation
functions is by changing pkg_malloc() itself to also grab a thread
lock.  And this is already too much, as it would unnecessarily slow down
the pkg allocator, while the benefits are minimal anyway: what do we
stand to gain if libcurl uses our mem pool?  Close to nothing.

We just let libcurl use the system memory manager (along with as much
memory as it wants) and we're done with this issue for good.

Fixes #1546




From noreply at github.com  Thu Jul 11 11:04:54 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 11 Jul 2019 08:04:54 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 26d18c: rest_client: Let
 libcurl use the system malloc fu...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/99dd4f-26d18c@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 26d18c5ce39883fd217153cfd1ce252b572763b4
      https://github.com/OpenSIPS/opensips/commit/26d18c5ce39883fd217153cfd1ce252b572763b4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/rest_client/rest_client.c

  Log Message:
  -----------
  rest_client:  Let libcurl use the system malloc functions

The fact that libcurl spawns a thread in order to perform each transfer
is well known.  Also known was the fact that by instructing libcurl to
use the pkg_*alloc() functions, an OpenSIPS worker must synchronize with
the libcurl thread before they can both manipulate the PKG pool.  Commit
900f6c996c697b was an attempt to solve this, however the fix DOES NOT
hold, as it was implemented in that commit (the curl thread is aware of
the thread lock while the original process ignores it...).

The only way we can make libcurl use the opensips pkg mem allocation
functions is by changing pkg_malloc() itself to also grab a thread
lock.  And this is already too much, as it would unnecessarily slow down
the pkg allocator, while the benefits are minimal anyway: what do we
stand to gain if libcurl uses our mem pool?  Close to nothing.

We just let libcurl use the system memory manager (along with as much
memory as it wants) and we're done with this issue for good.

Fixes #1546

(cherry picked from commit 3b2586d64828e89525ae050897c8bd62a9c9ce92)




From noreply at github.com  Thu Jul 11 11:05:20 2019
From: noreply at github.com (Liviu Chircu)
Date: Thu, 11 Jul 2019 08:05:20 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 766253: rest_client: Let
 libcurl use the system malloc fu...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/a44281-766253@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 76625354cfd31fddb765b8eff2c73ad7eb62586a
      https://github.com/OpenSIPS/opensips/commit/76625354cfd31fddb765b8eff2c73ad7eb62586a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/rest_client/rest_client.c

  Log Message:
  -----------
  rest_client:  Let libcurl use the system malloc functions

The fact that libcurl spawns a thread in order to perform each transfer
is well known.  Also known was the fact that by instructing libcurl to
use the pkg_*alloc() functions, an OpenSIPS worker must synchronize with
the libcurl thread before they can both manipulate the PKG pool.  Commit
900f6c996c697b was an attempt to solve this, however the fix DOES NOT
hold, as it was implemented in that commit (the curl thread is aware of
the thread lock while the original process ignores it...).

The only way we can make libcurl use the opensips pkg mem allocation
functions is by changing pkg_malloc() itself to also grab a thread
lock.  And this is already too much, as it would unnecessarily slow down
the pkg allocator, while the benefits are minimal anyway: what do we
stand to gain if libcurl uses our mem pool?  Close to nothing.

We just let libcurl use the system memory manager (along with as much
memory as it wants) and we're done with this issue for good.

Fixes #1546

(cherry picked from commit 3b2586d64828e89525ae050897c8bd62a9c9ce92)




From noreply at github.com  Thu Jul 11 12:37:11 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 11 Jul 2019 09:37:11 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c203dd: Fix wrong test
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/26d18c-c203dd@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c203ddec1e9ffcea5e141fbd03709921ded14c37
      https://github.com/OpenSIPS/opensips/commit/c203ddec1e9ffcea5e141fbd03709921ded14c37
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  Fix wrong test




From noreply at github.com  Thu Jul 11 12:37:29 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Thu, 11 Jul 2019 09:37:29 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9ca66c: Fix wrong test
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/3b2586-9ca66c@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9ca66c8dfa2f5befb117b9c236529d78f53a409f
      https://github.com/OpenSIPS/opensips/commit/9ca66c8dfa2f5befb117b9c236529d78f53a409f
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  Fix wrong test

(cherry picked from commit c203ddec1e9ffcea5e141fbd03709921ded14c37)




From noreply at github.com  Thu Jul 11 12:59:35 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 11 Jul 2019 09:59:35 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] dea97b: sql_cacher: fix
 several possible deadlocks in case...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/9ca66c-f6232b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: dea97be92d71514da6705e53a5265564902fc21f
      https://github.com/OpenSIPS/opensips/commit/dea97be92d71514da6705e53a5265564902fc21f
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: fix several possible deadlocks in case of errors

Reported by Ben Newlin in #1760


  Commit: aa38fb1fba6b51c6e27e4d8f87ae10c032700282
      https://github.com/OpenSIPS/opensips/commit/aa38fb1fba6b51c6e27e4d8f87ae10c032700282
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: fix a memory leak in case of a failed SQL query

Reported by Ben Newlin in #1760


  Commit: f6232b068e0e4d423747299be2f69ee011004733
      https://github.com/OpenSIPS/opensips/commit/f6232b068e0e4d423747299be2f69ee011004733
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: properly increment relod version on timer reloads

Reported by Ben Newlin in #1760


Compare: https://github.com/OpenSIPS/opensips/compare/9ca66c8dfa2f...f6232b068e0e


From noreply at github.com  Thu Jul 11 12:59:49 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 11 Jul 2019 09:59:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ef29dc: sql_cacher: fix
 several possible deadlocks in case...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/c203dd-df7a4e@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ef29dcedc7064e4f46695e18853431ac00a9430f
      https://github.com/OpenSIPS/opensips/commit/ef29dcedc7064e4f46695e18853431ac00a9430f
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: fix several possible deadlocks in case of errors

Reported by Ben Newlin in #1760

(cherry picked from commit dea97be92d71514da6705e53a5265564902fc21f)


  Commit: fddfe9f25c22839eaf3edef354f96d8d53d57528
      https://github.com/OpenSIPS/opensips/commit/fddfe9f25c22839eaf3edef354f96d8d53d57528
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: fix a memory leak in case of a failed SQL query

Reported by Ben Newlin in #1760

(cherry picked from commit aa38fb1fba6b51c6e27e4d8f87ae10c032700282)


  Commit: df7a4e77c6aa61c7b1626515f942e85aa5816321
      https://github.com/OpenSIPS/opensips/commit/df7a4e77c6aa61c7b1626515f942e85aa5816321
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: properly increment relod version on timer reloads

Reported by Ben Newlin in #1760

(cherry picked from commit f6232b068e0e4d423747299be2f69ee011004733)


Compare: https://github.com/OpenSIPS/opensips/compare/c203ddec1e9f...df7a4e77c6aa


From noreply at github.com  Thu Jul 11 13:00:14 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 11 Jul 2019 10:00:14 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3892fa: sql_cacher: fix
 several possible deadlocks in case...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/766253-da31a1@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3892fa74a789b464928bd9992e693765f0d02f53
      https://github.com/OpenSIPS/opensips/commit/3892fa74a789b464928bd9992e693765f0d02f53
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: fix several possible deadlocks in case of errors

Reported by Ben Newlin in #1760

(cherry picked from commit dea97be92d71514da6705e53a5265564902fc21f)


  Commit: 0ffa4f3297f89683ea400d6cfc09e583150f34a4
      https://github.com/OpenSIPS/opensips/commit/0ffa4f3297f89683ea400d6cfc09e583150f34a4
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: fix a memory leak in case of a failed SQL query

Reported by Ben Newlin in #1760

(cherry picked from commit aa38fb1fba6b51c6e27e4d8f87ae10c032700282)


  Commit: da31a162fc59ee94e232ad9e2e492bd91eacb91c
      https://github.com/OpenSIPS/opensips/commit/da31a162fc59ee94e232ad9e2e492bd91eacb91c
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-11 (Thu, 11 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: properly increment relod version on timer reloads

Reported by Ben Newlin in #1760

(cherry picked from commit f6232b068e0e4d423747299be2f69ee011004733)


Compare: https://github.com/OpenSIPS/opensips/compare/76625354cfd3...da31a162fc59


From noreply at github.com  Fri Jul 12 05:43:49 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 12 Jul 2019 02:43:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6638b0: dialog: run loaded
 callback for dialogs loaded fro...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/f6232b-6638b0@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6638b06f3ffa1fbc8d19f0532879e2c6c77a76d0
      https://github.com/OpenSIPS/opensips/commit/6638b06f3ffa1fbc8d19f0532879e2c6c77a76d0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: run loaded callback for dialogs loaded from db

Fixes a bug introduced in commit 8c8f27f that was relying on the fact
that dialogs were loaded from db *before* registering the loaded
callback, due to the dependencies mechanism. Thus the loaded callback
was ran on the spot, when the it was registered.

However, this is not entirely correct, since there are modules (such as
acc module) that do not have dialog dependencies, but still register
LOADED dialogs - in these cases, if dialog was loaded (in script) after
the module itself, the callback was never run. This behavior was
amplified by commit 3ddae43, which was basically never loading the
dialogs before registering the callback, thus the loaded callbacks were
never ran.

The purpose of this commit is to fix this issue, reported in #1754

Thanks go to Liviu Chircu for reporting the issue and providing the fix




From noreply at github.com  Fri Jul 12 05:44:09 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 12 Jul 2019 02:44:09 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 72cfdd: dialog: run loaded
 callback for dialogs loaded fro...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/df7a4e-72cfdd@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 72cfdd9082273c450b6cdbd52970f0a975962dd7
      https://github.com/OpenSIPS/opensips/commit/72cfdd9082273c450b6cdbd52970f0a975962dd7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: run loaded callback for dialogs loaded from db

Fixes a bug introduced in commit 8c8f27f that was relying on the fact
that dialogs were loaded from db *before* registering the loaded
callback, due to the dependencies mechanism. Thus the loaded callback
was ran on the spot, when the it was registered.

However, this is not entirely correct, since there are modules (such as
acc module) that do not have dialog dependencies, but still register
LOADED dialogs - in these cases, if dialog was loaded (in script) after
the module itself, the callback was never run. This behavior was
amplified by commit 3ddae43, which was basically never loading the
dialogs before registering the callback, thus the loaded callbacks were
never ran.

The purpose of this commit is to fix this issue, reported in #1754

Thanks go to Liviu Chircu for reporting the issue and providing the fix

(cherry picked from commit 6638b06f3ffa1fbc8d19f0532879e2c6c77a76d0)




From noreply at github.com  Fri Jul 12 05:44:22 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Fri, 12 Jul 2019 02:44:22 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8e8033: dialog: run loaded
 callback for dialogs loaded fro...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/da31a1-8e8033@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8e80335f324b16680e60a9cb04ff012ea88ca615
      https://github.com/OpenSIPS/opensips/commit/8e80335f324b16680e60a9cb04ff012ea88ca615
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: run loaded callback for dialogs loaded from db

Fixes a bug introduced in commit 8c8f27f that was relying on the fact
that dialogs were loaded from db *before* registering the loaded
callback, due to the dependencies mechanism. Thus the loaded callback
was ran on the spot, when the it was registered.

However, this is not entirely correct, since there are modules (such as
acc module) that do not have dialog dependencies, but still register
LOADED dialogs - in these cases, if dialog was loaded (in script) after
the module itself, the callback was never run. This behavior was
amplified by commit 3ddae43, which was basically never loading the
dialogs before registering the callback, thus the loaded callbacks were
never ran.

The purpose of this commit is to fix this issue, reported in #1754

Thanks go to Liviu Chircu for reporting the issue and providing the fix

(cherry picked from commit 6638b06f3ffa1fbc8d19f0532879e2c6c77a76d0)




From noreply at github.com  Fri Jul 12 10:24:13 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Fri, 12 Jul 2019 07:24:13 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] dc6ac9: [rtpproxy] Fixed wrong
 test when building MI output
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/6638b0-dc6ac9@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: dc6ac9e47b5825718204b08de8b90a60384598d2
      https://github.com/OpenSIPS/opensips/commit/dc6ac9e47b5825718204b08de8b90a60384598d2
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/rtpproxy/rtpproxy.c

  Log Message:
  -----------
  [rtpproxy] Fixed wrong test when building MI output




From noreply at github.com  Fri Jul 12 10:27:04 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Fri, 12 Jul 2019 07:27:04 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 71808a: [rtpproxy] Fixed wrong
 test when building MI output
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/72cfdd-71808a@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 71808a50ce01f1014f39090550e605f68713b884
      https://github.com/OpenSIPS/opensips/commit/71808a50ce01f1014f39090550e605f68713b884
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/rtpproxy/rtpproxy.c

  Log Message:
  -----------
  [rtpproxy] Fixed wrong test when building MI output

(cherry picked from commit dc6ac9e47b5825718204b08de8b90a60384598d2)




From noreply at github.com  Fri Jul 12 10:45:04 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Fri, 12 Jul 2019 07:45:04 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 303ff5: [rtpengine] Fixed
 wrong test when building MI output
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/dc6ac9-303ff5@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 303ff59c91f26affa070ccadc503c52fca527368
      https://github.com/OpenSIPS/opensips/commit/303ff59c91f26affa070ccadc503c52fca527368
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  [rtpengine] Fixed wrong test when building MI output




From noreply at github.com  Fri Jul 12 11:04:42 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Fri, 12 Jul 2019 08:04:42 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7b03d6: [rtpengine] Fixed
 wrong test when building MI output
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/71808a-7b03d6@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7b03d615d7a75af9ae9f94c0854c4a3dc5103471
      https://github.com/OpenSIPS/opensips/commit/7b03d615d7a75af9ae9f94c0854c4a3dc5103471
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  [rtpengine] Fixed wrong test when building MI output

(cherry picked from commit 303ff59c91f26affa070ccadc503c52fca527368)




From noreply at github.com  Fri Jul 12 11:13:14 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Fri, 12 Jul 2019 08:13:14 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 72f06a: [load-balancer] Link
 Resource under each Destinati...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/303ff5-72f06a@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 72f06a574427cd5627cf8b16780f4d622d7e0c3d
      https://github.com/OpenSIPS/opensips/commit/72f06a574427cd5627cf8b16780f4d622d7e0c3d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/load_balancer/load_balancer.c

  Log Message:
  -----------
  [load-balancer] Link Resource under each Destination node

Fixes how the output of the "lb_list" MI command is structured.




From noreply at github.com  Fri Jul 12 11:18:32 2019
From: noreply at github.com (Bogdan Andrei IANCU)
Date: Fri, 12 Jul 2019 08:18:32 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 319472: [load-balancer] Link
 Resource under each Destinati...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/7b03d6-319472@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3194727fadf466e394a0cbfd6662adf891779cad
      https://github.com/OpenSIPS/opensips/commit/3194727fadf466e394a0cbfd6662adf891779cad
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/load_balancer/load_balancer.c

  Log Message:
  -----------
  [load-balancer] Link Resource under each Destination node

Fixes how the output of the "lb_list" MI command is structured.

(cherry picked from commit 72f06a574427cd5627cf8b16780f4d622d7e0c3d)




From noreply at github.com  Fri Jul 12 12:26:41 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 12 Jul 2019 09:26:41 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ecea9b: 'include_file'
 statement: Re-introduce relative fi...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/72f06a-ecea9b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ecea9b07445d6125607cd086efc34b1dc9938669
      https://github.com/OpenSIPS/opensips/commit/ecea9b07445d6125607cd086efc34b1dc9938669
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  'include_file' statement: Re-introduce relative file paths

During the preprocessor migration, it seems the support for relative
file paths was lost.  This commit re-introduces all the lost features:

    * allow relative-path imports, e.g. include_file "cgrates.cfg".
      These file paths are considered to be relative to the .cfg file
      that is importing them

    * prioritize any relative-path imports found in the startup
      directory
      (Note: this is different from the "-w" working directory!)

    * detect infinite "include_file" loops

Many thanks to Jonathan Hulme for discovering and reporting this issue!




From noreply at github.com  Fri Jul 12 12:27:25 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 12 Jul 2019 09:27:25 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] eceef3: 'include_file'
 statement: Re-introduce relative fi...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/319472-eceef3@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: eceef3ec2da4f6571e4ace2134e101a3f8b9f706
      https://github.com/OpenSIPS/opensips/commit/eceef3ec2da4f6571e4ace2134e101a3f8b9f706
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  'include_file' statement: Re-introduce relative file paths

During the preprocessor migration, it seems the support for relative
file paths was lost.  This commit re-introduces all the lost features:

    * allow relative-path imports, e.g. include_file "cgrates.cfg".
      These file paths are considered to be relative to the .cfg file
      that is importing them

    * prioritize any relative-path imports found in the startup
      directory
      (Note: this is different from the "-w" working directory!)

    * detect infinite "include_file" loops

Many thanks to Jonathan Hulme for discovering and reporting this issue!

(cherry picked from commit ecea9b07445d6125607cd086efc34b1dc9938669)




From noreply at github.com  Fri Jul 12 12:40:34 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Fri, 12 Jul 2019 09:40:34 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 642271: sql_cacher: don't
 query the SQL DB under lock when...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ecea9b-642271@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 642271cf43ae005e81125bc98fcabc6700e46aca
      https://github.com/OpenSIPS/opensips/commit/642271cf43ae005e81125bc98fcabc6700e46aca
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: don't query the SQL DB under lock when reloading

Previously, retrieving any key from the cache during a reload would
blocked until the SQL DB query completed.

Suggested by Ben Newlin in #1760




From noreply at github.com  Fri Jul 12 12:40:42 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Fri, 12 Jul 2019 09:40:42 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1de370: sql_cacher: don't
 query the SQL DB under lock when...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/eceef3-1de370@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1de370ebfebe8eb0916603d97f0d475abb21d23c
      https://github.com/OpenSIPS/opensips/commit/1de370ebfebe8eb0916603d97f0d475abb21d23c
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: don't query the SQL DB under lock when reloading

Previously, retrieving any key from the cache during a reload would
blocked until the SQL DB query completed.

Suggested by Ben Newlin in #1760

(cherry picked from commit 642271cf43ae005e81125bc98fcabc6700e46aca)




From noreply at github.com  Fri Jul 12 12:40:58 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Fri, 12 Jul 2019 09:40:58 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5acb9a: sql_cacher: don't
 query the SQL DB under lock when...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/8e8033-5acb9a@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5acb9ac7dac1baee4ec1fbf74582c43d7d00e667
      https://github.com/OpenSIPS/opensips/commit/5acb9ac7dac1baee4ec1fbf74582c43d7d00e667
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-12 (Fri, 12 Jul 2019)

  Changed paths:
    M modules/sql_cacher/sql_cacher.c

  Log Message:
  -----------
  sql_cacher: don't query the SQL DB under lock when reloading

Previously, retrieving any key from the cache during a reload would
blocked until the SQL DB query completed.

Suggested by Ben Newlin in #1760

(cherry picked from commit 642271cf43ae005e81125bc98fcabc6700e46aca)




From noreply at github.com  Sun Jul 14 15:29:31 2019
From: noreply at github.com (opensips-github)
Date: Sun, 14 Jul 2019 12:29:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 50a37b: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/5acb9a-50a37b@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 50a37b3a2eba7e6d068abf385255c3c17878e4a0
      https://github.com/OpenSIPS/opensips/commit/50a37b3a2eba7e6d068abf385255c3c17878e4a0
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-14 (Sun, 14 Jul 2019)

  Changed paths:
    M modules/clusterer/README
    M modules/clusterer/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rls/README
    M modules/rls/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul 14 15:41:50 2019
From: noreply at github.com (opensips-github)
Date: Sun, 14 Jul 2019 12:41:50 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3f9473: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/1de370-3f9473@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3f9473432e66acb3635c3640a2801ffb5ce53c7a
      https://github.com/OpenSIPS/opensips/commit/3f9473432e66acb3635c3640a2801ffb5ce53c7a
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-14 (Sun, 14 Jul 2019)

  Changed paths:
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/clusterer/README
    M modules/clusterer/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/load_balancer/README
    M modules/load_balancer/doc/contributors.xml
    M modules/path/README
    M modules/path/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rtpengine/README
    M modules/rtpengine/doc/contributors.xml
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul 14 15:54:54 2019
From: noreply at github.com (opensips-github)
Date: Sun, 14 Jul 2019 12:54:54 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] cdb90b: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/642271-cdb90b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: cdb90bca77fe741b2c35233493d1f0279cb9aaf2
      https://github.com/OpenSIPS/opensips/commit/cdb90bca77fe741b2c35233493d1f0279cb9aaf2
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-14 (Sun, 14 Jul 2019)

  Changed paths:
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/clusterer/README
    M modules/clusterer/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/load_balancer/README
    M modules/load_balancer/doc/contributors.xml
    M modules/path/README
    M modules/path/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rls/README
    M modules/rls/doc/contributors.xml
    M modules/rtpengine/README
    M modules/rtpengine/doc/contributors.xml
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From bogdan at opensips.org  Wed Jul 17 06:39:45 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Wed, 17 Jul 2019 13:39:45 +0300
Subject: [OpenSIPS-Devel] OpenSIPS Security Training @ ClueCon 2019
Message-ID: <07218057-724c-dfe6-1615-3ce202322c21@opensips.org>


As we got used from the previous years, the ClueCon 2019 will host again 
an OpenSIPS training. This time it will be security focused training, 
teaching you how to prevent, detect and protect an OpenSIPS based VoIP 
system against various attacks using state-of-the-art prevention, 
detection and mitigation scripting techniques.  The training will do 
hands-on labs to demonstrate how to take advantage of the OpenSIPS 2.4 
capabilities to secure your SIP and RTP traffic.

The training will include the following:

     Securing the registration process
     Best practices for SIP authentication
     Detecting and blocking DoS attacks
     Preventing injections via SIP traffic
     Fighting back attacks based on DNS poisoning
     Fraud detection


Don't mis it and register here https://www.cluecon.com/training-4/ .

Security is hard to learn and costly to mis ;)

Best regards,

-- 
Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/



From noreply at github.com  Wed Jul 17 08:51:18 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 17 Jul 2019 05:51:18 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 91be78: smpp: make sure we
 re-fetch the connection after r...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/cdb90b-91be78@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 91be787f16414c208f64cd71d43d7e4fcb4bb987
      https://github.com/OpenSIPS/opensips/commit/91be787f16414c208f64cd71d43d7e4fcb4bb987
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-17 (Wed, 17 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  smpp: make sure we re-fetch the connection after rebinding

Reported by volga629 in ticket #1728




From noreply at github.com  Wed Jul 17 08:51:28 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 17 Jul 2019 05:51:28 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f5c8c0: smpp: make sure we
 re-fetch the connection after r...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/3f9473-f5c8c0@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f5c8c075589b9f8834d97fb67a59d63a6d54fb71
      https://github.com/OpenSIPS/opensips/commit/f5c8c075589b9f8834d97fb67a59d63a6d54fb71
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-17 (Wed, 17 Jul 2019)

  Changed paths:
    M modules/proto_smpp/smpp.c

  Log Message:
  -----------
  smpp: make sure we re-fetch the connection after rebinding

Reported by volga629 in ticket #1728

(cherry picked from commit 91be787f16414c208f64cd71d43d7e4fcb4bb987)




From noreply at github.com  Wed Jul 17 11:04:43 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Wed, 17 Jul 2019 08:04:43 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2f5be7: sip_i: allow
 add_isup_part() in request and failur...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/91be78-2f5be7@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2f5be7bb2ea733069c6f5cb6722cd972b17b31c5
      https://github.com/OpenSIPS/opensips/commit/2f5be7bb2ea733069c6f5cb6722cd972b17b31c5
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-17 (Wed, 17 Jul 2019)

  Changed paths:
    M modules/sip_i/sip_i.c

  Log Message:
  -----------
  sip_i: allow add_isup_part() in request and failure routes

Reported by Sagar Malam on the mailing list.




From noreply at github.com  Wed Jul 17 11:05:13 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Wed, 17 Jul 2019 08:05:13 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9bbf35: sip_i: allow
 add_isup_part() in request and failur...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/f5c8c0-9bbf35@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9bbf35b5f47df427b1432f73f9384fa9b1fb2ddf
      https://github.com/OpenSIPS/opensips/commit/9bbf35b5f47df427b1432f73f9384fa9b1fb2ddf
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-17 (Wed, 17 Jul 2019)

  Changed paths:
    M modules/sip_i/sip_i.c

  Log Message:
  -----------
  sip_i: allow add_isup_part() in request and failure routes

Reported by Sagar Malam on the mailing list.

(cherry picked from commit 2f5be7bb2ea733069c6f5cb6722cd972b17b31c5)




From noreply at github.com  Thu Jul 18 04:56:45 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 18 Jul 2019 01:56:45 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6e3938: tm: check branches
 that should be cancelled under ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/2f5be7-6e3938@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6e39385233543ee9583469c55d3d3d1738917fb7
      https://github.com/OpenSIPS/opensips/commit/6e39385233543ee9583469c55d3d3d1738917fb7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M modules/tm/t_cancel.c
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  tm: check branches that should be cancelled under lock

This fix avoids race condition between a CANCEL message and replies that
are coming in the same time.

Thanks go to Tommy Brecher for reprting this and offering extensive logs
to debug the issue in ticket #1759.
Credits for the fix are shared with Bogdan Iancu for the brainstoring.




From noreply at github.com  Thu Jul 18 04:57:06 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 18 Jul 2019 01:57:06 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 553341: tm: check branches
 that should be cancelled under ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/9bbf35-553341@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5533417f7741629bd797e18827385f8451ca374c
      https://github.com/OpenSIPS/opensips/commit/5533417f7741629bd797e18827385f8451ca374c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M modules/tm/t_cancel.c
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  tm: check branches that should be cancelled under lock

This fix avoids race condition between a CANCEL message and replies that
are coming in the same time.

Thanks go to Tommy Brecher for reprting this and offering extensive logs
to debug the issue in ticket #1759.
Credits for the fix are shared with Bogdan Iancu for the brainstoring.

(cherry picked from commit 6e39385233543ee9583469c55d3d3d1738917fb7)




From noreply at github.com  Thu Jul 18 04:57:35 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 18 Jul 2019 01:57:35 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2e1d01: tm: check branches
 that should be cancelled under ...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/50a37b-2e1d01@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2e1d01fb3363138d5af3203793fa10dbe8e10a27
      https://github.com/OpenSIPS/opensips/commit/2e1d01fb3363138d5af3203793fa10dbe8e10a27
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M modules/tm/t_cancel.c
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  tm: check branches that should be cancelled under lock

This fix avoids race condition between a CANCEL message and replies that
are coming in the same time.

Thanks go to Tommy Brecher for reprting this and offering extensive logs
to debug the issue in ticket #1759.
Credits for the fix are shared with Bogdan Iancu for the brainstoring.

(cherry picked from commit 6e39385233543ee9583469c55d3d3d1738917fb7)




From noreply at github.com  Thu Jul 18 05:55:38 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Thu, 18 Jul 2019 02:55:38 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f21e0b: dialog: set a
 termination reason for CANCELled dlgs
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/6e3938-f21e0b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f21e0bb66822fbb03a27005eb5f3451b789e263c
      https://github.com/OpenSIPS/opensips/commit/f21e0bb66822fbb03a27005eb5f3451b789e263c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-18 (Thu, 18 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: set a termination reason for CANCELled dlgs

Close #1481




From noreply at github.com  Fri Jul 19 04:21:07 2019
From: noreply at github.com (Dan Pascu)
Date: Fri, 19 Jul 2019 01:21:07 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f5c4df: Replaced TABs with
 spaces in the debian control file
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/f21e0b-f5c4df@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f5c4df538b31feefc592c3a0343a7cd6a4baf4a6
      https://github.com/OpenSIPS/opensips/commit/f5c4df538b31feefc592c3a0343a7cd6a4baf4a6
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-19 (Fri, 19 Jul 2019)

  Changed paths:
    M packaging/debian/control

  Log Message:
  -----------
  Replaced TABs with spaces in the debian control file




From noreply at github.com  Fri Jul 19 04:32:51 2019
From: noreply at github.com (Dan Pascu)
Date: Fri, 19 Jul 2019 01:32:51 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8bd9c6: Fixed Engrish
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/f5c4df-8bd9c6@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8bd9c604f4a331a0c5f3224a156144ddf62a0fd0
      https://github.com/OpenSIPS/opensips/commit/8bd9c604f4a331a0c5f3224a156144ddf62a0fd0
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-19 (Fri, 19 Jul 2019)

  Changed paths:
    M packaging/debian/control

  Log Message:
  -----------
  Fixed Engrish




From noreply at github.com  Fri Jul 19 04:37:40 2019
From: noreply at github.com (Dan Pascu)
Date: Fri, 19 Jul 2019 01:37:40 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0e6e1b: Updated debian package
	description
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/8bd9c6-0e6e1b@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0e6e1be7efabebce8d1158548dbea520445a0554
      https://github.com/OpenSIPS/opensips/commit/0e6e1be7efabebce8d1158548dbea520445a0554
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2019-07-19 (Fri, 19 Jul 2019)

  Changed paths:
    M packaging/debian/control

  Log Message:
  -----------
  Updated debian package description




From noreply at github.com  Fri Jul 19 07:57:17 2019
From: noreply at github.com (Nick Altmann)
Date: Fri, 19 Jul 2019 04:57:17 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8511c2: RPM spec: fix package
 description (following apt s...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/0e6e1b-8511c2@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8511c22c4331b1daa61cb85c33757d1d8765d5e7
      https://github.com/OpenSIPS/opensips/commit/8511c22c4331b1daa61cb85c33757d1d8765d5e7
  Author: Nick Altmann <nick.altmann at gmail.com>
  Date:   2019-07-19 (Fri, 19 Jul 2019)

  Changed paths:
    M packaging/redhat_fedora/opensips.spec

  Log Message:
  -----------
  RPM spec: fix package description (following apt spec)




From noreply at github.com  Sun Jul 21 15:29:36 2019
From: noreply at github.com (opensips-github)
Date: Sun, 21 Jul 2019 12:29:36 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8ef5d8: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/2e1d01-8ef5d8@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8ef5d8e6730786b312b8a1beb4cd2c780d3d8f86
      https://github.com/OpenSIPS/opensips/commit/8ef5d8e6730786b312b8a1beb4cd2c780d3d8f86
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-21 (Sun, 21 Jul 2019)

  Changed paths:
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul 21 15:41:54 2019
From: noreply at github.com (opensips-github)
Date: Sun, 21 Jul 2019 12:41:54 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f65583: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/553341-f65583@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f655830441df3a6b89304940b663178b70cbd5c0
      https://github.com/OpenSIPS/opensips/commit/f655830441df3a6b89304940b663178b70cbd5c0
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-21 (Sun, 21 Jul 2019)

  Changed paths:
    M modules/proto_smpp/README
    M modules/proto_smpp/doc/contributors.xml
    M modules/sip_i/README
    M modules/sip_i/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul 21 15:54:30 2019
From: noreply at github.com (opensips-github)
Date: Sun, 21 Jul 2019 12:54:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] cd3bc0: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/8511c2-cd3bc0@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: cd3bc09c716b1469b0b06d50794c7d1d9c42baf7
      https://github.com/OpenSIPS/opensips/commit/cd3bc09c716b1469b0b06d50794c7d1d9c42baf7
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-21 (Sun, 21 Jul 2019)

  Changed paths:
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/proto_smpp/README
    M modules/proto_smpp/doc/contributors.xml
    M modules/sip_i/README
    M modules/sip_i/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Mon Jul 22 06:50:51 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 22 Jul 2019 03:50:51 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a5a9c1: auth,
 auth_db: add support for "auth-int" qop
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/cd3bc0-5dbded@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a5a9c1c28ec876ae219ab34c1ef1bf61b40ceb5e
      https://github.com/OpenSIPS/opensips/commit/a5a9c1c28ec876ae219ab34c1ef1bf61b40ceb5e
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/auth/api.c
    M modules/auth/api.h
    M modules/auth/auth_mod.c
    M modules/auth/challenge.c
    M modules/auth/challenge.h
    M modules/auth/doc/auth_admin.xml
    M modules/auth/rfc2617.c
    M modules/auth/rfc2617.h
    M modules/auth_db/authorize.c

  Log Message:
  -----------
  auth, auth_db: add support for "auth-int" qop


  Commit: 5dbded6e97003f1389d3d5c36b24cffeab0dc51c
      https://github.com/OpenSIPS/opensips/commit/5dbded6e97003f1389d3d5c36b24cffeab0dc51c
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/uac/auth.c
    M modules/uac_auth/auth.c
    M modules/uac_auth/doc/uac_auth_admin.xml
    M modules/uac_auth/uac_auth.h
    M modules/uac_registrant/registrant.c
    M parser/parse_authenticate.c
    M parser/parse_authenticate.h
    A parser/test/test_parse_qop.c
    A parser/test/test_parse_qop.h
    M test/unit_tests.c

  Log Message:
  -----------
  uac_auth: add support for "auth-int" qop


Compare: https://github.com/OpenSIPS/opensips/compare/cd3bc09c716b...5dbded6e9700


From noreply at github.com  Mon Jul 22 07:59:54 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 22 Jul 2019 04:59:54 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] aafbb8: cachedb_mongodb: Add
 support for TIMESTAMP and BIN...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/5dbded-aafbb8@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: aafbb85ce6ce6d46c2cc25770e52cc012c4d4ac1
      https://github.com/OpenSIPS/opensips/commit/aafbb85ce6ce6d46c2cc25770e52cc012c4d4ac1
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/cachedb_mongodb/cachedb_mongodb_dbase.c
    M modules/cachedb_mongodb/cachedb_mongodb_json.c

  Log Message:
  -----------
  cachedb_mongodb: Add support for TIMESTAMP and BINARY types




From noreply at github.com  Mon Jul 22 08:02:38 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 22 Jul 2019 05:02:38 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d7d74d: cachedb_mongodb: Add
 support for TIMESTAMP and BIN...
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/f65583-d7d74d@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d7d74d62c1f29ab8e6f4b34fd6b82c6befe2f499
      https://github.com/OpenSIPS/opensips/commit/d7d74d62c1f29ab8e6f4b34fd6b82c6befe2f499
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/cachedb_mongodb/cachedb_mongodb_dbase.c
    M modules/cachedb_mongodb/cachedb_mongodb_json.c

  Log Message:
  -----------
  cachedb_mongodb: Add support for TIMESTAMP and BINARY types

(cherry picked from commit aafbb85ce6ce6d46c2cc25770e52cc012c4d4ac1)

This fixes some warnings when doing cache_raw_query() UPDATE operations:

WARNING:cachedb_mongodb:bson_to_json_generic:
    Unsupported type 17 for key clusterTime - skipping
WARNING:cachedb_mongodb:bson_to_json_generic:
    Unsupported type 5 for key hash - skipping




From noreply at github.com  Mon Jul 22 08:02:55 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 22 Jul 2019 05:02:55 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9c3a93: cachedb_mongodb: Add
 support for TIMESTAMP and BIN...
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/8ef5d8-9c3a93@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9c3a93201d59bf33e20e8e28a9a223eda64c2dc5
      https://github.com/OpenSIPS/opensips/commit/9c3a93201d59bf33e20e8e28a9a223eda64c2dc5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/cachedb_mongodb/cachedb_mongodb_dbase.c
    M modules/cachedb_mongodb/cachedb_mongodb_json.c

  Log Message:
  -----------
  cachedb_mongodb: Add support for TIMESTAMP and BINARY types

(cherry picked from commit aafbb85ce6ce6d46c2cc25770e52cc012c4d4ac1)

This fixes some warnings when doing cache_raw_query() UPDATE operations:

WARNING:cachedb_mongodb:bson_to_json_generic:
    Unsupported type 17 for key clusterTime - skipping
WARNING:cachedb_mongodb:bson_to_json_generic:
    Unsupported type 5 for key hash - skipping
(cherry picked from commit d7d74d62c1f29ab8e6f4b34fd6b82c6befe2f499)




From noreply at github.com  Mon Jul 22 08:30:45 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 22 Jul 2019 05:30:45 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1ebb8a: auth: fix a compile
	warning
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/aafbb8-1ebb8a@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1ebb8ac3dcf5dc65c1038b7398029062bfd79aa7
      https://github.com/OpenSIPS/opensips/commit/1ebb8ac3dcf5dc65c1038b7398029062bfd79aa7
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/auth/challenge.c

  Log Message:
  -----------
  auth: fix a compile warning




From noreply at github.com  Mon Jul 22 08:43:42 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Mon, 22 Jul 2019 05:43:42 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5f52ae: b2b_entities: fix call
 to _do_uac_auth() from auth...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/1ebb8a-5f52ae@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5f52ae39108cb171fae1338a4fad6126506df279
      https://github.com/OpenSIPS/opensips/commit/5f52ae39108cb171fae1338a4fad6126506df279
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-22 (Mon, 22 Jul 2019)

  Changed paths:
    M modules/b2b_entities/dlg.c

  Log Message:
  -----------
  b2b_entities: fix call to _do_uac_auth() from auth API




From bogdan at opensips.org  Mon Jul 22 12:32:34 2019
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 22 Jul 2019 19:32:34 +0300
Subject: [OpenSIPS-Devel] OpenSIPS Control Panel 8.3.0 was released
Message-ID: <b41a70c5-d6d3-103b-63d6-97e133ac91f1@opensips.org>

Hi all,

I know many of you were really axions, so here we have the release of 
OpenSIPS Control Panel 8.3.0, compatible with OpenSIPS 3.0 . So, at this 
point we have the full 3.0 suite in place :).

The OCP 8.3.0 has the same framework/engine as OCP 8.2.4, but it is 
aligned to the specifics of OpenSIPS 3.0 version:

* the MI backend wasaligned to the new MI interface in OpenSIPS (mi_http 
module)

* the "TLS Management" tool was update to fit to the DB changed in the 
tls_mgm OpenSIPS module

* new tool "UAC Registrant" was added for provisioning the remote SIP 
Registrar servers

* new tool "SMPP Gateway" was added for provisioning the SMS Center records


Where to check for more or to download it?
     http://controlpanel.opensips.org


Download and enjoy it as it's freshly baked for you,

-- 
Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/



From Ben.Newlin at genesys.com  Tue Jul  9 17:20:50 2019
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Tue, 9 Jul 2019 21:20:50 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <ABE9C9ED-36D6-41A7-8A53-72F5EE66BCAC@genesys.com>
References: <9A42C73B-825E-4286-9ED7-522C1800107E@genesys.com>
 <70CCAEBE-9751-4AF0-9AC9-BDBD19DDFEB4@genesys.com>
 <66379679-4b75-15fa-5fb4-98f447c0d3f1@opensips.org>
 <FAA0A90E-3BB6-41CF-ACD4-DF2634A4AE23@genesys.com>
 <15a49676-4516-bada-7781-ca6de90145fe@opensips.org>
 <22F024D2-E08B-4C18-BC12-323E33C104DD@genesys.com>
 <59ea1b3d-e640-3ca2-120b-e3c65ef6607b@opensips.org>
 <0495f4f7-1d0f-4297-92d1-5be7cc614b49@opensips.org>
 <62B9E126-54F4-4E27-9115-D176893161DE@genesys.com>
 <73585aa6-80d2-139e-7c69-ba33ace6d2fc@opensips.org>
 <ABE9C9ED-36D6-41A7-8A53-72F5EE66BCAC@genesys.com>
Message-ID: <135A3E63-B9FC-43E8-A1EE-C90994179949@genesys.com>

Any updates on this TLS crash? I see there is a ticket open on Github for a TLS crash. I wonder if that is the same issue?

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org>
Date: Thursday, June 27, 2019 at 6:42 AM
To: Bogdan-Andrei Iancu <bogdan at opensips.org>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Bogdan,

I was able to reproduce this crash on the newer 2.4 commit.

Backtrace: https://pastebin.com/RaMXTZA4

# opensips -V
version: opensips 2.4.6 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 714afb97f
main.c compiled on 17:22:40 Jun 26 2019 with gcc 7

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Wednesday, June 26, 2019 at 11:34 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

As per ticket, the issue you reported was already fixed, so going for the latest version in 2.4 branch should be fine with you.

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/26/2019 06:21 PM, Ben Newlin wrote:
Bogdan,

I will test both with the latest and with that specific commit, but I cannot use the latest in production due to the issue I reported in 2.4.6. [1] Perhaps that specific commit is before whatever change is causing that issue.

[1] https://github.com/OpenSIPS/opensips/issues/1736

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Wednesday, June 26, 2019 at 10:56 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

While re-checking some of some data related to your report, I noticed that your opensips version (revision d025b4f61) is a bit old and it is missing some fixes that might be relevant for you (mainly 3a994ceeafc6830a1c3b3f2699a7dc1ea915c83a).

Could you grab the latest 2.4 from git and give it a try please.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/26/2019 02:37 PM, Bogdan-Andrei Iancu wrote:
Thank you Ben,

This backtrace confirms the initial suspicion - I'm trying to find out a way to get it fixed in a more generic way; what you experience is just one face of the problem (with many faces :P) and there are other related reports.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/26/2019 02:34 AM, Ben Newlin wrote:
Bogdan,

I have now been able to reproduce this crash reliably, I believe. Please see the backtrace [1]. Is there some other information you would like me to collect when this occurs?

[1] https://pastebin.com/n0Ph8XH5

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, June 7, 2019 at 9:15 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

How often/easy is to reproduce this crash (if possible) ? Brainstorming with Razvan, we suspect a race (on the msg save in shmem in transaction) between the process doing the cleanup after the async resume and the process running the failure route (due th 503).

But this is just a supposition, eventually you can validate it or not by removing the async ??

And on the double ACK - I'm not 100% it is a actually a double one, as the second has a smaller MF value (69, versus the 70 on the first ACK).

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/07/2019 03:52 PM, Ben Newlin wrote:
Bogdan,

Sorry, I should have thought to actually look at the trace and examine this call.

1) Yes
2) The Called Party is 10.32.20.60, which is another OpenSIPS instance. The crashed instance received the "503 Service Unavailable" approximately 8-10 ms after sending the INVITE.

There is a SIP trace of the exchange here: https://pastebin.com/6bttsSVD.

One oddity I saw is that the crashed process appears to send (or at least siptrace) the ACK twice.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, June 6, 2019 at 11:42 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for "another" report :).

Questions:
1) do you do any async for the INVITE in this crash ?
2) if it is an YES to (1), is the caller party generating the "503 Service Unavailable" (which triggers the crash) - 10.32.20.60 ?? - a really close (from net delay perspective) and fast to answer party ?

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/05/2019 10:02 PM, Ben Newlin wrote:
We have had another crash today.

Backtrace is here: https://pastebin.com/q4RQC7kS

I found this in the log at the time of the crash:

Jun  5 17:54:10 [4978] CRITICAL:core:sig_usr: segfault in process pid: 4978, id: 8


Please let me know if any further information can be useful.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 6:31 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

I found this in the log at the time of the crash:

kernel: opensips[5003]: segfault at 30 ip 00007fbd4c8f59d0 sp 00007ffcaa850c80 error 6 in tm.so[7fbd4c887000+8e000]

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 5:44 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: [OpenSIPS-Devel] OpenSIPS Crash

Hello,

We had a crash today of our OpenSIPS instance.

Backtrace is here: https://pastebin.com/QbRJimwx

# opensips -V
version: opensips 2.4.5 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: d025b4f61
main.c compiled on 20:58:31 May  9 2019 with gcc 7

Ben Newlin








_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


















_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel







-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190709/61a15fd5/attachment-0001.html>

From Ben.Newlin at genesys.com  Thu Jul 11 16:15:00 2019
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Thu, 11 Jul 2019 20:15:00 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <34B6DBFA-04FF-4EC9-8F14-1BFB02B05F38@genesys.com>
References: <9A42C73B-825E-4286-9ED7-522C1800107E@genesys.com>
 <70CCAEBE-9751-4AF0-9AC9-BDBD19DDFEB4@genesys.com>
 <66379679-4b75-15fa-5fb4-98f447c0d3f1@opensips.org>
 <FAA0A90E-3BB6-41CF-ACD4-DF2634A4AE23@genesys.com>
 <15a49676-4516-bada-7781-ca6de90145fe@opensips.org>
 <22F024D2-E08B-4C18-BC12-323E33C104DD@genesys.com>
 <59ea1b3d-e640-3ca2-120b-e3c65ef6607b@opensips.org>
 <94A9B09C-B8F6-4493-BD32-87D0ED3164B6@genesys.com>
 <34B6DBFA-04FF-4EC9-8F14-1BFB02B05F38@genesys.com>
Message-ID: <4801ECED-9CC5-4F02-A02C-1AC6F0801908@genesys.com>

Hi,

We experienced an issue today in our testing environment where OpenSIPS was crashing pretty much constantly. We are investigating some changes we made to our TLS config, but I wanted to also provide some of the backtraces here. Due to the sheer number of core dumps (over 360) I cannot provide them all, so I tried to take a relative sampling. I expected the backtraces to all be similar but they do appear to be substantially different, although on closer inspection they may be the same cause. It’s also not clear to me whether any of these crashes are the same as the ones I have already reported.

Server 1:
https://pastebin.com/5gmfd0KU

Server 2:
https://pastebin.com/r8vNdA8W

Server 3:
https://pastebin.com/cyg9F4Z5
https://pastebin.com/r4fvLA91

Server 4:
https://pastebin.com/V5MWrUWh
https://pastebin.com/FShUNc6z


Ben Newlin

From: Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org>
Date: Tuesday, July 9, 2019 at 5:20 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org>, Bogdan-Andrei Iancu <bogdan at opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Any updates on this? Would you like me to open a ticket or does one already exist for the issue?

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org>
Date: Wednesday, June 26, 2019 at 11:58 AM
To: Bogdan-Andrei Iancu <bogdan at opensips.org>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Bogdan,

I am glad the cause is known at least. :)

Is there a ticket I can follow for more information and to be notified of resolution?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Wednesday, June 26, 2019 at 7:37 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Thank you Ben,

This backtrace confirms the initial suspicion - I'm trying to find out a way to get it fixed in a more generic way; what you experience is just one face of the problem (with many faces :P) and there are other related reports.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/26/2019 02:34 AM, Ben Newlin wrote:
Bogdan,

I have now been able to reproduce this crash reliably, I believe. Please see the backtrace [1]. Is there some other information you would like me to collect when this occurs?

[1] https://pastebin.com/n0Ph8XH5

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, June 7, 2019 at 9:15 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

How often/easy is to reproduce this crash (if possible) ? Brainstorming with Razvan, we suspect a race (on the msg save in shmem in transaction) between the process doing the cleanup after the async resume and the process running the failure route (due th 503).

But this is just a supposition, eventually you can validate it or not by removing the async ??

And on the double ACK - I'm not 100% it is a actually a double one, as the second has a smaller MF value (69, versus the 70 on the first ACK).

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/07/2019 03:52 PM, Ben Newlin wrote:
Bogdan,

Sorry, I should have thought to actually look at the trace and examine this call.

1) Yes
2) The Called Party is 10.32.20.60, which is another OpenSIPS instance. The crashed instance received the "503 Service Unavailable" approximately 8-10 ms after sending the INVITE.

There is a SIP trace of the exchange here: https://pastebin.com/6bttsSVD.

One oddity I saw is that the crashed process appears to send (or at least siptrace) the ACK twice.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, June 6, 2019 at 11:42 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for "another" report :).

Questions:
1) do you do any async for the INVITE in this crash ?
2) if it is an YES to (1), is the caller party generating the "503 Service Unavailable" (which triggers the crash) - 10.32.20.60 ?? - a really close (from net delay perspective) and fast to answer party ?

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/05/2019 10:02 PM, Ben Newlin wrote:
We have had another crash today.

Backtrace is here: https://pastebin.com/q4RQC7kS

I found this in the log at the time of the crash:

Jun  5 17:54:10 [4978] CRITICAL:core:sig_usr: segfault in process pid: 4978, id: 8


Please let me know if any further information can be useful.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 6:31 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

I found this in the log at the time of the crash:

kernel: opensips[5003]: segfault at 30 ip 00007fbd4c8f59d0 sp 00007ffcaa850c80 error 6 in tm.so[7fbd4c887000+8e000]

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 5:44 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: [OpenSIPS-Devel] OpenSIPS Crash

Hello,

We had a crash today of our OpenSIPS instance.

Backtrace is here: https://pastebin.com/QbRJimwx

# opensips -V
version: opensips 2.4.5 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: d025b4f61
main.c compiled on 20:58:31 May  9 2019 with gcc 7

Ben Newlin








_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel















-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190711/73323d7a/attachment-0001.html>

From Ben.Newlin at genesys.com  Thu Jul 11 16:16:21 2019
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Thu, 11 Jul 2019 20:16:21 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <4801ECED-9CC5-4F02-A02C-1AC6F0801908@genesys.com>
References: <9A42C73B-825E-4286-9ED7-522C1800107E@genesys.com>
 <70CCAEBE-9751-4AF0-9AC9-BDBD19DDFEB4@genesys.com>
 <66379679-4b75-15fa-5fb4-98f447c0d3f1@opensips.org>
 <FAA0A90E-3BB6-41CF-ACD4-DF2634A4AE23@genesys.com>
 <15a49676-4516-bada-7781-ca6de90145fe@opensips.org>
 <22F024D2-E08B-4C18-BC12-323E33C104DD@genesys.com>
 <59ea1b3d-e640-3ca2-120b-e3c65ef6607b@opensips.org>
 <94A9B09C-B8F6-4493-BD32-87D0ED3164B6@genesys.com>
 <34B6DBFA-04FF-4EC9-8F14-1BFB02B05F38@genesys.com>
 <4801ECED-9CC5-4F02-A02C-1AC6F0801908@genesys.com>
Message-ID: <E107BAED-74BF-412A-B101-E3210B1297EF@genesys.com>

I forgot to provide the version information:

# opensips -V
version: opensips 2.4.6 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 4e258b17f
main.c compiled on 13:16:44 Jul 11 2019 with gcc 7

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com>
Date: Thursday, July 11, 2019 at 4:14 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org>, Bogdan-Andrei Iancu <bogdan at opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi,

We experienced an issue today in our testing environment where OpenSIPS was crashing pretty much constantly. We are investigating some changes we made to our TLS config, but I wanted to also provide some of the backtraces here. Due to the sheer number of core dumps (over 360) I cannot provide them all, so I tried to take a relative sampling. I expected the backtraces to all be similar but they do appear to be substantially different, although on closer inspection they may be the same cause. It’s also not clear to me whether any of these crashes are the same as the ones I have already reported.

Server 1:
https://pastebin.com/5gmfd0KU

Server 2:
https://pastebin.com/r8vNdA8W

Server 3:
https://pastebin.com/cyg9F4Z5
https://pastebin.com/r4fvLA91

Server 4:
https://pastebin.com/V5MWrUWh
https://pastebin.com/FShUNc6z


Ben Newlin

From: Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org>
Date: Tuesday, July 9, 2019 at 5:20 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org>, Bogdan-Andrei Iancu <bogdan at opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Any updates on this? Would you like me to open a ticket or does one already exist for the issue?

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org>
Date: Wednesday, June 26, 2019 at 11:58 AM
To: Bogdan-Andrei Iancu <bogdan at opensips.org>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Bogdan,

I am glad the cause is known at least. :)

Is there a ticket I can follow for more information and to be notified of resolution?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Wednesday, June 26, 2019 at 7:37 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Thank you Ben,

This backtrace confirms the initial suspicion - I'm trying to find out a way to get it fixed in a more generic way; what you experience is just one face of the problem (with many faces :P) and there are other related reports.

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/26/2019 02:34 AM, Ben Newlin wrote:
Bogdan,

I have now been able to reproduce this crash reliably, I believe. Please see the backtrace [1]. Is there some other information you would like me to collect when this occurs?

[1] https://pastebin.com/n0Ph8XH5

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, June 7, 2019 at 9:15 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

How often/easy is to reproduce this crash (if possible) ? Brainstorming with Razvan, we suspect a race (on the msg save in shmem in transaction) between the process doing the cleanup after the async resume and the process running the failure route (due th 503).

But this is just a supposition, eventually you can validate it or not by removing the async ??

And on the double ACK - I'm not 100% it is a actually a double one, as the second has a smaller MF value (69, versus the 70 on the first ACK).

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/07/2019 03:52 PM, Ben Newlin wrote:
Bogdan,

Sorry, I should have thought to actually look at the trace and examine this call.

1) Yes
2) The Called Party is 10.32.20.60, which is another OpenSIPS instance. The crashed instance received the "503 Service Unavailable" approximately 8-10 ms after sending the INVITE.

There is a SIP trace of the exchange here: https://pastebin.com/6bttsSVD.

One oddity I saw is that the crashed process appears to send (or at least siptrace) the ACK twice.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, June 6, 2019 at 11:42 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for "another" report :).

Questions:
1) do you do any async for the INVITE in this crash ?
2) if it is an YES to (1), is the caller party generating the "503 Service Unavailable" (which triggers the crash) - 10.32.20.60 ?? - a really close (from net delay perspective) and fast to answer party ?

Regards,







Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  https://www.opensips-solutions.com

OpenSIPS Summit 2019

  https://www.opensips.org/events/Summit-2019Amsterdam/
On 06/05/2019 10:02 PM, Ben Newlin wrote:
We have had another crash today.

Backtrace is here: https://pastebin.com/q4RQC7kS

I found this in the log at the time of the crash:

Jun  5 17:54:10 [4978] CRITICAL:core:sig_usr: segfault in process pid: 4978, id: 8


Please let me know if any further information can be useful.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 6:31 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

I found this in the log at the time of the crash:

kernel: opensips[5003]: segfault at 30 ip 00007fbd4c8f59d0 sp 00007ffcaa850c80 error 6 in tm.so[7fbd4c887000+8e000]

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Friday, May 10, 2019 at 5:44 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: [OpenSIPS-Devel] OpenSIPS Crash

Hello,

We had a crash today of our OpenSIPS instance.

Backtrace is here: https://pastebin.com/QbRJimwx

# opensips -V
version: opensips 2.4.5 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, F_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: d025b4f61
main.c compiled on 20:58:31 May  9 2019 with gcc 7

Ben Newlin









_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


















-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190711/ff16353e/attachment-0001.html>

From johan at democon.be  Mon Jul 22 12:36:15 2019
From: johan at democon.be (johan de clercq)
Date: Mon, 22 Jul 2019 18:36:15 +0200
Subject: [OpenSIPS-Devel] [OpenSIPS-Users] OpenSIPS Control Panel 8.3.0
	was released
In-Reply-To: <b41a70c5-d6d3-103b-63d6-97e133ac91f1@opensips.org>
References: <b41a70c5-d6d3-103b-63d6-97e133ac91f1@opensips.org>
Message-ID: <00ac01d540ab$94d35200$be79f600$@democon.be>

Thanks Bogdan, I will let you know my findings in a few days. 

-----Original Message-----
From: Users <users-bounces at lists.opensips.org> On Behalf Of Bogdan-Andrei Iancu
Sent: Monday, July 22, 2019 6:33 PM
To: users at lists.opensips.org; developensips <Devel at lists.opensips.org>
Subject: [OpenSIPS-Users] OpenSIPS Control Panel 8.3.0 was released

Hi all,

I know many of you were really axions, so here we have the release of OpenSIPS Control Panel 8.3.0, compatible with OpenSIPS 3.0 . So, at this point we have the full 3.0 suite in place :).

The OCP 8.3.0 has the same framework/engine as OCP 8.2.4, but it is aligned to the specifics of OpenSIPS 3.0 version:

* the MI backend wasaligned to the new MI interface in OpenSIPS (mi_http
module)

* the "TLS Management" tool was update to fit to the DB changed in the tls_mgm OpenSIPS module

* new tool "UAC Registrant" was added for provisioning the remote SIP Registrar servers

* new tool "SMPP Gateway" was added for provisioning the SMS Center records


Where to check for more or to download it?
     http://controlpanel.opensips.org


Download and enjoy it as it's freshly baked for you,

--
Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   https://www.opensips-solutions.com
OpenSIPS Summit 2019
   https://www.opensips.org/events/Summit-2019Amsterdam/


_______________________________________________
Users mailing list
Users at lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users



From noreply at github.com  Tue Jul 23 05:38:49 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Tue, 23 Jul 2019 02:38:49 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2a175e: socket: properly check
	glibc version
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/5f52ae-7d01f0@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2a175eba2cfb93008ecda99896bb0735e0a4f12c
      https://github.com/OpenSIPS/opensips/commit/2a175eba2cfb93008ecda99896bb0735e0a4f12c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M socket_info.c

  Log Message:
  -----------
  socket: properly check glibc version


  Commit: e6d8c1f431034813daf313a104d695c2e0285ac8
      https://github.com/OpenSIPS/opensips/commit/e6d8c1f431034813daf313a104d695c2e0285ac8
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M resolve.h

  Log Message:
  -----------
  resolve: define MAXHOSTNAMELEN if not defined


  Commit: 8c4332ead923f27cfa89fa0f07f3add04cd1bbbe
      https://github.com/OpenSIPS/opensips/commit/8c4332ead923f27cfa89fa0f07f3add04cd1bbbe
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: fix glibc version check


  Commit: 7d01f00a0494435d0fdb2a54e810f2ae5628c19f
      https://github.com/OpenSIPS/opensips/commit/7d01f00a0494435d0fdb2a54e810f2ae5628c19f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M modules/mathops/math_funcs.c

  Log Message:
  -----------
  mathops: make GNU_SOURCE set for math.h


Compare: https://github.com/OpenSIPS/opensips/compare/5f52ae39108c...7d01f00a0494


From noreply at github.com  Tue Jul 23 10:44:51 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Tue, 23 Jul 2019 07:44:51 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 73cc6e: evi: fix subscribers
	list mi cmd
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/7d01f0-139bb4@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 73cc6ec8da931ce919d89a351de8a556d5952789
      https://github.com/OpenSIPS/opensips/commit/73cc6ec8da931ce919d89a351de8a556d5952789
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M evi/event_interface.c

  Log Message:
  -----------
  evi: fix subscribers list mi cmd


  Commit: 139bb4c0c65e8ec5a7c870c3fc9f35fcf2c24b87
      https://github.com/OpenSIPS/opensips/commit/139bb4c0c65e8ec5a7c870c3fc9f35fcf2c24b87
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M modules/event_jsonrpc/jsonrpc_send.c
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/event_xmlrpc/xmlrpc_send.c
    M modules/sngtc/sngtc.c
    M pt.c
    M pt.h

  Log Message:
  -----------
  pt: expose number of processes at mod_init

Add a function that exposes the number of processes at mod_init(). Even
if this is not entirely accurate (some processes might remove their
external processes during mod_init), it's the best chance we can get to
count the number of pipes we need to create for modules that use
synchronous communication.

This fix solves event_* sync processing.

Thanks go to Rizwan Syed for reporting this, close #1768


Compare: https://github.com/OpenSIPS/opensips/compare/7d01f00a0494...139bb4c0c65e


From noreply at github.com  Tue Jul 23 10:45:27 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Tue, 23 Jul 2019 07:45:27 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 52540b: evi: fix subscribers
	list mi cmd
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/d7d74d-a69707@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 52540b7d175154978958a15038bf3e75578b7681
      https://github.com/OpenSIPS/opensips/commit/52540b7d175154978958a15038bf3e75578b7681
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M evi/event_interface.c

  Log Message:
  -----------
  evi: fix subscribers list mi cmd

(cherry picked from commit 73cc6ec8da931ce919d89a351de8a556d5952789)


  Commit: a69707a0f8f2ed82be53f636e6fe10144221a216
      https://github.com/OpenSIPS/opensips/commit/a69707a0f8f2ed82be53f636e6fe10144221a216
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-23 (Tue, 23 Jul 2019)

  Changed paths:
    M modules/event_jsonrpc/jsonrpc_send.c
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/event_xmlrpc/xmlrpc_send.c
    M modules/sngtc/sngtc.c
    M pt.c
    M pt.h

  Log Message:
  -----------
  pt: expose number of processes at mod_init

Add a function that exposes the number of processes at mod_init(). Even
if this is not entirely accurate (some processes might remove their
external processes during mod_init), it's the best chance we can get to
count the number of pipes we need to create for modules that use
synchronous communication.

This fix solves event_* sync processing.

Thanks go to Rizwan Syed for reporting this, close #1768

(cherry picked from commit 139bb4c0c65e8ec5a7c870c3fc9f35fcf2c24b87)


Compare: https://github.com/OpenSIPS/opensips/compare/d7d74d62c1f2...a69707a0f8f2


From noreply at github.com  Wed Jul 24 03:54:52 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 24 Jul 2019 00:54:52 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d176c6: ipc: add new set of
	synchronous pipes
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/139bb4-935d76@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d176c6286620adb173d292d89cf86503bd1b57de
      https://github.com/OpenSIPS/opensips/commit/d176c6286620adb173d292d89cf86503bd1b57de
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M ipc.c
    M ipc.h
    M pt.c
    M pt.h

  Log Message:
  -----------
  ipc: add new set of synchronous pipes

These new pipe set for each process can be used to synchronously send a
command from one process to the other. When using these pipes, make sure
that there's no other job that can overlap, otherwise the receiver will
not be albe to handle it


  Commit: 935d7690733040c48599cbc6039ff9aa913e7d80
      https://github.com/OpenSIPS/opensips/commit/935d7690733040c48599cbc6039ff9aa913e7d80
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M modules/event_jsonrpc/jsonrpc_send.c
    M modules/event_jsonrpc/jsonrpc_send.h
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/event_rabbitmq/rabbitmq_send.h
    M modules/event_xmlrpc/xmlrpc_send.c
    M modules/event_xmlrpc/xmlrpc_send.h

  Log Message:
  -----------
  event_*: use the new sync pipes mechanism

Use the new pipe sync mechanism to notify the status of commands sent by
the following modules:
* event_xmlrpc
* event_jsonrpc
* event_rabbitmq


Compare: https://github.com/OpenSIPS/opensips/compare/139bb4c0c65e...935d76907330


From noreply at github.com  Wed Jul 24 04:01:09 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Wed, 24 Jul 2019 01:01:09 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bc62c9: fix previous commit
	rebase issue
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/935d76-bc62c9@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: bc62c9bb6b45c56a412bf36ebce9e1a215406cee
      https://github.com/OpenSIPS/opensips/commit/bc62c9bb6b45c56a412bf36ebce9e1a215406cee
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M modules/event_jsonrpc/jsonrpc_send.c
    M modules/event_rabbitmq/rabbitmq_send.c
    M modules/event_xmlrpc/xmlrpc_send.c

  Log Message:
  -----------
  fix previous commit rebase issue




From noreply at github.com  Wed Jul 24 06:10:59 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 24 Jul 2019 03:10:59 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 94bbbe: usrloc shutdown:
 Destroy the CDB conn _after_ cleanup
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/bc62c9-94bbbe@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 94bbbebbcf99843baa5b6d60e699a466c9adc3d2
      https://github.com/OpenSIPS/opensips/commit/94bbbebbcf99843baa5b6d60e699a466c9adc3d2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M modules/usrloc/ul_mod.c

  Log Message:
  -----------
  usrloc shutdown: Destroy the CDB conn _after_ cleanup

This fixes a possible crash on shutdown whenever a contact expires
during the shutdown and needs to be flushed.

Credits to @bogdan-iancu for the accurate report




From noreply at github.com  Wed Jul 24 06:11:12 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 24 Jul 2019 03:11:12 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] dc34a8: usrloc shutdown:
 Destroy the CDB conn _after_ cleanup
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/a69707-dc34a8@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: dc34a8399460ba9f67a8aa21917f9709b2eda4cc
      https://github.com/OpenSIPS/opensips/commit/dc34a8399460ba9f67a8aa21917f9709b2eda4cc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M modules/usrloc/ul_mod.c

  Log Message:
  -----------
  usrloc shutdown: Destroy the CDB conn _after_ cleanup

This fixes a possible crash on shutdown whenever a contact expires
during the shutdown and needs to be flushed.

Credits to @bogdan-iancu for the accurate report

(cherry picked from commit 94bbbebbcf99843baa5b6d60e699a466c9adc3d2)




From noreply at github.com  Wed Jul 24 06:11:24 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 24 Jul 2019 03:11:24 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ac4b46: usrloc shutdown:
 Destroy the CDB conn _after_ cleanup
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/9c3a93-ac4b46@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ac4b46965d8559c2dfb61b1adb6d96986f893d89
      https://github.com/OpenSIPS/opensips/commit/ac4b46965d8559c2dfb61b1adb6d96986f893d89
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-24 (Wed, 24 Jul 2019)

  Changed paths:
    M modules/usrloc/ul_mod.c

  Log Message:
  -----------
  usrloc shutdown: Destroy the CDB conn _after_ cleanup

This fixes a possible crash on shutdown whenever a contact expires
during the shutdown and needs to be flushed.

Credits to @bogdan-iancu for the accurate report

(cherry picked from commit 94bbbebbcf99843baa5b6d60e699a466c9adc3d2)




From noreply at github.com  Thu Jul 25 09:21:05 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 25 Jul 2019 06:21:05 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ca0ea3: dialog: fix memory
 leak in unset_dlg_profile()
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/dc34a8-ca0ea3@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ca0ea3f7fb5849f208d6a685739fdbae567caed3
      https://github.com/OpenSIPS/opensips/commit/ca0ea3f7fb5849f208d6a685739fdbae567caed3
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-25 (Thu, 25 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  dialog: fix memory leak in unset_dlg_profile()




From noreply at github.com  Thu Jul 25 09:21:17 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 25 Jul 2019 06:21:17 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9db3a5: dialog: fix memory
 leak in unset_dlg_profile()
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/94bbbe-9db3a5@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9db3a562a72d1b49b6a62cc42603748aad200f38
      https://github.com/OpenSIPS/opensips/commit/9db3a562a72d1b49b6a62cc42603748aad200f38
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-25 (Thu, 25 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  dialog: fix memory leak in unset_dlg_profile()

(cherry picked from commit ca0ea3f7fb5849f208d6a685739fdbae567caed3)




From noreply at github.com  Thu Jul 25 09:21:45 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Thu, 25 Jul 2019 06:21:45 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0dd8d9: dialog: fix memory
 leak in unset_dlg_profile()
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/ac4b46-0dd8d9@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0dd8d90f3ae80ffdfef6377e41abea270d29a022
      https://github.com/OpenSIPS/opensips/commit/0dd8d90f3ae80ffdfef6377e41abea270d29a022
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-25 (Thu, 25 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  dialog: fix memory leak in unset_dlg_profile()

(cherry picked from commit ca0ea3f7fb5849f208d6a685739fdbae567caed3)




From noreply at github.com  Fri Jul 26 09:50:19 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 26 Jul 2019 06:50:19 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 346b95: dialog: Improve
 accuracy for active/early dialog s...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/9db3a5-346b95@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 346b9528d1b6292bc4da1c2e976a2ff1b3d2a88e
      https://github.com/OpenSIPS/opensips/commit/346b9528d1b6292bc4da1c2e976a2ff1b3d2a88e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-26 (Fri, 26 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog: Improve accuracy for active/early dialog stats

Avoid lingering increments whenever a dialog is loaded from DB which
eventually ends up getting discarded.




From noreply at github.com  Fri Jul 26 17:30:53 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 26 Jul 2019 14:30:53 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bf968d: cfg preprocessor: Fix
 a dirty buffer management bug
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/346b95-bf968d@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: bf968d01679a48b9ff79f4edb9abf2743d3586b1
      https://github.com/OpenSIPS/opensips/commit/bf968d01679a48b9ff79f4edb9abf2743d3586b1
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  cfg preprocessor: Fix a dirty buffer management bug

One of those pesky bugs, caused by not knowing your snprintf's well...
This strange, seemingly inexplicable bug only manifested whenever a
series of config file lines + preprocessor tokens formed a multiple
of 4096 bytes, the amount by which the preprocessor buffer gets extended
with each reallocation.

With such config files, the snprintf() would truncate the last byte of
the config file line adding up to N*4096 bytes (usually a '\n'), and put
a '\0' instead, after which the preprocessing continued normally.

However, it seems Yacc isn't too happy when you feed it with a buffer
which includes '\0' characters, as this will cause it to barf some
binary data to stdout, somewhat ruining the logfile.




From liviu at opensips.org  Fri Jul 26 17:35:34 2019
From: liviu at opensips.org (Liviu Chircu)
Date: Sat, 27 Jul 2019 00:35:34 +0300
Subject: [OpenSIPS-Devel] Configuration issue with modparam syntax
In-Reply-To: <0AD9F991-35EC-420F-82FE-27AB71A960BE@ag-projects.com>
References: <6BBE80DE-A6FB-43AC-9831-433E60D5D1C9@ag-projects.com>
 <e776fce4-abf9-cd15-5cf5-5fd3fb95f4fd@opensips.org>
 <417793FA-C9F1-4759-9639-6561CB094550@ag-projects.com>
 <0AD9F991-35EC-420F-82FE-27AB71A960BE@ag-projects.com>
Message-ID: <91a83981-a9f2-0aa4-ae7a-40f1f6bc1fab@opensips.org>

On 08.07.2019 20:27, Dan Pascu wrote:
> What I noticed later made things much weirder, to the point that this bug now looks like something out of the twilight zone. To be honest I'm not even sure how to describe it properly.
>
> In short I have the following facts:
>
> 1. I have a configuration file of length N that has the error. The error is something about some items in $acc_extra not being defined when used in route later in the script. With this is doesn't matter if the certificate has a dash or not in its name. All it matter is the size of the configuration file being N.

Hi Dan,

The twilight zone may be more real than we thought.  Please make sure 
you pull this fix [1]
before trying again, the symptoms you describe point exactly to a bug 
that's gone now.

Regards,

[1]: https://github.com/OpenSIPS/opensips/commit/bf968d01679a48b9 
<https://github.com/OpenSIPS/opensips/commit/bf968d01679a48b9ff79f4edb9abf2743d3586b1>

-- 
Liviu Chircu
OpenSIPS Developer
http://www.opensips-solutions.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190727/34ae0df9/attachment.html>

From noreply at github.com  Fri Jul 26 17:36:21 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 26 Jul 2019 14:36:21 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 04eaa1: cfg preprocessor: Fix
 a dirty buffer management bug
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/ca0ea3-04eaa1@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 04eaa15dab8c632b24fe07e961a0b877458dd7ca
      https://github.com/OpenSIPS/opensips/commit/04eaa15dab8c632b24fe07e961a0b877458dd7ca
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  cfg preprocessor: Fix a dirty buffer management bug

One of those pesky bugs, caused by not knowing your snprintf's well...
This strange, seemingly inexplicable bug only manifested whenever a
series of config file lines + preprocessor tokens formed a multiple
of 4096 bytes, the amount by which the preprocessor buffer gets extended
with each reallocation.

With such config files, the snprintf() would truncate the last byte of
the config file line adding up to N*4096 bytes (usually a '\n'), and put
a '\0' instead, after which the preprocessing continued normally.

However, it seems Yacc isn't too happy when you feed it with a buffer
which includes '\0' characters, as this will cause it to barf some
binary data to stdout, somewhat ruining the logfile.

(cherry picked from commit bf968d01679a48b9ff79f4edb9abf2743d3586b1)




From noreply at github.com  Fri Jul 26 18:00:48 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 26 Jul 2019 15:00:48 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a97060: cfg script: Remove max
 line length limitation to 4...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/bf968d-a97060@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a970602b72a8fc0293a7aa2ea78070eaeb1406c5
      https://github.com/OpenSIPS/opensips/commit/a970602b72a8fc0293a7aa2ea78070eaeb1406c5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M cfg_pp.c

  Log Message:
  -----------
  cfg script: Remove max line length limitation to 4096 bytes




From noreply at github.com  Fri Jul 26 18:41:22 2019
From: noreply at github.com (Liviu Chircu)
Date: Fri, 26 Jul 2019 15:41:22 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ae3fcd: cfg syntax: Fully
 implement the 'break' statement
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/a97060-ae3fcd@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ae3fcda3b6971a8925d6ef96d641b0569e9a607e
      https://github.com/OpenSIPS/opensips/commit/ae3fcda3b6971a8925d6ef96d641b0569e9a607e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M action.c
    M action.h
    M cfg.lex
    M cfg.y
    M route_struct.c
    M route_struct.h

  Log Message:
  -----------
  cfg syntax: Fully implement the 'break' statement

The opensips.cfg now supports:

    * 'break' under an 'if', within a 'switch' statement (any part)
    * 'break' within a 'while' statement
    * 'break' under an 'if', within a 'while' statement
    * 'break' within a 'for-each' statement
    * 'break' under an 'if', within a 'for-each' statement
    * 'break' from nested 'switch' / 'while' / 'for-each' statements




From noreply at github.com  Sat Jul 27 12:54:47 2019
From: noreply at github.com (Liviu Chircu)
Date: Sat, 27 Jul 2019 09:54:47 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f3abf6: cfg syntax: Disallow
 esoteric if/while syntax
Message-ID: <OpenSIPS/opensips/push/refs/heads/feature/improve-cfg-syntax/000000-71fef1@github.com>

  Branch: refs/heads/feature/improve-cfg-syntax
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f3abf690a54f36edff08d2929d7634c7f5484761
      https://github.com/OpenSIPS/opensips/commit/f3abf690a54f36edff08d2929d7634c7f5484761
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M cfg.y

  Log Message:
  -----------
  cfg syntax: Disallow esoteric if/while syntax

The opensips.cfg no longer accepts constructs such as:

    if $var(foo) {
        ...
    }

    if [ $var(foo) == 2 ]
        xlog("bar\n");

    while $var(foo) < 10 {
	...
    }

... and forces the condition to be paranthesized.  Aside from any
consistency considerations, this change also allows us to disambiguate
the if-if-else shift/reduce conflicts of the grammar, which were so far
masked using the "expect 2" rule.


  Commit: b2b4f48a153fb37929014bff20a72ba4972414f8
      https://github.com/OpenSIPS/opensips/commit/b2b4f48a153fb37929014bff20a72ba4972414f8
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M cfg.y

  Log Message:
  -----------
  cfg syntax:  Enhance the 'return' statement

The opensips.cfg now additionally allows syntax such as:

    * return 1;
    * return +2;
    * return -3;
    * return $var(foo);


  Commit: 71fef11495168442718f5db61680abf48abf794d
      https://github.com/OpenSIPS/opensips/commit/71fef11495168442718f5db61680abf48abf794d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-27 (Sat, 27 Jul 2019)

  Changed paths:
    M action.c
    M route_struct.h

  Log Message:
  -----------
  cfg syntax: Fix all complex assignment operators

The opensips.cfg now fully supports the non-trivial assignment
operators, such as: +=, -=, *=, /=, %=, &=, |= and ^=.  Syntactially,
they were supported until now, but were actually unimplemented (more
precisely, they were equivalent to the "=" operator).

Only the "+=" operator can also work with strings, for example:

    $var(x) = "foo";
    $var(x) += "-bar"; # now contains "foo-bar"

    $rU = "+40";
    $rU += "729" + "884950"; # now contains "+40729884950"

All of them (including "+="), work with integers:

    $var(i) = 0;
    $var(i) += 2; # 2
    $var(i) *= 3; # 6
    $var(i) /= 6; # 1
    ...


Compare: https://github.com/OpenSIPS/opensips/compare/f3abf690a54f%5E...71fef1149516


From noreply at github.com  Sun Jul 28 15:29:54 2019
From: noreply at github.com (opensips-github)
Date: Sun, 28 Jul 2019 12:29:54 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ade908: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/0dd8d9-ade908@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ade908fba2bf0074fa2d499ee3417b22089f4d4f
      https://github.com/OpenSIPS/opensips/commit/ade908fba2bf0074fa2d499ee3417b22089f4d4f
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-28 (Sun, 28 Jul 2019)

  Changed paths:
    M modules/cachedb_mongodb/README
    M modules/cachedb_mongodb/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul 28 15:42:14 2019
From: noreply at github.com (opensips-github)
Date: Sun, 28 Jul 2019 12:42:14 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9e951c: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/04eaa1-9e951c@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9e951c904f7072fc647f85269a13fb4d63cf2bad
      https://github.com/OpenSIPS/opensips/commit/9e951c904f7072fc647f85269a13fb4d63cf2bad
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-28 (Sun, 28 Jul 2019)

  Changed paths:
    M modules/cachedb_mongodb/README
    M modules/cachedb_mongodb/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/event_jsonrpc/README
    M modules/event_jsonrpc/doc/contributors.xml
    M modules/event_rabbitmq/README
    M modules/event_rabbitmq/doc/contributors.xml
    M modules/event_xmlrpc/README
    M modules/event_xmlrpc/doc/contributors.xml
    M modules/sngtc/README
    M modules/sngtc/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Sun Jul 28 15:54:16 2019
From: noreply at github.com (opensips-github)
Date: Sun, 28 Jul 2019 12:54:16 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1c3859: Rebuild documentation
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ae3fcd-1c3859@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1c385981b0f1395b9d00a57e6a2d024760868a96
      https://github.com/OpenSIPS/opensips/commit/1c385981b0f1395b9d00a57e6a2d024760868a96
  Author: OpenSIPS <github at opensips.org>
  Date:   2019-07-28 (Sun, 28 Jul 2019)

  Changed paths:
    M modules/auth/README
    M modules/auth/doc/contributors.xml
    M modules/auth_db/README
    M modules/auth_db/doc/contributors.xml
    M modules/b2b_entities/README
    M modules/b2b_entities/doc/contributors.xml
    M modules/cachedb_mongodb/README
    M modules/cachedb_mongodb/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/event_jsonrpc/README
    M modules/event_jsonrpc/doc/contributors.xml
    M modules/event_rabbitmq/README
    M modules/event_rabbitmq/doc/contributors.xml
    M modules/event_xmlrpc/README
    M modules/event_xmlrpc/doc/contributors.xml
    M modules/mathops/README
    M modules/mathops/doc/contributors.xml
    M modules/sngtc/README
    M modules/sngtc/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/uac/README
    M modules/uac/doc/contributors.xml
    M modules/uac_auth/README
    M modules/uac_auth/doc/contributors.xml
    M modules/uac_registrant/README
    M modules/uac_registrant/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation




From noreply at github.com  Mon Jul 29 07:12:35 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 29 Jul 2019 04:12:35 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0b3ad4: clusterer: Make the
 data sync interface more robust
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/000000-cdec65@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0b3ad435be73d7ef49c511d2b70039c39a883135
      https://github.com/OpenSIPS/opensips/commit/0b3ad435be73d7ef49c511d2b70039c39a883135
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/clusterer/sync.c

  Log Message:
  -----------
  clusterer: Make the data sync interface more robust

This patch improves the data sync interface so that during a sync,
modules are no longer forced to micro-manage the data packets they are
receiving from the interface.  They can now freely abort the processing
of a sync chunk at any time, without disrupting the processing of the
entire sync packet (composed of many more of such data chunks).

Additionally, since the sync packet format has changed (an extra integer
is needed for each chunk in order to allow the "skip" mechanism), the
sync packet version is now bumped from 1 -> 2, in order to prevent any
compatibility issues with OpenSIPS nodes without this patch.


  Commit: cdec657458086f2624ae58fa7fb318de504c53eb
      https://github.com/OpenSIPS/opensips/commit/cdec657458086f2624ae58fa7fb318de504c53eb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  clusterer: Enhance the versioning of sync packets

This commit adds an additional "version" field for the sync packets,
which are more complex than the other ones.  Since they contain
serialization logic from two different layers (clusterer + data module),
they should also contain two version fields, to allow each module to
discard data coming from an OpenSIPS donor node running on a differing
binary version.


Compare: https://github.com/OpenSIPS/opensips/compare/0b3ad435be73%5E...cdec65745808


From noreply at github.com  Mon Jul 29 07:41:11 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 29 Jul 2019 04:41:11 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 91d3f3: dialog replication:
 Revert the sync packet alignme...
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/cdec65-91d3f3@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 91d3f39e6710a8cb73b36f6c9ed527b9b7ebb1ed
      https://github.com/OpenSIPS/opensips/commit/91d3f39e6710a8cb73b36f6c9ed527b9b7ebb1ed
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Revert the sync packet alignment code

... since now it is unnecessary, thanks to the sync layer enhancements.




From noreply at github.com  Mon Jul 29 09:25:34 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 29 Jul 2019 06:25:34 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8b2f74: clusterer: Enhance the
 versioning of sync packets
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/91d3f3-1ca815@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8b2f74aef79a48bb0798d476844f9d10a17f3b61
      https://github.com/OpenSIPS/opensips/commit/8b2f74aef79a48bb0798d476844f9d10a17f3b61
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  clusterer: Enhance the versioning of sync packets

This commit adds an additional "version" field for the sync packets,
which are more complex than the other ones.  Since they contain
serialization logic from two different layers (clusterer + data module),
they should also contain two version fields, to allow each module to
discard data coming from an OpenSIPS donor node running on a differing
binary version.


  Commit: d9a4923670b4ce4c2cd70acb1e3448deed7da77c
      https://github.com/OpenSIPS/opensips/commit/d9a4923670b4ce4c2cd70acb1e3448deed7da77c
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Revert the sync packet alignment code

... since now it is unnecessary, thanks to the sync layer enhancements.


  Commit: 1ca815a7ae1c08b2a6c8b7bbc544430ecf0e0ee2
      https://github.com/OpenSIPS/opensips/commit/1ca815a7ae1c08b2a6c8b7bbc544430ecf0e0ee2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync:  Do not include early or ended dialogs


Compare: https://github.com/OpenSIPS/opensips/compare/91d3f39e6710...1ca815a7ae1c


From noreply at github.com  Mon Jul 29 11:09:58 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 29 Jul 2019 08:09:58 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a20a0a: clusterer: Enhance the
 versioning of sync packets
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/1ca815-b8bde2@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a20a0acb5d9e8ef75d4cf2bb081ed1d5d259a3dd
      https://github.com/OpenSIPS/opensips/commit/a20a0acb5d9e8ef75d4cf2bb081ed1d5d259a3dd
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  clusterer: Enhance the versioning of sync packets

This commit adds an additional "version" field for the sync packets,
which are more complex than the other ones.  Since they contain
serialization logic from two different layers (clusterer + data module),
they should also contain two version fields, to allow each module to
discard data coming from an OpenSIPS donor node running on a differing
binary version.


  Commit: e33565342065298eeb542a73503f84402cc1076d
      https://github.com/OpenSIPS/opensips/commit/e33565342065298eeb542a73503f84402cc1076d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Revert the sync packet alignment code

... since now it is unnecessary, thanks to the sync layer enhancements.


  Commit: b8bde2f014e5b427c8517493a7ada16923d0928c
      https://github.com/OpenSIPS/opensips/commit/b8bde2f014e5b427c8517493a7ada16923d0928c
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Do not include early or ended dialogs


Compare: https://github.com/OpenSIPS/opensips/compare/1ca815a7ae1c...b8bde2f014e5


From noreply at github.com  Mon Jul 29 12:06:13 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 29 Jul 2019 09:06:13 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8265c6: dialog: Fix data
 reload race conditions on startup
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/b8bde2-a15aa0@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8265c6e4ef8f81f5b78f75f3f2315eccc9a633c3
      https://github.com/OpenSIPS/opensips/commit/8265c6e4ef8f81f5b78f75f3f2315eccc9a633c3
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix data reload race conditions on startup

Since loading the data on child_init(), the load_dialog_info_from_db()
routines and rcv_cluster_event() routines could run in parallel, without
any synchronization on the dialog table, which could lead to duplicate
dialogs in the hash.


  Commit: a15aa0b43b4eca5b37f56cbd53819b0f39a815c8
      https://github.com/OpenSIPS/opensips/commit/a15aa0b43b4eca5b37f56cbd53819b0f39a815c8
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h

  Log Message:
  -----------
  dialog: Decrement dialog stats during post-sync cleanup

After a sync completes, it proceeds to clean up all dialogs loaded from
DB which did not match the data received via sync.  However, make sure
to also decrement the 'active' / 'early' dialog stats on each delete!


Compare: https://github.com/OpenSIPS/opensips/compare/b8bde2f014e5...a15aa0b43b4e


From noreply at github.com  Mon Jul 29 12:14:56 2019
From: noreply at github.com (Liviu Chircu)
Date: Mon, 29 Jul 2019 09:14:56 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8e9cee: dialog: Fix data
 reload race conditions on startup
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/a15aa0-dfa863@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8e9cee7db956a0321a92b6771852521f90aac696
      https://github.com/OpenSIPS/opensips/commit/8e9cee7db956a0321a92b6771852521f90aac696
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix data reload race conditions on startup

Since loading the data on child_init(), the load_dialog_info_from_db()
routines and rcv_cluster_event() routines could run in parallel, without
any synchronization on the dialog table, which could lead to duplicate
dialogs in the hash.


  Commit: dfa863b9b2a9255e58be14b6ad3559406f7fdc99
      https://github.com/OpenSIPS/opensips/commit/dfa863b9b2a9255e58be14b6ad3559406f7fdc99
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h

  Log Message:
  -----------
  dialog: Decrement dialog stats during post-sync cleanup

After a sync completes, it proceeds to clean up all dialogs loaded from
DB which did not match the data received via sync.  However, make sure
to also decrement the 'active' / 'early' dialog stats on each delete!


Compare: https://github.com/OpenSIPS/opensips/compare/a15aa0b43b4e...dfa863b9b2a9


From noreply at github.com  Tue Jul 30 04:51:48 2019
From: noreply at github.com (=?UTF-8?B?UsSDenZhbiBDcmFpbmVh?=)
Date: Tue, 30 Jul 2019 01:51:48 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ff245d: siprec: provide means
 to add headers to initial req
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/1c3859-ff245d@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ff245d48e9ac1c90a805eaa9f7517646ddef9e0f
      https://github.com/OpenSIPS/opensips/commit/ff245d48e9ac1c90a805eaa9f7517646ddef9e0f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/siprec/doc/siprec_admin.xml
    M modules/siprec/siprec.c
    M modules/siprec/siprec_logic.c
    M modules/siprec/siprec_sess.c
    M modules/siprec/siprec_sess.h

  Log Message:
  -----------
  siprec: provide means to add headers to initial req




From noreply at github.com  Tue Jul 30 07:05:57 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 04:05:57 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] aa93d0: dialog: Fix data
 reload race conditions on startup
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/dfa863-51b5ec@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: aa93d0fbf369078f1c0e85fc10314fe7799aeca0
      https://github.com/OpenSIPS/opensips/commit/aa93d0fbf369078f1c0e85fc10314fe7799aeca0
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix data reload race conditions on startup

Since loading the data on child_init(), the load_dialog_info_from_db()
routines and rcv_cluster_event() routines could run in parallel, without
any synchronization on the dialog table, which could lead to duplicate
dialogs in the hash.


  Commit: f88c41064c9d895e52c6a8dac62867246da3b253
      https://github.com/OpenSIPS/opensips/commit/f88c41064c9d895e52c6a8dac62867246da3b253
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h

  Log Message:
  -----------
  dialog: Decrement dialog stats during post-sync cleanup

After a sync completes, it proceeds to clean up all dialogs loaded from
DB which did not match the data received via sync.  However, make sure
to also decrement the 'active' / 'early' dialog stats on each delete!


  Commit: 51b5ec3bac182104781a5e12287a217053170432
      https://github.com/OpenSIPS/opensips/commit/51b5ec3bac182104781a5e12287a217053170432
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix ref miscount during post-sync cleanup

The hash reference must only be decremented a single time during the
lifetime of a dialog.  Given that multiple pieces of code may attempt
to delete a dialog concurrently (e.g. a BIN "delete" packet and the
post-sync cleanup routine), the only way to guarantee a single decrement
of the hash ref is by using the dialog state machine transition.

Iff we're the ones to transition from ACK -> DELETED, we can (and MUST)
also decrement the hash reference.


Compare: https://github.com/OpenSIPS/opensips/compare/dfa863b9b2a9...51b5ec3bac18


From noreply at github.com  Tue Jul 30 09:04:43 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 06:04:43 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 65a9f5: dialog: Fix broken
 re-INVITE pinging after failover
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/51b5ec-65a9f5@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 65a9f51f1ee43e500d6fbe34c3a0e07722bd75b2
      https://github.com/OpenSIPS/opensips/commit/65a9f51f1ee43e500d6fbe34c3a0e07722bd75b2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken re-INVITE pinging after failover

The mandatory re-INVITE pinging data (SDP1, SDP2, ct1, ct2) was not
included in the BIN replication packets, so the pinging would stop
working once we'd failover to the backup box, in an active/backup
HA scenario.




From noreply at github.com  Tue Jul 30 09:39:02 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 06:39:02 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0b3ad4: clusterer: Make the
 data sync interface more robust
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/ade908-3b1c49@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0b3ad435be73d7ef49c511d2b70039c39a883135
      https://github.com/OpenSIPS/opensips/commit/0b3ad435be73d7ef49c511d2b70039c39a883135
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/clusterer/sync.c

  Log Message:
  -----------
  clusterer: Make the data sync interface more robust

This patch improves the data sync interface so that during a sync,
modules are no longer forced to micro-manage the data packets they are
receiving from the interface.  They can now freely abort the processing
of a sync chunk at any time, without disrupting the processing of the
entire sync packet (composed of many more of such data chunks).

Additionally, since the sync packet format has changed (an extra integer
is needed for each chunk in order to allow the "skip" mechanism), the
sync packet version is now bumped from 1 -> 2, in order to prevent any
compatibility issues with OpenSIPS nodes without this patch.


  Commit: a20a0acb5d9e8ef75d4cf2bb081ed1d5d259a3dd
      https://github.com/OpenSIPS/opensips/commit/a20a0acb5d9e8ef75d4cf2bb081ed1d5d259a3dd
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  clusterer: Enhance the versioning of sync packets

This commit adds an additional "version" field for the sync packets,
which are more complex than the other ones.  Since they contain
serialization logic from two different layers (clusterer + data module),
they should also contain two version fields, to allow each module to
discard data coming from an OpenSIPS donor node running on a differing
binary version.


  Commit: e33565342065298eeb542a73503f84402cc1076d
      https://github.com/OpenSIPS/opensips/commit/e33565342065298eeb542a73503f84402cc1076d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Revert the sync packet alignment code

... since now it is unnecessary, thanks to the sync layer enhancements.


  Commit: b8bde2f014e5b427c8517493a7ada16923d0928c
      https://github.com/OpenSIPS/opensips/commit/b8bde2f014e5b427c8517493a7ada16923d0928c
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-29 (Mon, 29 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Do not include early or ended dialogs


  Commit: aa93d0fbf369078f1c0e85fc10314fe7799aeca0
      https://github.com/OpenSIPS/opensips/commit/aa93d0fbf369078f1c0e85fc10314fe7799aeca0
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix data reload race conditions on startup

Since loading the data on child_init(), the load_dialog_info_from_db()
routines and rcv_cluster_event() routines could run in parallel, without
any synchronization on the dialog table, which could lead to duplicate
dialogs in the hash.


  Commit: f88c41064c9d895e52c6a8dac62867246da3b253
      https://github.com/OpenSIPS/opensips/commit/f88c41064c9d895e52c6a8dac62867246da3b253
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h

  Log Message:
  -----------
  dialog: Decrement dialog stats during post-sync cleanup

After a sync completes, it proceeds to clean up all dialogs loaded from
DB which did not match the data received via sync.  However, make sure
to also decrement the 'active' / 'early' dialog stats on each delete!


  Commit: 51b5ec3bac182104781a5e12287a217053170432
      https://github.com/OpenSIPS/opensips/commit/51b5ec3bac182104781a5e12287a217053170432
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix ref miscount during post-sync cleanup

The hash reference must only be decremented a single time during the
lifetime of a dialog.  Given that multiple pieces of code may attempt
to delete a dialog concurrently (e.g. a BIN "delete" packet and the
post-sync cleanup routine), the only way to guarantee a single decrement
of the hash ref is by using the dialog state machine transition.

Iff we're the ones to transition from ACK -> DELETED, we can (and MUST)
also decrement the hash reference.


  Commit: 65a9f51f1ee43e500d6fbe34c3a0e07722bd75b2
      https://github.com/OpenSIPS/opensips/commit/65a9f51f1ee43e500d6fbe34c3a0e07722bd75b2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken re-INVITE pinging after failover

The mandatory re-INVITE pinging data (SDP1, SDP2, ct1, ct2) was not
included in the BIN replication packets, so the pinging would stop
working once we'd failover to the backup box, in an active/backup
HA scenario.


  Commit: 3b1c49fdf99461594919fd9b5cf361fdb6e44372
      https://github.com/OpenSIPS/opensips/commit/3b1c49fdf99461594919fd9b5cf361fdb6e44372
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  Merge branch 'bugfix/fix-dialog-sync-bugs' into 2.4


Compare: https://github.com/OpenSIPS/opensips/compare/ade908fba2bf...3b1c49fdf994


From noreply at github.com  Tue Jul 30 09:40:22 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 06:40:22 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips]
Message-ID: <OpenSIPS/opensips/push/refs/heads/bugfix/fix-dialog-sync-bugs/65a9f5-000000@github.com>

  Branch: refs/heads/bugfix/fix-dialog-sync-bugs
  Home:   https://github.com/OpenSIPS/opensips


From noreply at github.com  Tue Jul 30 10:29:36 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 07:29:36 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 31352d: clusterer: Make the
 data sync interface more robust
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/9e951c-ba7516@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 31352d982b421f0c2a686d09bedf00a0bd1c44f2
      https://github.com/OpenSIPS/opensips/commit/31352d982b421f0c2a686d09bedf00a0bd1c44f2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/clusterer/sync.c

  Log Message:
  -----------
  clusterer: Make the data sync interface more robust

This patch improves the data sync interface so that during a sync,
modules are no longer forced to micro-manage the data packets they are
receiving from the interface.  They can now freely abort the processing
of a sync chunk at any time, without disrupting the processing of the
entire sync packet (composed of many more of such data chunks).

Additionally, since the sync packet format has changed (an extra integer
is needed for each chunk in order to allow the "skip" mechanism), the
sync packet version is now bumped from 1 -> 2, in order to prevent any
compatibility issues with OpenSIPS nodes without this patch.

(cherry picked from commit 0b3ad435be73d7ef49c511d2b70039c39a883135)


  Commit: 60bac3c3abc3fb2ba6a51f6659a9ac22a1eafddc
      https://github.com/OpenSIPS/opensips/commit/60bac3c3abc3fb2ba6a51f6659a9ac22a1eafddc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ul_cluster.c

  Log Message:
  -----------
  clusterer: Enhance the versioning of sync packets

This commit adds an additional "version" field for the sync packets,
which are more complex than the other ones.  Since they contain
serialization logic from two different layers (clusterer + data module),
they should also contain two version fields, to allow each module to
discard data coming from an OpenSIPS donor node running on a differing
binary version.

(cherry picked from commit a20a0acb5d9e8ef75d4cf2bb081ed1d5d259a3dd)


  Commit: 57bbad55c13e3156dcebf95bcd8adf8e52e97ecd
      https://github.com/OpenSIPS/opensips/commit/57bbad55c13e3156dcebf95bcd8adf8e52e97ecd
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_replication.h

  Log Message:
  -----------
  dialog replication: Prevent crashes due to differing packet versions

Commits 58dc435cb563 and 852e629e4700 changed the format of the dialog
binary data packets.  This would cause an immediate crash during a
rolling upgrade, since upon upgrading and restarting the backup node, it
would sync from or receive packets from a primary node running the older
version, with the previous data format.

This patch makes it so dialog packets which do not meet the expected
version are simply discarded, rather than being left to cause a crash.


  Commit: 82b87044e7d641ab307c8ceed65fc6c5fa0f710e
      https://github.com/OpenSIPS/opensips/commit/82b87044e7d641ab307c8ceed65fc6c5fa0f710e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Revert the sync packet alignment code

... since now it is unnecessary, thanks to the sync layer enhancements.

(cherry picked from commit e33565342065298eeb542a73503f84402cc1076d)


  Commit: 765c521e4ba041236f234cc186cc978247783dc7
      https://github.com/OpenSIPS/opensips/commit/765c521e4ba041236f234cc186cc978247783dc7
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Do not include early or ended dialogs

(cherry picked from commit b8bde2f014e5b427c8517493a7ada16923d0928c)


  Commit: a6345cc2d1ff801d51510001df04278b1ae12810
      https://github.com/OpenSIPS/opensips/commit/a6345cc2d1ff801d51510001df04278b1ae12810
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix data reload race conditions on startup

Since loading the data on child_init(), the load_dialog_info_from_db()
routines and rcv_cluster_event() routines could run in parallel, without
any synchronization on the dialog table, which could lead to duplicate
dialogs in the hash.

(cherry picked from commit aa93d0fbf369078f1c0e85fc10314fe7799aeca0)


  Commit: a468005019539d32613617e9bc549c1765e00764
      https://github.com/OpenSIPS/opensips/commit/a468005019539d32613617e9bc549c1765e00764
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h

  Log Message:
  -----------
  dialog: Decrement dialog stats during post-sync cleanup

After a sync completes, it proceeds to clean up all dialogs loaded from
DB which did not match the data received via sync.  However, make sure
to also decrement the 'active' / 'early' dialog stats on each delete!

(cherry picked from commit f88c41064c9d895e52c6a8dac62867246da3b253)


  Commit: ddcdab724f0da3ef1430353acceb8da686c8add1
      https://github.com/OpenSIPS/opensips/commit/ddcdab724f0da3ef1430353acceb8da686c8add1
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix ref miscount during post-sync cleanup

The hash reference must only be decremented a single time during the
lifetime of a dialog.  Given that multiple pieces of code may attempt
to delete a dialog concurrently (e.g. a BIN "delete" packet and the
post-sync cleanup routine), the only way to guarantee a single decrement
of the hash ref is by using the dialog state machine transition.

Iff we're the ones to transition from ACK -> DELETED, we can (and MUST)
also decrement the hash reference.

(cherry picked from commit 51b5ec3bac182104781a5e12287a217053170432)


  Commit: ba7516e92f4ba5ecf34234872d49ee2d07750888
      https://github.com/OpenSIPS/opensips/commit/ba7516e92f4ba5ecf34234872d49ee2d07750888
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken re-INVITE pinging after failover

The mandatory re-INVITE pinging data (SDP1, SDP2, ct1, ct2) was not
included in the BIN replication packets, so the pinging would stop
working once we'd failover to the backup box, in an active/backup
HA scenario.

(cherry picked from commit 65a9f51f1ee43e500d6fbe34c3a0e07722bd75b2)


Compare: https://github.com/OpenSIPS/opensips/compare/9e951c904f70...ba7516e92f4b


From noreply at github.com  Tue Jul 30 10:41:20 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 07:41:20 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 66f3d9: dialog replication:
 Fix a re-INVITE pinging shm leak
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/3b1c49-66f3d9@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 66f3d97ce3ee7e33d09b174de0b852c677c10f07
      https://github.com/OpenSIPS/opensips/commit/66f3d97ce3ee7e33d09b174de0b852c677c10f07
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog replication: Fix a re-INVITE pinging shm leak

In commit 65a9f51f1ee, we must make sure not to overwrite any already
existing SDP/contact pointers in each leg.




From noreply at github.com  Tue Jul 30 10:57:03 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 07:57:03 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9072fe: cachedb_local: Fix
	compile error
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/ba7516-9072fe@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9072fe1513506c548e6720bc80b7d7db66ab1ed2
      https://github.com/OpenSIPS/opensips/commit/9072fe1513506c548e6720bc80b7d7db66ab1ed2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local_replication.c

  Log Message:
  -----------
  cachedb_local: Fix compile error




From noreply at github.com  Tue Jul 30 11:01:43 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 08:01:43 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1f7ea9: clusterer: Make the
 data sync interface more robust
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ff245d-aaedaa@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1f7ea9613cb855f51b5d9877752494a15f2afbbf
      https://github.com/OpenSIPS/opensips/commit/1f7ea9613cb855f51b5d9877752494a15f2afbbf
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/clusterer/clusterer.c
    M modules/clusterer/sync.c

  Log Message:
  -----------
  clusterer: Make the data sync interface more robust

This patch improves the data sync interface so that during a sync,
modules are no longer forced to micro-manage the data packets they are
receiving from the interface.  They can now freely abort the processing
of a sync chunk at any time, without disrupting the processing of the
entire sync packet (composed of many more of such data chunks).

Additionally, since the sync packet format has changed (an extra integer
is needed for each chunk in order to allow the "skip" mechanism), the
sync packet version is now bumped from 1 -> 2, in order to prevent any
compatibility issues with OpenSIPS nodes without this patch.

(cherry picked from commit 0b3ad435be73d7ef49c511d2b70039c39a883135)

Conflicts:
    modules/clusterer/sync.c


  Commit: be7265f11da51717c064fa168f489d7e712f6bb0
      https://github.com/OpenSIPS/opensips/commit/be7265f11da51717c064fa168f489d7e712f6bb0
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M bin_interface.c
    M bin_interface.h
    M modules/clusterer/api.h
    M modules/clusterer/clusterer.h
    M modules/clusterer/sync.c
    M modules/clusterer/sync.h
    M modules/dialog/dlg_replication.c
    M modules/usrloc/ul_cluster.c

  Log Message:
  -----------
  clusterer: Enhance the versioning of sync packets

This commit adds an additional "version" field for the sync packets,
which are more complex than the other ones.  Since they contain
serialization logic from two different layers (clusterer + data module),
they should also contain two version fields, to allow each module to
discard data coming from an OpenSIPS donor node running on a differing
binary version.

(cherry picked from commit a20a0acb5d9e8ef75d4cf2bb081ed1d5d259a3dd)
(cherry picked from commit 60bac3c3abc3fb2ba6a51f6659a9ac22a1eafddc)


  Commit: d18089d89fbbeb3a2330feb89dff453999cd0886
      https://github.com/OpenSIPS/opensips/commit/d18089d89fbbeb3a2330feb89dff453999cd0886
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/cachedb_local/cachedb_local_replication.c

  Log Message:
  -----------
  cachedb_local: Fix compile error

(cherry picked from commit 9072fe1513506c548e6720bc80b7d7db66ab1ed2)


  Commit: f2956e9f4d17366e733e6c57871890d873843112
      https://github.com/OpenSIPS/opensips/commit/f2956e9f4d17366e733e6c57871890d873843112
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_replication.h

  Log Message:
  -----------
  dialog replication: Prevent crashes due to differing packet versions

Commits 58dc435cb563 and 852e629e4700 changed the format of the dialog
binary data packets.  This would cause an immediate crash during a
rolling upgrade, since upon upgrading and restarting the backup node, it
would sync from or receive packets from a primary node running the older
version, with the previous data format.

This patch makes it so dialog packets which do not meet the expected
version are simply discarded, rather than being left to cause a crash.

(cherry picked from commit 57bbad55c13e3156dcebf95bcd8adf8e52e97ecd)


  Commit: 616c989e44a3665b34aaf2547d495e30f20dd6fa
      https://github.com/OpenSIPS/opensips/commit/616c989e44a3665b34aaf2547d495e30f20dd6fa
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog replication: Revert the sync packet alignment code

... since now it is unnecessary, thanks to the sync layer enhancements.

(cherry picked from commit e33565342065298eeb542a73503f84402cc1076d)
(cherry picked from commit 82b87044e7d641ab307c8ceed65fc6c5fa0f710e)


  Commit: 4c749d6e79a21a51f9e16e17419424980e5c43d5
      https://github.com/OpenSIPS/opensips/commit/4c749d6e79a21a51f9e16e17419424980e5c43d5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Do not include early or ended dialogs

(cherry picked from commit b8bde2f014e5b427c8517493a7ada16923d0928c)
(cherry picked from commit 765c521e4ba041236f234cc186cc978247783dc7)


  Commit: b26d59e30c2c8df7b2f274a18e9ed3fb2b5a16fb
      https://github.com/OpenSIPS/opensips/commit/b26d59e30c2c8df7b2f274a18e9ed3fb2b5a16fb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix data reload race conditions on startup

Since loading the data on child_init(), the load_dialog_info_from_db()
routines and rcv_cluster_event() routines could run in parallel, without
any synchronization on the dialog table, which could lead to duplicate
dialogs in the hash.

(cherry picked from commit aa93d0fbf369078f1c0e85fc10314fe7799aeca0)
(cherry picked from commit a6345cc2d1ff801d51510001df04278b1ae12810)

 Conflicts:
	modules/dialog/dlg_db_handler.c


  Commit: 809746f160292240fd7a101492c5a434cd35e00b
      https://github.com/OpenSIPS/opensips/commit/809746f160292240fd7a101492c5a434cd35e00b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.h

  Log Message:
  -----------
  dialog: Decrement dialog stats during post-sync cleanup

After a sync completes, it proceeds to clean up all dialogs loaded from
DB which did not match the data received via sync.  However, make sure
to also decrement the 'active' / 'early' dialog stats on each delete!

(cherry picked from commit f88c41064c9d895e52c6a8dac62867246da3b253)
(cherry picked from commit a468005019539d32613617e9bc549c1765e00764)


  Commit: d37170707cceba961cf92aa5af10c1ff8e377b97
      https://github.com/OpenSIPS/opensips/commit/d37170707cceba961cf92aa5af10c1ff8e377b97
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix ref miscount during post-sync cleanup

The hash reference must only be decremented a single time during the
lifetime of a dialog.  Given that multiple pieces of code may attempt
to delete a dialog concurrently (e.g. a BIN "delete" packet and the
post-sync cleanup routine), the only way to guarantee a single decrement
of the hash ref is by using the dialog state machine transition.

Iff we're the ones to transition from ACK -> DELETED, we can (and MUST)
also decrement the hash reference.

(cherry picked from commit 51b5ec3bac182104781a5e12287a217053170432)
(cherry picked from commit ddcdab724f0da3ef1430353acceb8da686c8add1)


  Commit: aaedaace9032bb7b4c0d9286a59c2ca5702d91e5
      https://github.com/OpenSIPS/opensips/commit/aaedaace9032bb7b4c0d9286a59c2ca5702d91e5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_db_handler.h
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog: Fix broken re-INVITE pinging after failover

The mandatory re-INVITE pinging data (SDP1, SDP2, ct1, ct2) was not
included in the BIN replication packets, so the pinging would stop
working once we'd failover to the backup box, in an active/backup
HA scenario.

(cherry picked from commit 65a9f51f1ee43e500d6fbe34c3a0e07722bd75b2)
(cherry picked from commit ba7516e92f4ba5ecf34234872d49ee2d07750888)


Compare: https://github.com/OpenSIPS/opensips/compare/ff245d48e9ac...aaedaace9032


From noreply at github.com  Tue Jul 30 11:52:33 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 08:52:33 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ece8e0: utils: Add a Wireshark
 BIN dissector for 2.4+ packets
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/aaedaa-ece8e0@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ece8e08afcf6e7367b5e759f9441b22303b93d93
      https://github.com/OpenSIPS/opensips/commit/ece8e08afcf6e7367b5e759f9441b22303b93d93
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    A utils/wireshark/wsgd-dissector/README.md
    A utils/wireshark/wsgd-dissector/opensips.fdesc
    A utils/wireshark/wsgd-dissector/opensips.wsgd

  Log Message:
  -----------
  utils: Add a Wireshark BIN dissector for 2.4+ packets

Not all packets are supported in this initial release.  So, far we have:

    * dialog replication packets (2.4+)
    * dialog profiles broadcast packets (2.4+)
    * dialog sync packets (2.4+)
    * ratelimit pipes broadcast packets (2.4+)
    * usrloc contact update packets (2.4+)

Still plenty of work to be done, but this is a solid stepping stone!
See the README for installation tips.




From noreply at github.com  Tue Jul 30 11:56:25 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 08:56:25 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3119f6: opensips.wsgd: Update
	README.md
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/ece8e0-3119f6@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3119f66b0881b8e7a73c5a5c8b26da87276a2917
      https://github.com/OpenSIPS/opensips/commit/3119f66b0881b8e7a73c5a5c8b26da87276a2917
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M utils/wireshark/wsgd-dissector/README.md

  Log Message:
  -----------
  opensips.wsgd: Update README.md




From noreply at github.com  Tue Jul 30 13:56:31 2019
From: noreply at github.com (=?UTF-8?B?VmxhZCBQxIN0cmHImWN1?=)
Date: Tue, 30 Jul 2019 10:56:31 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 525b30: port core script
 functions to the same interface a...
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/3119f6-525b30@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 525b30a2a08e4c960e2448d746d5926cca33cbe1
      https://github.com/OpenSIPS/opensips/commit/525b30a2a08e4c960e2448d746d5926cca33cbe1
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M action.c
    M action.h
    M cfg.lex
    M cfg.y
    A cmds.c
    A cmds.h
    A core_cmds.c
    M modules/avpops/avpops_impl.c
    M modules/carrierroute/route_func.c
    M modules/dispatcher/dispatch.c
    M modules/drouting/drouting.c
    M modules/lua/sipapi.c
    M modules/perl/opensipsxs.xs
    M modules/python/python_msgobj.c
    M modules/textops/textops.c
    M msg_translator.c
    M parser/msg_parser.c
    M parser/msg_parser.h
    M pvar.c
    M route.c
    M route_struct.c
    M route_struct.h
    M sr_module.c
    M sr_module.h
    M ut.h

  Log Message:
  -----------
  port core script functions to the same interface as module functions




From noreply at github.com  Tue Jul 30 14:14:23 2019
From: noreply at github.com (Liviu Chircu)
Date: Tue, 30 Jul 2019 11:14:23 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9cd4be: cfg syntax: Disallow
 esoteric if/while syntax
Message-ID: <OpenSIPS/opensips/push/refs/heads/feature/improve-cfg-syntax/71fef1-6a97f6@github.com>

  Branch: refs/heads/feature/improve-cfg-syntax
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9cd4be4a2abf29f8eee673f56c048401bed9a511
      https://github.com/OpenSIPS/opensips/commit/9cd4be4a2abf29f8eee673f56c048401bed9a511
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M cfg.y

  Log Message:
  -----------
  cfg syntax: Disallow esoteric if/while syntax

The opensips.cfg no longer accepts constructs such as:

    if $var(foo) {
        ...
    }

    if [ $var(foo) == 2 ]
        xlog("bar\n");

    while $var(foo) < 10 {
	...
    }

... and forces the condition to be paranthesized.  Aside from any
consistency considerations, this change also allows us to disambiguate
the if-if-else shift/reduce conflicts of the grammar, which were so far
masked using the "expect 2" rule.


  Commit: 1a4498b8d133db2b8d3ecdc9e36d99543edb08c8
      https://github.com/OpenSIPS/opensips/commit/1a4498b8d133db2b8d3ecdc9e36d99543edb08c8
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M cfg.y

  Log Message:
  -----------
  cfg syntax:  Enhance the 'return' statement

The opensips.cfg now additionally allows syntax such as:

    * return 1;
    * return +2;
    * return -3;
    * return $var(foo);


  Commit: 6a97f68100e669cf6ceec53c073351d0bd07ebe2
      https://github.com/OpenSIPS/opensips/commit/6a97f68100e669cf6ceec53c073351d0bd07ebe2
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-30 (Tue, 30 Jul 2019)

  Changed paths:
    M action.c
    M route_struct.h

  Log Message:
  -----------
  cfg syntax: Fix all complex assignment operators

The opensips.cfg now fully supports the non-trivial assignment
operators, such as: +=, -=, *=, /=, %=, &=, |= and ^=.  Syntactially,
they were supported until now, but were actually unimplemented (more
precisely, they were equivalent to the "=" operator).

Only the "+=" operator can also work with strings, for example:

    $var(x) = "foo";
    $var(x) += "-bar"; # now contains "foo-bar"

    $rU = "+40";
    $rU += "729" + "884950"; # now contains "+40729884950"

All of them (including "+="), work with integers:

    $var(i) = 0;
    $var(i) += 2; # 2
    $var(i) *= 3; # 6
    $var(i) /= 6; # 1
    ...


Compare: https://github.com/OpenSIPS/opensips/compare/71fef1149516...6a97f68100e6


From noreply at github.com  Wed Jul 31 03:18:53 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 00:18:53 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 509e18: dialog sync: Fix some
 subtle backup box restart bugs
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/66f3d9-509e18@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 509e18113be5f217e6f421c97d2545239d996729
      https://github.com/OpenSIPS/opensips/commit/509e18113be5f217e6f421c97d2545239d996729
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix some subtle backup box restart bugs

In an HA setup, following a restart of the backup box, there would be:

    * an extra ref for dialogs loaded from DB but not confirmed through
      sync, leading to a few hanging state 5 dialogs (added in 51b5ec3b)
    * too little 'active_dlgs' stat decrements during the above
      corner-cases, since update_dlg_stats() ignores state 5 dialogs




From noreply at github.com  Wed Jul 31 03:19:11 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 00:19:11 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 931a7a: dialog sync: Fix some
 subtle backup box restart bugs
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/9072fe-931a7a@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 931a7a1f5cb3b6dabe759bc526a6f6a60ba606a6
      https://github.com/OpenSIPS/opensips/commit/931a7a1f5cb3b6dabe759bc526a6f6a60ba606a6
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix some subtle backup box restart bugs

In an HA setup, following a restart of the backup box, there would be:

    * an extra ref for dialogs loaded from DB but not confirmed through
      sync, leading to a few hanging state 5 dialogs (added in 51b5ec3b)
    * too little 'active_dlgs' stat decrements during the above
      corner-cases, since update_dlg_stats() ignores state 5 dialogs

(cherry picked from commit 509e18113be5f217e6f421c97d2545239d996729)




From noreply at github.com  Wed Jul 31 03:19:36 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 00:19:36 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] db2fc7: dialog sync: Fix some
 subtle backup box restart bugs
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/525b30-db2fc7@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: db2fc72ddcdfe6050a0f2b516754741d34bf7c68
      https://github.com/OpenSIPS/opensips/commit/db2fc72ddcdfe6050a0f2b516754741d34bf7c68
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_replication.c

  Log Message:
  -----------
  dialog sync: Fix some subtle backup box restart bugs

In an HA setup, following a restart of the backup box, there would be:

    * an extra ref for dialogs loaded from DB but not confirmed through
      sync, leading to a few hanging state 5 dialogs (added in 51b5ec3b)
    * too little 'active_dlgs' stat decrements during the above
      corner-cases, since update_dlg_stats() ignores state 5 dialogs

(cherry picked from commit 509e18113be5f217e6f421c97d2545239d996729)




From noreply at github.com  Wed Jul 31 04:47:45 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 01:47:45 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6094ab: acc, alias_db,
 auth_db: Align docs to latest changes
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/931a7a-6094ab@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6094ab19fa4737c8562a7d6f7033ad78e77f135c
      https://github.com/OpenSIPS/opensips/commit/6094ab19fa4737c8562a7d6f7033ad78e77f135c
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/acc/doc/acc_admin.xml
    M modules/alias_db/doc/alias_db_admin.xml
    M modules/auth_db/doc/auth_db_admin.xml

  Log Message:
  -----------
  acc, alias_db, auth_db: Align docs to latest changes

(cherry picked from commit a8fe40dcb8f39fa968e8b8c51b31ba8168f81310)




From noreply at github.com  Wed Jul 31 09:22:15 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 06:22:15 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 57cf12: dialog profiles: Fix
 deadlock during startup
Message-ID: <OpenSIPS/opensips/push/refs/heads/master/db2fc7-57cf12@github.com>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 57cf12dfa75a27a25f6c1dd50daa0cbb662e2ef0
      https://github.com/OpenSIPS/opensips/commit/57cf12dfa75a27a25f6c1dd50daa0cbb662e2ef0
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog profiles: Fix deadlock during startup

This updates commit b26d59e30c2c, which introduced a deadlock while
loading dialogs from DB which also contain profiles.




From noreply at github.com  Wed Jul 31 09:22:33 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 06:22:33 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7cf0ab: dialog profiles: Fix
 deadlock during startup
Message-ID: <OpenSIPS/opensips/push/refs/heads/3.0/6094ab-7cf0ab@github.com>

  Branch: refs/heads/3.0
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7cf0ab30fb803828edc07360d02a5fbf5ce4d540
      https://github.com/OpenSIPS/opensips/commit/7cf0ab30fb803828edc07360d02a5fbf5ce4d540
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog profiles: Fix deadlock during startup

This updates commit b26d59e30c2c, which introduced a deadlock while
loading dialogs from DB which also contain profiles.

(cherry picked from commit 57cf12dfa75a27a25f6c1dd50daa0cbb662e2ef0)




From noreply at github.com  Wed Jul 31 09:22:47 2019
From: noreply at github.com (Liviu Chircu)
Date: Wed, 31 Jul 2019 06:22:47 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 05d4a9: dialog profiles: Fix
 deadlock during startup
Message-ID: <OpenSIPS/opensips/push/refs/heads/2.4/509e18-05d4a9@github.com>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 05d4a9a1108f701b08c6b3eb83e97b819e34d03d
      https://github.com/OpenSIPS/opensips/commit/05d4a9a1108f701b08c6b3eb83e97b819e34d03d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2019-07-31 (Wed, 31 Jul 2019)

  Changed paths:
    M modules/dialog/dlg_db_handler.c

  Log Message:
  -----------
  dialog profiles: Fix deadlock during startup

This updates commit b26d59e30c2c, which introduced a deadlock while
loading dialogs from DB which also contain profiles.

(cherry picked from commit 57cf12dfa75a27a25f6c1dd50daa0cbb662e2ef0)




From denys.pozniak at gmail.com  Wed Jul 31 10:21:06 2019
From: denys.pozniak at gmail.com (Denys Pozniak)
Date: Wed, 31 Jul 2019 17:21:06 +0300
Subject: [OpenSIPS-Devel] opensips[14035]: segfault at d4 ip
 00007f3fd740c059 sp 00007ffea3b54050 error 4 in
 dispatcher.so[7f3fd73f2000+24000]
In-Reply-To: <CA+x3AxpKC2_mh2-_-4AYZ3PNrJRadX9cCHjLTGvw+Yz1sE=AMA@mail.gmail.com>
References: <CA+x3AxpKC2_mh2-_-4AYZ3PNrJRadX9cCHjLTGvw+Yz1sE=AMA@mail.gmail.com>
Message-ID: <CA+x3Axr2NE52SQuYEUEefdq8enOX7uUeSX_9FctBRPQUc9ukYg@mail.gmail.com>

Looks like ds_next_dst() in failure_route leads to crash. Also, I
use topology_hiding("CU")

ср, 31 июл. 2019 г. в 15:39, Denys Pozniak <denys.pozniak at gmail.com>:

> Hello!
>
> Please check the source of the crash. Bt full is in the attachment.
>
> Jul 27 19:22:15 localhost kernel: opensips[14035]: segfault at d4 ip
> 00007f3fd740c059 sp 00007ffea3b54050 error 4 in
> dispatcher.so[7f3fd73f2000+24000]
> Jul 27 19:22:15 localhost /usr/sbin/opensips[14035]:
> CRITICAL:core:sig_usr: segfault in process pid: 14035, id: 6
> Jul 27 19:22:15 localhost journal: Suppressed 1888 messages from
> /system.slice/opensips.service
> Jul 27 19:22:15 localhost /usr/sbin/opensips[14029]:
> INFO:core:handle_sigs: child process 14035 exited by a signal 11
> Jul 27 19:22:15 localhost /usr/sbin/opensips[14029]:
> INFO:core:handle_sigs: core was generated
> Jul 27 19:22:15 localhost /usr/sbin/opensips[14029]:
> INFO:core:handle_sigs: terminating due to SIGCHLD
>
>
> [root at localhost /]# opensips -V
> version: opensips 3.0.0 (x86_64/linux)
> flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC,
> Q_MALLOC, F_MALLOC, HP_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT
> ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16,
> MAX_URI_SIZE 1024, BUF_SIZE 65535
> poll method support: poll, epoll, sigio_rt, select.
> main.c compiled on 13:02:44 May 30 2019 with gcc 4.8.5
>
> --
>
> BR,
> Denys Pozniak
>
>
>

-- 

BR,
Denys Pozniak
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20190731/0e5fc76f/attachment.html>