[OpenSIPS-Devel] [OpenSIPS/opensips] fd3a6e: presence: MI flush subs_phtable_list only if there...

Bogdan Andrei IANCU noreply at github.com
Tue Feb 12 03:33:04 EST 2019


  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: fd3a6e4a71674c626c8b7f97f9892d08e48d0f7f
      https://github.com/OpenSIPS/opensips/commit/fd3a6e4a71674c626c8b7f97f9892d08e48d0f7f
  Author: Walter Doekes <walter+github at wjd.nu>
  Date:   2019-02-12 (Tue, 12 Feb 2019)

  Changed paths:
    M modules/presence/presence.c

  Log Message:
  -----------
  presence: MI flush subs_phtable_list only if there is data

Also flush pres_phtable_list after more than 50 entries.

Corrects problem with (soon to be removed) mi-datagram where flushing
after 0 bytes creates a negative response.


  Commit: fd75d765e7bf61ad76848d4277c9b7ff88aa3eb6
      https://github.com/OpenSIPS/opensips/commit/fd75d765e7bf61ad76848d4277c9b7ff88aa3eb6
  Author: Walter Doekes <walter+github at wjd.nu>
  Date:   2019-02-12 (Tue, 12 Feb 2019)

  Changed paths:
    M modules/mi_datagram/mi_datagram_writer.c

  Log Message:
  -----------
  mi_datagram: Correct leftover bytes count

Before this fix, a flush_mi_tree without new data would decrement the
bytes-left for no reason, and after a bunch of these, we'd run out of space.

Errors like these would flood the logs:

    failed to write -line too long!
    failed to write - EOC does not fit in!

Additionally, mi_datagram_write_node would decrease the length by more than
necessary, causing less than half the full size to fit in the response.

(dtgram->len is "bytes left", not "total length")


  Commit: a7eeaf1873d9d76309975aaf7b4f4ad02e435941
      https://github.com/OpenSIPS/opensips/commit/a7eeaf1873d9d76309975aaf7b4f4ad02e435941
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2019-02-12 (Tue, 12 Feb 2019)

  Changed paths:
    M modules/mi_datagram/mi_datagram_writer.c
    M modules/presence/presence.c

  Log Message:
  -----------
  Merge pull request #1614 from wdoekes/wjd-correct-presence-list-mi-flush-2.4

Correct presence list MI flush in OpenSIPS 2.4


Compare: https://github.com/OpenSIPS/opensips/compare/d57ce2d415fd...a7eeaf1873d9



More information about the Devel mailing list