[OpenSIPS-Devel] [OpenSIPS/opensips] 3aa559: acc: use the dependencies function to register dlg...

[Dan Pascu]

After this "fix" I get:

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x0000000000000000 in ?? ()
(gdb) bt
#0  0x0000000000000000 in ?? ()
#1  0x00007fd811646ca8 in acc_deps () at acc_mod.c:260
#2  0x0000563d2e6f40b6 in init_modules_deps () at sr_module.c:715
#3  0x0000563d2e6efab9 in main (argc=15, argv=0x7fffe26d6258) at main.c:1420
(gdb) frame 1
#1  0x00007fd811646ca8 in acc_deps () at acc_mod.c:260
260		acc_dlg_ctx_idx = dlg_api.dlg_ctx_register_ptr(unref_acc_ctx);
(gdb) list
255		},
256	};
257
258	static int acc_deps(void)
259	{
260		acc_dlg_ctx_idx = dlg_api.dlg_ctx_register_ptr(unref_acc_ctx);
261		return 0;
262	}
263
264	struct module_exports exports= {
(gdb) print dlg_api
$1 = {register_dlgcb = 0x0, create_dlg = 0x0, get_dlg = 0x0, add_profiles = 0x0, search_profile = 0x0,
  set_profile = 0x0, unset_profile = 0x0, get_profile_size = 0x0, store_dlg_value = 0x0, fetch_dlg_value = 0x0,
  terminate_dlg = 0x0, match_dialog = 0x0, validate_dialog = 0x0, fix_route_dialog = 0x0, set_mod_flag = 0x0,
  is_mod_flag_set = 0x0, ref_dlg = 0x0, unref_dlg = 0x0, get_rr_param = 0x0, dlg_ctx_register_int = 0x0,
  dlg_ctx_register_str = 0x0, dlg_ctx_register_ptr = 0x0, dlg_ctx_put_int = 0x0, dlg_ctx_put_str = 0x0,
  dlg_ctx_put_ptr = 0x0, dlg_ctx_get_int = 0x0, dlg_ctx_get_str = 0x0, dlg_ctx_get_ptr = 0x0}
(gdb)


Are things tested anymore before being committed? And to think that I was worried to push a fix because I wasn't able to test it...


On 23 Aug 2019, at 14:24, Răzvan Crainea wrote:

>  Branch: refs/heads/master
>  Home:   https://github.com/OpenSIPS/opensips
>  Commit: 3aa5596c5584141f0256959f18b606c256a48092
>      https://github.com/OpenSIPS/opensips/commit/3aa5596c5584141f0256959f18b606c256a48092
>  Author: Razvan Crainea <razvan at opensips.org>
>  Date:   2019-08-23 (Fri, 23 Aug 2019)
> 
>  Changed paths:
>    M modules/acc/acc_logic.c
>    M modules/acc/acc_mod.c
> 
>  Log Message:
>  -----------
>  acc: use the dependencies function to register dlg ctx
> 
> This is a temporary fix, until we figure out a way of registering the
> dlg ctx index only if cdr is used.
> 
> 
> 
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel


--
Dan