[OpenSIPS-Devel] [OpenSIPS/opensips] 5bbebf: dialog: Fix two referencing issues
Liviu Chircu
noreply at github.com
Mon Aug 12 07:19:10 EDT 2019
Branch: refs/heads/3.0
Home: https://github.com/OpenSIPS/opensips
Commit: 5bbebf682657ce0e162645ae593b503b6995bb27
https://github.com/OpenSIPS/opensips/commit/5bbebf682657ce0e162645ae593b503b6995bb27
Author: Liviu Chircu <liviu at opensips.org>
Date: 2019-08-12 (Mon, 12 Aug 2019)
Changed paths:
M modules/dialog/dlg_replication.c
Log Message:
-----------
dialog: Fix two referencing issues
* an unsafe referencing bug, introduced in 65a9f51f1ee. As long as
the dialog is not locked, we _must not_ call ref_dlg_unsafe().
This unsafe increment operation could lead to occasionally missing
references, possibly even a crash.
* a long-standing bug, where read_dialog_profiles() is invoked on
replicated create/update events with a dialog that has no extra
reference, so it could very well be a lingering/freed pointer.
Under the right conditions, this too could lead to a crash.
(cherry picked from commit 0e85dd69f9d9ead1363e2afe8f6b4f0d3293f4db)
More information about the Devel
mailing list