[OpenSIPS-Devel] [OpenSIPS/opensips] 525b30: port core script functions to the same interface a...

[Vlad Patrascu]

Hi Dan,

No, you don't have to quote the flag name in the global setting.

All the changes regarding the core functions only impact their 
signatures and the way parameters are passed. I will update the 
documentation as soon as possible.

Regards,

Vlad Patrascu
OpenSIPS Developer
http://www.opensips-solutions.com

On 08/05/2019 08:29 PM, Dan Pascu wrote:
> Now that all the functions dealing with flags received the flag name quoted like:
>
> setbflag("TCP_NO_NEW_CONN");
>
> do we also need to specify the flag name quoted in global settings? more specifically do I need to change this global setting to quote the flag name?
>
> tcp_no_new_conn_bflag = TCP_NO_NEW_CONN
>
>
> On 2 Aug 2019, at 10:41, Bogdan-Andrei Iancu wrote:
>
>> Hi Maxim,
>>
>> point taken. Vlad will start working on the migration doc next week asap. In the mean while, if you have any issues with any of the functions, just let me know, I will try to help you.
>> In regards the rewriteport() - I guess it was dropped (I do not find it in the exported list) as it can simply be replaced with "$rp = value"
>>
>> Thanks and regards,
>>   
>> Bogdan-Andrei Iancu
>>
>> OpenSIPS Founder and Developer
>>    
>> https://www.opensips-solutions.com
>>
>> OpenSIPS Summit 2019
>>    
>> https://www.opensips.org/events/Summit-2019Amsterdam/
>> On 08/01/2019 08:13 PM, Maxim Sobolev wrote:
>>> Hi Vlad, this is rather invasive change which is going to affect lot (most?) of OpenSIPS users. While understanding the value of re-organization I am having troubles now what needs to be done to get those functions (such as rewriteport() for example) to work properly.  Please supply some documentation for conversion ASAP. In general it would be nice to have some short reference in the commit message itself, so anyone who follows master branch (like we do) does not have to look elsewhere.
>>>
>>> Thanks!
>>>
>>> -Max
>>>
>>> On Tue, Jul 30, 2019 at 10:57 AM Vlad Pătrașcu <noreply at github.com> wrote:
>>>    Branch: refs/heads/master
>>>    Home:   https://github.com/OpenSIPS/opensips
>>>    Commit: 525b30a2a08e4c960e2448d746d5926cca33cbe1
>>>        https://github.com/OpenSIPS/opensips/commit/525b30a2a08e4c960e2448d746d5926cca33cbe1
>>>    Author: Vlad Patrascu <vladp at opensips.org>
>>>    Date:   2019-07-30 (Tue, 30 Jul 2019)
>>>
>>>    Changed paths:
>>>      M action.c
>>>      M action.h
>>>      M cfg.lex
>>>      M cfg.y
>>>      A cmds.c
>>>      A cmds.h
>>>      A core_cmds.c
>>>      M modules/avpops/avpops_impl.c
>>>      M modules/carrierroute/route_func.c
>>>      M modules/dispatcher/dispatch.c
>>>      M modules/drouting/drouting.c
>>>      M modules/lua/sipapi.c
>>>      M modules/perl/opensipsxs.xs
>>>      M modules/python/python_msgobj.c
>>>      M modules/textops/textops.c
>>>      M msg_translator.c
>>>      M parser/msg_parser.c
>>>      M parser/msg_parser.h
>>>      M pvar.c
>>>      M route.c
>>>      M route_struct.c
>>>      M route_struct.h
>>>      M sr_module.c
>>>      M sr_module.h
>>>      M ut.h
>>>
>>>    Log Message:
>>>    -----------
>>>    port core script functions to the same interface as module functions
>>>
>>>
>>>
>>> _______________________________________________
>>> Devel mailing list
>>> Devel at lists.opensips.org
>>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>>
>>>
>>> -- 
>>> Maksym Sobolyev
>>> Sippy Software, Inc.
>>> Internet Telephony (VoIP) Experts
>>> Tel (Canada): +1-778-783-0474
>>> Tel (Toll-Free): +1-855-747-7779
>>> Fax: +1-866-857-6942
>>> Web: http://www.sippysoft.com
>>> MSN: sales at sippysoft.com
>>> Skype: SippySoft
>> _______________________________________________
>> Devel mailing list
>> Devel at lists.opensips.org
>> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
> --
> Dan
>
>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel