[OpenSIPS-Devel] [OpenSIPS/opensips] 8e4806: rest_client: Add new error return codes for all tr...

[Liviu Chircu]

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8e480668e87e718c1c5ae00b8763ce3ea30e0ab4
      https://github.com/OpenSIPS/opensips/commit/8e480668e87e718c1c5ae00b8763ce3ea30e0ab4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rest_client/rest_cb.c
    M modules/rest_client/rest_client.c
    M modules/rest_client/rest_methods.c
    M modules/rest_client/rest_methods.h

  Log Message:
  -----------
  rest_client: Add new error return codes for all transfers

     1: success
    -1: connection refused
    -2: connection timeout (i.e. 'connection_timeout' was hit)
    -3: transfer timeout (i.e. 'curl_timeout' was hit)
    -10: internal error (i.e. "I hope OpenSIPS is still running")

This patch also includes additional fixes related to error handling:
    * fix undetected error conditions on "async-but-blocking" transfers
       (these transfers happen once you hit 'max_async_transfers')

    * fix a bunch of code paths where the rest_() functions return
       success despite not being able to set one or more output pvars

    * never abort(), regardless of what libcurl says

(cherry picked from commit 04e2ef3d091bba7a237589be03f53f27deabf413)


  Commit: f3e73546b570c02bef69b03d421732f40c12091d
      https://github.com/OpenSIPS/opensips/commit/f3e73546b570c02bef69b03d421732f40c12091d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rest_client/doc/rest_client.xml
    M modules/rest_client/doc/rest_client_admin.xml
    A modules/rest_client/doc/rest_return_codes.xml

  Log Message:
  -----------
  rest_client: Update documentation

(cherry picked from commit 59da2616ada4457447a5f816b1620e59577fffad)


  Commit: 98706f3c36350589869fb8aa548c8a7f20e48d56
      https://github.com/OpenSIPS/opensips/commit/98706f3c36350589869fb8aa548c8a7f20e48d56
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Fix warnings with clang 5.0

(cherry picked from commit 6126c2039e9ed6d2820e1dd3a66c97af4087da08)


Compare: https://github.com/OpenSIPS/opensips/compare/1fd7e2eb0197...98706f3c3635
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.