[OpenSIPS-Devel] [OpenSIPS/opensips] c037e1: dialog: fix behavior of backup node when replicati...

Vlad Patrascu vladp at opensips.org
Fri Nov 2 07:46:55 EDT 2018

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c037e104f1bf384818e021280b0c8d981fe5e41c
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c
    M modules/cgrates/cgrates_acc.c
    M modules/dialog/dialog.c
    M modules/dialog/dlg_cb.c
    M modules/dialog/dlg_cb.h
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.c

  Log Message:
  dialog: fix behavior of backup node when replicating dialogs

The node that has a backup state for the sharing tag of a dialog
was incorrectly:
* skipping the replication of all dialog events
* bypassing all registered DLGCB_TERMINATED and DLGCB_EXPIRED callbacks

This behavior was causing issues when replies and sequential requests did
arrive on the backup node. Eg. unable to match and fix the BYE for an
existing topology hiding dialog.

After this fix, only the acc and cgrates modules will skip all actions in the
above mentioned callbacks if the sharing tag is backup.

(cherry picked from commit 596c39d905dec66c87cf04ac43cac63921c1b7b8)

  Commit: c60b9495805a36abc80048621f082523e516db87
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  dialog: do not unnecessarily fetch sharing tag state

(cherry picked from commit f511f1c73dcdd64fdebe71205f5009ebf2da149e)

Compare: https://github.com/OpenSIPS/opensips/compare/1cd794c4dedf...c60b9495805a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

More information about the Devel mailing list