From liviu at opensips.org  Thu Nov  1 05:49:51 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 01 Nov 2018 02:49:51 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9094b5: HP_MALLOC: Recover
 from double pointer free
Message-ID: <5bdacc3f62299_78412ad55a41e5883416e@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9094b55152423617d9c4455ae9513b881616eaff
      https://github.com/OpenSIPS/opensips/commit/9094b55152423617d9c4455ae9513b881616eaff
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M mem/common.h
    M mem/f_malloc.c
    M mem/hp_malloc.c
    M mem/hp_malloc.h

  Log Message:
  -----------
  HP_MALLOC: Recover from double pointer free

Similar idea to commit 2254d00115.

Related to #1518.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Thu Nov  1 06:00:30 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 01 Nov 2018 03:00:30 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ede4db: HP_MALLOC: Recover
 from double pointer free
Message-ID: <5bdacebe8374d_52ef2abee1da8570102163@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ede4db8cea1a298a21c35e7d95d8c5f979e38148
      https://github.com/OpenSIPS/opensips/commit/ede4db8cea1a298a21c35e7d95d8c5f979e38148
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M mem/common.h
    M mem/f_malloc.c
    M mem/hp_malloc.c
    M mem/hp_malloc.h

  Log Message:
  -----------
  HP_MALLOC: Recover from double pointer free

Similar idea to commit 2254d00115.

Related to #1518.

(cherry picked from commit 9094b55152423617d9c4455ae9513b881616eaff)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Thu Nov  1 06:03:34 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 01 Nov 2018 03:03:34 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b455e1: HP_MALLOC: Recover
 from double pointer free
Message-ID: <5bdacf76be561_692b2abaf89ca580637da@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b455e1de836e9a92b28398b64c2049ac65043430
      https://github.com/OpenSIPS/opensips/commit/b455e1de836e9a92b28398b64c2049ac65043430
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M mem/common.h
    M mem/f_malloc.c
    M mem/f_malloc.h
    M mem/hp_malloc.c
    M mem/hp_malloc.h

  Log Message:
  -----------
  HP_MALLOC: Recover from double pointer free

Similar idea to commit 2254d00115.

Related to #1518.

(cherry picked from commit 9094b55152423617d9c4455ae9513b881616eaff)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  1 07:12:01 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 1 Nov 2018 13:12:01 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Control Panel 8.2.4 was released
Message-ID: <e4c2b527-6dce-7416-2445-2063a7033397@opensips.org>

Hi all,

We are proud and happy to announce the release of the OpenSIPS Control 
Panel 8.2.4 . This OpenSIPS Control Panel is a provisioning (SIP users 
and OpenSIPS system) web interface design for and compatible with 
OpenSIPS 2.4 LTS - http://controlpanel.opensips.org .


The OCP 8.2.4 has new awesome additions :

* a new modern look by reworking the entire CSS and layout, see 
http://controlpanel.opensips.org/screenshots.php

* a new tool for handling the RTPEngine instances via database

* a new tool for provisioning TLS domains and certificates via database

* a more powerful Tviewer engine to allow more complex displaying, 
correlation and validation of the data types and to create inter-tool 
web links.


In the same time the OCP 8.2.4 brings great improvements under the hood:

* compatibility with PHP 7, by migrating from MDB2 to PDO database support

* better security of the DB operations by migrating to prepared 
statements, to avoid SQL injections

* improved security for the WEB sessions and page access to avoid 
illegitimate direct access to sub-pages

* extended tooltip and data validation support

* code refactoring for easy further development


This new OpenSIPS Control Panel release is a significant step forward 
for the project in terms of vision. All this happened thanks to the 
people and companies involved in the development of the project.

Special thanks to the Voicenter team - https://www.voicenter.com -  for 
its great contribution in re-styling and re-designing this web interface.


Download and enjoy it as it's freshly baked for you,

-- 
Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com



From bogdan at opensips.org  Thu Nov  1 10:53:00 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 01 Nov 2018 07:53:00 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e3dca7: Fix delete query for
 expired presentities.
Message-ID: <5bdb134c577c7_2624c2b14ee19658014022@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e3dca71eed1a5e7607bc58dff1ff8cf9ed4f8dc0
      https://github.com/OpenSIPS/opensips/commit/e3dca71eed1a5e7607bc58dff1ff8cf9ed4f8dc0
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M modules/presence/publish.c

  Log Message:
  -----------
  Fix delete query for expired presentities.

Set the table to be used again before the delete (even if already set before the select), as other called functions like publ_notify() may change the table.
Reported by Dan Pascu.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  1 10:53:58 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 01 Nov 2018 07:53:58 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 94b557: Fix delete query for
 expired presentities.
Message-ID: <5bdb1386804b0_71102aaca7822584154f6@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 94b557f93a739c597b93d6feef411e41d8ff59e2
      https://github.com/OpenSIPS/opensips/commit/94b557f93a739c597b93d6feef411e41d8ff59e2
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M modules/presence/publish.c

  Log Message:
  -----------
  Fix delete query for expired presentities.

Set the table to be used again before the delete (even if already set before the select), as other called functions like publ_notify() may change the table.
Reported by Dan Pascu.

(cherry picked from commit e3dca71eed1a5e7607bc58dff1ff8cf9ed4f8dc0)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  1 12:52:51 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 01 Nov 2018 09:52:51 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e4868a: Improve login whne
 get_out_socket() fails.
Message-ID: <5bdb2f6322c9_55342adc4943a5804258b@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e4868acfb1bd92fd9ec32489c18b0aaebbf8fc5b
      https://github.com/OpenSIPS/opensips/commit/e4868acfb1bd92fd9ec32489c18b0aaebbf8fc5b
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M forward.c

  Log Message:
  -----------
  Improve login whne get_out_socket() fails.

If no listener is found, print the outbound IP picked by OS and the destination IP.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  1 13:19:01 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 1 Nov 2018 19:19:01 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
Message-ID: <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an 
"opensips -V" to check the resulting compile flags - do you see the 
DBG_MALLOC and QM_MALLOC ?

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 10/31/2018 05:04 PM, Ben Newlin wrote:
>
> Bogdan,
>
> I was able to compile with those options and the crash has occurred 
> again. Backtrace is here: https://pastebin.com/dezi9xUU.
>
> Even though I had `memdump=1` set in my script, there was no extra 
> memory debugging information in the logs prior to or at the time of 
> the crash. I’m not sure if that is expected or not.
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Monday, October 29, 2018 at 8:11 AM
> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
> list <devel at lists.opensips.org>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> You can change the compile flags via the Makefile.conf file - the 
> menuconfig is also updating that file. So during your build you can 
> simply push a pre-modified Makefile.conf file with the options needed 
> for memory debugging.
>
> Regards,
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 10/26/2018 05:14 PM, Ben Newlin wrote:
>
>     Bogdan,
>
>     Unfortunately, we have run into a similar issue before. Our build
>     system is completely automated and there is no way to inject the
>     `make menuconfig` interactive step into that process. If I were to
>     be testing this locally I might be able to work something out, but
>     I could never get such a build into our testing environment which
>     is where the crashes are occurring.
>
>     Do you have instructions for enabling memory debugging that do not
>     require using the interactive TUI tool? What does the menuconfig
>     program do when these options are selected? Are there some defines
>     or other settings we can change ourselves and bypass menuconfig?
>
>     Ben Newlin
>
>     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>     <mailto:bogdan at opensips.org>
>     *Date: *Friday, October 26, 2018 at 4:59 AM
>     *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>     <mailto:devel at lists.opensips.org>, Ben Newlin
>     <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>     Hi Ben,
>
>     all the BT's points to crashes while doing memory ops. I suspect a
>     memory corruption that randomly triggers crashes in different
>     parts of the code.
>
>     Could you try to re-compile with memory debugging support ? See
>     http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>     the "How to handle it" section.
>
>     Regards,
>
>
>     Bogdan-Andrei Iancu
>
>       
>
>     OpenSIPS Founder and Developer
>
>        http://www.opensips-solutions.com
>
>     OpenSIPS Bootcamp 2018
>
>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>     On 10/24/2018 04:28 AM, Ben Newlin wrote:
>
>         We have had 2 more crashes today.
>
>         Crash 2: https://pastebin.com/rMruBQcZ
>         <https://pastebin.com/rMruBQcZ>
>
>         This crash appears to have occurred while processing an
>         initial INVITE request. I could not see anything unusual about
>         the request. I cannot tell if this crash is related to the others.
>
>         Crash 3: https://pastebin.com/Gmk1m4NT
>         <https://pastebin.com/Gmk1m4NT>
>
>         This crash follows the pattern of the original crash I reported.
>
>         Ben Newlin
>
>         *From: *Devel <devel-bounces at lists.opensips.org>
>         <mailto:devel-bounces at lists.opensips.org> on behalf of Ben
>         Newlin <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>         *Reply-To: *OpenSIPS devel mailling list
>         <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>         *Date: *Monday, October 22, 2018 at 4:45 PM
>         *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>         <mailto:devel at lists.opensips.org>
>         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>         Here is a better trace of the call:
>         https://pastebin.com/gWpQR8E7 <https://pastebin.com/gWpQR8E7>
>
>         Ben Newlin
>
>         *From: *Ben Newlin <Ben.Newlin at genesys.com>
>         <mailto:Ben.Newlin at genesys.com>
>         *Date: *Monday, October 22, 2018 at 4:34 PM
>         *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>         <mailto:devel at lists.opensips.org>
>         *Subject: *OpenSIPS Crash
>
>         Hello,
>
>         We have been having sporadic crashes and I was recently able
>         to recover a core dump for one. I have uploaded it here:
>         https://pastebin.com/ABktcYcH <https://pastebin.com/ABktcYcH>.
>
>         I picked out a Call-ID from the crash data and took a look in
>         our tracing. I have uploaded it here:
>         https://pastebin.com/ZEzUUKZ5 <https://pastebin.com/ZEzUUKZ5>.
>
>         It appears that a downstream server was extremely lagged and
>         failed to respond to an INVITE. We sent the INVITE to another
>         server and the call was connected, but then eventually the
>         original server “caught up” and sent a burst of 200 OK
>         responses. The crash seems to have occurred processing the ACK
>         to one of these responses.
>
>         Ben Newlin
>
>
>
>
>
>         _______________________________________________
>
>         Devel mailing list
>
>         Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>
>         http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181101/e986582d/attachment-0001.html>

From razvan at opensips.org  Thu Nov  1 13:25:39 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 01 Nov 2018 10:25:39 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7c13f2: usrloc: use contact id
 in update replicated msg
Message-ID: <5bdb371310fb7_7b762ae71edb6584198a7@hookshot-fe-88eb02d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7c13f2e7d89a8e5f297f0d29faa047b1b1a5cb04
      https://github.com/OpenSIPS/opensips/commit/7c13f2e7d89a8e5f297f0d29faa047b1b1a5cb04
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  usrloc: use contact id in update replicated msg

This commit also sends the contact_id in a replicated update packet.
This is useful when the instance that receives the replicated update
does not have the actual contact (it previously expired), and needs to
treat the update as an insert - before this patch insert would have
generated a new contact_id, possibly overlapping with another one
generated by the primary server.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  1 13:26:15 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 01 Nov 2018 10:26:15 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1cd794: usrloc: use contact id
 in update replicated msg
Message-ID: <5bdb3737de4ad_185d2b2351d1857c7982@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1cd794c4dedf4881db8b4ffc04a76b34c53a5bab
      https://github.com/OpenSIPS/opensips/commit/1cd794c4dedf4881db8b4ffc04a76b34c53a5bab
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-01 (Thu, 01 Nov 2018)

  Changed paths:
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  usrloc: use contact id in update replicated msg

This commit also sends the contact_id in a replicated update packet.
This is useful when the instance that receives the replicated update
does not have the actual contact (it previously expired), and needs to
treat the update as an insert - before this patch insert would have
generated a new contact_id, possibly overlapping with another one
generated by the primary server.

(cherry picked from commit 7c13f2e7d89a8e5f297f0d29faa047b1b1a5cb04)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  2 07:27:04 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 02 Nov 2018 04:27:04 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 596c39: dialog: fix behavior
 of backup node when replicati...
Message-ID: <5bdc3488a0ed_5ebc2ae9201ee57c6002d@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 596c39d905dec66c87cf04ac43cac63921c1b7b8
      https://github.com/OpenSIPS/opensips/commit/596c39d905dec66c87cf04ac43cac63921c1b7b8
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c
    M modules/cgrates/cgrates_acc.c
    M modules/dialog/dialog.c
    M modules/dialog/dlg_cb.c
    M modules/dialog/dlg_cb.h
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  dialog: fix behavior of backup node when replicating dialogs

The node that has a backup state for the sharing tag of a dialog
was incorrectly:
* skipping the replication of all dialog events
* bypassing all registered DLGCB_TERMINATED and DLGCB_EXPIRED callbacks

This behavior was causing issues when replies and sequential requests did
arrive on the backup node. Eg. unable to match and fix the BYE for an
existing topology hiding dialog.

After this fix, only the acc and cgrates modules will skip all actions in the
above mentioned callbacks if the sharing tag is backup.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  2 07:40:32 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 02 Nov 2018 04:40:32 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f511f1: dialog: do not
 unnecessarily fetch sharing tag sta...
Message-ID: <5bdc37b0d144d_7cea2abb645d857875511@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f511f1c73dcdd64fdebe71205f5009ebf2da149e
      https://github.com/OpenSIPS/opensips/commit/f511f1c73dcdd64fdebe71205f5009ebf2da149e
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: do not unnecessarily fetch sharing tag state



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  2 07:46:55 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 02 Nov 2018 04:46:55 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c037e1: dialog: fix behavior
 of backup node when replicati...
Message-ID: <5bdc392f3d677_53792adfaff4458492124@hookshot-fe-6b2eebc.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c037e104f1bf384818e021280b0c8d981fe5e41c
      https://github.com/OpenSIPS/opensips/commit/c037e104f1bf384818e021280b0c8d981fe5e41c
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c
    M modules/cgrates/cgrates_acc.c
    M modules/dialog/dialog.c
    M modules/dialog/dlg_cb.c
    M modules/dialog/dlg_cb.h
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_req_within.c

  Log Message:
  -----------
  dialog: fix behavior of backup node when replicating dialogs

The node that has a backup state for the sharing tag of a dialog
was incorrectly:
* skipping the replication of all dialog events
* bypassing all registered DLGCB_TERMINATED and DLGCB_EXPIRED callbacks

This behavior was causing issues when replies and sequential requests did
arrive on the backup node. Eg. unable to match and fix the BYE for an
existing topology hiding dialog.

After this fix, only the acc and cgrates modules will skip all actions in the
above mentioned callbacks if the sharing tag is backup.

(cherry picked from commit 596c39d905dec66c87cf04ac43cac63921c1b7b8)


  Commit: c60b9495805a36abc80048621f082523e516db87
      https://github.com/OpenSIPS/opensips/commit/c60b9495805a36abc80048621f082523e516db87
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: do not unnecessarily fetch sharing tag state

(cherry picked from commit f511f1c73dcdd64fdebe71205f5009ebf2da149e)


Compare: https://github.com/OpenSIPS/opensips/compare/1cd794c4dedf...c60b9495805a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Fri Nov  2 07:51:38 2018
From: bogdan at opensips.org (Bogdan Andrei IANCU)
Date: Fri, 02 Nov 2018 04:51:38 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] af8c95: fix quotes in
	clusterer documentation
Message-ID: <5bdc3a4aae9b4_7f192b1575a0858856027@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: af8c95bfa80fe5597522771f8268925533d4209a
      https://github.com/OpenSIPS/opensips/commit/af8c95bfa80fe5597522771f8268925533d4209a
  Author: Fabian Gast <fgast+git at only640k.net>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/clusterer/doc/clusterer_admin.xml

  Log Message:
  -----------
  fix quotes in clusterer documentation


  Commit: 38a1c8bf2d0b5d8daea13a1e1c88c7bc531c915d
      https://github.com/OpenSIPS/opensips/commit/38a1c8bf2d0b5d8daea13a1e1c88c7bc531c915d
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/clusterer/doc/clusterer_admin.xml

  Log Message:
  -----------
  Merge pull request #1521 from fgast/fix-clusterer-doc

fix quotes in clusterer documentation


Compare: https://github.com/OpenSIPS/opensips/compare/f511f1c73dcd...38a1c8bf2d0b
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From fgast+git at only640k.net  Fri Nov  2 07:53:58 2018
From: fgast+git at only640k.net (Fabian Gast)
Date: Fri, 02 Nov 2018 04:53:58 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 35252a: fix quotes in
	clusterer documentation
Message-ID: <5bdc3ad676741_80b2b07a627a578436d3@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 35252a877109a33d2e92ee4b7fdac0efc1803866
      https://github.com/OpenSIPS/opensips/commit/35252a877109a33d2e92ee4b7fdac0efc1803866
  Author: Fabian Gast <fgast+git at only640k.net>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/clusterer/doc/clusterer_admin.xml

  Log Message:
  -----------
  fix quotes in clusterer documentation

(cherry picked from commit af8c95bfa80fe5597522771f8268925533d4209a)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Fri Nov  2 08:11:40 2018
From: razvan at opensips.org (=?UTF-8?Q?R=c4=83zvan_Crainea?=)
Date: Fri, 2 Nov 2018 14:11:40 +0200
Subject: [OpenSIPS-Devel] [RELEASE] OpenSIPS 2.4.3 Release Planning
Message-ID: <bf12f64b-fa08-d917-04d4-cae1d459256f@opensips.org>

Hi, Everyone!

After a long series of bug fixes, especially the presence modules ones, 
we decided it's time to make a new OpenSIPS 2.4 release.

Therefore I would like to announce that the new OpenSIPS 2.4.3 release 
is scheduled for next Thursday, 8th of November 2018.

We are now pushing hard to solve all known issues - but if you do have 
any other problems with OpenSIPS 2.4.2, now is the time to let us know 
by opening a ticket[1].

Thank you all for using OpenSIPS!

[1] https://github.com/OpenSIPS/opensips/issues

Cheers,
-- 
Răzvan Crainea
OpenSIPS Core Developer
   http://www.opensips-solutions.com


From razvan at opensips.org  Fri Nov  2 10:26:25 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Fri, 02 Nov 2018 07:26:25 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 37c56c: dialog: enhance LOADED
 and EXPIRED callbacs docs
Message-ID: <5bdc5e915ea61_40ea2b00b513e58028961@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 37c56cf3973611a19e52aa13abd3616d2f4148a4
      https://github.com/OpenSIPS/opensips/commit/37c56cf3973611a19e52aa13abd3616d2f4148a4
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_cb.h
    M modules/dialog/doc/dialog_devel.xml

  Log Message:
  -----------
  dialog: enhance LOADED and EXPIRED callbacs docs



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Fri Nov  2 10:26:44 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Fri, 02 Nov 2018 07:26:44 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] cbb888: dialog: enhance LOADED
 and EXPIRED callbacs docs
Message-ID: <5bdc5ea45ea14_5e4e2abb719bc58839892@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: cbb888a07bf370524534423569b8a916f7531924
      https://github.com/OpenSIPS/opensips/commit/cbb888a07bf370524534423569b8a916f7531924
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_cb.h
    M modules/dialog/doc/dialog_devel.xml

  Log Message:
  -----------
  dialog: enhance LOADED and EXPIRED callbacs docs

(cherry picked from commit 37c56cf3973611a19e52aa13abd3616d2f4148a4)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  2 11:30:26 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 02 Nov 2018 08:30:26 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3642e3: dialog: complete the
 fix in commit 596c39d9
Message-ID: <5bdc6d9273314_21e42abc289f85801847c@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3642e3f9e8eb70bce3793c0216bec63518bfc8be
      https://github.com/OpenSIPS/opensips/commit/3642e3f9e8eb70bce3793c0216bec63518bfc8be
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c
    M modules/cgrates/cgrates_acc.c
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: complete the fix in commit 596c39d9

This commit improves the previous fix that was incorrectly allowing
DLGCB_EXPIRED callbacks registered by other modules than acc and cgrates
to be run.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  2 11:33:40 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 02 Nov 2018 08:33:40 -0700
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 82f0d7: dialog: complete the
 fix in commit 596c39d9
Message-ID: <5bdc6e5478ecc_51e72ac6875345809679d@hookshot-fe-31feec6.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 82f0d758765f816dad9df3353ff62ade6a67e9fb
      https://github.com/OpenSIPS/opensips/commit/82f0d758765f816dad9df3353ff62ade6a67e9fb
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-02 (Fri, 02 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c
    M modules/cgrates/cgrates_acc.c
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: complete the fix in commit 596c39d9

This commit improves the previous fix that was incorrectly allowing
DLGCB_EXPIRED callbacks registered by other modules than acc and cgrates
to be run.

(cherry picked from commit 3642e3f9e8eb70bce3793c0216bec63518bfc8be)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov  4 15:10:26 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 04 Nov 2018 12:10:26 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bd8931: Rebuild documentation
Message-ID: <5bdf5232422eb_5dd22b2719b5c5789900@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: bd89315652f0a558566de92f9803a5dd2f975e01
      https://github.com/OpenSIPS/opensips/commit/bd89315652f0a558566de92f9803a5dd2f975e01
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-04 (Sun, 04 Nov 2018)

  Changed paths:
    M modules/stun/README
    M modules/stun/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov  4 15:29:26 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 04 Nov 2018 12:29:26 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1fd7e2: Rebuild documentation
Message-ID: <5bdf56a6585a2_d842b218d878578132f9@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1fd7e2eb0197da4db8f569a8997a3e8a5015421d
      https://github.com/OpenSIPS/opensips/commit/1fd7e2eb0197da4db8f569a8997a3e8a5015421d
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-04 (Sun, 04 Nov 2018)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/cgrates/README
    M modules/cgrates/doc/contributors.xml
    M modules/clusterer/README
    M modules/clusterer/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/mid_registrar/README
    M modules/mid_registrar/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/stun/README
    M modules/stun/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov  5 03:47:55 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 05 Nov 2018 00:47:55 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2bf9d2: rtpengine: Fix doc
	build
Message-ID: <5be003bb4e6ca_31ff2b27b91b45848196@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2bf9d2452a91d1b1896b54abfeb4fa8c5bc376b5
      https://github.com/OpenSIPS/opensips/commit/2bf9d2452a91d1b1896b54abfeb4fa8c5bc376b5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rtpengine/doc/rtpengine_admin.xml

  Log Message:
  -----------
  rtpengine: Fix doc build



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov  5 06:11:06 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 05 Nov 2018 03:11:06 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8e4806: rest_client: Add new
 error return codes for all tr...
Message-ID: <5be0254aec935_601f2b04b5e2c57c44499@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8e480668e87e718c1c5ae00b8763ce3ea30e0ab4
      https://github.com/OpenSIPS/opensips/commit/8e480668e87e718c1c5ae00b8763ce3ea30e0ab4
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rest_client/rest_cb.c
    M modules/rest_client/rest_client.c
    M modules/rest_client/rest_methods.c
    M modules/rest_client/rest_methods.h

  Log Message:
  -----------
  rest_client: Add new error return codes for all transfers

     1: success
    -1: connection refused
    -2: connection timeout (i.e. 'connection_timeout' was hit)
    -3: transfer timeout (i.e. 'curl_timeout' was hit)
    -10: internal error (i.e. "I hope OpenSIPS is still running")

This patch also includes additional fixes related to error handling:
    * fix undetected error conditions on "async-but-blocking" transfers
       (these transfers happen once you hit 'max_async_transfers')

    * fix a bunch of code paths where the rest_() functions return
       success despite not being able to set one or more output pvars

    * never abort(), regardless of what libcurl says

(cherry picked from commit 04e2ef3d091bba7a237589be03f53f27deabf413)


  Commit: f3e73546b570c02bef69b03d421732f40c12091d
      https://github.com/OpenSIPS/opensips/commit/f3e73546b570c02bef69b03d421732f40c12091d
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rest_client/doc/rest_client.xml
    M modules/rest_client/doc/rest_client_admin.xml
    A modules/rest_client/doc/rest_return_codes.xml

  Log Message:
  -----------
  rest_client: Update documentation

(cherry picked from commit 59da2616ada4457447a5f816b1620e59577fffad)


  Commit: 98706f3c36350589869fb8aa548c8a7f20e48d56
      https://github.com/OpenSIPS/opensips/commit/98706f3c36350589869fb8aa548c8a7f20e48d56
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Fix warnings with clang 5.0

(cherry picked from commit 6126c2039e9ed6d2820e1dd3a66c97af4087da08)


Compare: https://github.com/OpenSIPS/opensips/compare/1fd7e2eb0197...98706f3c3635
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov  5 10:36:58 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 05 Nov 2018 07:36:58 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3650af: usrloc: Fix possible
 crash in federation mode
Message-ID: <5be0639a6cd41_60912b07ecdc6580199fc@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3650af33bf4a45d0f783375878bf4921a2b823bc
      https://github.com/OpenSIPS/opensips/commit/3650af33bf4a45d0f783375878bf4921a2b823bc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/usrloc/udomain.c

  Log Message:
  -----------
  usrloc: Fix possible crash in federation mode



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov  5 10:37:12 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 05 Nov 2018 07:37:12 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ab005a: usrloc: Fix possible
 crash in federation mode
Message-ID: <5be063a8894f2_5c182aac415d857865378@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ab005ac75996b1a4200f6df93a87e623b448391f
      https://github.com/OpenSIPS/opensips/commit/ab005ac75996b1a4200f6df93a87e623b448391f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/usrloc/udomain.c

  Log Message:
  -----------
  usrloc: Fix possible crash in federation mode

(cherry picked from commit 3650af33bf4a45d0f783375878bf4921a2b823bc)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov  5 11:05:29 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 05 Nov 2018 08:05:29 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 41fd98: usrloc: Fix a
 replication bug of commit 7c13f2e7d8
Message-ID: <5be06a49cdea1_235d2b279c97a5881064aa@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 41fd98ea2025fdce0e9d031a91b27b052bc851e9
      https://github.com/OpenSIPS/opensips/commit/41fd98ea2025fdce0e9d031a91b27b052bc851e9
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  usrloc: Fix a replication bug of commit 7c13f2e7d8

Do not overwrite the K/V storage buffer while reading additional data
from the received update packet.

Reported by @sekil75
Fixes #1523



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov  5 11:06:01 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 05 Nov 2018 08:06:01 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 489de0: usrloc: Fix a
 replication bug of commit 7c13f2e7d8
Message-ID: <5be06a69886d2_35822acdfa43257c457b6@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 489de02c4423b6e06a86b8cc7eb202c224892a64
      https://github.com/OpenSIPS/opensips/commit/489de02c4423b6e06a86b8cc7eb202c224892a64
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-05 (Mon, 05 Nov 2018)

  Changed paths:
    M modules/usrloc/ureplication.c

  Log Message:
  -----------
  usrloc: Fix a replication bug of commit 7c13f2e7d8

Do not overwrite the K/V storage buffer while reading additional data
from the received update packet.

Reported by @sekil75
Fixes #1523

(cherry picked from commit 41fd98ea2025fdce0e9d031a91b27b052bc851e9)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Mon Nov  5 12:01:18 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 5 Nov 2018 19:01:18 +0200
Subject: [OpenSIPS-Devel] [OpenSIPS-Users] OpenSIPS Control Panel 8.2.4
	was released
In-Reply-To: <8B36F227BD22B041AEA7015FD914CD9503817141FA@JET-EX02.jettel.ru>
References: <e4c2b527-6dce-7416-2445-2063a7033397@opensips.org>
 <8B36F227BD22B041AEA7015FD914CD9503817141FA@JET-EX02.jettel.ru>
Message-ID: <29d0413d-5171-4323-b416-42359d90d6f4@opensips.org>

Hi Yuriy,

Thanks for spotting that, I just pushed a fix:
https://github.com/OpenSIPS/opensips-cp/commit/9556483a80514509def862bd2c870f738adda29a

Best regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/05/2018 05:30 PM, zzz wrote:
> Hi Bogdan,
> Thanks for all you do.
> Ive tried the new release on debian8, it works great.
> Would you please change "domaini" to "domain" in the file acl_management.php
> https://github.com/OpenSIPS/opensips-cp/blob/8.2.4/web/tools/users/acl_management/acl_management.php
> lines 156 and 169.
> Thanks,
> Yuriy
>
>
>
> -----Original Message-----
> From: Users [mailto:users-bounces at lists.opensips.org] On Behalf Of Bogdan-Andrei Iancu
> Sent: Thursday, November 1, 2018 2:12 PM
> To: users at lists.opensips.org; developensips <Devel at lists.opensips.org>; business at lists.opensips.org
> Subject: [OpenSIPS-Users] OpenSIPS Control Panel 8.2.4 was released
>
> Hi all,
>
> We are proud and happy to announce the release of the OpenSIPS Control Panel 8.2.4 . This OpenSIPS Control Panel is a provisioning (SIP users and OpenSIPS system) web interface design for and compatible with OpenSIPS 2.4 LTS - http://controlpanel.opensips.org .
>
>
> The OCP 8.2.4 has new awesome additions :
>
> * a new modern look by reworking the entire CSS and layout, see http://controlpanel.opensips.org/screenshots.php
>
> * a new tool for handling the RTPEngine instances via database
>
> * a new tool for provisioning TLS domains and certificates via database
>
> * a more powerful Tviewer engine to allow more complex displaying, correlation and validation of the data types and to create inter-tool web links.
>
>
> In the same time the OCP 8.2.4 brings great improvements under the hood:
>
> * compatibility with PHP 7, by migrating from MDB2 to PDO database support
>
> * better security of the DB operations by migrating to prepared statements, to avoid SQL injections
>
> * improved security for the WEB sessions and page access to avoid illegitimate direct access to sub-pages
>
> * extended tooltip and data validation support
>
> * code refactoring for easy further development
>
>
> This new OpenSIPS Control Panel release is a significant step forward for the project in terms of vision. All this happened thanks to the people and companies involved in the development of the project.
>
> Special thanks to the Voicenter team - https://www.voicenter.com -  for its great contribution in re-styling and re-designing this web interface.
>
>
> Download and enjoy it as it's freshly baked for you,
>



From Ben.Newlin at genesys.com  Tue Nov  6 15:24:59 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Tue, 6 Nov 2018 20:24:59 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
Message-ID: <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>

Bogdan,

I have reproduced this crash and verified this time that the flags were set.

$ opensips -V
version: opensips 2.4.1 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 5d042cffc
main.c compiled on 23:38:55 Nov  5 2018 with gcc 7

Backtrace is available here: https://pastebin.com/KTQjkCwq

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Thursday, November 1, 2018 at 1:19 PM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an "opensips -V" to check the resulting compile flags - do you see the DBG_MALLOC and QM_MALLOC ?

Regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/31/2018 05:04 PM, Ben Newlin wrote:
Bogdan,

I was able to compile with those options and the crash has occurred again. Backtrace is here: https://pastebin.com/dezi9xUU<https://pastebin.com/dezi9xUU>.

Even though I had `memdump=1` set in my script, there was no extra memory debugging information in the logs prior to or at the time of the crash. I’m not sure if that is expected or not.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, October 29, 2018 at 8:11 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

You can change the compile flags via the Makefile.conf file - the menuconfig is also updating that file. So during your build you can simply push a pre-modified Makefile.conf file with the options needed for memory debugging.

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/26/2018 05:14 PM, Ben Newlin wrote:
Bogdan,

Unfortunately, we have run into a similar issue before. Our build system is completely automated and there is no way to inject the `make menuconfig` interactive step into that process. If I were to be testing this locally I might be able to work something out, but I could never get such a build into our testing environment which is where the crashes are occurring.

Do you have instructions for enabling memory debugging that do not require using the interactive TUI tool? What does the menuconfig program do when these options are selected? Are there some defines or other settings we can change ourselves and bypass menuconfig?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, October 26, 2018 at 4:59 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

all the BT's points to crashes while doing memory ops. I suspect a memory corruption that randomly triggers crashes in different parts of the code.

Could you try to re-compile with memory debugging support ? See http://www.opensips.org/Documentation/TroubleShooting-OutOfMem<http://www.opensips.org/Documentation/TroubleShooting-OutOfMem>, the "How to handle it" section.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/24/2018 04:28 AM, Ben Newlin wrote:
We have had 2 more crashes today.

Crash 2: https://pastebin.com/rMruBQcZ<https://pastebin.com/rMruBQcZ>
This crash appears to have occurred while processing an initial INVITE request. I could not see anything unusual about the request. I cannot tell if this crash is related to the others.

Crash 3: https://pastebin.com/Gmk1m4NT<https://pastebin.com/Gmk1m4NT>
This crash follows the pattern of the original crash I reported.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Monday, October 22, 2018 at 4:45 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Here is a better trace of the call: https://pastebin.com/gWpQR8E7<https://pastebin.com/gWpQR8E7>

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Date: Monday, October 22, 2018 at 4:34 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: OpenSIPS Crash

Hello,

We have been having sporadic crashes and I was recently able to recover a core dump for one. I have uploaded it here: https://pastebin.com/ABktcYcH<https://pastebin.com/ABktcYcH>.

I picked out a Call-ID from the crash data and took a look in our tracing. I have uploaded it here: https://pastebin.com/ZEzUUKZ5<https://pastebin.com/ZEzUUKZ5>.

It appears that a downstream server was extremely lagged and failed to respond to an INVITE. We sent the INVITE to another server and the call was connected, but then eventually the original server “caught up” and sent a burst of 200 OK responses. The crash seems to have occurred processing the ACK to one of these responses.

Ben Newlin






_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>









-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181106/667eb1f7/attachment-0001.html>

From bogdan at opensips.org  Tue Nov  6 16:13:56 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 6 Nov 2018 23:13:56 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
Message-ID: <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>

Jackpot - you get it right !! I will start digging into the trace, but 
please keep the corefile, I might need it later.

Thanks and regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/06/2018 10:24 PM, Ben Newlin wrote:
>
> Bogdan,
>
> I have reproduced this crash and verified this time that the flags 
> were set.
>
> $ opensips -V
>
> version: opensips 2.4.1 (x86_64/linux)
>
> flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, 
> QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
>
> ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
> MAX_URI_SIZE 1024, BUF_SIZE 65535
>
> poll method support: poll, epoll, sigio_rt, select.
>
> git revision: 5d042cffc
>
> main.c compiled on 23:38:55 Nov  5 2018 with gcc 7
>
> Backtrace is available here: https://pastebin.com/KTQjkCwq 
> <https://pastebin.com/KTQjkCwq>
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Thursday, November 1, 2018 at 1:19 PM
> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
> list <devel at lists.opensips.org>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> According to the backtrace, the memory debugger was not activated. Do 
> an "opensips -V" to check the resulting compile flags - do you see the 
> DBG_MALLOC and QM_MALLOC ?
>
> Regards,
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 10/31/2018 05:04 PM, Ben Newlin wrote:
>
>     Bogdan,
>
>     I was able to compile with those options and the crash has
>     occurred again. Backtrace is here: https://pastebin.com/dezi9xUU
>     <https://pastebin.com/dezi9xUU>.
>
>     Even though I had `memdump=1` set in my script, there was no extra
>     memory debugging information in the logs prior to or at the time
>     of the crash. I’m not sure if that is expected or not.
>
>     Ben Newlin
>
>     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>     <mailto:bogdan at opensips.org>
>     *Date: *Monday, October 29, 2018 at 8:11 AM
>     *To: *Ben Newlin <Ben.Newlin at genesys.com>
>     <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list
>     <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>     Hi Ben,
>
>     You can change the compile flags via the Makefile.conf file - the
>     menuconfig is also updating that file. So during your build you
>     can simply push a pre-modified Makefile.conf file with the options
>     needed for memory debugging.
>
>     Regards,
>
>
>     Bogdan-Andrei Iancu
>
>       
>
>     OpenSIPS Founder and Developer
>
>        http://www.opensips-solutions.com
>
>     OpenSIPS Bootcamp 2018
>
>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>     On 10/26/2018 05:14 PM, Ben Newlin wrote:
>
>         Bogdan,
>
>         Unfortunately, we have run into a similar issue before. Our
>         build system is completely automated and there is no way to
>         inject the `make menuconfig` interactive step into that
>         process. If I were to be testing this locally I might be able
>         to work something out, but I could never get such a build into
>         our testing environment which is where the crashes are occurring.
>
>         Do you have instructions for enabling memory debugging that do
>         not require using the interactive TUI tool? What does the
>         menuconfig program do when these options are selected? Are
>         there some defines or other settings we can change ourselves
>         and bypass menuconfig?
>
>         Ben Newlin
>
>         *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>         <mailto:bogdan at opensips.org>
>         *Date: *Friday, October 26, 2018 at 4:59 AM
>         *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>         <mailto:devel at lists.opensips.org>, Ben Newlin
>         <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>         Hi Ben,
>
>         all the BT's points to crashes while doing memory ops. I
>         suspect a memory corruption that randomly triggers crashes in
>         different parts of the code.
>
>         Could you try to re-compile with memory debugging support ?
>         See
>         http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>         the "How to handle it" section.
>
>         Regards,
>
>
>
>         Bogdan-Andrei Iancu
>
>           
>
>         OpenSIPS Founder and Developer
>
>            http://www.opensips-solutions.com
>
>         OpenSIPS Bootcamp 2018
>
>            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>         On 10/24/2018 04:28 AM, Ben Newlin wrote:
>
>             We have had 2 more crashes today.
>
>             Crash 2: https://pastebin.com/rMruBQcZ
>             <https://pastebin.com/rMruBQcZ>
>
>             This crash appears to have occurred while processing an
>             initial INVITE request. I could not see anything unusual
>             about the request. I cannot tell if this crash is related
>             to the others.
>
>             Crash 3: https://pastebin.com/Gmk1m4NT
>             <https://pastebin.com/Gmk1m4NT>
>
>             This crash follows the pattern of the original crash I
>             reported.
>
>             Ben Newlin
>
>             *From: *Devel <devel-bounces at lists.opensips.org>
>             <mailto:devel-bounces at lists.opensips.org> on behalf of Ben
>             Newlin <Ben.Newlin at genesys.com>
>             <mailto:Ben.Newlin at genesys.com>
>             *Reply-To: *OpenSIPS devel mailling list
>             <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>             *Date: *Monday, October 22, 2018 at 4:45 PM
>             *To: *OpenSIPS devel mailling list
>             <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>             *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>             Here is a better trace of the call:
>             https://pastebin.com/gWpQR8E7 <https://pastebin.com/gWpQR8E7>
>
>             Ben Newlin
>
>             *From: *Ben Newlin <Ben.Newlin at genesys.com>
>             <mailto:Ben.Newlin at genesys.com>
>             *Date: *Monday, October 22, 2018 at 4:34 PM
>             *To: *OpenSIPS devel mailling list
>             <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>             *Subject: *OpenSIPS Crash
>
>             Hello,
>
>             We have been having sporadic crashes and I was recently
>             able to recover a core dump for one. I have uploaded it
>             here: https://pastebin.com/ABktcYcH
>             <https://pastebin.com/ABktcYcH>.
>
>             I picked out a Call-ID from the crash data and took a look
>             in our tracing. I have uploaded it here:
>             https://pastebin.com/ZEzUUKZ5 <https://pastebin.com/ZEzUUKZ5>.
>
>             It appears that a downstream server was extremely lagged
>             and failed to respond to an INVITE. We sent the INVITE to
>             another server and the call was connected, but then
>             eventually the original server “caught up” and sent a
>             burst of 200 OK responses. The crash seems to have
>             occurred processing the ACK to one of these responses.
>
>             Ben Newlin
>
>
>
>
>
>
>             _______________________________________________
>
>             Devel mailing list
>
>             Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>
>             http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181106/b6385ac8/attachment-0001.html>

From liviu at opensips.org  Wed Nov  7 05:09:42 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Wed, 07 Nov 2018 02:09:42 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a9b916: opensipsctl trap: Be
 quiet if opensips is not runn...
Message-ID: <5be2b9e6f25b2_293e2afcfa54257888118@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a9b9169542b2e9976bfaf514f6a8af1e34d8e035
      https://github.com/OpenSIPS/opensips/commit/a9b9169542b2e9976bfaf514f6a8af1e34d8e035
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-07 (Wed, 07 Nov 2018)

  Changed paths:
    M scripts/opensipsctl
    M scripts/opensipsctl.base

  Log Message:
  -----------
  opensipsctl trap: Be quiet if opensips is not running

(cherry picked from commit 5dee6cd8e13ba7c8442db833c8eb7ef4e8163413)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Wed Nov  7 06:18:43 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Wed, 7 Nov 2018 13:18:43 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
Message-ID: <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>

Hi Ben,

The BT indicates a double free for the accounting context - and I 
noticed you use 2.4.1 version. And yes, there was an issue related to 
acc context, issue that was fixed starting 2.4.2. So, could you upgrade 
to the latest 2.4 and see if the crash still happens ? As I think the 
fix is already there.

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
> Jackpot - you get it right !! I will start digging into the trace, but 
> please keep the corefile, I might need it later.
>
> Thanks and regards,
> Bogdan-Andrei Iancu
>
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
> On 11/06/2018 10:24 PM, Ben Newlin wrote:
>>
>> Bogdan,
>>
>> I have reproduced this crash and verified this time that the flags 
>> were set.
>>
>> $ opensips -V
>>
>> version: opensips 2.4.1 (x86_64/linux)
>>
>> flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, 
>> QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
>>
>> ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, 
>> MAX_URI_SIZE 1024, BUF_SIZE 65535
>>
>> poll method support: poll, epoll, sigio_rt, select.
>>
>> git revision: 5d042cffc
>>
>> main.c compiled on 23:38:55 Nov  5 2018 with gcc 7
>>
>> Backtrace is available here: https://pastebin.com/KTQjkCwq 
>> <https://pastebin.com/KTQjkCwq>
>>
>> Ben Newlin
>>
>> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>> *Date: *Thursday, November 1, 2018 at 1:19 PM
>> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
>> list <devel at lists.opensips.org>
>> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>>
>> Hi Ben,
>>
>> According to the backtrace, the memory debugger was not activated. Do 
>> an "opensips -V" to check the resulting compile flags - do you see 
>> the DBG_MALLOC and QM_MALLOC ?
>>
>> Regards,
>>
>> Bogdan-Andrei Iancu
>> OpenSIPS Founder and Developer
>>    http://www.opensips-solutions.com
>> OpenSIPS Bootcamp 2018
>>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>>
>> On 10/31/2018 05:04 PM, Ben Newlin wrote:
>>
>>     Bogdan,
>>
>>     I was able to compile with those options and the crash has
>>     occurred again. Backtrace is here: https://pastebin.com/dezi9xUU
>>     <https://pastebin.com/dezi9xUU>.
>>
>>     Even though I had `memdump=1` set in my script, there was no
>>     extra memory debugging information in the logs prior to or at the
>>     time of the crash. I’m not sure if that is expected or not.
>>
>>     Ben Newlin
>>
>>     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>>     <mailto:bogdan at opensips.org>
>>     *Date: *Monday, October 29, 2018 at 8:11 AM
>>     *To: *Ben Newlin <Ben.Newlin at genesys.com>
>>     <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list
>>     <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>>     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>>
>>     Hi Ben,
>>
>>     You can change the compile flags via the Makefile.conf file - the
>>     menuconfig is also updating that file. So during your build you
>>     can simply push a pre-modified Makefile.conf file with the
>>     options needed for memory debugging.
>>
>>     Regards,
>>
>>
>>     Bogdan-Andrei Iancu
>>
>>       
>>
>>     OpenSIPS Founder and Developer
>>
>>        http://www.opensips-solutions.com
>>
>>     OpenSIPS Bootcamp 2018
>>
>>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>>
>>     On 10/26/2018 05:14 PM, Ben Newlin wrote:
>>
>>         Bogdan,
>>
>>         Unfortunately, we have run into a similar issue before. Our
>>         build system is completely automated and there is no way to
>>         inject the `make menuconfig` interactive step into that
>>         process. If I were to be testing this locally I might be able
>>         to work something out, but I could never get such a build
>>         into our testing environment which is where the crashes are
>>         occurring.
>>
>>         Do you have instructions for enabling memory debugging that
>>         do not require using the interactive TUI tool? What does the
>>         menuconfig program do when these options are selected? Are
>>         there some defines or other settings we can change ourselves
>>         and bypass menuconfig?
>>
>>         Ben Newlin
>>
>>         *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>>         <mailto:bogdan at opensips.org>
>>         *Date: *Friday, October 26, 2018 at 4:59 AM
>>         *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>>         <mailto:devel at lists.opensips.org>, Ben Newlin
>>         <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>>         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>>
>>         Hi Ben,
>>
>>         all the BT's points to crashes while doing memory ops. I
>>         suspect a memory corruption that randomly triggers crashes in
>>         different parts of the code.
>>
>>         Could you try to re-compile with memory debugging support ?
>>         See
>>         http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>>         the "How to handle it" section.
>>
>>         Regards,
>>
>>
>>
>>         Bogdan-Andrei Iancu
>>
>>           
>>
>>         OpenSIPS Founder and Developer
>>
>>            http://www.opensips-solutions.com
>>
>>         OpenSIPS Bootcamp 2018
>>
>>            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>>
>>         On 10/24/2018 04:28 AM, Ben Newlin wrote:
>>
>>             We have had 2 more crashes today.
>>
>>             Crash 2: https://pastebin.com/rMruBQcZ
>>             <https://pastebin.com/rMruBQcZ>
>>
>>             This crash appears to have occurred while processing an
>>             initial INVITE request. I could not see anything unusual
>>             about the request. I cannot tell if this crash is related
>>             to the others.
>>
>>             Crash 3: https://pastebin.com/Gmk1m4NT
>>             <https://pastebin.com/Gmk1m4NT>
>>
>>             This crash follows the pattern of the original crash I
>>             reported.
>>
>>             Ben Newlin
>>
>>             *From: *Devel <devel-bounces at lists.opensips.org>
>>             <mailto:devel-bounces at lists.opensips.org> on behalf of
>>             Ben Newlin <Ben.Newlin at genesys.com>
>>             <mailto:Ben.Newlin at genesys.com>
>>             *Reply-To: *OpenSIPS devel mailling list
>>             <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>>             *Date: *Monday, October 22, 2018 at 4:45 PM
>>             *To: *OpenSIPS devel mailling list
>>             <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>>             *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>>
>>             Here is a better trace of the call:
>>             https://pastebin.com/gWpQR8E7 <https://pastebin.com/gWpQR8E7>
>>
>>             Ben Newlin
>>
>>             *From: *Ben Newlin <Ben.Newlin at genesys.com>
>>             <mailto:Ben.Newlin at genesys.com>
>>             *Date: *Monday, October 22, 2018 at 4:34 PM
>>             *To: *OpenSIPS devel mailling list
>>             <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>>             *Subject: *OpenSIPS Crash
>>
>>             Hello,
>>
>>             We have been having sporadic crashes and I was recently
>>             able to recover a core dump for one. I have uploaded it
>>             here: https://pastebin.com/ABktcYcH
>>             <https://pastebin.com/ABktcYcH>.
>>
>>             I picked out a Call-ID from the crash data and took a
>>             look in our tracing. I have uploaded it here:
>>             https://pastebin.com/ZEzUUKZ5
>>             <https://pastebin.com/ZEzUUKZ5>.
>>
>>             It appears that a downstream server was extremely lagged
>>             and failed to respond to an INVITE. We sent the INVITE to
>>             another server and the call was connected, but then
>>             eventually the original server “caught up” and sent a
>>             burst of 200 OK responses. The crash seems to have
>>             occurred processing the ACK to one of these responses.
>>
>>             Ben Newlin
>>
>>
>>
>>
>>
>>
>>             _______________________________________________
>>
>>             Devel mailing list
>>
>>             Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>>
>>             http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
>
>
> _______________________________________________
> Devel mailing list
> Devel at lists.opensips.org
> http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181107/d894eb81/attachment-0001.html>

From razvan at opensips.org  Thu Nov  8 06:09:13 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 03:09:13 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a2b243: ws: decrement load
 statistic in case of error or o...
Message-ID: <5be41959682ae_75262ab64c89e57c107f5@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a2b2435729bc5b7ad8071cb60aac914a49c49ffb
      https://github.com/OpenSIPS/opensips/commit/a2b2435729bc5b7ad8071cb60aac914a49c49ffb
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/proto_ws/ws_common.h

  Log Message:
  -----------
  ws: decrement load statistic in case of error or other msg



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 07:00:24 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 04:00:24 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 54ca97: registrar: fix
	contacts re-alloc issue
Message-ID: <5be425584dfd1_26a42af034c6a58032479@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 54ca97b50ad0f52d43a5b6819ce7f42ea019ecc6
      https://github.com/OpenSIPS/opensips/commit/54ca97b50ad0f52d43a5b6819ce7f42ea019ecc6
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/registrar/lookup.c

  Log Message:
  -----------
  registrar: fix contacts re-alloc issue

When more than 20 contacts were serialized in a buffer, the realloc was
not allocating enough space for the buffer to hold all entries. This
lead to a memory corruption and further to a crash.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 07:00:40 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 04:00:40 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7943ae: registrar: fix
	contacts re-alloc issue
Message-ID: <5be42568e1225_1942a2abc61c9e58042610@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7943ae41da33af4b4311093bc3fbc56ec41cd65b
      https://github.com/OpenSIPS/opensips/commit/7943ae41da33af4b4311093bc3fbc56ec41cd65b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/registrar/lookup.c

  Log Message:
  -----------
  registrar: fix contacts re-alloc issue

When more than 20 contacts were serialized in a buffer, the realloc was
not allocating enough space for the buffer to hold all entries. This
lead to a memory corruption and further to a crash.

(cherry picked from commit 54ca97b50ad0f52d43a5b6819ce7f42ea019ecc6)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  8 07:08:51 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 08 Nov 2018 04:08:51 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6a11f6: Fix too script
 restrictions on allowed types of ro...
Message-ID: <5be4275362470_1e1c2ace3114a5806157b@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6a11f68cb7a2381c2b6febff9b47979237761ff6
      https://github.com/OpenSIPS/opensips/commit/6a11f68cb7a2381c2b6febff9b47979237761ff6
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/uri/uri_mod.c

  Log Message:
  -----------
  Fix too script restrictions on allowed types of routes for runing certain functions.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  8 07:09:32 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 08 Nov 2018 04:09:32 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e4ffbf: Fix too script
 restrictions on allowed types of ro...
Message-ID: <5be4277c8449e_28cc2b06a275a584137e@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e4ffbf76640f368d862b58fb374fe2a8f60e99f6
      https://github.com/OpenSIPS/opensips/commit/e4ffbf76640f368d862b58fb374fe2a8f60e99f6
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/uri/uri_mod.c

  Log Message:
  -----------
  Fix too script restrictions on allowed types of routes for runing certain functions.

(cherry picked from commit 6a11f68cb7a2381c2b6febff9b47979237761ff6)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  8 08:23:07 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 08 Nov 2018 05:23:07 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a9eba1: Fix INT only
 restriction on integer columns in DR
Message-ID: <5be438bba4b49_19ad2ae83a6da57c4742@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a9eba1f38f1cdf70c7b58f145fea7c030aa7ef4d
      https://github.com/OpenSIPS/opensips/commit/a9eba1f38f1cdf70c7b58f145fea7c030aa7ef4d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/drouting/dr_load.c

  Log Message:
  -----------
  Fix INT only restriction on integer columns in DR

The mysql views report any static integer as DB_BIGINT, makeing it impossible to be used with drouting.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  8 08:26:28 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 08 Nov 2018 05:26:28 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9a3b28: Fix INT only
 restriction on integer columns in DR
Message-ID: <5be4398472165_308e2b0a55ea65841191e@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9a3b280b75258d9a28d3bdd737286f493eb65a68
      https://github.com/OpenSIPS/opensips/commit/9a3b280b75258d9a28d3bdd737286f493eb65a68
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/drouting/dr_load.c

  Log Message:
  -----------
  Fix INT only restriction on integer columns in DR

The mysql views report any static integer as DB_BIGINT, makeing it impossible to be used with drouting.

(cherry picked from commit a9eba1f38f1cdf70c7b58f145fea7c030aa7ef4d)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov  8 08:38:27 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 08 Nov 2018 05:38:27 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 98d832: Fix INT only
 restriction on integer columns in DR
Message-ID: <5be43c534f625_353a2ac92f73e58880624@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 98d83208959a93058eafd485f96a4f1a6af10d57
      https://github.com/OpenSIPS/opensips/commit/98d83208959a93058eafd485f96a4f1a6af10d57
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/drouting/dr_load.c

  Log Message:
  -----------
  Fix INT only restriction on integer columns in DR

The mysql views report any static integer as DB_BIGINT, makeing it impossible to be used with drouting.

(cherry picked from commit a9eba1f38f1cdf70c7b58f145fea7c030aa7ef4d)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 09:34:33 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 06:34:33 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c5d6c0: tls_mgm: fix
 tls_method for openssl >= 1.1.0
Message-ID: <5be44979621b6_79202ab8c00045801021d@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c5d6c087268c09d0acd0fa7bd3cdb321207c1536
      https://github.com/OpenSIPS/opensips/commit/c5d6c087268c09d0acd0fa7bd3cdb321207c1536
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/tls_mgm/tls.h
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: fix tls_method for openssl >= 1.1.0

Reported by netaskd(GitHub) in #1517



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 09:46:42 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 06:46:42 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a67387: tls_mgm: fix
 tls_method for openssl >= 1.1.0
Message-ID: <5be44c52ae73b_722f2b09470f25785837f@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a67387f3a1baa1420c8a200f9c42c6be63ec8905
      https://github.com/OpenSIPS/opensips/commit/a67387f3a1baa1420c8a200f9c42c6be63ec8905
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M modules/tls_mgm/tls.h
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: fix tls_method for openssl >= 1.1.0

Reported by netaskd(GitHub) in #1517

(cherry picked from commit c5d6c087268c09d0acd0fa7bd3cdb321207c1536)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 10:10:53 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 07:10:53 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7704ab: Bump version to 2.4.3
Message-ID: <5be451fdc721a_511c2ada260ce5741414e@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7704abb729092fc2d0be01b12802bc971466507c
      https://github.com/OpenSIPS/opensips/commit/7704abb729092fc2d0be01b12802bc971466507c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M Makefile.defs
    M packaging/debian/changelog
    M packaging/freebsd/Makefile
    R packaging/gentoo/opensips-2.4.2.ebuild
    A packaging/gentoo/opensips-2.4.3.ebuild
    M packaging/netbsd/Makefile
    M packaging/openbsd/Makefile
    M packaging/redhat_fedora/opensips.spec
    M packaging/solaris/base-pkginfo
    M packaging/solaris/berkeley-pkginfo
    M packaging/solaris/carrierroute-pkginfo
    M packaging/solaris/identity-pkginfo
    M packaging/solaris/ldap-pkginfo
    M packaging/solaris/mmgeoip-pkginfo
    M packaging/solaris/mysql-pkginfo
    M packaging/solaris/perl-pkginfo
    M packaging/solaris/pgsql-pkginfo
    M packaging/solaris/regex-pkginfo
    M packaging/solaris/snmp-pkginfo
    M packaging/solaris/tls-pkginfo
    M packaging/solaris/xmlrpc-pkginfo

  Log Message:
  -----------
  Bump version to 2.4.3



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 10:14:05 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 08 Nov 2018 07:14:05 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c49ae1: Update ChangeLog for
	2.4.3
Message-ID: <5be452bdcb20e_189b2b1752632588319c3@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c49ae1d5357ef9791ea7e92bd4d09b668a28537a
      https://github.com/OpenSIPS/opensips/commit/c49ae1d5357ef9791ea7e92bd4d09b668a28537a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-08 (Thu, 08 Nov 2018)

  Changed paths:
    M ChangeLog

  Log Message:
  -----------
  Update ChangeLog for 2.4.3



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov  8 10:14:16 2018
From: razvan at opensips.org (razvancrainea)
Date: Thu, 08 Nov 2018 07:14:16 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips]
Message-ID: <5be452c89f5d2_288e2abd2e294580302bd@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/tags/2.4.3
  Home:   https://github.com/OpenSIPS/opensips

      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Fri Nov  9 03:11:02 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Fri, 09 Nov 2018 00:11:02 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8c8d3b: tls_mgm: a bit of
 cleanup of the tls methods
Message-ID: <5be541166bf7c_722e2ac10691e578953da@hookshot-fe-88eb02d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8c8d3b632340a2a412c4e0e4a06cb40e27b9ec2a
      https://github.com/OpenSIPS/opensips/commit/8c8d3b632340a2a412c4e0e4a06cb40e27b9ec2a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M modules/tls_mgm/tls_config_helper.h
    M modules/tls_mgm/tls_mgm.c

  Log Message:
  -----------
  tls_mgm: a bit of cleanup of the tls methods

removed *_cli and *_srv methods, since nobody uses them



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  9 12:30:12 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 09 Nov 2018 09:30:12 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3b1c13: sql_cacher: small doc
 improvement regarding delimi...
Message-ID: <5be5c424e9899_64262b1f67a56584713da@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3b1c13a749328a9f3e341d942ca2a990e95ae877
      https://github.com/OpenSIPS/opensips/commit/3b1c13a749328a9f3e341d942ca2a990e95ae877
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M modules/sql_cacher/doc/sql_cacher_admin.xml

  Log Message:
  -----------
  sql_cacher: small doc improvement regarding delimiter parameters



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  9 12:30:44 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 09 Nov 2018 09:30:44 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3d23d0: sql_cacher: small doc
 improvement regarding delimi...
Message-ID: <5be5c444c98c_73362b006a14858010197c@hookshot-fe-88eb02d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3d23d0fcfcfb897c923a6cfea64b5fba13245664
      https://github.com/OpenSIPS/opensips/commit/3d23d0fcfcfb897c923a6cfea64b5fba13245664
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M modules/sql_cacher/doc/sql_cacher_admin.xml

  Log Message:
  -----------
  sql_cacher: small doc improvement regarding delimiter parameters

(cherry picked from commit 3b1c13a749328a9f3e341d942ca2a990e95ae877)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladp at opensips.org  Fri Nov  9 12:31:01 2018
From: vladp at opensips.org (Vlad Patrascu)
Date: Fri, 09 Nov 2018 09:31:01 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 245916: sql_cacher: small doc
 improvement regarding delimi...
Message-ID: <5be5c4554a6bc_60152ab6b9c6e57c6214f@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 245916deaf15d73df76dba59ee78734fe49b0c24
      https://github.com/OpenSIPS/opensips/commit/245916deaf15d73df76dba59ee78734fe49b0c24
  Author: Vlad Patrascu <vladp at opensips.org>
  Date:   2018-11-09 (Fri, 09 Nov 2018)

  Changed paths:
    M modules/sql_cacher/doc/sql_cacher_admin.xml

  Log Message:
  -----------
  sql_cacher: small doc improvement regarding delimiter parameters

(cherry picked from commit 3b1c13a749328a9f3e341d942ca2a990e95ae877)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sat Nov 10 03:11:19 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sat, 10 Nov 2018 00:11:19 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 03c910: Improve documentation
Message-ID: <5be692a7eb225_c2a2b05fd4905748427f@hookshot-fe-31feec6.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 03c910bdf36a5740ee0f79b146ad46895d2ecda9
      https://github.com/OpenSIPS/opensips/commit/03c910bdf36a5740ee0f79b146ad46895d2ecda9
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-10 (Sat, 10 Nov 2018)

  Changed paths:
    M async.h
    M etc/opensips.cfg
    M modules/acc/doc/acc_admin.xml
    M modules/rtpproxy/doc/rtpproxy_admin.xml
    M modules/sql_cacher/doc/sql_cacher_admin.xml
    M modules/usrloc/doc/usrloc_admin.xml

  Log Message:
  -----------
  Improve documentation

    * sql_cacher: fix grammar
    * usrloc: fix out-of-date explanations; improve wording
    * rtpproxy: improve function signatures (each param is optional)
    * acc: Add $acc_leg examples (negative index); Add links
    * fix typos



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sat Nov 10 03:12:02 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sat, 10 Nov 2018 00:12:02 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 30a7d8: Improve documentation
Message-ID: <5be692d25f094_27872afb6e09a5802576@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 30a7d87731c9b97185e3c88cb512e6ce88469e9f
      https://github.com/OpenSIPS/opensips/commit/30a7d87731c9b97185e3c88cb512e6ce88469e9f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-10 (Sat, 10 Nov 2018)

  Changed paths:
    M async.h
    M etc/opensips.cfg
    M modules/acc/doc/acc_admin.xml
    M modules/rtpproxy/doc/rtpproxy_admin.xml
    M modules/sql_cacher/doc/sql_cacher_admin.xml
    M modules/usrloc/doc/usrloc_admin.xml

  Log Message:
  -----------
  Improve documentation

    * sql_cacher: fix grammar
    * usrloc: fix out-of-date explanations; improve wording
    * rtpproxy: improve function signatures (each param is optional)
    * acc: Add $acc_leg examples (negative index); Add links
    * fix typos

(cherry picked from commit 03c910bdf36a5740ee0f79b146ad46895d2ecda9)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sat Nov 10 03:20:43 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sat, 10 Nov 2018 00:20:43 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d9d27e: Improve documentation
Message-ID: <5be694dbc4702_41812af0f341458864992@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d9d27e35897add8d4ca120ffb9b46f660978fadb
      https://github.com/OpenSIPS/opensips/commit/d9d27e35897add8d4ca120ffb9b46f660978fadb
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-10 (Sat, 10 Nov 2018)

  Changed paths:
    M async.h
    M etc/opensips.cfg
    M modules/rtpproxy/doc/rtpproxy_admin.xml
    M modules/sql_cacher/doc/sql_cacher_admin.xml

  Log Message:
  -----------
  Improve documentation

    * sql_cacher: fix grammar
    * rtpproxy: improve function signatures (each param is optional)
    * fix typos

(cherry picked from commit 03c910bdf36a5740ee0f79b146ad46895d2ecda9)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sun Nov 11 04:20:33 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sun, 11 Nov 2018 01:20:33 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ca50f4: build-contrib.sh:
 Prepare for upcoming module rena...
Message-ID: <5be7f461d5d95_62282af9a52e8578730b6@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ca50f4ae7bc5703bd09276175028f5157d186997
      https://github.com/OpenSIPS/opensips/commit/ca50f4ae7bc5703bd09276175028f5157d186997
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M doc/build-contrib.sh

  Log Message:
  -----------
  build-contrib.sh: Prepare for upcoming module renames

This patch extends the "mod_renames" array logic to allow specifying
modules renamed to older module names (name repurposing) while properly
keeping track of their histories.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sun Nov 11 04:29:54 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sun, 11 Nov 2018 01:29:54 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d6a6e8: build-contrib.sh: Fix
 a counting bug with renamed ...
Message-ID: <5be7f692548e3_22a472aedcb3a8584810c1@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d6a6e8d6830e80a87b48583b79117058a34e720c
      https://github.com/OpenSIPS/opensips/commit/d6a6e8d6830e80a87b48583b79117058a34e720c
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M doc/build-contrib.sh

  Log Message:
  -----------
  build-contrib.sh: Fix a counting bug with renamed modules

The "pre-rename" documentation-related commits were being skipped when
dealing with renamed modules.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sun Nov 11 04:30:59 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sun, 11 Nov 2018 01:30:59 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6eb581: build-contrib.sh: Fix
 a counting bug with renamed ...
Message-ID: <5be7f6d3afd99_60542b03fea4c57c86384@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6eb5817343060ff1945bcff4cd1ee7588e8123ce
      https://github.com/OpenSIPS/opensips/commit/6eb5817343060ff1945bcff4cd1ee7588e8123ce
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M doc/build-contrib.sh

  Log Message:
  -----------
  build-contrib.sh: Fix a counting bug with renamed modules

The "pre-rename" documentation-related commits were being skipped when
dealing with renamed modules.

(cherry picked from commit d6a6e8d6830e80a87b48583b79117058a34e720c)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sun Nov 11 04:31:10 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sun, 11 Nov 2018 01:31:10 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] de714e: build-contrib.sh: Fix
 a counting bug with renamed ...
Message-ID: <5be7f6de5863a_2e1b2ae2b2f2257872429@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: de714edc364949ffbd0bf0d65f1b531b3dd431d8
      https://github.com/OpenSIPS/opensips/commit/de714edc364949ffbd0bf0d65f1b531b3dd431d8
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M doc/build-contrib.sh

  Log Message:
  -----------
  build-contrib.sh: Fix a counting bug with renamed modules

The "pre-rename" documentation-related commits were being skipped when
dealing with renamed modules.

(cherry picked from commit d6a6e8d6830e80a87b48583b79117058a34e720c)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Sun Nov 11 04:36:02 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Sun, 11 Nov 2018 01:36:02 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6ae80c: build-contrib.sh:
	Update mod_renames
Message-ID: <5be7f80236ed4_60112afd1b9bc58865986@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6ae80c8679a22cbcda083180eae1f13b5507da14
      https://github.com/OpenSIPS/opensips/commit/6ae80c8679a22cbcda083180eae1f13b5507da14
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M doc/build-contrib.sh

  Log Message:
  -----------
  build-contrib.sh: Update mod_renames

Do not rename the modules before actually merging "mi_rework"...



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 11 15:10:43 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 11 Nov 2018 12:10:43 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9ca20f: Rebuild documentation
Message-ID: <5be88cc37a649_2b6d2ac9d9b4a578240d3@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9ca20fd2c0e1f5474b4e127875463e368d2d25ab
      https://github.com/OpenSIPS/opensips/commit/9ca20fd2c0e1f5474b4e127875463e368d2d25ab
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M modules/auth_aaa/README
    M modules/auth_aaa/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cpl_c/README
    M modules/cpl_c/doc/contributors.xml
    M modules/db_flatstore/README
    M modules/db_flatstore/doc/contributors.xml
    M modules/db_mysql/README
    M modules/db_mysql/doc/contributors.xml
    M modules/db_perlvdb/README
    M modules/db_perlvdb/doc/contributors.xml
    M modules/db_postgres/README
    M modules/db_postgres/doc/contributors.xml
    M modules/db_text/README
    M modules/db_text/doc/contributors.xml
    M modules/db_unixodbc/README
    M modules/db_unixodbc/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/proto_ws/README
    M modules/proto_ws/doc/contributors.xml
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/uri/README
    M modules/uri/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 11 15:19:48 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 11 Nov 2018 12:19:48 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b3b1d2: Rebuild documentation
Message-ID: <5be88ee4d1456_16682af033d6857886174@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b3b1d207f69eba8cfd7aeb6a6ee2e99f7922b481
      https://github.com/OpenSIPS/opensips/commit/b3b1d207f69eba8cfd7aeb6a6ee2e99f7922b481
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M modules/auth_aaa/README
    M modules/auth_aaa/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cpl_c/README
    M modules/cpl_c/doc/contributors.xml
    M modules/db_flatstore/README
    M modules/db_flatstore/doc/contributors.xml
    M modules/db_mysql/README
    M modules/db_mysql/doc/contributors.xml
    M modules/db_perlvdb/README
    M modules/db_perlvdb/doc/contributors.xml
    M modules/db_postgres/README
    M modules/db_postgres/doc/contributors.xml
    M modules/db_text/README
    M modules/db_text/doc/contributors.xml
    M modules/db_unixodbc/README
    M modules/db_unixodbc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 11 15:30:28 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 11 Nov 2018 12:30:28 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8d3d8b: Rebuild documentation
Message-ID: <5be891643aac5_2fda2af2c3fc659410098a@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8d3d8b8a4749938e252320262c448c89dd853a3e
      https://github.com/OpenSIPS/opensips/commit/8d3d8b8a4749938e252320262c448c89dd853a3e
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/auth_aaa/README
    M modules/auth_aaa/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cpl_c/README
    M modules/cpl_c/doc/contributors.xml
    M modules/db_flatstore/README
    M modules/db_flatstore/doc/contributors.xml
    M modules/db_mysql/README
    M modules/db_mysql/doc/contributors.xml
    M modules/db_perlvdb/README
    M modules/db_perlvdb/doc/contributors.xml
    M modules/db_postgres/README
    M modules/db_postgres/doc/contributors.xml
    M modules/db_text/README
    M modules/db_text/doc/contributors.xml
    M modules/db_unixodbc/README
    M modules/db_unixodbc/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/registrar/README
    M modules/registrar/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/uri/README
    M modules/uri/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 11 15:42:09 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 11 Nov 2018 12:42:09 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 02ca3e: Rebuild documentation
Message-ID: <5be8942115bad_3a122ac463daa578725f0@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 02ca3eb8b2b1657c5348c2ab62fe536992e9ad2f
      https://github.com/OpenSIPS/opensips/commit/02ca3eb8b2b1657c5348c2ab62fe536992e9ad2f
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-11 (Sun, 11 Nov 2018)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/auth_aaa/README
    M modules/auth_aaa/doc/contributors.xml
    M modules/cachedb_local/README
    M modules/cachedb_local/doc/contributors.xml
    M modules/cgrates/README
    M modules/cgrates/doc/contributors.xml
    M modules/clusterer/README
    M modules/clusterer/doc/contributors.xml
    M modules/cpl_c/README
    M modules/cpl_c/doc/contributors.xml
    M modules/db_flatstore/README
    M modules/db_flatstore/doc/contributors.xml
    M modules/db_mysql/README
    M modules/db_mysql/doc/contributors.xml
    M modules/db_perlvdb/README
    M modules/db_perlvdb/doc/contributors.xml
    M modules/db_postgres/README
    M modules/db_postgres/doc/contributors.xml
    M modules/db_unixodbc/README
    M modules/db_unixodbc/doc/contributors.xml
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/mid_registrar/README
    M modules/mid_registrar/doc/contributors.xml
    M modules/presence/README
    M modules/presence/doc/contributors.xml
    M modules/registrar/README
    M modules/registrar/doc/contributors.xml
    M modules/rtpengine/README
    M modules/rtpengine/doc/contributors.xml
    M modules/rtpproxy/README
    M modules/rtpproxy/doc/contributors.xml
    M modules/sql_cacher/README
    M modules/sql_cacher/doc/contributors.xml
    M modules/stun/README
    M modules/stun/doc/contributors.xml
    M modules/tls_mgm/README
    M modules/tls_mgm/doc/contributors.xml
    M modules/usrloc/README
    M modules/usrloc/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 12 10:29:48 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 12 Nov 2018 07:29:48 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ae32d8: dialog: Fix outdated
	warning
Message-ID: <5be99c6ce486a_3c372b0c7915a5809814f@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ae32d8e487e37955be7e594dd439eb03f3554dfc
      https://github.com/OpenSIPS/opensips/commit/ae32d8e487e37955be7e594dd439eb03f3554dfc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  dialog: Fix outdated warning



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 12 10:30:24 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 12 Nov 2018 07:30:24 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7730f2: dialog: Fix outdated
	warning
Message-ID: <5be99c9037029_383e2aec8ecda578256dd@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7730f225b514840f68d649ca41088a024564250e
      https://github.com/OpenSIPS/opensips/commit/7730f225b514840f68d649ca41088a024564250e
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M modules/dialog/dlg_profile.c

  Log Message:
  -----------
  dialog: Fix outdated warning

(cherry picked from commit ae32d8e487e37955be7e594dd439eb03f3554dfc)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From z at startit.ru  Mon Nov  5 10:30:25 2018
From: z at startit.ru (zzz)
Date: Mon, 5 Nov 2018 15:30:25 +0000
Subject: [OpenSIPS-Devel] [OpenSIPS-Users] OpenSIPS Control Panel 8.2.4
	was released
In-Reply-To: <e4c2b527-6dce-7416-2445-2063a7033397@opensips.org>
References: <e4c2b527-6dce-7416-2445-2063a7033397@opensips.org>
Message-ID: <8B36F227BD22B041AEA7015FD914CD9503817141FA@JET-EX02.jettel.ru>

Hi Bogdan,
Thanks for all you do.
Ive tried the new release on debian8, it works great.
Would you please change "domaini" to "domain" in the file acl_management.php
https://github.com/OpenSIPS/opensips-cp/blob/8.2.4/web/tools/users/acl_management/acl_management.php
lines 156 and 169.
Thanks,
Yuriy



-----Original Message-----
From: Users [mailto:users-bounces at lists.opensips.org] On Behalf Of Bogdan-Andrei Iancu
Sent: Thursday, November 1, 2018 2:12 PM
To: users at lists.opensips.org; developensips <Devel at lists.opensips.org>; business at lists.opensips.org
Subject: [OpenSIPS-Users] OpenSIPS Control Panel 8.2.4 was released

Hi all,

We are proud and happy to announce the release of the OpenSIPS Control Panel 8.2.4 . This OpenSIPS Control Panel is a provisioning (SIP users and OpenSIPS system) web interface design for and compatible with OpenSIPS 2.4 LTS - http://controlpanel.opensips.org .


The OCP 8.2.4 has new awesome additions :

* a new modern look by reworking the entire CSS and layout, see http://controlpanel.opensips.org/screenshots.php

* a new tool for handling the RTPEngine instances via database

* a new tool for provisioning TLS domains and certificates via database

* a more powerful Tviewer engine to allow more complex displaying, correlation and validation of the data types and to create inter-tool web links.


In the same time the OCP 8.2.4 brings great improvements under the hood:

* compatibility with PHP 7, by migrating from MDB2 to PDO database support

* better security of the DB operations by migrating to prepared statements, to avoid SQL injections

* improved security for the WEB sessions and page access to avoid illegitimate direct access to sub-pages

* extended tooltip and data validation support

* code refactoring for easy further development


This new OpenSIPS Control Panel release is a significant step forward for the project in terms of vision. All this happened thanks to the people and companies involved in the development of the project.

Special thanks to the Voicenter team - https://www.voicenter.com -  for its great contribution in re-styling and re-designing this web interface.


Download and enjoy it as it's freshly baked for you,

-- 
Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com


_______________________________________________
Users mailing list
Users at lists.opensips.org
http://lists.opensips.org/cgi-bin/mailman/listinfo/users

From Ben.Newlin at genesys.com  Mon Nov 12 13:55:20 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Mon, 12 Nov 2018 18:55:20 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
Message-ID: <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>

Bogdan,

We upgraded to 2.4.3 and the crash reproduced today. Backtrace is available here: https://pastebin.com/CZxQnZdR.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Wednesday, November 7, 2018 at 6:18 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

The BT indicates a double free for the accounting context - and I noticed you use 2.4.1 version. And yes, there was an issue related to acc context, issue that was fixed starting 2.4.2. So, could you upgrade to the latest 2.4 and see if the crash still happens ? As I think the fix is already there.

Regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
Jackpot - you get it right !! I will start digging into the trace, but please keep the corefile, I might need it later.

Thanks and regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 10:24 PM, Ben Newlin wrote:
Bogdan,

I have reproduced this crash and verified this time that the flags were set.

$ opensips -V
version: opensips 2.4.1 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 5d042cffc
main.c compiled on 23:38:55 Nov  5 2018 with gcc 7

Backtrace is available here: https://pastebin.com/KTQjkCwq<https://pastebin.com/KTQjkCwq>

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, November 1, 2018 at 1:19 PM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an "opensips -V" to check the resulting compile flags - do you see the DBG_MALLOC and QM_MALLOC ?

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/31/2018 05:04 PM, Ben Newlin wrote:
Bogdan,

I was able to compile with those options and the crash has occurred again. Backtrace is here: https://pastebin.com/dezi9xUU<https://pastebin.com/dezi9xUU>.

Even though I had `memdump=1` set in my script, there was no extra memory debugging information in the logs prior to or at the time of the crash. I’m not sure if that is expected or not.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, October 29, 2018 at 8:11 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

You can change the compile flags via the Makefile.conf file - the menuconfig is also updating that file. So during your build you can simply push a pre-modified Makefile.conf file with the options needed for memory debugging.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/26/2018 05:14 PM, Ben Newlin wrote:
Bogdan,

Unfortunately, we have run into a similar issue before. Our build system is completely automated and there is no way to inject the `make menuconfig` interactive step into that process. If I were to be testing this locally I might be able to work something out, but I could never get such a build into our testing environment which is where the crashes are occurring.

Do you have instructions for enabling memory debugging that do not require using the interactive TUI tool? What does the menuconfig program do when these options are selected? Are there some defines or other settings we can change ourselves and bypass menuconfig?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, October 26, 2018 at 4:59 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

all the BT's points to crashes while doing memory ops. I suspect a memory corruption that randomly triggers crashes in different parts of the code.

Could you try to re-compile with memory debugging support ? See http://www.opensips.org/Documentation/TroubleShooting-OutOfMem<http://www.opensips.org/Documentation/TroubleShooting-OutOfMem>, the "How to handle it" section.

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/24/2018 04:28 AM, Ben Newlin wrote:
We have had 2 more crashes today.

Crash 2: https://pastebin.com/rMruBQcZ<https://pastebin.com/rMruBQcZ>
This crash appears to have occurred while processing an initial INVITE request. I could not see anything unusual about the request. I cannot tell if this crash is related to the others.

Crash 3: https://pastebin.com/Gmk1m4NT<https://pastebin.com/Gmk1m4NT>
This crash follows the pattern of the original crash I reported.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Monday, October 22, 2018 at 4:45 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Here is a better trace of the call: https://pastebin.com/gWpQR8E7<https://pastebin.com/gWpQR8E7>

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Date: Monday, October 22, 2018 at 4:34 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: OpenSIPS Crash

Hello,

We have been having sporadic crashes and I was recently able to recover a core dump for one. I have uploaded it here: https://pastebin.com/ABktcYcH<https://pastebin.com/ABktcYcH>.

I picked out a Call-ID from the crash data and took a look in our tracing. I have uploaded it here: https://pastebin.com/ZEzUUKZ5<https://pastebin.com/ZEzUUKZ5>.

It appears that a downstream server was extremely lagged and failed to respond to an INVITE. We sent the INVITE to another server and the call was connected, but then eventually the original server “caught up” and sent a burst of 200 OK responses. The crash seems to have occurred processing the ACK to one of these responses.

Ben Newlin







_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>

















_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181112/e97837fa/attachment-0001.html>

From bogdan at opensips.org  Tue Nov 13 09:13:42 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 13 Nov 2018 16:13:42 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
Message-ID: <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>

Hi Ben,

Thanks for the info. The crash happens when you try to set an acc extra 
variable in branch route (when a creating a new branch via failure 
route, on timeout).

Now, do you use the drop accounting in your script ? and considering the 
above scenario, it is possible to have the drop acc before the branch 
route ?

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/12/2018 08:55 PM, Ben Newlin wrote:
>
> Bogdan,
>
> We upgraded to 2.4.3 and the crash reproduced today. Backtrace is 
> available here: https://pastebin.com/CZxQnZdR.
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Wednesday, November 7, 2018 at 6:18 AM
> *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>, Ben 
> Newlin <Ben.Newlin at genesys.com>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> The BT indicates a double free for the accounting context - and I 
> noticed you use 2.4.1 version. And yes, there was an issue related to 
> acc context, issue that was fixed starting 2.4.2. So, could you 
> upgrade to the latest 2.4 and see if the crash still happens ? As I 
> think the fix is already there.
>
> Regards,
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
>
>     Jackpot - you get it right !! I will start digging into the trace,
>     but please keep the corefile, I might need it later.
>
>     Thanks and regards,
>
>     Bogdan-Andrei Iancu
>
>     OpenSIPS Founder and Developer
>
>        http://www.opensips-solutions.com
>
>     OpenSIPS Bootcamp 2018
>
>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>     On 11/06/2018 10:24 PM, Ben Newlin wrote:
>
>         Bogdan,
>
>         I have reproduced this crash and verified this time that the
>         flags were set.
>
>         $ opensips -V
>
>         version: opensips 2.4.1 (x86_64/linux)
>
>         flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP,
>         PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT,
>         DBG_LOCK
>
>         ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144,
>         MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
>
>         poll method support: poll, epoll, sigio_rt, select.
>
>         git revision: 5d042cffc
>
>         main.c compiled on 23:38:55 Nov  5 2018 with gcc 7
>
>         Backtrace is available here: https://pastebin.com/KTQjkCwq
>         <https://pastebin.com/KTQjkCwq>
>
>         Ben Newlin
>
>         *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>         <mailto:bogdan at opensips.org>
>         *Date: *Thursday, November 1, 2018 at 1:19 PM
>         *To: *Ben Newlin <Ben.Newlin at genesys.com>
>         <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list
>         <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>         Hi Ben,
>
>         According to the backtrace, the memory debugger was not
>         activated. Do an "opensips -V" to check the resulting compile
>         flags - do you see the DBG_MALLOC and QM_MALLOC ?
>
>         Regards,
>
>
>         Bogdan-Andrei Iancu
>
>           
>
>         OpenSIPS Founder and Developer
>
>            http://www.opensips-solutions.com
>
>         OpenSIPS Bootcamp 2018
>
>            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>         On 10/31/2018 05:04 PM, Ben Newlin wrote:
>
>             Bogdan,
>
>             I was able to compile with those options and the crash has
>             occurred again. Backtrace is here:
>             https://pastebin.com/dezi9xUU <https://pastebin.com/dezi9xUU>.
>
>             Even though I had `memdump=1` set in my script, there was
>             no extra memory debugging information in the logs prior to
>             or at the time of the crash. I’m not sure if that is
>             expected or not.
>
>             Ben Newlin
>
>             *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>             <mailto:bogdan at opensips.org>
>             *Date: *Monday, October 29, 2018 at 8:11 AM
>             *To: *Ben Newlin <Ben.Newlin at genesys.com>
>             <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling
>             list <devel at lists.opensips.org>
>             <mailto:devel at lists.opensips.org>
>             *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>             Hi Ben,
>
>             You can change the compile flags via the Makefile.conf
>             file - the menuconfig is also updating that file. So
>             during your build you can simply push a pre-modified
>             Makefile.conf file with the options needed for memory
>             debugging.
>
>             Regards,
>
>
>
>             Bogdan-Andrei Iancu
>
>               
>
>             OpenSIPS Founder and Developer
>
>                http://www.opensips-solutions.com
>
>             OpenSIPS Bootcamp 2018
>
>                http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>             On 10/26/2018 05:14 PM, Ben Newlin wrote:
>
>                 Bogdan,
>
>                 Unfortunately, we have run into a similar issue
>                 before. Our build system is completely automated and
>                 there is no way to inject the `make menuconfig`
>                 interactive step into that process. If I were to be
>                 testing this locally I might be able to work something
>                 out, but I could never get such a build into our
>                 testing environment which is where the crashes are
>                 occurring.
>
>                 Do you have instructions for enabling memory debugging
>                 that do not require using the interactive TUI tool?
>                 What does the menuconfig program do when these options
>                 are selected? Are there some defines or other settings
>                 we can change ourselves and bypass menuconfig?
>
>                 Ben Newlin
>
>                 *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                 <mailto:bogdan at opensips.org>
>                 *Date: *Friday, October 26, 2018 at 4:59 AM
>                 *To: *OpenSIPS devel mailling list
>                 <devel at lists.opensips.org>
>                 <mailto:devel at lists.opensips.org>, Ben Newlin
>                 <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>                 *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                 Hi Ben,
>
>                 all the BT's points to crashes while doing memory ops.
>                 I suspect a memory corruption that randomly triggers
>                 crashes in different parts of the code.
>
>                 Could you try to re-compile with memory debugging
>                 support ? See
>                 http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>                 the "How to handle it" section.
>
>                 Regards,
>
>
>
>
>                 Bogdan-Andrei Iancu
>
>                   
>
>                 OpenSIPS Founder and Developer
>
>                    http://www.opensips-solutions.com
>
>                 OpenSIPS Bootcamp 2018
>
>                    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                 On 10/24/2018 04:28 AM, Ben Newlin wrote:
>
>                     We have had 2 more crashes today.
>
>                     Crash 2: https://pastebin.com/rMruBQcZ
>                     <https://pastebin.com/rMruBQcZ>
>
>                     This crash appears to have occurred while
>                     processing an initial INVITE request. I could not
>                     see anything unusual about the request. I cannot
>                     tell if this crash is related to the others.
>
>                     Crash 3: https://pastebin.com/Gmk1m4NT
>                     <https://pastebin.com/Gmk1m4NT>
>
>                     This crash follows the pattern of the original
>                     crash I reported.
>
>                     Ben Newlin
>
>                     *From: *Devel <devel-bounces at lists.opensips.org>
>                     <mailto:devel-bounces at lists.opensips.org> on
>                     behalf of Ben Newlin <Ben.Newlin at genesys.com>
>                     <mailto:Ben.Newlin at genesys.com>
>                     *Reply-To: *OpenSIPS devel mailling list
>                     <devel at lists.opensips.org>
>                     <mailto:devel at lists.opensips.org>
>                     *Date: *Monday, October 22, 2018 at 4:45 PM
>                     *To: *OpenSIPS devel mailling list
>                     <devel at lists.opensips.org>
>                     <mailto:devel at lists.opensips.org>
>                     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                     Here is a better trace of the call:
>                     https://pastebin.com/gWpQR8E7
>                     <https://pastebin.com/gWpQR8E7>
>
>                     Ben Newlin
>
>                     *From: *Ben Newlin <Ben.Newlin at genesys.com>
>                     <mailto:Ben.Newlin at genesys.com>
>                     *Date: *Monday, October 22, 2018 at 4:34 PM
>                     *To: *OpenSIPS devel mailling list
>                     <devel at lists.opensips.org>
>                     <mailto:devel at lists.opensips.org>
>                     *Subject: *OpenSIPS Crash
>
>                     Hello,
>
>                     We have been having sporadic crashes and I was
>                     recently able to recover a core dump for one. I
>                     have uploaded it here:
>                     https://pastebin.com/ABktcYcH
>                     <https://pastebin.com/ABktcYcH>.
>
>                     I picked out a Call-ID from the crash data and
>                     took a look in our tracing. I have uploaded it
>                     here: https://pastebin.com/ZEzUUKZ5
>                     <https://pastebin.com/ZEzUUKZ5>.
>
>                     It appears that a downstream server was extremely
>                     lagged and failed to respond to an INVITE. We sent
>                     the INVITE to another server and the call was
>                     connected, but then eventually the original server
>                     “caught up” and sent a burst of 200 OK responses.
>                     The crash seems to have occurred processing the
>                     ACK to one of these responses.
>
>                     Ben Newlin
>
>
>
>
>
>
>
>                     _______________________________________________
>
>                     Devel mailing list
>
>                     Devel at lists.opensips.org
>                     <mailto:Devel at lists.opensips.org>
>
>                     http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>     _______________________________________________
>
>     Devel mailing list
>
>     Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>
>     http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181113/f6df0a4f/attachment-0001.html>

From bogdan at opensips.org  Tue Nov 13 12:08:46 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 13 Nov 2018 09:08:46 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 42934c: Fix annoying bogus
	error log
Message-ID: <5beb051e5e6be_2bbe2abc21fe4590908de@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 42934c42400842a2e72e6766e040037f366643f4
      https://github.com/OpenSIPS/opensips/commit/42934c42400842a2e72e6766e040037f366643f4
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M parser/sdp/sdp.c

  Log Message:
  -----------
  Fix annoying bogus error log



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 13 12:09:23 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 13 Nov 2018 09:09:23 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bc8598: Fix annoying bogus
	error log
Message-ID: <5beb054337ce9_70662ab1dccd859471124@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: bc859828a3e79877845236c89af9784bca2b2eec
      https://github.com/OpenSIPS/opensips/commit/bc859828a3e79877845236c89af9784bca2b2eec
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M parser/sdp/sdp.c

  Log Message:
  -----------
  Fix annoying bogus error log

(cherry picked from commit 42934c42400842a2e72e6766e040037f366643f4)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 13 12:09:43 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 13 Nov 2018 09:09:43 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 857b9a: Fix annoying bogus
	error log
Message-ID: <5beb0557640f_c3e2ab1a5a8a580457db@hookshot-fe-31feec6.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 857b9a1dc149fac607de0ffd6d4b49b439f1a751
      https://github.com/OpenSIPS/opensips/commit/857b9a1dc149fac607de0ffd6d4b49b439f1a751
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-13 (Tue, 13 Nov 2018)

  Changed paths:
    M parser/sdp/sdp.c

  Log Message:
  -----------
  Fix annoying bogus error log

(cherry picked from commit 42934c42400842a2e72e6766e040037f366643f4)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Wed Nov 14 06:18:08 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Wed, 14 Nov 2018 03:18:08 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2bee3c: rtpengine: reconnect
 socket in case of bad fds
Message-ID: <5bec0470e0785_3dba2adc7cf2c5789783b@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2bee3c6df0a4a1c6ffde7556c95c7ee88b923b6f
      https://github.com/OpenSIPS/opensips/commit/2bee3c6df0a4a1c6ffde7556c95c7ee88b923b6f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: reconnect socket in case of bad fds



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Wed Nov 14 06:18:27 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Wed, 14 Nov 2018 03:18:27 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c94041: rtpengine: reconnect
 socket in case of bad fds
Message-ID: <5bec04831f902_3d122aff34444590129477@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c940412bb3d82146e7ab1bc3d6c85dae89cec49b
      https://github.com/OpenSIPS/opensips/commit/c940412bb3d82146e7ab1bc3d6c85dae89cec49b
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: reconnect socket in case of bad fds

(cherry picked from commit 2bee3c6df0a4a1c6ffde7556c95c7ee88b923b6f)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Wed Nov 14 11:07:11 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Wed, 14 Nov 2018 08:07:11 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8f7314: rest_client: Fix
	swapped parameters
Message-ID: <5bec482ffddb_5052ae21b98a580539eb@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8f73149b26a142b2511804b9c7385babc916874b
      https://github.com/OpenSIPS/opensips/commit/8f73149b26a142b2511804b9c7385babc916874b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M modules/rest_client/rest_client.c
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Fix swapped parameters

Affected functions: async rest_post() and async rest_put().

Reported by Ben Newlin.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Wed Nov 14 11:08:13 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Wed, 14 Nov 2018 08:08:13 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] fb2aaf: rest_client: Fix
	swapped parameters
Message-ID: <5bec486dc3217_514d2ac1f502c57410347@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: fb2aaf65ed993f429b2f12b547dc872aa8632992
      https://github.com/OpenSIPS/opensips/commit/fb2aaf65ed993f429b2f12b547dc872aa8632992
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-14 (Wed, 14 Nov 2018)

  Changed paths:
    M modules/rest_client/rest_client.c
    M modules/rest_client/rest_methods.c

  Log Message:
  -----------
  rest_client: Fix swapped parameters

Affected functions: async rest_post() and async rest_put().

Reported by Ben Newlin.

(cherry picked from commit 8f73149b26a142b2511804b9c7385babc916874b)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov 15 04:51:19 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 15 Nov 2018 01:51:19 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8bbc18: event_jsonrpc: use an
 unique flag for declaring ev...
Message-ID: <5bed419738387_3d4a2ae8224fa59423134@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 8bbc185888730fc1c49a8b3f3fec1550afbf4a74
      https://github.com/OpenSIPS/opensips/commit/8bbc185888730fc1c49a8b3f3fec1550afbf4a74
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-15 (Thu, 15 Nov 2018)

  Changed paths:
    M modules/event_jsonrpc/event_jsonrpc.h

  Log Message:
  -----------
  event_jsonrpc: use an unique flag for declaring events



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov 15 04:51:39 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 15 Nov 2018 01:51:39 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3fe6c3: event_jsonrpc: use an
 unique flag for declaring ev...
Message-ID: <5bed41ab39181_5dc72b0e7184058061072@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3fe6c3804c3e2ed2bdc884d1dbc053940f72f557
      https://github.com/OpenSIPS/opensips/commit/3fe6c3804c3e2ed2bdc884d1dbc053940f72f557
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-15 (Thu, 15 Nov 2018)

  Changed paths:
    M modules/event_jsonrpc/event_jsonrpc.h

  Log Message:
  -----------
  event_jsonrpc: use an unique flag for declaring events

(cherry picked from commit 8bbc185888730fc1c49a8b3f3fec1550afbf4a74)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From Ben.Newlin at genesys.com  Tue Nov 13 12:41:52 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Tue, 13 Nov 2018 17:41:52 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
Message-ID: <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>

Bogdan,

Yes, we are setting acc_extra variables in our branch routes, which are sometimes (but not always) called from failure route. Are acc_extra variables not available for use in branch_routes?

We don’t currently use drop_accounting anywhere in our script. If I call it before that branch_route then it will stop accounting for that call, right? We need to have accounting records for the call, so I’m not sure how that would resolve the issue?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Tuesday, November 13, 2018 at 9:13 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for the info. The crash happens when you try to set an acc extra variable in branch route (when a creating a new branch via failure route, on timeout).

Now, do you use the drop accounting in your script ? and considering the above scenario, it is possible to have the drop acc before the branch route ?

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/12/2018 08:55 PM, Ben Newlin wrote:
Bogdan,

We upgraded to 2.4.3 and the crash reproduced today. Backtrace is available here: https://pastebin.com/CZxQnZdR<https://pastebin.com/CZxQnZdR>.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Wednesday, November 7, 2018 at 6:18 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

The BT indicates a double free for the accounting context - and I noticed you use 2.4.1 version. And yes, there was an issue related to acc context, issue that was fixed starting 2.4.2. So, could you upgrade to the latest 2.4 and see if the crash still happens ? As I think the fix is already there.

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
Jackpot - you get it right !! I will start digging into the trace, but please keep the corefile, I might need it later.

Thanks and regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 10:24 PM, Ben Newlin wrote:
Bogdan,

I have reproduced this crash and verified this time that the flags were set.

$ opensips -V
version: opensips 2.4.1 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 5d042cffc
main.c compiled on 23:38:55 Nov  5 2018 with gcc 7

Backtrace is available here: https://pastebin.com/KTQjkCwq<https://pastebin.com/KTQjkCwq>

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, November 1, 2018 at 1:19 PM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an "opensips -V" to check the resulting compile flags - do you see the DBG_MALLOC and QM_MALLOC ?

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/31/2018 05:04 PM, Ben Newlin wrote:
Bogdan,

I was able to compile with those options and the crash has occurred again. Backtrace is here: https://pastebin.com/dezi9xUU<https://pastebin.com/dezi9xUU>.

Even though I had `memdump=1` set in my script, there was no extra memory debugging information in the logs prior to or at the time of the crash. I’m not sure if that is expected or not.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, October 29, 2018 at 8:11 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

You can change the compile flags via the Makefile.conf file - the menuconfig is also updating that file. So during your build you can simply push a pre-modified Makefile.conf file with the options needed for memory debugging.

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/26/2018 05:14 PM, Ben Newlin wrote:
Bogdan,

Unfortunately, we have run into a similar issue before. Our build system is completely automated and there is no way to inject the `make menuconfig` interactive step into that process. If I were to be testing this locally I might be able to work something out, but I could never get such a build into our testing environment which is where the crashes are occurring.

Do you have instructions for enabling memory debugging that do not require using the interactive TUI tool? What does the menuconfig program do when these options are selected? Are there some defines or other settings we can change ourselves and bypass menuconfig?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, October 26, 2018 at 4:59 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

all the BT's points to crashes while doing memory ops. I suspect a memory corruption that randomly triggers crashes in different parts of the code.

Could you try to re-compile with memory debugging support ? See http://www.opensips.org/Documentation/TroubleShooting-OutOfMem<http://www.opensips.org/Documentation/TroubleShooting-OutOfMem>, the "How to handle it" section.

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/24/2018 04:28 AM, Ben Newlin wrote:
We have had 2 more crashes today.

Crash 2: https://pastebin.com/rMruBQcZ<https://pastebin.com/rMruBQcZ>
This crash appears to have occurred while processing an initial INVITE request. I could not see anything unusual about the request. I cannot tell if this crash is related to the others.

Crash 3: https://pastebin.com/Gmk1m4NT<https://pastebin.com/Gmk1m4NT>
This crash follows the pattern of the original crash I reported.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Monday, October 22, 2018 at 4:45 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Here is a better trace of the call: https://pastebin.com/gWpQR8E7<https://pastebin.com/gWpQR8E7>

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Date: Monday, October 22, 2018 at 4:34 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: OpenSIPS Crash

Hello,

We have been having sporadic crashes and I was recently able to recover a core dump for one. I have uploaded it here: https://pastebin.com/ABktcYcH<https://pastebin.com/ABktcYcH>.

I picked out a Call-ID from the crash data and took a look in our tracing. I have uploaded it here: https://pastebin.com/ZEzUUKZ5<https://pastebin.com/ZEzUUKZ5>.

It appears that a downstream server was extremely lagged and failed to respond to an INVITE. We sent the INVITE to another server and the call was connected, but then eventually the original server “caught up” and sent a burst of 200 OK responses. The crash seems to have occurred processing the ACK to one of these responses.

Ben Newlin








_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>





















_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181113/99583496/attachment-0001.html>

From bogdan at opensips.org  Thu Nov 15 07:06:21 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 15 Nov 2018 14:06:21 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
Message-ID: <5e79332b-c921-a4fa-2ab6-0ec53eff0cf7@opensips.org>

Hi Ben,

How often this crash happens ? are you able to reproduce it ?

The acc extra should work in the branch route, no problem. Out of 
curiosity, I will try to reproduce you case (timeout -> failure route -> 
t_relay -> branch_route) to see if I can reproduce it.

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/13/2018 07:41 PM, Ben Newlin wrote:
>
> Bogdan,
>
> Yes, we are setting acc_extra variables in our branch routes, which 
> are sometimes (but not always) called from failure route. Are 
> acc_extra variables not available for use in branch_routes?
>
> We don’t currently use drop_accounting anywhere in our script. If I 
> call it before that branch_route then it will stop accounting for that 
> call, right? We need to have accounting records for the call, so I’m 
> not sure how that would resolve the issue?
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Tuesday, November 13, 2018 at 9:13 AM
> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
> list <devel at lists.opensips.org>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> Thanks for the info. The crash happens when you try to set an acc 
> extra variable in branch route (when a creating a new branch via 
> failure route, on timeout).
>
> Now, do you use the drop accounting in your script ? and considering 
> the above scenario, it is possible to have the drop acc before the 
> branch route ?
>
> Regards,
>
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 11/12/2018 08:55 PM, Ben Newlin wrote:
>
>     Bogdan,
>
>     We upgraded to 2.4.3 and the crash reproduced today. Backtrace is
>     available here: https://pastebin.com/CZxQnZdR
>     <https://pastebin.com/CZxQnZdR>.
>
>     Ben Newlin
>
>     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>     <mailto:bogdan at opensips.org>
>     *Date: *Wednesday, November 7, 2018 at 6:18 AM
>     *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>     <mailto:devel at lists.opensips.org>, Ben Newlin
>     <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>     Hi Ben,
>
>     The BT indicates a double free for the accounting context - and I
>     noticed you use 2.4.1 version. And yes, there was an issue related
>     to acc context, issue that was fixed starting 2.4.2. So, could you
>     upgrade to the latest 2.4 and see if the crash still happens ? As
>     I think the fix is already there.
>
>     Regards,
>
>
>     Bogdan-Andrei Iancu
>
>       
>
>     OpenSIPS Founder and Developer
>
>        http://www.opensips-solutions.com
>
>     OpenSIPS Bootcamp 2018
>
>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>     On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
>
>         Jackpot - you get it right !! I will start digging into the
>         trace, but please keep the corefile, I might need it later.
>
>         Thanks and regards,
>
>
>         Bogdan-Andrei Iancu
>
>           
>
>         OpenSIPS Founder and Developer
>
>            http://www.opensips-solutions.com
>
>         OpenSIPS Bootcamp 2018
>
>            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>         On 11/06/2018 10:24 PM, Ben Newlin wrote:
>
>             Bogdan,
>
>             I have reproduced this crash and verified this time that
>             the flags were set.
>
>             $ opensips -V
>
>             version: opensips 2.4.1 (x86_64/linux)
>
>             flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP,
>             PKG_MALLOC, QM_MALLOC, DBG_MALLOC,
>             FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
>
>             ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144,
>             MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
>
>             poll method support: poll, epoll, sigio_rt, select.
>
>             git revision: 5d042cffc
>
>             main.c compiled on 23:38:55 Nov  5 2018 with gcc 7
>
>             Backtrace is available here: https://pastebin.com/KTQjkCwq
>             <https://pastebin.com/KTQjkCwq>
>
>             Ben Newlin
>
>             *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>             <mailto:bogdan at opensips.org>
>             *Date: *Thursday, November 1, 2018 at 1:19 PM
>             *To: *Ben Newlin <Ben.Newlin at genesys.com>
>             <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling
>             list <devel at lists.opensips.org>
>             <mailto:devel at lists.opensips.org>
>             *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>             Hi Ben,
>
>             According to the backtrace, the memory debugger was not
>             activated. Do an "opensips -V" to check the resulting
>             compile flags - do you see the DBG_MALLOC and QM_MALLOC ?
>
>             Regards,
>
>
>
>             Bogdan-Andrei Iancu
>
>               
>
>             OpenSIPS Founder and Developer
>
>                http://www.opensips-solutions.com
>
>             OpenSIPS Bootcamp 2018
>
>                http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>             On 10/31/2018 05:04 PM, Ben Newlin wrote:
>
>                 Bogdan,
>
>                 I was able to compile with those options and the crash
>                 has occurred again. Backtrace is here:
>                 https://pastebin.com/dezi9xUU
>                 <https://pastebin.com/dezi9xUU>.
>
>                 Even though I had `memdump=1` set in my script, there
>                 was no extra memory debugging information in the logs
>                 prior to or at the time of the crash. I’m not sure if
>                 that is expected or not.
>
>                 Ben Newlin
>
>                 *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                 <mailto:bogdan at opensips.org>
>                 *Date: *Monday, October 29, 2018 at 8:11 AM
>                 *To: *Ben Newlin <Ben.Newlin at genesys.com>
>                 <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel
>                 mailling list <devel at lists.opensips.org>
>                 <mailto:devel at lists.opensips.org>
>                 *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                 Hi Ben,
>
>                 You can change the compile flags via the Makefile.conf
>                 file - the menuconfig is also updating that file. So
>                 during your build you can simply push a pre-modified
>                 Makefile.conf file with the options needed for memory
>                 debugging.
>
>                 Regards,
>
>
>
>
>                 Bogdan-Andrei Iancu
>
>                   
>
>                 OpenSIPS Founder and Developer
>
>                    http://www.opensips-solutions.com
>
>                 OpenSIPS Bootcamp 2018
>
>                    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                 On 10/26/2018 05:14 PM, Ben Newlin wrote:
>
>                     Bogdan,
>
>                     Unfortunately, we have run into a similar issue
>                     before. Our build system is completely automated
>                     and there is no way to inject the `make
>                     menuconfig` interactive step into that process. If
>                     I were to be testing this locally I might be able
>                     to work something out, but I could never get such
>                     a build into our testing environment which is
>                     where the crashes are occurring.
>
>                     Do you have instructions for enabling memory
>                     debugging that do not require using the
>                     interactive TUI tool? What does the menuconfig
>                     program do when these options are selected? Are
>                     there some defines or other settings we can change
>                     ourselves and bypass menuconfig?
>
>                     Ben Newlin
>
>                     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                     <mailto:bogdan at opensips.org>
>                     *Date: *Friday, October 26, 2018 at 4:59 AM
>                     *To: *OpenSIPS devel mailling list
>                     <devel at lists.opensips.org>
>                     <mailto:devel at lists.opensips.org>, Ben Newlin
>                     <Ben.Newlin at genesys.com>
>                     <mailto:Ben.Newlin at genesys.com>
>                     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                     Hi Ben,
>
>                     all the BT's points to crashes while doing memory
>                     ops. I suspect a memory corruption that randomly
>                     triggers crashes in different parts of the code.
>
>                     Could you try to re-compile with memory debugging
>                     support ? See
>                     http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>                     the "How to handle it" section.
>
>                     Regards,
>
>
>
>
>
>                     Bogdan-Andrei Iancu
>
>                       
>
>                     OpenSIPS Founder and Developer
>
>                        http://www.opensips-solutions.com
>
>                     OpenSIPS Bootcamp 2018
>
>                        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                     On 10/24/2018 04:28 AM, Ben Newlin wrote:
>
>                         We have had 2 more crashes today.
>
>                         Crash 2: https://pastebin.com/rMruBQcZ
>                         <https://pastebin.com/rMruBQcZ>
>
>                         This crash appears to have occurred while
>                         processing an initial INVITE request. I could
>                         not see anything unusual about the request. I
>                         cannot tell if this crash is related to the
>                         others.
>
>                         Crash 3: https://pastebin.com/Gmk1m4NT
>                         <https://pastebin.com/Gmk1m4NT>
>
>                         This crash follows the pattern of the original
>                         crash I reported.
>
>                         Ben Newlin
>
>                         *From: *Devel
>                         <devel-bounces at lists.opensips.org>
>                         <mailto:devel-bounces at lists.opensips.org> on
>                         behalf of Ben Newlin <Ben.Newlin at genesys.com>
>                         <mailto:Ben.Newlin at genesys.com>
>                         *Reply-To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>
>                         *Date: *Monday, October 22, 2018 at 4:45 PM
>                         *To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>
>                         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                         Here is a better trace of the call:
>                         https://pastebin.com/gWpQR8E7
>                         <https://pastebin.com/gWpQR8E7>
>
>                         Ben Newlin
>
>                         *From: *Ben Newlin <Ben.Newlin at genesys.com>
>                         <mailto:Ben.Newlin at genesys.com>
>                         *Date: *Monday, October 22, 2018 at 4:34 PM
>                         *To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>
>                         *Subject: *OpenSIPS Crash
>
>                         Hello,
>
>                         We have been having sporadic crashes and I was
>                         recently able to recover a core dump for one.
>                         I have uploaded it here:
>                         https://pastebin.com/ABktcYcH
>                         <https://pastebin.com/ABktcYcH>.
>
>                         I picked out a Call-ID from the crash data and
>                         took a look in our tracing. I have uploaded it
>                         here: https://pastebin.com/ZEzUUKZ5
>                         <https://pastebin.com/ZEzUUKZ5>.
>
>                         It appears that a downstream server was
>                         extremely lagged and failed to respond to an
>                         INVITE. We sent the INVITE to another server
>                         and the call was connected, but then
>                         eventually the original server “caught up” and
>                         sent a burst of 200 OK responses. The crash
>                         seems to have occurred processing the ACK to
>                         one of these responses.
>
>                         Ben Newlin
>
>
>
>
>
>
>
>
>                         _______________________________________________
>
>                         Devel mailing list
>
>                         Devel at lists.opensips.org
>                         <mailto:Devel at lists.opensips.org>
>
>                         http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>         _______________________________________________
>
>         Devel mailing list
>
>         Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>
>         http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181115/5f84098d/attachment-0001.html>

From Ben.Newlin at genesys.com  Thu Nov 15 10:01:19 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Thu, 15 Nov 2018 15:01:19 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <5e79332b-c921-a4fa-2ab6-0ec53eff0cf7@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <5e79332b-c921-a4fa-2ab6-0ec53eff0cf7@opensips.org>
Message-ID: <F1AA3509-48E6-4C40-957B-C1EEC531C91A@genesys.com>

Bogdan,

It’s happening every few days, so it is pretty frequent. There was another one yesterday but the DBG compile flags had been temporarily removed for that one.

We have not been able to determine a sequence to reproduce it yet.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Thursday, November 15, 2018 at 7:06 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

How often this crash happens ? are you able to reproduce it ?

The acc extra should work in the branch route, no problem. Out of curiosity, I will try to reproduce you case (timeout -> failure route -> t_relay -> branch_route) to see if I can reproduce it.

Regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/13/2018 07:41 PM, Ben Newlin wrote:
Bogdan,

Yes, we are setting acc_extra variables in our branch routes, which are sometimes (but not always) called from failure route. Are acc_extra variables not available for use in branch_routes?

We don’t currently use drop_accounting anywhere in our script. If I call it before that branch_route then it will stop accounting for that call, right? We need to have accounting records for the call, so I’m not sure how that would resolve the issue?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Tuesday, November 13, 2018 at 9:13 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for the info. The crash happens when you try to set an acc extra variable in branch route (when a creating a new branch via failure route, on timeout).

Now, do you use the drop accounting in your script ? and considering the above scenario, it is possible to have the drop acc before the branch route ?

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/12/2018 08:55 PM, Ben Newlin wrote:
Bogdan,

We upgraded to 2.4.3 and the crash reproduced today. Backtrace is available here: https://pastebin.com/CZxQnZdR<https://pastebin.com/CZxQnZdR>.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Wednesday, November 7, 2018 at 6:18 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

The BT indicates a double free for the accounting context - and I noticed you use 2.4.1 version. And yes, there was an issue related to acc context, issue that was fixed starting 2.4.2. So, could you upgrade to the latest 2.4 and see if the crash still happens ? As I think the fix is already there.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
Jackpot - you get it right !! I will start digging into the trace, but please keep the corefile, I might need it later.

Thanks and regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 10:24 PM, Ben Newlin wrote:
Bogdan,

I have reproduced this crash and verified this time that the flags were set.

$ opensips -V
version: opensips 2.4.1 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 5d042cffc
main.c compiled on 23:38:55 Nov  5 2018 with gcc 7

Backtrace is available here: https://pastebin.com/KTQjkCwq<https://pastebin.com/KTQjkCwq>

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, November 1, 2018 at 1:19 PM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an "opensips -V" to check the resulting compile flags - do you see the DBG_MALLOC and QM_MALLOC ?

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/31/2018 05:04 PM, Ben Newlin wrote:
Bogdan,

I was able to compile with those options and the crash has occurred again. Backtrace is here: https://pastebin.com/dezi9xUU<https://pastebin.com/dezi9xUU>.

Even though I had `memdump=1` set in my script, there was no extra memory debugging information in the logs prior to or at the time of the crash. I’m not sure if that is expected or not.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, October 29, 2018 at 8:11 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

You can change the compile flags via the Makefile.conf file - the menuconfig is also updating that file. So during your build you can simply push a pre-modified Makefile.conf file with the options needed for memory debugging.

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/26/2018 05:14 PM, Ben Newlin wrote:
Bogdan,

Unfortunately, we have run into a similar issue before. Our build system is completely automated and there is no way to inject the `make menuconfig` interactive step into that process. If I were to be testing this locally I might be able to work something out, but I could never get such a build into our testing environment which is where the crashes are occurring.

Do you have instructions for enabling memory debugging that do not require using the interactive TUI tool? What does the menuconfig program do when these options are selected? Are there some defines or other settings we can change ourselves and bypass menuconfig?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, October 26, 2018 at 4:59 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

all the BT's points to crashes while doing memory ops. I suspect a memory corruption that randomly triggers crashes in different parts of the code.

Could you try to re-compile with memory debugging support ? See http://www.opensips.org/Documentation/TroubleShooting-OutOfMem<http://www.opensips.org/Documentation/TroubleShooting-OutOfMem>, the "How to handle it" section.

Regards,







Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/24/2018 04:28 AM, Ben Newlin wrote:
We have had 2 more crashes today.

Crash 2: https://pastebin.com/rMruBQcZ<https://pastebin.com/rMruBQcZ>
This crash appears to have occurred while processing an initial INVITE request. I could not see anything unusual about the request. I cannot tell if this crash is related to the others.

Crash 3: https://pastebin.com/Gmk1m4NT<https://pastebin.com/Gmk1m4NT>
This crash follows the pattern of the original crash I reported.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Monday, October 22, 2018 at 4:45 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Here is a better trace of the call: https://pastebin.com/gWpQR8E7<https://pastebin.com/gWpQR8E7>

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Date: Monday, October 22, 2018 at 4:34 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: OpenSIPS Crash

Hello,

We have been having sporadic crashes and I was recently able to recover a core dump for one. I have uploaded it here: https://pastebin.com/ABktcYcH<https://pastebin.com/ABktcYcH>.

I picked out a Call-ID from the crash data and took a look in our tracing. I have uploaded it here: https://pastebin.com/ZEzUUKZ5<https://pastebin.com/ZEzUUKZ5>.

It appears that a downstream server was extremely lagged and failed to respond to an INVITE. We sent the INVITE to another server and the call was connected, but then eventually the original server “caught up” and sent a burst of 200 OK responses. The crash seems to have occurred processing the ACK to one of these responses.

Ben Newlin









_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>

























_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>









-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181115/de0d331b/attachment-0001.html>

From liviu at opensips.org  Fri Nov 16 11:36:42 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Fri, 16 Nov 2018 08:36:42 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f18be8: tm: Drop redundant
	function parameter
Message-ID: <5beef21a776a3_3f6d2aac3808c578831b7@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f18be86a5f3f277f1cd7f34669974da039666526
      https://github.com/OpenSIPS/opensips/commit/f18be86a5f3f277f1cd7f34669974da039666526
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M modules/tm/tm.c

  Log Message:
  -----------
  tm: Drop redundant function parameter


  Commit: 853755f11d372c29866bed948796320314540084
      https://github.com/OpenSIPS/opensips/commit/853755f11d372c29866bed948796320314540084
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M modules/tm/h_table.c
    M modules/tm/t_funcs.h
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  tm: Properly re-init branches after t_relay("0x02") fails

A t_relay("0x02") failure would do the required t->uac[] array element
buffer cleanups (good!) but then have these elements completely zeroized
(bad!).  These entries must additionally be initialized afterwards,
similarly to how init_branches() leaves them after a new transaction is
built.

Many thanks to Debasis Das from Twilio for reporting this bug.


  Commit: 2196fbc96b622ce1612e9de2e6444bf5058988f1
      https://github.com/OpenSIPS/opensips/commit/2196fbc96b622ce1612e9de2e6444bf5058988f1
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M modules/tm/t_funcs.c
    M modules/tm/t_funcs.h

  Log Message:
  -----------
  tm: Improve code readability


Compare: https://github.com/OpenSIPS/opensips/compare/8bbc18588873...2196fbc96b62
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Fri Nov 16 11:38:56 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Fri, 16 Nov 2018 08:38:56 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0f0752: tm: Properly re-init
 branches after t_relay("0x02"...
Message-ID: <5beef2a0b8f87_6b432ab37020e5881147cb@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0f075233e5720a3073f1019e1ff7f921b0f51e6a
      https://github.com/OpenSIPS/opensips/commit/0f075233e5720a3073f1019e1ff7f921b0f51e6a
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M modules/tm/h_table.c
    M modules/tm/t_funcs.h
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  tm: Properly re-init branches after t_relay("0x02") fails

A t_relay("0x02") failure would do the required t->uac[] array element
buffer cleanups (good!) but then have these elements completely zeroized
(bad!).  These entries must additionally be initialized afterwards,
similarly to how init_branches() leaves them after a new transaction is
built.

Many thanks to Debasis Das from Twilio for reporting this bug.

(cherry picked from commit 853755f11d372c29866bed948796320314540084)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Fri Nov 16 11:40:37 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Fri, 16 Nov 2018 08:40:37 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a20e6f: tm: Properly re-init
 branches after t_relay("0x02"...
Message-ID: <5beef3053a411_68312aeb1497257817665@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a20e6f49af2b44409cbc8ac85d8a44983945dd01
      https://github.com/OpenSIPS/opensips/commit/a20e6f49af2b44409cbc8ac85d8a44983945dd01
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-16 (Fri, 16 Nov 2018)

  Changed paths:
    M modules/tm/h_table.c
    M modules/tm/t_funcs.h
    M modules/tm/t_fwd.c

  Log Message:
  -----------
  tm: Properly re-init branches after t_relay("0x02") fails

A t_relay("0x02") failure would do the required t->uac[] array element
buffer cleanups (good!) but then have these elements completely zeroized
(bad!).  These entries must additionally be initialized afterwards,
similarly to how init_branches() leaves them after a new transaction is
built.

Many thanks to Debasis Das from Twilio for reporting this bug.

(cherry picked from commit 853755f11d372c29866bed948796320314540084)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 18 15:10:40 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 18 Nov 2018 12:10:40 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9c6b26: Rebuild documentation
Message-ID: <5bf1c74014f31_3d292ad9b62f2578882b9@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9c6b26e5b7b39fa5fda007011143c3577f53c850
      https://github.com/OpenSIPS/opensips/commit/9c6b26e5b7b39fa5fda007011143c3577f53c850
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-18 (Sun, 18 Nov 2018)

  Changed paths:
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 18 15:30:19 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 18 Nov 2018 12:30:19 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c6d75e: Rebuild documentation
Message-ID: <5bf1cbdb92825_650e2ab48b224588875e6@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c6d75e7b8c48cd4dd4b7a64083ad8e3ca6eb22da
      https://github.com/OpenSIPS/opensips/commit/c6d75e7b8c48cd4dd4b7a64083ad8e3ca6eb22da
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-18 (Sun, 18 Nov 2018)

  Changed paths:
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/event_jsonrpc/README
    M modules/event_jsonrpc/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rtpengine/README
    M modules/rtpengine/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 18 15:42:14 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 18 Nov 2018 12:42:14 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b89bf4: Rebuild documentation
Message-ID: <5bf1cea6177dc_36b52ab29bc42584637b9@hookshot-fe-88eb02d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b89bf4bb8e5d6a9a169cf23f5a40b62657d2a3d0
      https://github.com/OpenSIPS/opensips/commit/b89bf4bb8e5d6a9a169cf23f5a40b62657d2a3d0
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-18 (Sun, 18 Nov 2018)

  Changed paths:
    M modules/dialog/README
    M modules/dialog/doc/contributors.xml
    M modules/event_jsonrpc/README
    M modules/event_jsonrpc/doc/contributors.xml
    M modules/rest_client/README
    M modules/rest_client/doc/contributors.xml
    M modules/rtpengine/README
    M modules/rtpengine/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 19 03:50:15 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 19 Nov 2018 00:50:15 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 97dbc5: Fix changed iana url
Message-ID: <5bf27947e9be3_39cb2b1f01d3658049920@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 97dbc56a44b0cbfd7321cc03adc9a0f4ba044632
      https://github.com/OpenSIPS/opensips/commit/97dbc56a44b0cbfd7321cc03adc9a0f4ba044632
  Author: Fabian Gast <fabian.gast at nfon.com>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/sipmsgops/doc/sipmsgops_admin.xml

  Log Message:
  -----------
  Fix changed iana url


  Commit: 15e7b23ccdad8e89d87d6100e8b271ee6c711709
      https://github.com/OpenSIPS/opensips/commit/15e7b23ccdad8e89d87d6100e8b271ee6c711709
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/sipmsgops/doc/sipmsgops_admin.xml

  Log Message:
  -----------
  Merge pull request #1534 from fgast/new-iana-url

sipmsgops: Fix changed URL in documentation


Compare: https://github.com/OpenSIPS/opensips/compare/b89bf4bb8e5d...15e7b23ccdad
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From fabian.gast at nfon.com  Mon Nov 19 03:55:21 2018
From: fabian.gast at nfon.com (Fabian Gast)
Date: Mon, 19 Nov 2018 00:55:21 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ce6512: Fix changed iana url
Message-ID: <5bf27a79dbbb_380e2af7481305781828a@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ce6512a4e0cf74ae81dbbcc2e3cac0a1147cb1e8
      https://github.com/OpenSIPS/opensips/commit/ce6512a4e0cf74ae81dbbcc2e3cac0a1147cb1e8
  Author: Fabian Gast <fabian.gast at nfon.com>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/sipmsgops/doc/sipmsgops_admin.xml

  Log Message:
  -----------
  Fix changed iana url

(cherry picked from commit 97dbc56a44b0cbfd7321cc03adc9a0f4ba044632)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From fabian.gast at nfon.com  Mon Nov 19 03:55:41 2018
From: fabian.gast at nfon.com (Fabian Gast)
Date: Mon, 19 Nov 2018 00:55:41 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 87a33a: Fix changed iana url
Message-ID: <5bf27a8d1bdf6_2a52acb649265803282e@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 87a33af734c98472462aea48abd9bd581c9719b7
      https://github.com/OpenSIPS/opensips/commit/87a33af734c98472462aea48abd9bd581c9719b7
  Author: Fabian Gast <fabian.gast at nfon.com>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/sipmsgops/doc/sipmsgops_admin.xml

  Log Message:
  -----------
  Fix changed iana url

(cherry picked from commit 97dbc56a44b0cbfd7321cc03adc9a0f4ba044632)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov 15 11:08:10 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 15 Nov 2018 18:08:10 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <F1AA3509-48E6-4C40-957B-C1EEC531C91A@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <5e79332b-c921-a4fa-2ab6-0ec53eff0cf7@opensips.org>
 <F1AA3509-48E6-4C40-957B-C1EEC531C91A@genesys.com>
Message-ID: <168766bf-103b-dd54-132b-b528f5debdba@opensips.org>

Hi Ben,

DO you have the backtraces from more similar crashes ? may there is 
apattern there.

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/15/2018 05:01 PM, Ben Newlin wrote:
>
> Bogdan,
>
> It’s happening every few days, so it is pretty frequent. There was 
> another one yesterday but the DBG compile flags had been temporarily 
> removed for that one.
>
> We have not been able to determine a sequence to reproduce it yet.
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Thursday, November 15, 2018 at 7:06 AM
> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
> list <devel at lists.opensips.org>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> How often this crash happens ? are you able to reproduce it ?
>
> The acc extra should work in the branch route, no problem. Out of 
> curiosity, I will try to reproduce you case (timeout -> failure route 
> -> t_relay -> branch_route) to see if I can reproduce it.
>
> Regards,
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 11/13/2018 07:41 PM, Ben Newlin wrote:
>
>     Bogdan,
>
>     Yes, we are setting acc_extra variables in our branch routes,
>     which are sometimes (but not always) called from failure route.
>     Are acc_extra variables not available for use in branch_routes?
>
>     We don’t currently use drop_accounting anywhere in our script. If
>     I call it before that branch_route then it will stop accounting
>     for that call, right? We need to have accounting records for the
>     call, so I’m not sure how that would resolve the issue?
>
>     Ben Newlin
>
>     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>     <mailto:bogdan at opensips.org>
>     *Date: *Tuesday, November 13, 2018 at 9:13 AM
>     *To: *Ben Newlin <Ben.Newlin at genesys.com>
>     <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list
>     <devel at lists.opensips.org> <mailto:devel at lists.opensips.org>
>     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>     Hi Ben,
>
>     Thanks for the info. The crash happens when you try to set an acc
>     extra variable in branch route (when a creating a new branch via
>     failure route, on timeout).
>
>     Now, do you use the drop accounting in your script ? and
>     considering the above scenario, it is possible to have the drop
>     acc before the branch route ?
>
>     Regards,
>
>
>
>     Bogdan-Andrei Iancu
>
>       
>
>     OpenSIPS Founder and Developer
>
>        http://www.opensips-solutions.com
>
>     OpenSIPS Bootcamp 2018
>
>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>     On 11/12/2018 08:55 PM, Ben Newlin wrote:
>
>         Bogdan,
>
>         We upgraded to 2.4.3 and the crash reproduced today. Backtrace
>         is available here: https://pastebin.com/CZxQnZdR
>         <https://pastebin.com/CZxQnZdR>.
>
>         Ben Newlin
>
>         *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>         <mailto:bogdan at opensips.org>
>         *Date: *Wednesday, November 7, 2018 at 6:18 AM
>         *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>         <mailto:devel at lists.opensips.org>, Ben Newlin
>         <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>         Hi Ben,
>
>         The BT indicates a double free for the accounting context -
>         and I noticed you use 2.4.1 version. And yes, there was an
>         issue related to acc context, issue that was fixed starting
>         2.4.2. So, could you upgrade to the latest 2.4 and see if the
>         crash still happens ? As I think the fix is already there.
>
>         Regards,
>
>
>
>         Bogdan-Andrei Iancu
>
>           
>
>         OpenSIPS Founder and Developer
>
>            http://www.opensips-solutions.com
>
>         OpenSIPS Bootcamp 2018
>
>            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>         On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
>
>             Jackpot - you get it right !! I will start digging into
>             the trace, but please keep the corefile, I might need it
>             later.
>
>             Thanks and regards,
>
>
>
>             Bogdan-Andrei Iancu
>
>               
>
>             OpenSIPS Founder and Developer
>
>                http://www.opensips-solutions.com
>
>             OpenSIPS Bootcamp 2018
>
>                http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>             On 11/06/2018 10:24 PM, Ben Newlin wrote:
>
>                 Bogdan,
>
>                 I have reproduced this crash and verified this time
>                 that the flags were set.
>
>                 $ opensips -V
>
>                 version: opensips 2.4.1 (x86_64/linux)
>
>                 flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP,
>                 PKG_MALLOC, QM_MALLOC, DBG_MALLOC,
>                 FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
>
>                 ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144,
>                 MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
>
>                 poll method support: poll, epoll, sigio_rt, select.
>
>                 git revision: 5d042cffc
>
>                 main.c compiled on 23:38:55 Nov 5 2018 with gcc 7
>
>                 Backtrace is available here:
>                 https://pastebin.com/KTQjkCwq
>                 <https://pastebin.com/KTQjkCwq>
>
>                 Ben Newlin
>
>                 *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                 <mailto:bogdan at opensips.org>
>                 *Date: *Thursday, November 1, 2018 at 1:19 PM
>                 *To: *Ben Newlin <Ben.Newlin at genesys.com>
>                 <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel
>                 mailling list <devel at lists.opensips.org>
>                 <mailto:devel at lists.opensips.org>
>                 *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                 Hi Ben,
>
>                 According to the backtrace, the memory debugger was
>                 not activated. Do an "opensips -V" to check the
>                 resulting compile flags - do you see the DBG_MALLOC
>                 and QM_MALLOC ?
>
>                 Regards,
>
>
>
>
>                 Bogdan-Andrei Iancu
>
>                   
>
>                 OpenSIPS Founder and Developer
>
>                    http://www.opensips-solutions.com
>
>                 OpenSIPS Bootcamp 2018
>
>                    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                 On 10/31/2018 05:04 PM, Ben Newlin wrote:
>
>                     Bogdan,
>
>                     I was able to compile with those options and the
>                     crash has occurred again. Backtrace is here:
>                     https://pastebin.com/dezi9xUU
>                     <https://pastebin.com/dezi9xUU>.
>
>                     Even though I had `memdump=1` set in my script,
>                     there was no extra memory debugging information in
>                     the logs prior to or at the time of the crash. I’m
>                     not sure if that is expected or not.
>
>                     Ben Newlin
>
>                     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                     <mailto:bogdan at opensips.org>
>                     *Date: *Monday, October 29, 2018 at 8:11 AM
>                     *To: *Ben Newlin <Ben.Newlin at genesys.com>
>                     <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel
>                     mailling list <devel at lists.opensips.org>
>                     <mailto:devel at lists.opensips.org>
>                     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                     Hi Ben,
>
>                     You can change the compile flags via the
>                     Makefile.conf file - the menuconfig is also
>                     updating that file. So during your build you can
>                     simply push a pre-modified Makefile.conf file with
>                     the options needed for memory debugging.
>
>                     Regards,
>
>
>
>
>
>                     Bogdan-Andrei Iancu
>
>                       
>
>                     OpenSIPS Founder and Developer
>
>                        http://www.opensips-solutions.com
>
>                     OpenSIPS Bootcamp 2018
>
>                        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                     On 10/26/2018 05:14 PM, Ben Newlin wrote:
>
>                         Bogdan,
>
>                         Unfortunately, we have run into a similar
>                         issue before. Our build system is completely
>                         automated and there is no way to inject the
>                         `make menuconfig` interactive step into that
>                         process. If I were to be testing this locally
>                         I might be able to work something out, but I
>                         could never get such a build into our testing
>                         environment which is where the crashes are
>                         occurring.
>
>                         Do you have instructions for enabling memory
>                         debugging that do not require using the
>                         interactive TUI tool? What does the menuconfig
>                         program do when these options are selected?
>                         Are there some defines or other settings we
>                         can change ourselves and bypass menuconfig?
>
>                         Ben Newlin
>
>                         *From: *Bogdan-Andrei Iancu
>                         <bogdan at opensips.org> <mailto:bogdan at opensips.org>
>                         *Date: *Friday, October 26, 2018 at 4:59 AM
>                         *To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>, Ben Newlin
>                         <Ben.Newlin at genesys.com>
>                         <mailto:Ben.Newlin at genesys.com>
>                         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                         Hi Ben,
>
>                         all the BT's points to crashes while doing
>                         memory ops. I suspect a memory corruption that
>                         randomly triggers crashes in different parts
>                         of the code.
>
>                         Could you try to re-compile with memory
>                         debugging support ? See
>                         http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>                         the "How to handle it" section.
>
>                         Regards,
>
>
>
>
>
>
>                         Bogdan-Andrei Iancu
>
>                           
>
>                         OpenSIPS Founder and Developer
>
>                            http://www.opensips-solutions.com
>
>                         OpenSIPS Bootcamp 2018
>
>                            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                         On 10/24/2018 04:28 AM, Ben Newlin wrote:
>
>                             We have had 2 more crashes today.
>
>                             Crash 2: https://pastebin.com/rMruBQcZ
>                             <https://pastebin.com/rMruBQcZ>
>
>                             This crash appears to have occurred while
>                             processing an initial INVITE request. I
>                             could not see anything unusual about the
>                             request. I cannot tell if this crash is
>                             related to the others.
>
>                             Crash 3: https://pastebin.com/Gmk1m4NT
>                             <https://pastebin.com/Gmk1m4NT>
>
>                             This crash follows the pattern of the
>                             original crash I reported.
>
>                             Ben Newlin
>
>                             *From: *Devel
>                             <devel-bounces at lists.opensips.org>
>                             <mailto:devel-bounces at lists.opensips.org>
>                             on behalf of Ben Newlin
>                             <Ben.Newlin at genesys.com>
>                             <mailto:Ben.Newlin at genesys.com>
>                             *Reply-To: *OpenSIPS devel mailling list
>                             <devel at lists.opensips.org>
>                             <mailto:devel at lists.opensips.org>
>                             *Date: *Monday, October 22, 2018 at 4:45 PM
>                             *To: *OpenSIPS devel mailling list
>                             <devel at lists.opensips.org>
>                             <mailto:devel at lists.opensips.org>
>                             *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                             Here is a better trace of the call:
>                             https://pastebin.com/gWpQR8E7
>                             <https://pastebin.com/gWpQR8E7>
>
>                             Ben Newlin
>
>                             *From: *Ben Newlin
>                             <Ben.Newlin at genesys.com>
>                             <mailto:Ben.Newlin at genesys.com>
>                             *Date: *Monday, October 22, 2018 at 4:34 PM
>                             *To: *OpenSIPS devel mailling list
>                             <devel at lists.opensips.org>
>                             <mailto:devel at lists.opensips.org>
>                             *Subject: *OpenSIPS Crash
>
>                             Hello,
>
>                             We have been having sporadic crashes and I
>                             was recently able to recover a core dump
>                             for one. I have uploaded it here:
>                             https://pastebin.com/ABktcYcH
>                             <https://pastebin.com/ABktcYcH>.
>
>                             I picked out a Call-ID from the crash data
>                             and took a look in our tracing. I have
>                             uploaded it here:
>                             https://pastebin.com/ZEzUUKZ5
>                             <https://pastebin.com/ZEzUUKZ5>.
>
>                             It appears that a downstream server was
>                             extremely lagged and failed to respond to
>                             an INVITE. We sent the INVITE to another
>                             server and the call was connected, but
>                             then eventually the original server
>                             “caught up” and sent a burst of 200 OK
>                             responses. The crash seems to have
>                             occurred processing the ACK to one of
>                             these responses.
>
>                             Ben Newlin
>
>
>
>
>
>
>
>
>
>                             _______________________________________________
>
>                             Devel mailing list
>
>                             Devel at lists.opensips.org
>                             <mailto:Devel at lists.opensips.org>
>
>                             http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>             _______________________________________________
>
>             Devel mailing list
>
>             Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>
>             http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181115/0716c1ed/attachment-0001.html>

From Ben.Newlin at genesys.com  Thu Nov 15 11:26:41 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Thu, 15 Nov 2018 16:26:41 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <168766bf-103b-dd54-132b-b528f5debdba@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <5e79332b-c921-a4fa-2ab6-0ec53eff0cf7@opensips.org>
 <F1AA3509-48E6-4C40-957B-C1EEC531C91A@genesys.com>
 <168766bf-103b-dd54-132b-b528f5debdba@opensips.org>
Message-ID: <7DE5921A-008D-4D77-988D-C5FA6379196B@genesys.com>

Bogdan,

The one I provided is the only one I have with the memory debugging compiled in. I’m going to re-enable that and push it so that we will have that info when it recurs.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Thursday, November 15, 2018 at 11:08 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

DO you have the backtraces from more similar crashes ? may there is a pattern there.

Regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/15/2018 05:01 PM, Ben Newlin wrote:
Bogdan,

It’s happening every few days, so it is pretty frequent. There was another one yesterday but the DBG compile flags had been temporarily removed for that one.

We have not been able to determine a sequence to reproduce it yet.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, November 15, 2018 at 7:06 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

How often this crash happens ? are you able to reproduce it ?

The acc extra should work in the branch route, no problem. Out of curiosity, I will try to reproduce you case (timeout -> failure route -> t_relay -> branch_route) to see if I can reproduce it.

Regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/13/2018 07:41 PM, Ben Newlin wrote:
Bogdan,

Yes, we are setting acc_extra variables in our branch routes, which are sometimes (but not always) called from failure route. Are acc_extra variables not available for use in branch_routes?

We don’t currently use drop_accounting anywhere in our script. If I call it before that branch_route then it will stop accounting for that call, right? We need to have accounting records for the call, so I’m not sure how that would resolve the issue?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Tuesday, November 13, 2018 at 9:13 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for the info. The crash happens when you try to set an acc extra variable in branch route (when a creating a new branch via failure route, on timeout).

Now, do you use the drop accounting in your script ? and considering the above scenario, it is possible to have the drop acc before the branch route ?

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/12/2018 08:55 PM, Ben Newlin wrote:
Bogdan,

We upgraded to 2.4.3 and the crash reproduced today. Backtrace is available here: https://pastebin.com/CZxQnZdR<https://pastebin.com/CZxQnZdR>.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Wednesday, November 7, 2018 at 6:18 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

The BT indicates a double free for the accounting context - and I noticed you use 2.4.1 version. And yes, there was an issue related to acc context, issue that was fixed starting 2.4.2. So, could you upgrade to the latest 2.4 and see if the crash still happens ? As I think the fix is already there.

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
Jackpot - you get it right !! I will start digging into the trace, but please keep the corefile, I might need it later.

Thanks and regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 10:24 PM, Ben Newlin wrote:
Bogdan,

I have reproduced this crash and verified this time that the flags were set.

$ opensips -V
version: opensips 2.4.1 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 5d042cffc
main.c compiled on 23:38:55 Nov  5 2018 with gcc 7

Backtrace is available here: https://pastebin.com/KTQjkCwq<https://pastebin.com/KTQjkCwq>

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, November 1, 2018 at 1:19 PM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an "opensips -V" to check the resulting compile flags - do you see the DBG_MALLOC and QM_MALLOC ?

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/31/2018 05:04 PM, Ben Newlin wrote:
Bogdan,

I was able to compile with those options and the crash has occurred again. Backtrace is here: https://pastebin.com/dezi9xUU<https://pastebin.com/dezi9xUU>.

Even though I had `memdump=1` set in my script, there was no extra memory debugging information in the logs prior to or at the time of the crash. I’m not sure if that is expected or not.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, October 29, 2018 at 8:11 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

You can change the compile flags via the Makefile.conf file - the menuconfig is also updating that file. So during your build you can simply push a pre-modified Makefile.conf file with the options needed for memory debugging.

Regards,







Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/26/2018 05:14 PM, Ben Newlin wrote:
Bogdan,

Unfortunately, we have run into a similar issue before. Our build system is completely automated and there is no way to inject the `make menuconfig` interactive step into that process. If I were to be testing this locally I might be able to work something out, but I could never get such a build into our testing environment which is where the crashes are occurring.

Do you have instructions for enabling memory debugging that do not require using the interactive TUI tool? What does the menuconfig program do when these options are selected? Are there some defines or other settings we can change ourselves and bypass menuconfig?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, October 26, 2018 at 4:59 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

all the BT's points to crashes while doing memory ops. I suspect a memory corruption that randomly triggers crashes in different parts of the code.

Could you try to re-compile with memory debugging support ? See http://www.opensips.org/Documentation/TroubleShooting-OutOfMem<http://www.opensips.org/Documentation/TroubleShooting-OutOfMem>, the "How to handle it" section.

Regards,








Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/24/2018 04:28 AM, Ben Newlin wrote:
We have had 2 more crashes today.

Crash 2: https://pastebin.com/rMruBQcZ<https://pastebin.com/rMruBQcZ>
This crash appears to have occurred while processing an initial INVITE request. I could not see anything unusual about the request. I cannot tell if this crash is related to the others.

Crash 3: https://pastebin.com/Gmk1m4NT<https://pastebin.com/Gmk1m4NT>
This crash follows the pattern of the original crash I reported.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Monday, October 22, 2018 at 4:45 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Here is a better trace of the call: https://pastebin.com/gWpQR8E7<https://pastebin.com/gWpQR8E7>

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Date: Monday, October 22, 2018 at 4:34 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: OpenSIPS Crash

Hello,

We have been having sporadic crashes and I was recently able to recover a core dump for one. I have uploaded it here: https://pastebin.com/ABktcYcH<https://pastebin.com/ABktcYcH>.

I picked out a Call-ID from the crash data and took a look in our tracing. I have uploaded it here: https://pastebin.com/ZEzUUKZ5<https://pastebin.com/ZEzUUKZ5>.

It appears that a downstream server was extremely lagged and failed to respond to an INVITE. We sent the INVITE to another server and the call was connected, but then eventually the original server “caught up” and sent a burst of 200 OK responses. The crash seems to have occurred processing the ACK to one of these responses.

Ben Newlin










_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>





























_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>














-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181115/1d1552ac/attachment-0001.html>

From bogdan at opensips.org  Mon Nov 19 09:03:30 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 19 Nov 2018 16:03:30 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
Message-ID: <0fef793b-2a1f-14ff-f757-37f36035d065@opensips.org>

Hi Ben,

With someadditional information that we got from a different feed, we 
managed to reproduce the crashand Liviu is working on a fix as we speak. 
I will keep you posted, but many thanks for your help in investigating 
this issue.

Best regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/13/2018 07:41 PM, Ben Newlin wrote:
>
> Bogdan,
>
> Yes, we are setting acc_extra variables in our branch routes, which 
> are sometimes (but not always) called from failure route. Are 
> acc_extra variables not available for use in branch_routes?
>
> We don’t currently use drop_accounting anywhere in our script. If I 
> call it before that branch_route then it will stop accounting for that 
> call, right? We need to have accounting records for the call, so I’m 
> not sure how that would resolve the issue?
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Tuesday, November 13, 2018 at 9:13 AM
> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
> list <devel at lists.opensips.org>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> Thanks for the info. The crash happens when you try to set an acc 
> extra variable in branch route (when a creating a new branch via 
> failure route, on timeout).
>
> Now, do you use the drop accounting in your script ? and considering 
> the above scenario, it is possible to have the drop acc before the 
> branch route ?
>
> Regards,
>
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 11/12/2018 08:55 PM, Ben Newlin wrote:
>
>     Bogdan,
>
>     We upgraded to 2.4.3 and the crash reproduced today. Backtrace is
>     available here: https://pastebin.com/CZxQnZdR
>     <https://pastebin.com/CZxQnZdR>.
>
>     Ben Newlin
>
>     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>     <mailto:bogdan at opensips.org>
>     *Date: *Wednesday, November 7, 2018 at 6:18 AM
>     *To: *OpenSIPS devel mailling list <devel at lists.opensips.org>
>     <mailto:devel at lists.opensips.org>, Ben Newlin
>     <Ben.Newlin at genesys.com> <mailto:Ben.Newlin at genesys.com>
>     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>     Hi Ben,
>
>     The BT indicates a double free for the accounting context - and I
>     noticed you use 2.4.1 version. And yes, there was an issue related
>     to acc context, issue that was fixed starting 2.4.2. So, could you
>     upgrade to the latest 2.4 and see if the crash still happens ? As
>     I think the fix is already there.
>
>     Regards,
>
>
>     Bogdan-Andrei Iancu
>
>       
>
>     OpenSIPS Founder and Developer
>
>        http://www.opensips-solutions.com
>
>     OpenSIPS Bootcamp 2018
>
>        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>     On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
>
>         Jackpot - you get it right !! I will start digging into the
>         trace, but please keep the corefile, I might need it later.
>
>         Thanks and regards,
>
>
>         Bogdan-Andrei Iancu
>
>           
>
>         OpenSIPS Founder and Developer
>
>            http://www.opensips-solutions.com
>
>         OpenSIPS Bootcamp 2018
>
>            http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>         On 11/06/2018 10:24 PM, Ben Newlin wrote:
>
>             Bogdan,
>
>             I have reproduced this crash and verified this time that
>             the flags were set.
>
>             $ opensips -V
>
>             version: opensips 2.4.1 (x86_64/linux)
>
>             flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP,
>             PKG_MALLOC, QM_MALLOC, DBG_MALLOC,
>             FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
>
>             ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144,
>             MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
>
>             poll method support: poll, epoll, sigio_rt, select.
>
>             git revision: 5d042cffc
>
>             main.c compiled on 23:38:55 Nov  5 2018 with gcc 7
>
>             Backtrace is available here: https://pastebin.com/KTQjkCwq
>             <https://pastebin.com/KTQjkCwq>
>
>             Ben Newlin
>
>             *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>             <mailto:bogdan at opensips.org>
>             *Date: *Thursday, November 1, 2018 at 1:19 PM
>             *To: *Ben Newlin <Ben.Newlin at genesys.com>
>             <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling
>             list <devel at lists.opensips.org>
>             <mailto:devel at lists.opensips.org>
>             *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>             Hi Ben,
>
>             According to the backtrace, the memory debugger was not
>             activated. Do an "opensips -V" to check the resulting
>             compile flags - do you see the DBG_MALLOC and QM_MALLOC ?
>
>             Regards,
>
>
>
>             Bogdan-Andrei Iancu
>
>               
>
>             OpenSIPS Founder and Developer
>
>                http://www.opensips-solutions.com
>
>             OpenSIPS Bootcamp 2018
>
>                http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>             On 10/31/2018 05:04 PM, Ben Newlin wrote:
>
>                 Bogdan,
>
>                 I was able to compile with those options and the crash
>                 has occurred again. Backtrace is here:
>                 https://pastebin.com/dezi9xUU
>                 <https://pastebin.com/dezi9xUU>.
>
>                 Even though I had `memdump=1` set in my script, there
>                 was no extra memory debugging information in the logs
>                 prior to or at the time of the crash. I’m not sure if
>                 that is expected or not.
>
>                 Ben Newlin
>
>                 *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                 <mailto:bogdan at opensips.org>
>                 *Date: *Monday, October 29, 2018 at 8:11 AM
>                 *To: *Ben Newlin <Ben.Newlin at genesys.com>
>                 <mailto:Ben.Newlin at genesys.com>, OpenSIPS devel
>                 mailling list <devel at lists.opensips.org>
>                 <mailto:devel at lists.opensips.org>
>                 *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                 Hi Ben,
>
>                 You can change the compile flags via the Makefile.conf
>                 file - the menuconfig is also updating that file. So
>                 during your build you can simply push a pre-modified
>                 Makefile.conf file with the options needed for memory
>                 debugging.
>
>                 Regards,
>
>
>
>
>                 Bogdan-Andrei Iancu
>
>                   
>
>                 OpenSIPS Founder and Developer
>
>                    http://www.opensips-solutions.com
>
>                 OpenSIPS Bootcamp 2018
>
>                    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                 On 10/26/2018 05:14 PM, Ben Newlin wrote:
>
>                     Bogdan,
>
>                     Unfortunately, we have run into a similar issue
>                     before. Our build system is completely automated
>                     and there is no way to inject the `make
>                     menuconfig` interactive step into that process. If
>                     I were to be testing this locally I might be able
>                     to work something out, but I could never get such
>                     a build into our testing environment which is
>                     where the crashes are occurring.
>
>                     Do you have instructions for enabling memory
>                     debugging that do not require using the
>                     interactive TUI tool? What does the menuconfig
>                     program do when these options are selected? Are
>                     there some defines or other settings we can change
>                     ourselves and bypass menuconfig?
>
>                     Ben Newlin
>
>                     *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
>                     <mailto:bogdan at opensips.org>
>                     *Date: *Friday, October 26, 2018 at 4:59 AM
>                     *To: *OpenSIPS devel mailling list
>                     <devel at lists.opensips.org>
>                     <mailto:devel at lists.opensips.org>, Ben Newlin
>                     <Ben.Newlin at genesys.com>
>                     <mailto:Ben.Newlin at genesys.com>
>                     *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                     Hi Ben,
>
>                     all the BT's points to crashes while doing memory
>                     ops. I suspect a memory corruption that randomly
>                     triggers crashes in different parts of the code.
>
>                     Could you try to re-compile with memory debugging
>                     support ? See
>                     http://www.opensips.org/Documentation/TroubleShooting-OutOfMem,
>                     the "How to handle it" section.
>
>                     Regards,
>
>
>
>
>
>                     Bogdan-Andrei Iancu
>
>                       
>
>                     OpenSIPS Founder and Developer
>
>                        http://www.opensips-solutions.com
>
>                     OpenSIPS Bootcamp 2018
>
>                        http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
>                     On 10/24/2018 04:28 AM, Ben Newlin wrote:
>
>                         We have had 2 more crashes today.
>
>                         Crash 2: https://pastebin.com/rMruBQcZ
>                         <https://pastebin.com/rMruBQcZ>
>
>                         This crash appears to have occurred while
>                         processing an initial INVITE request. I could
>                         not see anything unusual about the request. I
>                         cannot tell if this crash is related to the
>                         others.
>
>                         Crash 3: https://pastebin.com/Gmk1m4NT
>                         <https://pastebin.com/Gmk1m4NT>
>
>                         This crash follows the pattern of the original
>                         crash I reported.
>
>                         Ben Newlin
>
>                         *From: *Devel
>                         <devel-bounces at lists.opensips.org>
>                         <mailto:devel-bounces at lists.opensips.org> on
>                         behalf of Ben Newlin <Ben.Newlin at genesys.com>
>                         <mailto:Ben.Newlin at genesys.com>
>                         *Reply-To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>
>                         *Date: *Monday, October 22, 2018 at 4:45 PM
>                         *To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>
>                         *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
>                         Here is a better trace of the call:
>                         https://pastebin.com/gWpQR8E7
>                         <https://pastebin.com/gWpQR8E7>
>
>                         Ben Newlin
>
>                         *From: *Ben Newlin <Ben.Newlin at genesys.com>
>                         <mailto:Ben.Newlin at genesys.com>
>                         *Date: *Monday, October 22, 2018 at 4:34 PM
>                         *To: *OpenSIPS devel mailling list
>                         <devel at lists.opensips.org>
>                         <mailto:devel at lists.opensips.org>
>                         *Subject: *OpenSIPS Crash
>
>                         Hello,
>
>                         We have been having sporadic crashes and I was
>                         recently able to recover a core dump for one.
>                         I have uploaded it here:
>                         https://pastebin.com/ABktcYcH
>                         <https://pastebin.com/ABktcYcH>.
>
>                         I picked out a Call-ID from the crash data and
>                         took a look in our tracing. I have uploaded it
>                         here: https://pastebin.com/ZEzUUKZ5
>                         <https://pastebin.com/ZEzUUKZ5>.
>
>                         It appears that a downstream server was
>                         extremely lagged and failed to respond to an
>                         INVITE. We sent the INVITE to another server
>                         and the call was connected, but then
>                         eventually the original server “caught up” and
>                         sent a burst of 200 OK responses. The crash
>                         seems to have occurred processing the ACK to
>                         one of these responses.
>
>                         Ben Newlin
>
>
>
>
>
>
>
>
>                         _______________________________________________
>
>                         Devel mailing list
>
>                         Devel at lists.opensips.org
>                         <mailto:Devel at lists.opensips.org>
>
>                         http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>
>         _______________________________________________
>
>         Devel mailing list
>
>         Devel at lists.opensips.org <mailto:Devel at lists.opensips.org>
>
>         http://lists.opensips.org/cgi-bin/mailman/listinfo/devel
>
>
>
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181119/9d6ecc7e/attachment-0001.html>

From vladpaiu at opensips.org  Mon Nov 19 10:11:02 2018
From: vladpaiu at opensips.org (Vlad Paiu)
Date: Mon, 19 Nov 2018 07:11:02 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b0bf92: Fixed
 dr_number_routing crash with empty partition
Message-ID: <5bf2d286b46a_2b292aefcdb7c57c95249@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b0bf9270729b0de5f7894688411353e1c5738be3
      https://github.com/OpenSIPS/opensips/commit/b0bf9270729b0de5f7894688411353e1c5738be3
  Author: Vlad Paiu <vladpaiu at opensips.org>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  Fixed dr_number_routing crash with empty partition



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 19 10:28:46 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 19 Nov 2018 07:28:46 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6eb14f: acc: Do not
 dereference NULL dialog contexts
Message-ID: <5bf2d6ae91eee_62d22ab2616c85848792f@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6eb14f6a3d23bb6a646aa414907755ea9b381511
      https://github.com/OpenSIPS/opensips/commit/6eb14f6a3d23bb6a646aa414907755ea9b381511
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c

  Log Message:
  -----------
  acc: Do not dereference NULL dialog contexts

This bug could be triggered in failover scenarios, where the accounting
context would be created and cleaned up at least once before actually
calling do_accounting().  One way to trigger it would be:

    * create_dialog();
    * $acc_extra(foo) = "bar"; # create a dialog-stored acc context
    * t_relay(); exit; # msg is relayed, but ctx is unused =>
	the code frees it and leaves a NULL dialog value marker.
    * inside failure_route, do: $acc_extra(foo) = "bar".  We fetch the
      NULL context stored inside dialog, dereference it and crash.

Many thanks to 46Labs for reporting this issue, as well as providing
extensive troubleshooting information.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 19 10:30:14 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 19 Nov 2018 07:30:14 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e25895: acc: Do not
 dereference NULL dialog contexts
Message-ID: <5bf2d706caeb9_798a2aea2aa48578680a5@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e25895624b1c815dd800bc73452f90223a94242b
      https://github.com/OpenSIPS/opensips/commit/e25895624b1c815dd800bc73452f90223a94242b
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-19 (Mon, 19 Nov 2018)

  Changed paths:
    M modules/acc/acc_logic.c

  Log Message:
  -----------
  acc: Do not dereference NULL dialog contexts

This bug could be triggered in failover scenarios, where the accounting
context would be created and cleaned up at least once before actually
calling do_accounting().  One way to trigger it would be:

    * create_dialog();
    * $acc_extra(foo) = "bar"; # create a dialog-stored acc context
    * t_relay(); exit; # msg is relayed, but ctx is unused =>
	the code frees it and leaves a NULL dialog value marker.
    * inside failure_route, do: $acc_extra(foo) = "bar".  We fetch the
      NULL context stored inside dialog, dereference it and crash.

Many thanks to 46Labs for reporting this issue, as well as providing
extensive troubleshooting information.

(cherry picked from commit 6eb14f6a3d23bb6a646aa414907755ea9b381511)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From Ben.Newlin at genesys.com  Mon Nov 19 10:31:07 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Mon, 19 Nov 2018 15:31:07 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <0fef793b-2a1f-14ff-f757-37f36035d065@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <0fef793b-2a1f-14ff-f757-37f36035d065@opensips.org>
Message-ID: <13F09A3F-00FE-4000-83A1-B6731B921EEE@genesys.com>

Bogdan,

That is excellent news! Thank you very much for your work on this and Liviu as well!

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Monday, November 19, 2018 at 9:03 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

With some additional information that we got from a different feed, we managed to reproduce the crash and Liviu is working on a fix as we speak. I will keep you posted, but many thanks for your help in investigating this issue.

Best regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/13/2018 07:41 PM, Ben Newlin wrote:
Bogdan,

Yes, we are setting acc_extra variables in our branch routes, which are sometimes (but not always) called from failure route. Are acc_extra variables not available for use in branch_routes?

We don’t currently use drop_accounting anywhere in our script. If I call it before that branch_route then it will stop accounting for that call, right? We need to have accounting records for the call, so I’m not sure how that would resolve the issue?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Tuesday, November 13, 2018 at 9:13 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

Thanks for the info. The crash happens when you try to set an acc extra variable in branch route (when a creating a new branch via failure route, on timeout).

Now, do you use the drop accounting in your script ? and considering the above scenario, it is possible to have the drop acc before the branch route ?

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/12/2018 08:55 PM, Ben Newlin wrote:
Bogdan,

We upgraded to 2.4.3 and the crash reproduced today. Backtrace is available here: https://pastebin.com/CZxQnZdR<https://pastebin.com/CZxQnZdR>.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Wednesday, November 7, 2018 at 6:18 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

The BT indicates a double free for the accounting context - and I noticed you use 2.4.1 version. And yes, there was an issue related to acc context, issue that was fixed starting 2.4.2. So, could you upgrade to the latest 2.4 and see if the crash still happens ? As I think the fix is already there.

Regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 11:13 PM, Bogdan-Andrei Iancu wrote:
Jackpot - you get it right !! I will start digging into the trace, but please keep the corefile, I might need it later.

Thanks and regards,




Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/06/2018 10:24 PM, Ben Newlin wrote:
Bogdan,

I have reproduced this crash and verified this time that the flags were set.

$ opensips -V
version: opensips 2.4.1 (x86_64/linux)
flags: STATS: On, DISABLE_NAGLE, USE_MCAST, SHM_MMAP, PKG_MALLOC, QM_MALLOC, DBG_MALLOC, FAST_LOCK-ADAPTIVE_WAIT, DBG_LOCK
ADAPTIVE_WAIT_LOOPS=1024, MAX_RECV_BUFFER_SIZE 262144, MAX_LISTEN 16, MAX_URI_SIZE 1024, BUF_SIZE 65535
poll method support: poll, epoll, sigio_rt, select.
git revision: 5d042cffc
main.c compiled on 23:38:55 Nov  5 2018 with gcc 7

Backtrace is available here: https://pastebin.com/KTQjkCwq<https://pastebin.com/KTQjkCwq>

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Thursday, November 1, 2018 at 1:19 PM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

According to the backtrace, the memory debugger was not activated. Do an "opensips -V" to check the resulting compile flags - do you see the DBG_MALLOC and QM_MALLOC ?

Regards,





Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/31/2018 05:04 PM, Ben Newlin wrote:
Bogdan,

I was able to compile with those options and the crash has occurred again. Backtrace is here: https://pastebin.com/dezi9xUU<https://pastebin.com/dezi9xUU>.

Even though I had `memdump=1` set in my script, there was no extra memory debugging information in the logs prior to or at the time of the crash. I’m not sure if that is expected or not.

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, October 29, 2018 at 8:11 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

You can change the compile flags via the Makefile.conf file - the menuconfig is also updating that file. So during your build you can simply push a pre-modified Makefile.conf file with the options needed for memory debugging.

Regards,






Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/26/2018 05:14 PM, Ben Newlin wrote:
Bogdan,

Unfortunately, we have run into a similar issue before. Our build system is completely automated and there is no way to inject the `make menuconfig` interactive step into that process. If I were to be testing this locally I might be able to work something out, but I could never get such a build into our testing environment which is where the crashes are occurring.

Do you have instructions for enabling memory debugging that do not require using the interactive TUI tool? What does the menuconfig program do when these options are selected? Are there some defines or other settings we can change ourselves and bypass menuconfig?

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Friday, October 26, 2018 at 4:59 AM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>, Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

all the BT's points to crashes while doing memory ops. I suspect a memory corruption that randomly triggers crashes in different parts of the code.

Could you try to re-compile with memory debugging support ? See http://www.opensips.org/Documentation/TroubleShooting-OutOfMem<http://www.opensips.org/Documentation/TroubleShooting-OutOfMem>, the "How to handle it" section.

Regards,







Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 10/24/2018 04:28 AM, Ben Newlin wrote:
We have had 2 more crashes today.

Crash 2: https://pastebin.com/rMruBQcZ<https://pastebin.com/rMruBQcZ>
This crash appears to have occurred while processing an initial INVITE request. I could not see anything unusual about the request. I cannot tell if this crash is related to the others.

Crash 3: https://pastebin.com/Gmk1m4NT<https://pastebin.com/Gmk1m4NT>
This crash follows the pattern of the original crash I reported.

Ben Newlin

From: Devel <devel-bounces at lists.opensips.org><mailto:devel-bounces at lists.opensips.org> on behalf of Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Reply-To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Date: Monday, October 22, 2018 at 4:45 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Here is a better trace of the call: https://pastebin.com/gWpQR8E7<https://pastebin.com/gWpQR8E7>

Ben Newlin

From: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>
Date: Monday, October 22, 2018 at 4:34 PM
To: OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: OpenSIPS Crash

Hello,

We have been having sporadic crashes and I was recently able to recover a core dump for one. I have uploaded it here: https://pastebin.com/ABktcYcH<https://pastebin.com/ABktcYcH>.

I picked out a Call-ID from the crash data and took a look in our tracing. I have uploaded it here: https://pastebin.com/ZEzUUKZ5<https://pastebin.com/ZEzUUKZ5>.

It appears that a downstream server was extremely lagged and failed to respond to an INVITE. We sent the INVITE to another server and the call was connected, but then eventually the original server “caught up” and sent a burst of 200 OK responses. The crash seems to have occurred processing the ACK to one of these responses.

Ben Newlin









_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>

























_______________________________________________

Devel mailing list

Devel at lists.opensips.org<mailto:Devel at lists.opensips.org>

http://lists.opensips.org/cgi-bin/mailman/listinfo/devel<http://lists.opensips.org/cgi-bin/mailman/listinfo/devel>









-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181119/e7f16a78/attachment-0001.html>

From liviu at opensips.org  Mon Nov 19 12:05:16 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 19 Nov 2018 19:05:16 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <13F09A3F-00FE-4000-83A1-B6731B921EEE@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <0fef793b-2a1f-14ff-f757-37f36035d065@opensips.org>
 <13F09A3F-00FE-4000-83A1-B6731B921EEE@genesys.com>
Message-ID: <51a82c5c-760f-2d77-dd4d-5a908880b023@opensips.org>

Hi Ben,

Not sure if you noticed yet, but the fix is already available here [1].  
Thank you for all the help!

Cheers,

[1]: https://github.com/OpenSIPS/opensips/commit/e25895624b1c815dd8

Liviu Chircu
OpenSIPS Developer
http://www.opensips-solutions.com

On 19.11.2018 17:31, Ben Newlin wrote:
>
> Bogdan,
>
> That is excellent news! Thank you very much for your work on this and 
> Liviu as well!
>
> Ben Newlin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181119/23dc2d3b/attachment.html>

From bogdan at opensips.org  Tue Nov 20 07:37:59 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 20 Nov 2018 14:37:59 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <13F09A3F-00FE-4000-83A1-B6731B921EEE@genesys.com>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <0fef793b-2a1f-14ff-f757-37f36035d065@opensips.org>
 <13F09A3F-00FE-4000-83A1-B6731B921EEE@genesys.com>
Message-ID: <212db1fd-9621-8993-b2f7-1ca593fecae1@opensips.org>

Hi Ben,

The fix is now available on GIT repo, so simply update and it should be 
fine.

Regards,

Bogdan-Andrei Iancu

OpenSIPS Founder and Developer
   http://www.opensips-solutions.com
OpenSIPS Bootcamp 2018
   http://opensips.org/training/OpenSIPS_Bootcamp_2018/

On 11/19/2018 05:31 PM, Ben Newlin wrote:
>
> Bogdan,
>
> That is excellent news! Thank you very much for your work on this and 
> Liviu as well!
>
> Ben Newlin
>
> *From: *Bogdan-Andrei Iancu <bogdan at opensips.org>
> *Date: *Monday, November 19, 2018 at 9:03 AM
> *To: *Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling 
> list <devel at lists.opensips.org>
> *Subject: *Re: [OpenSIPS-Devel] OpenSIPS Crash
>
> Hi Ben,
>
> With some additional information that we got from a different feed, we 
> managed to reproduce the crash and Liviu is working on a fix as we 
> speak. I will keep you posted, but many thanks for your help in 
> investigating this issue.
>
> Best regards,
>
> Bogdan-Andrei Iancu
> OpenSIPS Founder and Developer
>    http://www.opensips-solutions.com
> OpenSIPS Bootcamp 2018
>    http://opensips.org/training/OpenSIPS_Bootcamp_2018/
>
> On 11/13/2018 07:41 PM, Ben Newlin wrote:
>
>     Bogdan,
>
>     Yes, we are setting acc_extra variables in our branch routes,
>     which are sometimes (but not always) called from failure route.
>     Are acc_extra variables not available for use in branch_routes?
>
>     We don’t currently use drop_accounting anywhere in our script. If
>     I call it before that branch_route then it will stop accounting
>     for that call, right? We need to have accounting records for the
>     call, so I’m not sure how that would resolve the issue?
>
>     Ben Newlin
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181120/e9eb5fb5/attachment.html>

From Ben.Newlin at genesys.com  Tue Nov 20 08:18:09 2018
From: Ben.Newlin at genesys.com (Ben Newlin)
Date: Tue, 20 Nov 2018 13:18:09 +0000
Subject: [OpenSIPS-Devel] OpenSIPS Crash
In-Reply-To: <212db1fd-9621-8993-b2f7-1ca593fecae1@opensips.org>
References: <0564CECC-E8C6-4B7D-AF5C-D0FA0D4010EE@genesys.com>
 <bff60fb6-3e9f-b869-678e-cde2ad0bf739@opensips.org>
 <78E544C4-D735-4EE2-B4C8-7A49ECA15F84@genesys.com>
 <0f8aa7f0-815b-0516-17cf-1668d74b9aaa@opensips.org>
 <E76DF1A1-C03F-485C-8DF0-B4DF0FE06D07@genesys.com>
 <92c53f58-ce1a-b433-2e95-0bb256683129@opensips.org>
 <3CB63581-3C6F-49F7-892D-80A130B8B75D@genesys.com>
 <244cb304-5af5-9e93-0214-3c16fdd07e2e@opensips.org>
 <c537ec96-fe0d-6e00-ac35-cc2885131d3e@opensips.org>
 <C8006710-CD9C-48E6-9773-A2F019848438@genesys.com>
 <79138097-0f61-4b3d-1e0e-6766c7c97986@opensips.org>
 <7032F04A-043B-417A-90CB-B0C7D28BE19A@genesys.com>
 <0fef793b-2a1f-14ff-f757-37f36035d065@opensips.org>
 <13F09A3F-00FE-4000-83A1-B6731B921EEE@genesys.com>
 <212db1fd-9621-8993-b2f7-1ca593fecae1@opensips.org>
Message-ID: <B280F659-4758-4E36-90B2-1CA89F675F72@genesys.com>

Yes, Liviu provided the specific commit in another message and I have upgraded.

Thanks again!

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org>
Date: Tuesday, November 20, 2018 at 7:38 AM
To: Ben Newlin <Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

The fix is now available on GIT repo, so simply update and it should be fine.

Regards,


Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/19/2018 05:31 PM, Ben Newlin wrote:
Bogdan,

That is excellent news! Thank you very much for your work on this and Liviu as well!

Ben Newlin

From: Bogdan-Andrei Iancu <bogdan at opensips.org><mailto:bogdan at opensips.org>
Date: Monday, November 19, 2018 at 9:03 AM
To: Ben Newlin <Ben.Newlin at genesys.com><mailto:Ben.Newlin at genesys.com>, OpenSIPS devel mailling list <devel at lists.opensips.org><mailto:devel at lists.opensips.org>
Subject: Re: [OpenSIPS-Devel] OpenSIPS Crash

Hi Ben,

With some additional information that we got from a different feed, we managed to reproduce the crash and Liviu is working on a fix as we speak. I will keep you posted, but many thanks for your help in investigating this issue.

Best regards,



Bogdan-Andrei Iancu



OpenSIPS Founder and Developer

  http://www.opensips-solutions.com<http://www.opensips-solutions.com>

OpenSIPS Bootcamp 2018

  http://opensips.org/training/OpenSIPS_Bootcamp_2018/<http://opensips.org/training/OpenSIPS_Bootcamp_2018/>
On 11/13/2018 07:41 PM, Ben Newlin wrote:
Bogdan,

Yes, we are setting acc_extra variables in our branch routes, which are sometimes (but not always) called from failure route. Are acc_extra variables not available for use in branch_routes?

We don’t currently use drop_accounting anywhere in our script. If I call it before that branch_route then it will stop accounting for that call, right? We need to have accounting records for the call, so I’m not sure how that would resolve the issue?

Ben Newlin



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181120/6b881006/attachment-0001.html>

From bogdan at opensips.org  Thu Nov 22 04:57:38 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 22 Nov 2018 01:57:38 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 95bf16: Fix setting loop
	params during fallback.
Message-ID: <5bf67d924e705_57582abf30f6a5801072@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 95bf163ae951fe145c4735682f8949dc1626abb0
      https://github.com/OpenSIPS/opensips/commit/95bf163ae951fe145c4735682f8949dc1626abb0
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  Fix setting loop params during fallback.

While doing a prefixless rule matching, reset the rule_idx to be sure we break the fallback looping.
Addresses #1536



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov 22 05:12:33 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 22 Nov 2018 02:12:33 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d72f85: b2b_logic: fix doc
	useless phrase
Message-ID: <5bf6811126c62_57652ae1c26c8594138cb@hookshot-fe-265448d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d72f85d9f903e31313e1b048798fefa4e4774354
      https://github.com/OpenSIPS/opensips/commit/d72f85d9f903e31313e1b048798fefa4e4774354
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/b2b_logic/doc/b2b_logic_admin.xml

  Log Message:
  -----------
  b2b_logic: fix doc useless phrase



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov 22 05:16:41 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 22 Nov 2018 02:16:41 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ca643d: net/tcp: listen for
 read events after async connec...
Message-ID: <5bf682094b00_32e92afd2d5fa57861666@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ca643dee0f8851be7c1756bd270f168e41fb053c
      https://github.com/OpenSIPS/opensips/commit/ca643dee0f8851be7c1756bd270f168e41fb053c
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M net/net_tcp.c

  Log Message:
  -----------
  net/tcp: listen for read events after async connect

After an async connect succeeds, the fd should also be added in reactor
for read events, otherwise these will be lost.

Many thanks go to Pete Kelly for reporting and testing!



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov 22 05:17:01 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 22 Nov 2018 02:17:01 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 4b5e25: net/tcp: listen for
 read events after async connec...
Message-ID: <5bf6821d5336d_1c352ae18212657c7819b@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 4b5e254a29740dd1bca9131835c6fc5c103c28c6
      https://github.com/OpenSIPS/opensips/commit/4b5e254a29740dd1bca9131835c6fc5c103c28c6
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M net/net_tcp.c

  Log Message:
  -----------
  net/tcp: listen for read events after async connect

After an async connect succeeds, the fd should also be added in reactor
for read events, otherwise these will be lost.

Many thanks go to Pete Kelly for reporting and testing!

(cherry picked from commit ca643dee0f8851be7c1756bd270f168e41fb053c)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Thu Nov 22 05:17:18 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Thu, 22 Nov 2018 02:17:18 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 362b3c: net/tcp: listen for
 read events after async connec...
Message-ID: <5bf6822e5e16_10f02b09fadc8578233db@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 362b3c22037ad9ccedda68e20147073cbe0acf5f
      https://github.com/OpenSIPS/opensips/commit/362b3c22037ad9ccedda68e20147073cbe0acf5f
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M net/net_tcp.c

  Log Message:
  -----------
  net/tcp: listen for read events after async connect

After an async connect succeeds, the fd should also be added in reactor
for read events, otherwise these will be lost.

Many thanks go to Pete Kelly for reporting and testing!

(cherry picked from commit ca643dee0f8851be7c1756bd270f168e41fb053c)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov 22 05:35:36 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 22 Nov 2018 02:35:36 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6bc2a9: Fix nested triggers of
	local route.
Message-ID: <5bf68678e26a7_32c42ae2beae65708039e@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 6bc2a94c85d61c61f50ed5fc63e626a23a63258e
      https://github.com/OpenSIPS/opensips/commit/6bc2a94c85d61c61f50ed5fc63e626a23a63258e
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_msgbuilder.h
    M modules/tm/uac.c

  Log Message:
  -----------
  Fix nested triggers of local route.

Use a dynamically allocated sip_msg struct rather than a static one.
Credits go to Aron Podrigal to spot and report the problem.
Addresses #1537



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov 22 07:09:38 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 22 Nov 2018 04:09:38 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2a96e2: Fix setting loop
	params during fallback.
Message-ID: <5bf69c82c9fd7_27622b06576f65845368@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2a96e2052b1815b131af1a3dc8967ffcee319855
      https://github.com/OpenSIPS/opensips/commit/2a96e2052b1815b131af1a3dc8967ffcee319855
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  Fix setting loop params during fallback.

While doing a prefixless rule matching, reset the rule_idx to be sure we break the fallback looping.
Addresses #1536

(cherry picked from commit 95bf163ae951fe145c4735682f8949dc1626abb0)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov 22 07:10:20 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Thu, 22 Nov 2018 04:10:20 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 928ea9: Fix setting loop
	params during fallback.
Message-ID: <5bf69cac361bf_a322ae9d9b74574355b4@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 928ea999b6f10045f643e7c550672f7cf506332b
      https://github.com/OpenSIPS/opensips/commit/928ea999b6f10045f643e7c550672f7cf506332b
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  Fix setting loop params during fallback.

While doing a prefixless rule matching, reset the rule_idx to be sure we break the fallback looping.
Addresses #1536

(cherry picked from commit 95bf163ae951fe145c4735682f8949dc1626abb0)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Thu Nov 22 09:50:36 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 22 Nov 2018 06:50:36 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d75644: acc: Fix buffer
	overflow
Message-ID: <5bf6c23ceb330_29212aba6c0e2580766d9@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d75644994c3fbf2d503aaa2912ca8b6b11fcf715
      https://github.com/OpenSIPS/opensips/commit/d75644994c3fbf2d503aaa2912ca8b6b11fcf715
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix buffer overflow

The set_dlg_value() code would initialize the buffer to STRING_INIT_SIZE
(128) bytes but then immediately proceed to using it without any more
length checks, thus corrupting the memory any time it is run with larger
than 128-byte acc_extra values.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Thu Nov 22 09:59:21 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 22 Nov 2018 06:59:21 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9cd25a: acc: Fix previous
	commit
Message-ID: <5bf6c449d0bd7_11202af44b462584135ef@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9cd25a74e95f17130d1920c5f0845887b5b78722
      https://github.com/OpenSIPS/opensips/commit/9cd25a74e95f17130d1920c5f0845887b5b78722
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix previous commit

Optimize storage space -- don't store entire buffer, rather only the
useful part of it...



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Thu Nov 22 10:09:15 2018
From: bogdan at opensips.org (Bogdan Andrei IANCU)
Date: Thu, 22 Nov 2018 07:09:15 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3462e8: Fixed what was missed
	out in 6bc2a94
Message-ID: <5bf6c69ba0349_49462aedc25425887275d@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3462e8906c878f779ba696db29b3610606f0d9f5
      https://github.com/OpenSIPS/opensips/commit/3462e8906c878f779ba696db29b3610606f0d9f5
  Author: Aron Podrigal <aronp at guaranteedplus.com>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_reply.c
    M modules/tm/uac.c

  Log Message:
  -----------
  Fixed what was missed out in 6bc2a94

refs #1537


  Commit: 340adcdfb3f0f65d0b0f281a7f2f4d1c4e12ee61
      https://github.com/OpenSIPS/opensips/commit/340adcdfb3f0f65d0b0f281a7f2f4d1c4e12ee61
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_reply.c
    M modules/tm/uac.c

  Log Message:
  -----------
  Merge pull request #1543 from ar45/fix_1537

Fixed what was missed out in 6bc2a94


Compare: https://github.com/OpenSIPS/opensips/compare/9cd25a74e95f...340adcdfb3f0
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From aronp at guaranteedplus.com  Thu Nov 22 10:21:36 2018
From: aronp at guaranteedplus.com (Aron Podrigal)
Date: Thu, 22 Nov 2018 07:21:36 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b4f7ad: Fix nested triggers of
	local route.
Message-ID: <5bf6c980d9429_77782b1c4d5585901149b@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b4f7ad3a20b76cf5abbadd1d73eeee317929d1d5
      https://github.com/OpenSIPS/opensips/commit/b4f7ad3a20b76cf5abbadd1d73eeee317929d1d5
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_msgbuilder.h
    M modules/tm/uac.c

  Log Message:
  -----------
  Fix nested triggers of local route.

Use a dynamically allocated sip_msg struct rather than a static one.
Credits go to Aron Podrigal to spot and report the problem.
Addresses #1537

(cherry picked from commit 6bc2a94c85d61c61f50ed5fc63e626a23a63258e)


  Commit: 1d9e1f36d69fb8cdf7decde856756f6b76da427d
      https://github.com/OpenSIPS/opensips/commit/1d9e1f36d69fb8cdf7decde856756f6b76da427d
  Author: Aron Podrigal <aronp at guaranteedplus.com>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_reply.c
    M modules/tm/uac.c

  Log Message:
  -----------
  Fixed what was missed out in 6bc2a94

refs #1537

(cherry picked from commit 3462e8906c878f779ba696db29b3610606f0d9f5)


Compare: https://github.com/OpenSIPS/opensips/compare/4b5e254a2974...1d9e1f36d69f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From aronp at guaranteedplus.com  Thu Nov 22 10:22:39 2018
From: aronp at guaranteedplus.com (Aron Podrigal)
Date: Thu, 22 Nov 2018 07:22:39 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a21fa6: Fix nested triggers of
	local route.
Message-ID: <5bf6c9bf3c8fe_3d9f2acc78072578479b9@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a21fa6ddd9573aad99b83034c656ed4def2e6564
      https://github.com/OpenSIPS/opensips/commit/a21fa6ddd9573aad99b83034c656ed4def2e6564
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_msgbuilder.h
    M modules/tm/uac.c

  Log Message:
  -----------
  Fix nested triggers of local route.

Use a dynamically allocated sip_msg struct rather than a static one.
Credits go to Aron Podrigal to spot and report the problem.
Addresses #1537

(cherry picked from commit 6bc2a94c85d61c61f50ed5fc63e626a23a63258e)


  Commit: 0cd9bba22675217bb1000fd2e66f93c2c844dd8a
      https://github.com/OpenSIPS/opensips/commit/0cd9bba22675217bb1000fd2e66f93c2c844dd8a
  Author: Aron Podrigal <aronp at guaranteedplus.com>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/tm/t_reply.c
    M modules/tm/uac.c

  Log Message:
  -----------
  Fixed what was missed out in 6bc2a94

refs #1537

(cherry picked from commit 3462e8906c878f779ba696db29b3610606f0d9f5)


Compare: https://github.com/OpenSIPS/opensips/compare/928ea999b6f1...0cd9bba22675
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Thu Nov 22 10:46:09 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 22 Nov 2018 07:46:09 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 405d28: acc: Fix buffer
	overflow
Message-ID: <5bf6cf4125d64_3f342aba959ee588897f4@hookshot-fe-31feec6.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 405d2889ba1974e0b181cd8725b0ac98258c5c9f
      https://github.com/OpenSIPS/opensips/commit/405d2889ba1974e0b181cd8725b0ac98258c5c9f
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix buffer overflow

The set_dlg_value() code would initialize the buffer to STRING_INIT_SIZE
(128) bytes but then immediately proceed to using it without any more
length checks, thus corrupting the memory any time it is run with larger
than 128-byte acc_extra values.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Thu Nov 22 10:51:34 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Thu, 22 Nov 2018 07:51:34 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5a147c: acc: Fix buffer
	overflow
Message-ID: <5bf6d086c3a9a_77d52b01c1dac58099e2@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5a147c6e3aa21edde413f7c0246a532ca6a85448
      https://github.com/OpenSIPS/opensips/commit/5a147c6e3aa21edde413f7c0246a532ca6a85448
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-22 (Thu, 22 Nov 2018)

  Changed paths:
    M modules/acc/acc.c

  Log Message:
  -----------
  acc: Fix buffer overflow



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 25 15:10:44 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 25 Nov 2018 12:10:44 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d578fa: Rebuild documentation
Message-ID: <5bfb01c4d5af3_3bc2add38fba57877478@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d578fa6e7c08c1c04dfb95afb7e0b90407f5a1c9
      https://github.com/OpenSIPS/opensips/commit/d578fa6e7c08c1c04dfb95afb7e0b90407f5a1c9
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-25 (Sun, 25 Nov 2018)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/sipmsgops/README
    M modules/sipmsgops/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 25 15:30:27 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 25 Nov 2018 12:30:27 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 24dbe1: Rebuild documentation
Message-ID: <5bfb0663b1c_7c002b254ea4457c516d9@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 24dbe1d01dd67d4aa4adede3eede70703533ac3f
      https://github.com/OpenSIPS/opensips/commit/24dbe1d01dd67d4aa4adede3eede70703533ac3f
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-25 (Sun, 25 Nov 2018)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/sipmsgops/README
    M modules/sipmsgops/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From github at opensips.org  Sun Nov 25 15:42:27 2018
From: github at opensips.org (OpenSIPS)
Date: Sun, 25 Nov 2018 12:42:27 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2b0ce6: Rebuild documentation
Message-ID: <5bfb0933fedc_72e02ae05b58858462d8@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2b0ce6e36da3aa32ff4e66c937a946a2e701cf59
      https://github.com/OpenSIPS/opensips/commit/2b0ce6e36da3aa32ff4e66c937a946a2e701cf59
  Author: OpenSIPS <github at opensips.org>
  Date:   2018-11-25 (Sun, 25 Nov 2018)

  Changed paths:
    M modules/acc/README
    M modules/acc/doc/contributors.xml
    M modules/b2b_logic/README
    M modules/b2b_logic/doc/contributors.xml
    M modules/drouting/README
    M modules/drouting/doc/contributors.xml
    M modules/sipmsgops/README
    M modules/sipmsgops/doc/contributors.xml
    M modules/tm/README
    M modules/tm/doc/contributors.xml

  Log Message:
  -----------
  Rebuild documentation



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 26 06:44:50 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 26 Nov 2018 03:44:50 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 770ff5: acc/dialog: Drop
	redundant operations
Message-ID: <5bfbdcb267a76_50672b06e502c5941017fe@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 770ff565f99554dedc606c98f1d31c1947a07470
      https://github.com/OpenSIPS/opensips/commit/770ff565f99554dedc606c98f1d31c1947a07470
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/acc/acc.c
    M modules/dialog/dlg_vals.c

  Log Message:
  -----------
  acc/dialog: Drop redundant operations



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Mon Nov 26 06:52:10 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Mon, 26 Nov 2018 03:52:10 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] abe988: tm: fix avp add error
	check
Message-ID: <5bfbde6a628ff_17282b21a922657844b7@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: abe988a2df61dc8deaae18e9fbfedc12f0c806a7
      https://github.com/OpenSIPS/opensips/commit/abe988a2df61dc8deaae18e9fbfedc12f0c806a7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/tm/tm.c

  Log Message:
  -----------
  tm: fix avp add error check


  Commit: 3659b848f0bca6c6faa0d80b24cda1aff2f25434
      https://github.com/OpenSIPS/opensips/commit/3659b848f0bca6c6faa0d80b24cda1aff2f25434
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/b2b_entities/b2b_entities.c
    M modules/b2b_logic/b2b_load.h
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/doc/b2b_logic_admin.xml
    M modules/b2b_logic/logic.c

  Log Message:
  -----------
  b2b: make the dialog matching logic more relaxed

When bridging an entity, instead of matching the B2B dialog only by B2B
key (which is basically impossible to find out unless you run b2b_list),
from now on one can also use the `B2B.entity.key;from_tag;to_tag`.


Compare: https://github.com/OpenSIPS/opensips/compare/770ff565f995...3659b848f0bc
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Mon Nov 26 08:14:56 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 26 Nov 2018 05:14:56 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0ccda2: Fix formating floats
	in SQL queries.
Message-ID: <5bfbf1d0eefc_305e2aac7937657c139ac@hookshot-fe-da92815.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0ccda2e249890238f94736dfd8b179c359afa8f0
      https://github.com/OpenSIPS/opensips/commit/0ccda2e249890238f94736dfd8b179c359afa8f0
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M main.c

  Log Message:
  -----------
  Fix formating floats in SQL queries.

Force POSIX locale for LC_NUMERIC to be sure that the dot separater is used when using floats in SQL queries (some locales are using the comma for that, breaking the SQL syntax).

Closes #1538



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Mon Nov 26 08:15:39 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 26 Nov 2018 05:15:39 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e2d1a6: Fix formating floats
	in SQL queries.
Message-ID: <5bfbf1fb9d0ea_5c62ac984e72584242c6@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e2d1a67ab45363e001ff979f506982f6871e827c
      https://github.com/OpenSIPS/opensips/commit/e2d1a67ab45363e001ff979f506982f6871e827c
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M main.c

  Log Message:
  -----------
  Fix formating floats in SQL queries.

Force POSIX locale for LC_NUMERIC to be sure that the dot separater is used when using floats in SQL queries (some locales are using the comma for that, breaking the SQL syntax).

Closes #1538

(cherry picked from commit 0ccda2e249890238f94736dfd8b179c359afa8f0)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Mon Nov 26 08:19:41 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Mon, 26 Nov 2018 05:19:41 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a03416: Fix formating floats
	in SQL queries.
Message-ID: <5bfbf2edf116a_337e2acbd16e657897120@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: a034161054b013649f0a02cf26f2f3cea76a3fae
      https://github.com/OpenSIPS/opensips/commit/a034161054b013649f0a02cf26f2f3cea76a3fae
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M main.c

  Log Message:
  -----------
  Fix formating floats in SQL queries.

Force POSIX locale for LC_NUMERIC to be sure that the dot separater is used when using floats in SQL queries (some locales are using the comma for that, breaking the SQL syntax).

Closes #1538

(cherry picked from commit 0ccda2e249890238f94736dfd8b179c359afa8f0)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladpaiu at opensips.org  Mon Nov 26 08:21:32 2018
From: vladpaiu at opensips.org (Vlad Paiu)
Date: Mon, 26 Nov 2018 05:21:32 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 471be6: Fixed
 dr_number_routing crash with empty partition
Message-ID: <5bfbf35ca386a_125f2ae1bda2e580823a3@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 471be6300afae359265e41d53bc790d02e2102a6
      https://github.com/OpenSIPS/opensips/commit/471be6300afae359265e41d53bc790d02e2102a6
  Author: Vlad Paiu <vladpaiu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  Fixed dr_number_routing crash with empty partition

(cherry picked from commit b0bf9270729b0de5f7894688411353e1c5738be3)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From vladpaiu at opensips.org  Mon Nov 26 08:21:49 2018
From: vladpaiu at opensips.org (Vlad Paiu)
Date: Mon, 26 Nov 2018 05:21:49 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 94b7a5: Fixed
 dr_number_routing crash with empty partition
Message-ID: <5bfbf36d9e70a_8d72b157eb4657c1000cf@hookshot-fe-31feec6.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 94b7a5b26a0bfbf718d10d360f1bb70a6d5924d2
      https://github.com/OpenSIPS/opensips/commit/94b7a5b26a0bfbf718d10d360f1bb70a6d5924d2
  Author: Vlad Paiu <vladpaiu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/drouting/drouting.c

  Log Message:
  -----------
  Fixed dr_number_routing crash with empty partition

(cherry picked from commit b0bf9270729b0de5f7894688411353e1c5738be3)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Mon Nov 26 09:23:58 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Mon, 26 Nov 2018 06:23:58 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 25fb33: b2b_logic: use late
 negociation for last ACK using...
Message-ID: <5bfc01fea7f22_62ce2acb85960584406df@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 25fb33ee7f562b1f2b7a4001d9c6460ba3199a04
      https://github.com/OpenSIPS/opensips/commit/25fb33ee7f562b1f2b7a4001d9c6460ba3199a04
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/b2b_logic/b2b_logic.c

  Log Message:
  -----------
  b2b_logic: use late negociation for last ACK using MI bridge



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Mon Nov 26 09:24:17 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Mon, 26 Nov 2018 06:24:17 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 156cc6: b2b_logic: use late
 negociation for last ACK using...
Message-ID: <5bfc02113a96a_2982ad5f487a58845380@hookshot-fe-0763bc5.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 156cc6f0bf0dd1395fc4706dcdf6a18b6c390f88
      https://github.com/OpenSIPS/opensips/commit/156cc6f0bf0dd1395fc4706dcdf6a18b6c390f88
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/b2b_logic/b2b_logic.c

  Log Message:
  -----------
  b2b_logic: use late negociation for last ACK using MI bridge

(cherry picked from commit 25fb33ee7f562b1f2b7a4001d9c6460ba3199a04)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Mon Nov 26 09:24:29 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Mon, 26 Nov 2018 06:24:29 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b1a9dc: b2b_logic: use late
 negociation for last ACK using...
Message-ID: <5bfc021da6e5c_d0822abf588ac57c91162@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: b1a9dcf9c6671ed42d1586ded563cb972ddb5204
      https://github.com/OpenSIPS/opensips/commit/b1a9dcf9c6671ed42d1586ded563cb972ddb5204
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/b2b_logic/b2b_logic.c

  Log Message:
  -----------
  b2b_logic: use late negociation for last ACK using MI bridge

(cherry picked from commit 25fb33ee7f562b1f2b7a4001d9c6460ba3199a04)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 26 09:36:07 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 26 Nov 2018 06:36:07 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 20f13a: registrar: Fix a flag
	parsing limitation
Message-ID: <5bfc04d7477ca_6e5e2acfbd340578452d7@hookshot-fe-88eb02d.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 20f13a53d5460ef610bb784734e093cfd43ff218
      https://github.com/OpenSIPS/opensips/commit/20f13a53d5460ef610bb784734e093cfd43ff218
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/registrar/lookup.c

  Log Message:
  -----------
  registrar: Fix a flag parsing limitation

Once again allow the "i" and "e" flags to be given before or after the
regexp following the "u" flag.

Many thanks to @ivanoff946 for reporting!

Fixes #1545



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 26 09:37:02 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 26 Nov 2018 06:37:02 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 59667f: registrar: Fix a flag
	parsing limitation
Message-ID: <5bfc050e1cd21_36832af1486f057c398e0@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 59667fb087c25310d696d8b65f1c4484fadf0edc
      https://github.com/OpenSIPS/opensips/commit/59667fb087c25310d696d8b65f1c4484fadf0edc
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/registrar/lookup.c

  Log Message:
  -----------
  registrar: Fix a flag parsing limitation

Once again allow the "i" and "e" flags to be given before or after the
regexp following the "u" flag.

Many thanks to @ivanoff946 for reporting!

Fixes #1545

(cherry picked from commit 20f13a53d5460ef610bb784734e093cfd43ff218)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 26 10:27:29 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 26 Nov 2018 07:27:29 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 3f698a: Logging: Fix missing
	'\n' endings
Message-ID: <5bfc10e152c49_19582abd4bd1c58064f7@hookshot-fe-b0febf1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 3f698a26c816d8b14530da65f208f417845d0852
      https://github.com/OpenSIPS/opensips/commit/3f698a26c816d8b14530da65f208f417845d0852
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/aaa_radius/rad.c
    M modules/acc/acc_mod.c
    M modules/auth/challenge.c
    M modules/auth_aaa/checks.c
    M modules/auth_aaa/sterman.c
    M modules/auth_db/checks.c
    M modules/b2b_entities/b2be_db.c
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/logic.c
    M modules/benchmark/benchmark.c
    M modules/cachedb_cassandra/cachedb_cassandra_dbase.c
    M modules/cachedb_sql/cachedb_sql.c
    M modules/cfgutils/cfgutils.c
    M modules/db_berkeley/bdb_lib.c
    M modules/db_berkeley/bdb_res.c
    M modules/db_perlvdb/perlvdb_oohelpers.c
    M modules/db_postgres/dbase.c
    M modules/db_text/dbt_api.c
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_replication.c
    M modules/dialog/dlg_vals.c
    M modules/dialplan/dp_repl.c
    M modules/domain/domain.c
    M modules/domain/domain_mod.c
    M modules/drouting/dr_api_internal.c
    M modules/drouting/drouting.c
    M modules/emergency/emergency_methods.c
    M modules/emergency/http_emergency.c
    M modules/emergency/notifier_emergency.c
    M modules/emergency/post_curl.c
    M modules/emergency/report_emergency.c
    M modules/emergency/sip_emergency.c
    M modules/emergency/subscriber_emergency.c
    M modules/event_datagram/event_datagram.c
    M modules/event_jsonrpc/event_jsonrpc.c
    M modules/event_jsonrpc/jsonrpc_send.c
    M modules/event_rabbitmq/event_rabbitmq.c
    M modules/event_xmlrpc/event_xmlrpc.c
    M modules/exec/exec_mod.c
    M modules/fraud_detection/fraud_detection.c
    M modules/fraud_detection/frd_events.c
    M modules/fraud_detection/frd_load.c
    M modules/group/group.c
    M modules/json/json.c
    M modules/jsonrpc/jsonrpc.c
    M modules/lua/sipluafunc.c
    M modules/mi_datagram/mi_datagram_parser.c
    M modules/mi_xmlrpc_ng/http_fnc.c
    M modules/mid_registrar/lookup.c
    M modules/mid_registrar/save.c
    M modules/msilo/msilo.c
    M modules/osp/osp_mod.c
    M modules/perl/opensipsxs.xs
    M modules/perl/perlfunc.c
    M modules/presence/notify.c
    M modules/presence/presentity.c
    M modules/presence/sharing_tags.c
    M modules/presence_dialoginfo/notify_body.c
    M modules/presence_xml/notify_body.c
    M modules/presence_xml/xcap_auth.c
    M modules/proto_hep/hep.c
    M modules/proto_ws/ws_handshake_common.h
    M modules/pua/hash.c
    M modules/pua/pua.c
    M modules/pua/send_subscribe.c
    M modules/pua_bla/notify.c
    M modules/pua_dialoginfo/pua_dialoginfo.c
    M modules/pua_usrloc/ul_publish.c
    M modules/pua_xmpp/pua_xmpp.c
    M modules/pua_xmpp/simple2xmpp.c
    M modules/pua_xmpp/xmpp2simple.c
    M modules/ratelimit/ratelimit.c
    M modules/regex/regex_mod.c
    M modules/registrar/lookup.c
    M modules/registrar/save.c
    M modules/rls/notify.c
    M modules/rr/record.c
    M modules/rtpengine/rtpengine.c
    M modules/rtpproxy/nhelpr_funcs.c
    M modules/rtpproxy/rtpproxy.c
    M modules/rtpproxy/timeout_process.c
    M modules/script_helper/script_helper.c
    M modules/seas/seas_action.c
    M modules/sipcapture/sipcapture.c
    M modules/sipmsgops/sipmsgops.c
    M modules/siprec/siprec_body.c
    M modules/snmpstats/hashTable.c
    M modules/snmpstats/snmpstats.c
    M modules/speeddial/sdlookup.c
    M modules/sql_cacher/sql_cacher.c
    M modules/stun/stun.c
    M modules/tls_mgm/tls_domain.c
    M modules/tls_mgm/tls_mgm.c
    M modules/tm/t_msgbuilder.h
    M modules/uac_auth/uac_auth.c
    M modules/userblacklist/userblacklist.c
    M modules/usrloc/ul_dbg.h

  Log Message:
  -----------
  Logging: Fix missing '\n' endings



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From liviu at opensips.org  Mon Nov 26 10:31:49 2018
From: liviu at opensips.org (Liviu Chircu)
Date: Mon, 26 Nov 2018 07:31:49 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f82c49: acc/dialog: Drop
	redundant operations
Message-ID: <5bfc11e5bc455_3daf2b13ddc8657427552@hookshot-fe-d2afb11.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: f82c49eb97224a20255ff88d6c6dc0a94d2a68b5
      https://github.com/OpenSIPS/opensips/commit/f82c49eb97224a20255ff88d6c6dc0a94d2a68b5
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/acc/acc.c
    M modules/dialog/dlg_vals.c

  Log Message:
  -----------
  acc/dialog: Drop redundant operations

(cherry picked from commit 770ff565f99554dedc606c98f1d31c1947a07470)


  Commit: 4aec0b23869c0525ca5175bfdcfae5d30f901b66
      https://github.com/OpenSIPS/opensips/commit/4aec0b23869c0525ca5175bfdcfae5d30f901b66
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-11-26 (Mon, 26 Nov 2018)

  Changed paths:
    M modules/aaa_radius/rad.c
    M modules/acc/acc_mod.c
    M modules/auth/challenge.c
    M modules/auth_aaa/sterman.c
    M modules/b2b_entities/b2be_db.c
    M modules/b2b_entities/dlg.c
    M modules/b2b_logic/b2b_logic.c
    M modules/b2b_logic/logic.c
    M modules/benchmark/benchmark.c
    M modules/cachedb_sql/cachedb_sql.c
    M modules/cfgutils/cfgutils.c
    M modules/db_berkeley/bdb_lib.c
    M modules/db_berkeley/bdb_res.c
    M modules/db_perlvdb/perlvdb_oohelpers.c
    M modules/db_postgres/dbase.c
    M modules/db_text/dbt_api.c
    M modules/dialog/dialog.c
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_replication.c
    M modules/dialplan/dp_repl.c
    M modules/domain/domain.c
    M modules/domain/domain_mod.c
    M modules/drouting/dr_api_internal.c
    M modules/drouting/drouting.c
    M modules/emergency/emergency_methods.c
    M modules/emergency/http_emergency.c
    M modules/emergency/notifier_emergency.c
    M modules/emergency/post_curl.c
    M modules/emergency/report_emergency.c
    M modules/emergency/sip_emergency.c
    M modules/emergency/subscriber_emergency.c
    M modules/event_datagram/event_datagram.c
    M modules/event_jsonrpc/event_jsonrpc.c
    M modules/event_jsonrpc/jsonrpc_send.c
    M modules/event_rabbitmq/event_rabbitmq.c
    M modules/event_xmlrpc/event_xmlrpc.c
    M modules/exec/exec_mod.c
    M modules/fraud_detection/fraud_detection.c
    M modules/fraud_detection/frd_events.c
    M modules/fraud_detection/frd_load.c
    M modules/group/group.c
    M modules/json/json.c
    M modules/jsonrpc/jsonrpc.c
    M modules/lua/sipluafunc.c
    M modules/mi_datagram/mi_datagram_parser.c
    M modules/mi_xmlrpc_ng/http_fnc.c
    M modules/mid_registrar/lookup.c
    M modules/mid_registrar/save.c
    M modules/msilo/msilo.c
    M modules/osp/osp_mod.c
    M modules/perl/opensipsxs.xs
    M modules/perl/perlfunc.c
    M modules/presence/notify.c
    M modules/presence/presentity.c
    M modules/presence/sharing_tags.c
    M modules/presence_dialoginfo/notify_body.c
    M modules/presence_xml/notify_body.c
    M modules/presence_xml/xcap_auth.c
    M modules/proto_hep/hep.c
    M modules/proto_ws/ws_handshake_common.h
    M modules/pua/hash.c
    M modules/pua/pua.c
    M modules/pua/send_subscribe.c
    M modules/pua_bla/notify.c
    M modules/pua_dialoginfo/pua_dialoginfo.c
    M modules/pua_usrloc/ul_publish.c
    M modules/pua_xmpp/pua_xmpp.c
    M modules/pua_xmpp/simple2xmpp.c
    M modules/pua_xmpp/xmpp2simple.c
    M modules/ratelimit/ratelimit.c
    M modules/regex/regex_mod.c
    M modules/registrar/lookup.c
    M modules/registrar/save.c
    M modules/rls/notify.c
    M modules/rr/record.c
    M modules/rtpengine/rtpengine.c
    M modules/rtpproxy/nhelpr_funcs.c
    M modules/rtpproxy/rtpproxy.c
    M modules/rtpproxy/timeout_process.c
    M modules/script_helper/script_helper.c
    M modules/seas/seas_action.c
    M modules/sipcapture/sipcapture.c
    M modules/sipmsgops/sipmsgops.c
    M modules/siprec/siprec_body.c
    M modules/snmpstats/hashTable.c
    M modules/snmpstats/snmpstats.c
    M modules/speeddial/sdlookup.c
    M modules/sql_cacher/sql_cacher.c
    M modules/stun/stun.c
    M modules/tls_mgm/tls_domain.c
    M modules/tls_mgm/tls_mgm.c
    M modules/tm/t_msgbuilder.h
    M modules/uac_auth/uac_auth.c
    M modules/uri/aaa_checks.c
    M modules/uri/db_checks.c
    M modules/userblacklist/userblacklist.c
    M modules/usrloc/ul_dbg.h

  Log Message:
  -----------
  Logging: Fix missing '\n' endings

(cherry picked from commit 3f698a26c816d8b14530da65f208f417845d0852)

Conflicts:
      modules/cachedb_cassandra/cachedb_cassandra_dbase.c
      modules/dialog/dialog.c
      modules/tls_mgm/tls_mgm.c
      modules/uri/db_checks.c


Compare: https://github.com/OpenSIPS/opensips/compare/59667fb087c2...4aec0b23869c
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 27 08:58:56 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 27 Nov 2018 15:58:56 +0200
Subject: [OpenSIPS-Devel] OpenSIPS Summit 2019 - Amsterdam, NL
Message-ID: <1a9ba488-1e8a-3b47-7b83-969da3349e82@opensips.org>

<http://www.opensips.org/events/Summit-2019Amsterdam>



  OpenSIPS Summit 2019

April 30 - May 3, 2019

Amsterdam, The Netherlands


Once again, the OpenSIPS Summit 
<https://www.opensips.org/events/Summit-2019Amsterdam/> will take place 
in Amsterdam, becoming the hotspot of VoIP & RTC world for *4 full 
days*.**Three**days of talks, inspiring presentations, amazing demos 
followed by one day of trainings about *OpenSIPS* and the *Open Source* 
ecosystem.

Join us to learn what is new & important in VoIP & RTC, to discover how 
technology evolves and how you can benefit of it. *Just knowledge in its 
most pure format*.


*Some Great Reasons to Attend*

  * Access the latest news, knowledge and experience in the VoIP & RTC world
  * Learn about upcoming 3.0 OpenSIPS release and how you can leverage it
  * Attend unique presentations and interactive technical workshops
  * Meet FOSS developers and community to share experience and comments
  * Get solutions consultancy during the Free Design Clinics
  * Become an Expert attending the OpenSIPS Advanced Training


*Summit Agenda*

  * Two full days of presentations given by key speakers
  * Open Discussions with key people from OpenSIPS and other OSS projects
  * Interactive Demos and Showcases
  * Design Clinics to validate your OpenSIPS deployments
  * One full day of OpenSIPS Training (limited seats!)
  * Social events in the amazing Amsterdam


*Be part of it*

Be part of the OpenSIPS and the Open Source community, be part of the 
OpenSIPS Summit 2019.

*Attend to learn* - the registration process will be open in the 
following days, stay tuned. Nevertheless, pre-registration is available, 
just contact us.

*Speak to share* - the Call for Papers will be announced during next 
week, so you can share your wisdom and experience with the world.

*Sponsor to help* - we welcome any help in making the Summit such a 
great event. Sponsoring is a natural way of saying "Thank you" for the 
Open Source code you are using within your businesses.

Interested? Please contact 
<https://www.opensips.org/events/Summit-2019Amsterdam/#contact-map> our 
team or email <mailto:summit at opensips.org?subject=OpenSIPS%20Summit> us!


<https://www.google.com/maps/place/Radisson+Blu+Hotel,+Amsterdam/@52.3702502,4.8944856,17z/data=%213m1%214b1%214m5%213m4%211s0x47c609bf6cde2ad5:0x764aad4243f5348f%218m2%213d52.3702469%214d4.8966743?hl=en> 


*
*

*Radisson Blu**
**Rusland 17, 1012CK Amsterdam, The Netherlands*

Meet us again at our familiar Venue, with even more space and comfort 
than ever! This year the OpenSIPS Summit expands in size and will 
accommodate more participants and speakers.


**


	
	

	
	


-- 
Bogdan-Andrei Iancu
   OpenSIPS Founder and Developer
   http://www.opensips-solutions.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opensips.org/pipermail/devel/attachments/20181127/bb2d5229/attachment.html>

From bogdan at opensips.org  Tue Nov 27 10:50:47 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 27 Nov 2018 07:50:47 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2fa738: Improve docs
Message-ID: <5bfd67d7eeb6b_5f662ad2e6b6458442384@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 2fa7389b973360c12c46963ec6cef9bb038e3b0d
      https://github.com/OpenSIPS/opensips/commit/2fa7389b973360c12c46963ec6cef9bb038e3b0d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/registrar/README
    M modules/registrar/doc/registrar_admin.xml

  Log Message:
  -----------
  Improve docs

A bit more details on handling GRUU.
Thanks to Robert Dyck for contributing on this.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 27 10:51:35 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 27 Nov 2018 07:51:35 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e6aead: Improve docs
Message-ID: <5bfd6807f1661_3ecc2ad9f38a85843144f@hookshot-fe-88eb02d.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e6aead732c43607ba8df9f8e9f77ef33559f3312
      https://github.com/OpenSIPS/opensips/commit/e6aead732c43607ba8df9f8e9f77ef33559f3312
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/registrar/README
    M modules/registrar/doc/registrar_admin.xml

  Log Message:
  -----------
  Improve docs

A bit more details on handling GRUU.
Thanks to Robert Dyck for contributing on this.

(cherry picked from commit 2fa7389b973360c12c46963ec6cef9bb038e3b0d)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 27 10:52:03 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 27 Nov 2018 07:52:03 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 15cdc6: Improve docs
Message-ID: <5bfd6823d3a7d_76572acd6ba9458014653@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 15cdc6f92b33f301708b34c78c80768829198755
      https://github.com/OpenSIPS/opensips/commit/15cdc6f92b33f301708b34c78c80768829198755
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/registrar/README
    M modules/registrar/doc/registrar_admin.xml

  Log Message:
  -----------
  Improve docs

A bit more details on handling GRUU.
Thanks to Robert Dyck for contributing on this.

(cherry picked from commit 2fa7389b973360c12c46963ec6cef9bb038e3b0d)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 27 10:52:24 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 27 Nov 2018 07:52:24 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ed4f97: Improve docs
Message-ID: <5bfd683878679_74e82af3fe2ec5803877f@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: ed4f97e295e10708594efecbf31cafc19fd02cb9
      https://github.com/OpenSIPS/opensips/commit/ed4f97e295e10708594efecbf31cafc19fd02cb9
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/registrar/README
    M modules/registrar/doc/registrar_admin.xml

  Log Message:
  -----------
  Improve docs

A bit more details on handling GRUU.
Thanks to Robert Dyck for contributing on this.

(cherry picked from commit 2fa7389b973360c12c46963ec6cef9bb038e3b0d)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 27 11:31:49 2018
From: bogdan at opensips.org (Bogdan Andrei IANCU)
Date: Tue, 27 Nov 2018 08:31:49 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7b2a29: Correct parsing IPv6
	address
Message-ID: <5bfd71758d59c_45e42adad4e685788361f@hookshot-fe-a5fcff7.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7b2a296daa1fee0c9a6c7cd2f0be2bfde25e0e0b
      https://github.com/OpenSIPS/opensips/commit/7b2a296daa1fee0c9a6c7cd2f0be2bfde25e0e0b
  Author: Alexey Vasilyev <alexei.vasilyev at gmail.com>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/tls_mgm/tls_domain.c

  Log Message:
  -----------
  Correct parsing IPv6 address


  Commit: 7565427577efcbd9e437dbdb9784e0e5ab629c9f
      https://github.com/OpenSIPS/opensips/commit/7565427577efcbd9e437dbdb9784e0e5ab629c9f
  Author: Bogdan Andrei IANCU <bogdan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/tls_mgm/tls_domain.c

  Log Message:
  -----------
  Merge pull request #1549 from vasilevalex/tls_mgmt_ipv6

Correct parsing IPv6 address


Compare: https://github.com/OpenSIPS/opensips/compare/2fa7389b9733...7565427577ef
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From bogdan at opensips.org  Tue Nov 27 11:35:11 2018
From: bogdan at opensips.org (Bogdan-Andrei Iancu)
Date: Tue, 27 Nov 2018 08:35:11 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7c785f: Correct parsing IPv6
	address
Message-ID: <5bfd723fd338_77532ad9438305809398b@hookshot-fe-32b5f5b.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 7c785fc4df21ed21f27b6a490e279ac167de5c2c
      https://github.com/OpenSIPS/opensips/commit/7c785fc4df21ed21f27b6a490e279ac167de5c2c
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/tls_mgm/api.h

  Log Message:
  -----------
  Correct parsing IPv6 address

Manual backport of 7b2a296daa1fee0c9a6c7cd2f0be2bfde25e0e0b



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Tue Nov 27 11:48:45 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Tue, 27 Nov 2018 08:48:45 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] be3b60: compression: fix leaks
 when message was rebuilt
Message-ID: <5bfd756d6f449_63312b153286e580485b7@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: be3b60366763c3c0390f20be590420440c834204
      https://github.com/OpenSIPS/opensips/commit/be3b60366763c3c0390f20be590420440c834204
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/compression/compression.c

  Log Message:
  -----------
  compression: fix leaks when message was rebuilt

When the initial buffer had to be changed, the previous one was no
longer released, resulting in a memleak.

Credits go to Jock McKechnie for reporting and providing testing env!



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Tue Nov 27 11:48:59 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Tue, 27 Nov 2018 08:48:59 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d7f636: compression: fix leaks
 when message was rebuilt
Message-ID: <5bfd757b7a94f_c392af85c3ea5746085d@hookshot-fe-5a11256.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: d7f636733c47310f5af3468d499e14a79653f1e7
      https://github.com/OpenSIPS/opensips/commit/d7f636733c47310f5af3468d499e14a79653f1e7
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/compression/compression.c

  Log Message:
  -----------
  compression: fix leaks when message was rebuilt

When the initial buffer had to be changed, the previous one was no
longer released, resulting in a memleak.

Credits go to Jock McKechnie for reporting and providing testing env!

(cherry picked from commit be3b60366763c3c0390f20be590420440c834204)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Tue Nov 27 11:49:14 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Tue, 27 Nov 2018 08:49:14 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9efcb7: compression: fix leaks
 when message was rebuilt
Message-ID: <5bfd758aedee3_62cb2afd9eaa857c680ba@hookshot-fe-7191cb1.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9efcb7d07da4150757f28597f652793e5da09e0a
      https://github.com/OpenSIPS/opensips/commit/9efcb7d07da4150757f28597f652793e5da09e0a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/compression/compression.c

  Log Message:
  -----------
  compression: fix leaks when message was rebuilt

When the initial buffer had to be changed, the previous one was no
longer released, resulting in a memleak.

Credits go to Jock McKechnie for reporting and providing testing env!

(cherry picked from commit be3b60366763c3c0390f20be590420440c834204)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Tue Nov 27 12:48:14 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Tue, 27 Nov 2018 09:48:14 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e7fa92: rtpengine: fix
	checking "cached" stats
Message-ID: <5bfd835e83264_77632aba16820578529a9@hookshot-fe-d252ca1.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: e7fa92cc2c8124f40240deecdc56ad2f258ff21a
      https://github.com/OpenSIPS/opensips/commit/e7fa92cc2c8124f40240deecdc56ad2f258ff21a
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: fix checking "cached" stats

Credits go to Nick Altman for reporting this in ticket #1500



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Tue Nov 27 12:48:26 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Tue, 27 Nov 2018 09:48:26 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5cf181: rtpengine: fix
	checking "cached" stats
Message-ID: <5bfd836a62746_46282b28a748457c3273f@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 5cf1811aabdcf3dfcad8431bd5f4549c8fc02be0
      https://github.com/OpenSIPS/opensips/commit/5cf1811aabdcf3dfcad8431bd5f4549c8fc02be0
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-27 (Tue, 27 Nov 2018)

  Changed paths:
    M modules/rtpengine/rtpengine.c

  Log Message:
  -----------
  rtpengine: fix checking "cached" stats

Credits go to Nick Altman for reporting this in ticket #1500

(cherry picked from commit e7fa92cc2c8124f40240deecdc56ad2f258ff21a)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Wed Nov 28 10:02:41 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Wed, 28 Nov 2018 07:02:41 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0d8197: mongodb: remove
 deprecated is_error() in json-c 0....
Message-ID: <5bfeae114abdc_7b132af380d0e5787394@hookshot-fe-6b2eebc.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0d819747817b90d05610e57a1168ce56b0610c09
      https://github.com/OpenSIPS/opensips/commit/0d819747817b90d05610e57a1168ce56b0610c09
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M modules/cachedb_mongodb/cachedb_mongodb_json.c

  Log Message:
  -----------
  mongodb: remove deprecated is_error() in json-c 0.13



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From razvan at opensips.org  Wed Nov 28 10:02:52 2018
From: razvan at opensips.org (Razvan Crainea)
Date: Wed, 28 Nov 2018 07:02:52 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9d3249: mongodb: remove
 deprecated is_error() in json-c 0....
Message-ID: <5bfeae1cc3803_8222aba9b00859042212@hookshot-fe-cace476.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 9d32492f1ed15eb976a5f7862761c01dc4e2d129
      https://github.com/OpenSIPS/opensips/commit/9d32492f1ed15eb976a5f7862761c01dc4e2d129
  Author: Razvan Crainea <razvan at opensips.org>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M modules/cachedb_mongodb/cachedb_mongodb_json.c

  Log Message:
  -----------
  mongodb: remove deprecated is_error() in json-c 0.13

(cherry picked from commit 0d819747817b90d05610e57a1168ce56b0610c09)



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From dan at ag-projects.com  Thu Nov 29 06:02:07 2018
From: dan at ag-projects.com (Dan Pascu)
Date: Thu, 29 Nov 2018 03:02:07 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0fb084: Fixed segfault when
 resource list document is not ...
Message-ID: <5bffc72f5d14d_33a12ab96a97a58810223@hookshot-fe-6e9b612.cp1-iad.github.net.mail>

  Branch: refs/heads/master
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 0fb0849adf4f6ab48fdc5f84f9bab6f3bfa9bd33
      https://github.com/OpenSIPS/opensips/commit/0fb0849adf4f6ab48fdc5f84f9bab6f3bfa9bd33
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2018-11-29 (Thu, 29 Nov 2018)

  Changed paths:
    M modules/presence_xml/xcap_auth.c

  Log Message:
  -----------
  Fixed segfault when resource list document is not found



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From dan at ag-projects.com  Thu Nov 29 06:02:54 2018
From: dan at ag-projects.com (Dan Pascu)
Date: Thu, 29 Nov 2018 03:02:54 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 797af7: Fixed segfault when
 resource list document is not ...
Message-ID: <5bffc75e52edc_1b77a2ae2f35e05787143d@hookshot-fe-dfcc362.cp1-iad.github.net.mail>

  Branch: refs/heads/2.4
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 797af72395fdca2f5982220899f6059420ddb49f
      https://github.com/OpenSIPS/opensips/commit/797af72395fdca2f5982220899f6059420ddb49f
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2018-11-29 (Thu, 29 Nov 2018)

  Changed paths:
    M modules/presence_xml/xcap_auth.c

  Log Message:
  -----------
  Fixed segfault when resource list document is not found



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

From dan at ag-projects.com  Thu Nov 29 09:15:35 2018
From: dan at ag-projects.com (Dan Pascu)
Date: Thu, 29 Nov 2018 06:15:35 -0800
Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 101722: Fixed segfault when
 resource list document is not ...
Message-ID: <5bfff48732549_325f2ae3a8dce57c2338b@hookshot-fe-2cc8887.cp1-iad.github.net.mail>

  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: 1017225bf5d6bacf18734db44f529c2d45c7ad7e
      https://github.com/OpenSIPS/opensips/commit/1017225bf5d6bacf18734db44f529c2d45c7ad7e
  Author: Dan Pascu <dan at ag-projects.com>
  Date:   2018-11-29 (Thu, 29 Nov 2018)

  Changed paths:
    M modules/presence_xml/xcap_auth.c

  Log Message:
  -----------
  Fixed segfault when resource list document is not found



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.