From bogdan at opensips.org Wed May 2 05:52:49 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Wed, 2 May 2018 12:52:49 +0300 Subject: [OpenSIPS-Devel] Fwd: ClueCon Weekly is live from OpenSIPS Summit in Amsterdam In-Reply-To: <73f7dcee16e0a87ece76c372d.a3d5aaa2f1.20180501130003.ea7a0aa130.a9c4f3f2@mail210.atl121.mcsv.net> References: <73f7dcee16e0a87ece76c372d.a3d5aaa2f1.20180501130003.ea7a0aa130.a9c4f3f2@mail210.atl121.mcsv.net> Message-ID: <11acba6d-229b-00f0-2360-13a69dd55674@opensips.org> ClueCon Weekly is live from OpenSIPS Summit in Amsterdam *Special ClueCon Weekly Live From OpenSIPS Summit in Amsterdam* Don't miss this weeks ClueCon Weekly. For the first time ever we will be airing live from OpenSIPS Summit in Amsterdam. Tune in on Wednesday, May 2nd at 12pm Central Standard time here: Dial 888 athttps://conference.freeswitch.org/vc/ or https://www.youtube.com/watch?v=gJqkld_C0dk Michael Mavroudis will be moderating a live panel of OpenSIPS summit attendees discussing all things VoIP. *Check out Fred's latest episode: * *FreeSWITCH PBX Phrase Macros* ** Fred Muteesa illustrates how you can use Phrase Macros in your dialplan to add more logic to your sound files. FreeSWITCH will be reading back to the caller, their caller ID Number or Extension. Subscribe to our YouTube channel today! *Did You Know?* FreeSWITCH Offers Several Products to Make Your FreeSWITCH Deployment Easier Our just announced, Cloud hosted VM's. Pre-provisioned with FreeSWITCH OR FreeSWITCH and FusionPBX. Many options to choose from, check out what we have to offer! This is our online version of the FreeSWITCH Basic training that is offered a few times a year and at ClueCon. Get a head start with FreeSWITCH by signing up for Virtual Training! Are you interested in sponsoring ClueCon 2018? Contact marketing at cluecon.com and we can let you know what options are available. *The Earlier You Register the More Chances to Win Great Prizes!* * *Before May 1st* 20 Raffle Tickets Per Day* * *Before June 1st* 15 Raffle Tickets Per Day* * *Before June 15th* 10 Raffle Tickets Per Day* * *Before July 1st* 5 Raffle Tickets Per Day * *New Speakers Added weekly!* Keep checking back for the latest updates on ClueCon 2018 speakers and events! Follow us on Facebook and Twitter to keep up with the latest /Copyright © 2018 FreeSWITCH Solutions, All rights reserved./ This is a mailing list for all things FreeSWITCH! You have been subscribed to this list because you subscribed to the FreeSWITCH Users mailing list. If you would like to unsubscribe please click the link below. *Our mailing address is:* FreeSWITCH Solutions 17345 Civic Drive #2531 Brookfield, WI 53045 Add us to your address book Want to change how you receive these emails? You can update your preferences or unsubscribe from this list -------------- next part -------------- An HTML attachment was scrubbed... URL: From liviu at opensips.org Wed May 2 08:17:57 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 02 May 2018 05:17:57 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bbfdba: registrar: Fix expires handling on 200 OK save() Message-ID: <5ae9ac7564c4c_57042ad1ac133c1c657ca@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: bbfdbaf9d69ef39160459b6f5f81e5a2e9344cdc https://github.com/OpenSIPS/opensips/commit/bbfdbaf9d69ef39160459b6f5f81e5a2e9344cdc Author: Liviu Chircu Date: 2018-05-02 (Wed, 02 May 2018) Changed paths: M modules/registrar/save.c Log Message: ----------- registrar: Fix expires handling on 200 OK save() Silently use the default_expires, similarly to the behavior during a standard save() on a REGISTER, without throwing warnings. Credits to Norman Brandinger for providing the patch. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 2 08:18:31 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 02 May 2018 05:18:31 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ba005a: registrar: Fix expires handling on 200 OK save() Message-ID: <5ae9ac97dd16b_5dd2ab099309c141028bc@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: ba005ae890ede8de7fc99e6ad87ca99dde7cb525 https://github.com/OpenSIPS/opensips/commit/ba005ae890ede8de7fc99e6ad87ca99dde7cb525 Author: Liviu Chircu Date: 2018-05-02 (Wed, 02 May 2018) Changed paths: M modules/registrar/save.c Log Message: ----------- registrar: Fix expires handling on 200 OK save() Silently use the default_expires, similarly to the behavior during a standard save() on a REGISTER, without throwing warnings. Credits to Norman Brandinger for providing the patch. (cherry picked from commit bbfdbaf9d69ef39160459b6f5f81e5a2e9344cdc) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 2 08:18:43 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 02 May 2018 05:18:43 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ddf9f8: registrar: Fix expires handling on 200 OK save() Message-ID: <5ae9aca37b649_68d22b1655963c1427641@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: ddf9f84e57674f616d93a818636ab8e42f7f909b https://github.com/OpenSIPS/opensips/commit/ddf9f84e57674f616d93a818636ab8e42f7f909b Author: Liviu Chircu Date: 2018-05-02 (Wed, 02 May 2018) Changed paths: M modules/registrar/save.c Log Message: ----------- registrar: Fix expires handling on 200 OK save() Silently use the default_expires, similarly to the behavior during a standard save() on a REGISTER, without throwing warnings. Credits to Norman Brandinger for providing the patch. (cherry picked from commit bbfdbaf9d69ef39160459b6f5f81e5a2e9344cdc) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 2 08:18:54 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 02 May 2018 05:18:54 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 053f1f: registrar: Fix expires handling on 200 OK save() Message-ID: <5ae9acae11bb6_8b02ab9fbef9c0c315f2@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: 053f1feedb753d837c01a25190cdf2e53e93abc5 https://github.com/OpenSIPS/opensips/commit/053f1feedb753d837c01a25190cdf2e53e93abc5 Author: Liviu Chircu Date: 2018-05-02 (Wed, 02 May 2018) Changed paths: M modules/registrar/save.c Log Message: ----------- registrar: Fix expires handling on 200 OK save() Silently use the default_expires, similarly to the behavior during a standard save() on a REGISTER, without throwing warnings. Credits to Norman Brandinger for providing the patch. (cherry picked from commit bbfdbaf9d69ef39160459b6f5f81e5a2e9344cdc) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Mon May 7 09:07:48 2018 From: liviu at opensips.org (Liviu Chircu) Date: Mon, 07 May 2018 06:07:48 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f2c86e: acc: Fix "ms_duration" computation Message-ID: <5af04fa4b7d34_48452adb1ced1c106179f@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: f2c86ed3fa19d256c1a2c5ae5b246871ccc8b312 https://github.com/OpenSIPS/opensips/commit/f2c86ed3fa19d256c1a2c5ae5b246871ccc8b312 Author: Liviu Chircu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/acc/acc.c M ut.h Log Message: ----------- acc: Fix "ms_duration" computation Reported by John Quick **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Mon May 7 09:08:20 2018 From: liviu at opensips.org (Liviu Chircu) Date: Mon, 07 May 2018 06:08:20 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e0e927: acc: Fix "ms_duration" computation Message-ID: <5af04fc482b2a_18762af5a8c69c105235@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: e0e927cae6b6198530f0f9c9294f39359add632a https://github.com/OpenSIPS/opensips/commit/e0e927cae6b6198530f0f9c9294f39359add632a Author: Liviu Chircu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/acc/acc.c M ut.h Log Message: ----------- acc: Fix "ms_duration" computation Reported by John Quick (cherry picked from commit f2c86ed3fa19d256c1a2c5ae5b246871ccc8b312) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Mon May 7 09:35:04 2018 From: liviu at opensips.org (Liviu Chircu) Date: Mon, 07 May 2018 06:35:04 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 88b3cb: acc: Fix "ms_duration" computation Message-ID: <5af0560835a2e_4e762ad832957c0421332@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 88b3cb65e746d2402b69d5bd41651f418c968db7 https://github.com/OpenSIPS/opensips/commit/88b3cb65e746d2402b69d5bd41651f418c968db7 Author: Liviu Chircu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/acc/acc.c M ut.h Log Message: ----------- acc: Fix "ms_duration" computation Reported by John Quick (cherry picked from commit f2c86ed3fa19d256c1a2c5ae5b246871ccc8b312) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Mon May 7 09:41:35 2018 From: liviu at opensips.org (Liviu Chircu) Date: Mon, 07 May 2018 06:41:35 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6a07d5: acc: Fix "ms_duration" computation Message-ID: <5af0578f66269_30ec2b2298d2dbfc82925@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: 6a07d588f6b6e1400e29bdd50246ce334af84caf https://github.com/OpenSIPS/opensips/commit/6a07d588f6b6e1400e29bdd50246ce334af84caf Author: Liviu Chircu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/acc/acc.c M ut.h Log Message: ----------- acc: Fix "ms_duration" computation Reported by John Quick (cherry picked from commit f2c86ed3fa19d256c1a2c5ae5b246871ccc8b312) (cherry picked from commit 88b3cb65e746d2402b69d5bd41651f418c968db7) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 7 12:38:38 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 07 May 2018 09:38:38 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 47e5c4: sip_i: fix crash for numbers longer than 15 digits Message-ID: <5af0810e6a837_c172af959669c0c585ad@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 47e5c47d3bb2ad7999a14b80d6412866d90493c9 https://github.com/OpenSIPS/opensips/commit/47e5c47d3bb2ad7999a14b80d6412866d90493c9 Author: Vlad Patrascu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/sip_i/sip_i.c M modules/sip_i/sip_i.h Log Message: ----------- sip_i: fix crash for numbers longer than 15 digits Mapping the Called Party number or Calling Party number for IAM by default could cause a stack smashing for numbers longer than 15 digits (E.164 limit). Fixes #1348 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 7 12:39:46 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 07 May 2018 09:39:46 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1ee6c8: sip_i: fix crash for numbers longer than 15 digits Message-ID: <5af08152cbde_74552ae5aeb69c0c953fb@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 1ee6c85b6ea2d672fae1217c8c711cc96a6e1566 https://github.com/OpenSIPS/opensips/commit/1ee6c85b6ea2d672fae1217c8c711cc96a6e1566 Author: Vlad Patrascu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/sip_i/sip_i.c M modules/sip_i/sip_i.h Log Message: ----------- sip_i: fix crash for numbers longer than 15 digits Mapping the Called Party number or Calling Party number for IAM by default could cause a stack smashing for numbers longer than 15 digits (E.164 limit). Fixes #1348 (cherry picked from commit 47e5c47d3bb2ad7999a14b80d6412866d90493c9) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 7 12:40:35 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 07 May 2018 09:40:35 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c30017: sip_i: fix crash for numbers longer than 15 digits Message-ID: <5af0818380ffc_59ad2b1956d3dc14909bf@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: c30017b708a630ee5dc9f657f98e901ba4e6b718 https://github.com/OpenSIPS/opensips/commit/c30017b708a630ee5dc9f657f98e901ba4e6b718 Author: Vlad Patrascu Date: 2018-05-07 (Mon, 07 May 2018) Changed paths: M modules/sip_i/sip_i.c M modules/sip_i/sip_i.h Log Message: ----------- sip_i: fix crash for numbers longer than 15 digits Mapping the Called Party number or Calling Party number for IAM by default could cause a stack smashing for numbers longer than 15 digits (E.164 limit). Fixes #1348 (cherry picked from commit 47e5c47d3bb2ad7999a14b80d6412866d90493c9) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 8 05:43:19 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 08 May 2018 02:43:19 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0fcee0: sip_i docs: fix subfield value Message-ID: <5af171375f24a_5b962b11a843fc0897520@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 0fcee0b4ae1402038d4e7ad375762fc0ef631539 https://github.com/OpenSIPS/opensips/commit/0fcee0b4ae1402038d4e7ad375762fc0ef631539 Author: Vlad Patrascu Date: 2018-05-08 (Tue, 08 May 2018) Changed paths: M modules/sip_i/README M modules/sip_i/doc/sip_i_admin.xml Log Message: ----------- sip_i docs: fix subfield value **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 8 06:51:36 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 08 May 2018 03:51:36 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1b69af: sip_i docs: fix subfield value Message-ID: <5af181389fc3a_4ebf2ab6ac425c10381b5@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 1b69af0673659899f41a00f31675c6f87fefd516 https://github.com/OpenSIPS/opensips/commit/1b69af0673659899f41a00f31675c6f87fefd516 Author: Vlad Patrascu Date: 2018-05-08 (Tue, 08 May 2018) Changed paths: M modules/sip_i/README M modules/sip_i/doc/sip_i_admin.xml Log Message: ----------- sip_i docs: fix subfield value **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 8 06:52:31 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 08 May 2018 03:52:31 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 060a38: sip_i docs: fix subfield value Message-ID: <5af1816f5df58_175c2ac75c9fdc08465ef@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 060a386fc9731ee613433e781d8869119f3e67f1 https://github.com/OpenSIPS/opensips/commit/060a386fc9731ee613433e781d8869119f3e67f1 Author: Vlad Patrascu Date: 2018-05-08 (Tue, 08 May 2018) Changed paths: M modules/sip_i/README M modules/sip_i/doc/sip_i_admin.xml Log Message: ----------- sip_i docs: fix subfield value **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 8 08:56:04 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 08 May 2018 05:56:04 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 341429: xmpp: fix uninitialized warning Message-ID: <5af19e64decaa_9db2aec7878bc043007@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 3414292faa23d63d6039d9dd31c3bbe2e4cf0e7c https://github.com/OpenSIPS/opensips/commit/3414292faa23d63d6039d9dd31c3bbe2e4cf0e7c Author: Vlad Patrascu Date: 2018-05-08 (Tue, 08 May 2018) Changed paths: M modules/xmpp/xmpp.c Log Message: ----------- xmpp: fix uninitialized warning **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 8 08:56:31 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 08 May 2018 05:56:31 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 4592fd: xmpp: fix uninitialized warning Message-ID: <5af19e7f2f654_368d2b0fdc3dbc08865f0@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 4592fde0f93587b3fea06e72e0c396a4cc04187b https://github.com/OpenSIPS/opensips/commit/4592fde0f93587b3fea06e72e0c396a4cc04187b Author: Vlad Patrascu Date: 2018-05-08 (Tue, 08 May 2018) Changed paths: M modules/xmpp/xmpp.c Log Message: ----------- xmpp: fix uninitialized warning **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 05:04:34 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 02:04:34 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1d1f3d: dialog: Fix re-INVITE pinging SDPs after on-hold/r... Message-ID: <5af2b9a21e9b5_3ce02ac2e3c57bfc15869@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 1d1f3d04d75b3c2a46444d7a6d57348ce85543a9 https://github.com/OpenSIPS/opensips/commit/1d1f3d04d75b3c2a46444d7a6d57348ce85543a9 Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix re-INVITE pinging SDPs after on-hold/resume **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 05:26:47 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 02:26:47 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 4b59ff: dialog: Document re-INVITE pinging interval restri... Message-ID: <5af2bed754ea6_40c62ae6f40ffc0c80018@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 4b59ffc0c65dca11a043faf61eb2987555192603 https://github.com/OpenSIPS/opensips/commit/4b59ffc0c65dca11a043faf61eb2987555192603 Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/dialog/README M modules/dialog/doc/dialog_admin.xml Log Message: ----------- dialog: Document re-INVITE pinging interval restrictions **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 06:14:01 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 03:14:01 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2bb11c: usrloc: Fix possible crash during contact pinging Message-ID: <5af2c9e9e11cb_1a522b120fd49c10109661@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 2bb11c599095fbef90706bad9e314feba80d107f https://github.com/OpenSIPS/opensips/commit/2bb11c599095fbef90706bad9e314feba80d107f Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/usrloc/dlist.c Log Message: ----------- usrloc: Fix possible crash during contact pinging This patch fixes a bug introduced in commit 02e6a641292, where the output buffer does not contain a leading "0000" marker despite the "ul.get_all_contacts()" function returning a 0 ("all contacts have been dumped, the buffer is properly formatted"). Reported by @thesipguy Credits to Răzvan Crainea for spotting the bug Fixes #1352 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 06:22:47 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 03:22:47 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 31fba7: usrloc: Fix possible crash during contact pinging Message-ID: <5af2cbf7c2981_1ed12ac9c2583c1484230@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 31fba7d0f82eecfd0fadb0f99e02e903f5888e65 https://github.com/OpenSIPS/opensips/commit/31fba7d0f82eecfd0fadb0f99e02e903f5888e65 Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/usrloc/dlist.c Log Message: ----------- usrloc: Fix possible crash during contact pinging This patch fixes a bug introduced in commit 02e6a641292, where the output buffer does not contain a leading "0000" marker despite the "ul.get_all_contacts()" function returning a 0 ("all contacts have been dumped, the buffer is properly formatted"). Reported by @thesipguy Credits to Răzvan Crainea for spotting the bug Fixes #1352 (cherry picked from commit 2bb11c599095fbef90706bad9e314feba80d107f) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Wed May 9 08:15:45 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Wed, 09 May 2018 05:15:45 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ea647c: Fixed empty socket info in DB during reload Message-ID: <5af2e67118fd5_32552aeec56adc0c673ed@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: ea647c59aeaea6c8abfc910a8c6bbb31e0f552eb https://github.com/OpenSIPS/opensips/commit/ea647c59aeaea6c8abfc910a8c6bbb31e0f552eb Author: Bogdan-Andrei Iancu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/presence/subscribe.c Log Message: ----------- Fixed empty socket info in DB during reload The insert subscription code may push an empty string for the socket info, so the DB reload code must cope with this without error. Also relax the reloading sequence - ignore broken subscription records rather than stopping the entire reload and breaking the startup sequence. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Wed May 9 08:34:08 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Wed, 09 May 2018 05:34:08 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 187f7d: Fixed empty socket info in DB during reload Message-ID: <5af2eac087e0d_6db62b272fed9c08711fa@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 187f7d08eada6a83c2303f7601227d8f2aab1e29 https://github.com/OpenSIPS/opensips/commit/187f7d08eada6a83c2303f7601227d8f2aab1e29 Author: Bogdan-Andrei Iancu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/presence/subscribe.c Log Message: ----------- Fixed empty socket info in DB during reload The insert subscription code may push an empty string for the socket info, so the DB reload code must cope with this without error. Also relax the reloading sequence - ignore broken subscription records rather than stopping the entire reload and breaking the startup sequence. (cherry picked from commit ea647c59aeaea6c8abfc910a8c6bbb31e0f552eb) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 11:58:37 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 08:58:37 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9fe020: freeswitch: Fix ESL handle and file descriptor lea... Message-ID: <5af31aadcab60_4c1e2af8ccf5fc044352f@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 9fe0201819653bd47f3638e8c161a946fa71b738 https://github.com/OpenSIPS/opensips/commit/9fe0201819653bd47f3638e8c161a946fa71b738 Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/freeswitch/esl/src/esl.c M modules/freeswitch/fs_proc.c Log Message: ----------- freeswitch: Fix ESL handle and file descriptor leaks Thanks to Ken Rice for reporting, providing a testing environment and helping troubleshoot these bugs. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 11:58:51 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 08:58:51 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] aa37c2: freeswitch: Fix ESL handle and file descriptor lea... Message-ID: <5af31abbbe4af_18762af5a8c69c1068397@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: aa37c2caf884fed4a446d28ee21ad28cab6215f1 https://github.com/OpenSIPS/opensips/commit/aa37c2caf884fed4a446d28ee21ad28cab6215f1 Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/freeswitch/esl/src/esl.c M modules/freeswitch/fs_proc.c Log Message: ----------- freeswitch: Fix ESL handle and file descriptor leaks Thanks to Ken Rice for reporting, providing a testing environment and helping troubleshoot these bugs. (cherry picked from commit 9fe0201819653bd47f3638e8c161a946fa71b738) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 12:46:15 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 09:46:15 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a2934c: freeswitch: Force event re-subscribes after a disc... Message-ID: <5af325d716b38_2c8e2ae61dc83c049224e@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: a2934c79ed80401387e0e889293ab89d106922ef https://github.com/OpenSIPS/opensips/commit/a2934c79ed80401387e0e889293ab89d106922ef Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/freeswitch/fs_proc.c Log Message: ----------- freeswitch: Force event re-subscribes after a disconnect Credits to Ken Rice for reporting this issue **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 9 12:46:33 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 09 May 2018 09:46:33 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ea3559: freeswitch: Force event re-subscribes after a disc... Message-ID: <5af325e96a3ac_49a82ade0af15c08529c4@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: ea355971733098dac3f4d82dac1667dc90e0288c https://github.com/OpenSIPS/opensips/commit/ea355971733098dac3f4d82dac1667dc90e0288c Author: Liviu Chircu Date: 2018-05-09 (Wed, 09 May 2018) Changed paths: M modules/freeswitch/fs_proc.c Log Message: ----------- freeswitch: Force event re-subscribes after a disconnect Credits to Ken Rice for reporting this issue (cherry picked from commit a2934c79ed80401387e0e889293ab89d106922ef) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 10 12:39:54 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 10 May 2018 09:39:54 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] deb3ee: dialog: Fix dialog matching bugs in looping + TH s... Message-ID: <5af475da7c5fd_19812b28e4823c0487377@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: deb3ee457b1f64a169b61751e6490c7049f1493e https://github.com/OpenSIPS/opensips/commit/deb3ee457b1f64a169b61751e6490c7049f1493e Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dialog.c M modules/dialog/dlg_handlers.h M modules/dialog/dlg_load.h M modules/script_helper/script_helper.c M modules/topology_hiding/topology_hiding.c Log Message: ----------- dialog: Fix dialog matching bugs in looping + TH scenarios This patch adds an extra control parameter to topology_hiding_match() and match_dialog() which allows the script writer to disable the current behavior of forcefully imposing the "DID_FALLBACK" dialog matching mode. In looping scenarios, performing SIP-wise dialog matching may be out of the question, as we may randomly match one of multiple dialogs with identical SIP coordinates. Commit: 362e65d28ac6409d66d48bea4a735c1558dd6993 https://github.com/OpenSIPS/opensips/commit/362e65d28ac6409d66d48bea4a735c1558dd6993 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/README M modules/dialog/doc/dialog_admin.xml M modules/topology_hiding/README M modules/topology_hiding/doc/topology_hiding_admin.xml Log Message: ----------- dialog/topology_hiding: Update docs Compare: https://github.com/OpenSIPS/opensips/compare/a2934c79ed80...362e65d28ac6 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 10 12:41:28 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 10 May 2018 09:41:28 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] fba650: dialog: Fix Re-INVITE pinging issues with parallel... Message-ID: <5af476387068c_1322af9bbff7c1c853ab@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: fba65033e8878bdc3ab7b8ebcb1c7029e02e2237 https://github.com/OpenSIPS/opensips/commit/fba65033e8878bdc3ab7b8ebcb1c7029e02e2237 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_handlers.c M modules/dialog/dlg_handlers.h M modules/dialog/dlg_hash.c M modules/dialog/dlg_hash.h M modules/dialog/dlg_replication.c M modules/dialog/dlg_timer.c Log Message: ----------- dialog: Fix Re-INVITE pinging issues with parallel forking The Re-INVITE pinging code would always leak both SDP and contact buffers when parallel forking. Moreover, depending on which branch answered the call, in some cases OpenSIPS would only Re-INVITE ping one of the parties involved, even if both "Rr" create_dialog() flags are set. This patch fixes the above issues by storing the SDPs of each forked branch into the "callee" leg array. Each call leg gets created before the INVITE branch is sent out, rather than only getting created upon matching a 200 OK reply. When matching a reply, the corresponding leg becomes 1 + the Via branch idx, which added by tm. (0, 1, 2, ...) Remaining issue: Proper handling for the multi-200 OK scenario, as we currently still overwrite the callee SDP at each 200 OK. (cherry picked from commit a03ed4e1a366807df3a89efada59df0d07f4d361) Commit: 6fa390bde2c408fa291973929eaa97bad3238f2c https://github.com/OpenSIPS/opensips/commit/6fa390bde2c408fa291973929eaa97bad3238f2c Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_hash.h Log Message: ----------- dialog: Clarify the new meaning of dlg_leg.sdp (cherry picked from commit bf2ae315609b1224338273a059b5f760b961b89f) Commit: 67b2bf382de40bc2e93672d8e952ffd30e12940b https://github.com/OpenSIPS/opensips/commit/67b2bf382de40bc2e93672d8e952ffd30e12940b Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_handlers.c M modules/dialog/dlg_hash.c M modules/dialog/dlg_hash.h M modules/dialog/dlg_timer.c Log Message: ----------- dialog: Fix regression in commit a03ed4e1a3 Commit a03ed4e1a3 may have fixed the create_dialog("Rr") scenarios, but it also broke the simpler ones, which rely on create_dialog(). Reported by Nick Altmann (cherry picked from commit b45ee74f5994ffdca12ccc8b6df0bcb33ca4c0b5) Commit: 7d887fb4e8ffe15e93ae6d15e2d777469e5a056b https://github.com/OpenSIPS/opensips/commit/7d887fb4e8ffe15e93ae6d15e2d777469e5a056b Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix pkg memleak in commit a03ed4e1a3 The auto-generated CANCEL messages were leaking the parsed Via header. Reported by Nick Altmann (cherry picked from commit 34960b140f81adca25bf9ad84ac2bc078732421e) Commit: 7d0f6bc0ec4aa823f83199c91591dfbfe56cc1a7 https://github.com/OpenSIPS/opensips/commit/7d0f6bc0ec4aa823f83199c91591dfbfe56cc1a7 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix Re-INVITE pinging after restarts The current solution is to persist the SDPs/Contacts of the caller side and the winning callee side into dialog var storage, which is restart persistent ("vars" column). Fixes #1342 (cherry picked from commit 9521770efccd385fafdb2c58ff365627e0d65fef) Commit: fd854b77866e6d591f84ed2db07c39a785f21b7a https://github.com/OpenSIPS/opensips/commit/fd854b77866e6d591f84ed2db07c39a785f21b7a Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_vals.c M modules/dialog/dlg_vals.h Log Message: ----------- dialog: Improve fetch_dlg_value() signature & docs (cherry picked from commit f2626d471d6c1d1b58c2d4a27eee13f96203c24f) Commit: 123255c3e9be2e926c67cfefa340f7c46acb9456 https://github.com/OpenSIPS/opensips/commit/123255c3e9be2e926c67cfefa340f7c46acb9456 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_vals.c Log Message: ----------- dialog: Fix unnecessary errors on DB load Affects DB-persistent dialogs w/o reinvite pinging. This regression was introduced by commit 9521770e. (cherry picked from commit 200a5563b227fc8c231e82f3d42e3c8528358fa2) Commit: 430039fd8c04f17cc762401e1511e01fed20776a https://github.com/OpenSIPS/opensips/commit/430039fd8c04f17cc762401e1511e01fed20776a Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix re-INVITE pinging SDPs after on-hold/resume (cherry picked from commit 1d1f3d04d75b3c2a46444d7a6d57348ce85543a9) Commit: 44af51b1ad35dff8d193fdd3b50f9b8ba02ca546 https://github.com/OpenSIPS/opensips/commit/44af51b1ad35dff8d193fdd3b50f9b8ba02ca546 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/README M modules/dialog/doc/dialog_admin.xml Log Message: ----------- dialog: Document re-INVITE pinging interval restrictions (cherry picked from commit 4b59ffc0c65dca11a043faf61eb2987555192603) Commit: 2ddb4d10cb1ace4f9e50f3c057bd1f978f893d22 https://github.com/OpenSIPS/opensips/commit/2ddb4d10cb1ace4f9e50f3c057bd1f978f893d22 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dialog.c M modules/dialog/dlg_handlers.h M modules/dialog/dlg_load.h M modules/script_helper/script_helper.c M modules/topology_hiding/topology_hiding.c Log Message: ----------- dialog: Fix dialog matching bugs in looping + TH scenarios This patch adds an extra control parameter to topology_hiding_match() and match_dialog() which allows the script writer to disable the current behavior of forcefully imposing the "DID_FALLBACK" dialog matching mode. In looping scenarios, performing SIP-wise dialog matching may be out of the question, as we may randomly match one of multiple dialogs with identical SIP coordinates. (cherry picked from commit deb3ee457b1f64a169b61751e6490c7049f1493e) Commit: 718cf732c76e03cdf3aaee3ed4d2402c0f8bbb99 https://github.com/OpenSIPS/opensips/commit/718cf732c76e03cdf3aaee3ed4d2402c0f8bbb99 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/README M modules/dialog/doc/dialog_admin.xml M modules/topology_hiding/README M modules/topology_hiding/doc/topology_hiding_admin.xml Log Message: ----------- dialog/topology_hiding: Update docs (cherry picked from commit 362e65d28ac6409d66d48bea4a735c1558dd6993) Compare: https://github.com/OpenSIPS/opensips/compare/ea3559717330...718cf732c76e **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 10 12:46:37 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 10 May 2018 09:46:37 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 185672: dialog: Fix Re-INVITE pinging issues with parallel... Message-ID: <5af4776d8b1ab_1aa32ae2fc195c0812032a@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 185672e0f5b17915f5eb4be354082653b341c5a8 https://github.com/OpenSIPS/opensips/commit/185672e0f5b17915f5eb4be354082653b341c5a8 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_handlers.c M modules/dialog/dlg_handlers.h M modules/dialog/dlg_hash.c M modules/dialog/dlg_hash.h M modules/dialog/dlg_replication.c M modules/dialog/dlg_timer.c Log Message: ----------- dialog: Fix Re-INVITE pinging issues with parallel forking The Re-INVITE pinging code would always leak both SDP and contact buffers when parallel forking. Moreover, depending on which branch answered the call, in some cases OpenSIPS would only Re-INVITE ping one of the parties involved, even if both "Rr" create_dialog() flags are set. This patch fixes the above issues by storing the SDPs of each forked branch into the "callee" leg array. Each call leg gets created before the INVITE branch is sent out, rather than only getting created upon matching a 200 OK reply. When matching a reply, the corresponding leg becomes 1 + the Via branch idx, which added by tm. (0, 1, 2, ...) Remaining issue: Proper handling for the multi-200 OK scenario, as we currently still overwrite the callee SDP at each 200 OK. (cherry picked from commit a03ed4e1a366807df3a89efada59df0d07f4d361) (cherry picked from commit fba65033e8878bdc3ab7b8ebcb1c7029e02e2237) Commit: 6f7c7130ab3ee6b4fee28935b075f55cdf9f2c40 https://github.com/OpenSIPS/opensips/commit/6f7c7130ab3ee6b4fee28935b075f55cdf9f2c40 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_hash.h Log Message: ----------- dialog: Clarify the new meaning of dlg_leg.sdp (cherry picked from commit bf2ae315609b1224338273a059b5f760b961b89f) (cherry picked from commit 6fa390bde2c408fa291973929eaa97bad3238f2c) Commit: aea1869ac4361824f67b9682a5f1046a7686d1b8 https://github.com/OpenSIPS/opensips/commit/aea1869ac4361824f67b9682a5f1046a7686d1b8 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_handlers.c M modules/dialog/dlg_hash.c M modules/dialog/dlg_hash.h M modules/dialog/dlg_timer.c Log Message: ----------- dialog: Fix regression in commit a03ed4e1a3 Commit a03ed4e1a3 may have fixed the create_dialog("Rr") scenarios, but it also broke the simpler ones, which rely on create_dialog(). Reported by Nick Altmann (cherry picked from commit b45ee74f5994ffdca12ccc8b6df0bcb33ca4c0b5) (cherry picked from commit 67b2bf382de40bc2e93672d8e952ffd30e12940b) Commit: acb17059e19807c4a1122350c2f1b04cb6fbead8 https://github.com/OpenSIPS/opensips/commit/acb17059e19807c4a1122350c2f1b04cb6fbead8 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix pkg memleak in commit a03ed4e1a3 The auto-generated CANCEL messages were leaking the parsed Via header. Reported by Nick Altmann (cherry picked from commit 34960b140f81adca25bf9ad84ac2bc078732421e) (cherry picked from commit 7d887fb4e8ffe15e93ae6d15e2d777469e5a056b) Commit: 27dee095f9a3707655acdd364c129edc58d4e20f https://github.com/OpenSIPS/opensips/commit/27dee095f9a3707655acdd364c129edc58d4e20f Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix Re-INVITE pinging after restarts The current solution is to persist the SDPs/Contacts of the caller side and the winning callee side into dialog var storage, which is restart persistent ("vars" column). Fixes #1342 (cherry picked from commit 9521770efccd385fafdb2c58ff365627e0d65fef) (cherry picked from commit 7d0f6bc0ec4aa823f83199c91591dfbfe56cc1a7) Commit: 625286e267a65b481ed90fad6a3807a43c8f8cd9 https://github.com/OpenSIPS/opensips/commit/625286e267a65b481ed90fad6a3807a43c8f8cd9 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_vals.c M modules/dialog/dlg_vals.h Log Message: ----------- dialog: Improve fetch_dlg_value() signature & docs (cherry picked from commit f2626d471d6c1d1b58c2d4a27eee13f96203c24f) (cherry picked from commit fd854b77866e6d591f84ed2db07c39a785f21b7a) Commit: 2a59013d7aa5ffbcbac585947e7284b73c10cfcc https://github.com/OpenSIPS/opensips/commit/2a59013d7aa5ffbcbac585947e7284b73c10cfcc Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c M modules/dialog/dlg_vals.c Log Message: ----------- dialog: Fix unnecessary errors on DB load Affects DB-persistent dialogs w/o reinvite pinging. This regression was introduced by commit 9521770e. (cherry picked from commit 200a5563b227fc8c231e82f3d42e3c8528358fa2) (cherry picked from commit 123255c3e9be2e926c67cfefa340f7c46acb9456) Commit: 0d7dea1d52689567ebaba36e8d1f9d4900bcf450 https://github.com/OpenSIPS/opensips/commit/0d7dea1d52689567ebaba36e8d1f9d4900bcf450 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dlg_handlers.c Log Message: ----------- dialog: Fix re-INVITE pinging SDPs after on-hold/resume (cherry picked from commit 1d1f3d04d75b3c2a46444d7a6d57348ce85543a9) (cherry picked from commit 430039fd8c04f17cc762401e1511e01fed20776a) Commit: c4df9724a22dd0b52abb5bda99b8f98435f7e618 https://github.com/OpenSIPS/opensips/commit/c4df9724a22dd0b52abb5bda99b8f98435f7e618 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/README M modules/dialog/doc/dialog_admin.xml Log Message: ----------- dialog: Document re-INVITE pinging interval restrictions (cherry picked from commit 4b59ffc0c65dca11a043faf61eb2987555192603) (cherry picked from commit 44af51b1ad35dff8d193fdd3b50f9b8ba02ca546) Commit: e797ca1e0a7c02a30606ec9de7b68e67560e8465 https://github.com/OpenSIPS/opensips/commit/e797ca1e0a7c02a30606ec9de7b68e67560e8465 Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/dialog.c M modules/dialog/dlg_handlers.h M modules/dialog/dlg_load.h M modules/script_helper/script_helper.c M modules/topology_hiding/topology_hiding.c Log Message: ----------- dialog: Fix dialog matching bugs in looping + TH scenarios This patch adds an extra control parameter to topology_hiding_match() and match_dialog() which allows the script writer to disable the current behavior of forcefully imposing the "DID_FALLBACK" dialog matching mode. In looping scenarios, performing SIP-wise dialog matching may be out of the question, as we may randomly match one of multiple dialogs with identical SIP coordinates. (cherry picked from commit deb3ee457b1f64a169b61751e6490c7049f1493e) (cherry picked from commit 2ddb4d10cb1ace4f9e50f3c057bd1f978f893d22) Commit: 55184367c66d3858da905c9423187d4f0bba14cb https://github.com/OpenSIPS/opensips/commit/55184367c66d3858da905c9423187d4f0bba14cb Author: Liviu Chircu Date: 2018-05-10 (Thu, 10 May 2018) Changed paths: M modules/dialog/README M modules/dialog/dialog.c M modules/dialog/dlg_handlers.c M modules/dialog/doc/dialog_admin.xml M modules/topology_hiding/README M modules/topology_hiding/doc/topology_hiding_admin.xml M modules/topology_hiding/topology_hiding.c Log Message: ----------- dialog/topology_hiding: Update docs (cherry picked from commit 362e65d28ac6409d66d48bea4a735c1558dd6993) (cherry picked from commit 718cf732c76e03cdf3aaee3ed4d2402c0f8bbb99) Compare: https://github.com/OpenSIPS/opensips/compare/060a386fc973...55184367c66d **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Fri May 11 05:55:53 2018 From: razvan at opensips.org (Razvan Crainea) Date: Fri, 11 May 2018 02:55:53 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0da244: rtpproxy: add flag to prevent RTPProxy change body Message-ID: <5af568a9b634d_64242abd76e6bc1c5677b@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 0da2449bec3d115fac3eaecdc2fb687108e7209b https://github.com/OpenSIPS/opensips/commit/0da2449bec3d115fac3eaecdc2fb687108e7209b Author: Razvan Crainea Date: 2018-05-11 (Fri, 11 May 2018) Changed paths: M modules/rtpproxy/README M modules/rtpproxy/doc/rtpproxy_admin.xml M modules/rtpproxy/rtpproxy.c Log Message: ----------- rtpproxy: add flag to prevent RTPProxy change body This is useful when you only want to engage RTPProxy in a ringing state, but then allow the call go though. Close #1349 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 11 06:13:57 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 11 May 2018 03:13:57 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 61829d: dialog: Always match dialogs using dlg_match_mode Message-ID: <5af56ce55e2c_3ed82ae83f217c106010@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 61829d66321e8c37dbfeff36a25bfb95fcead866 https://github.com/OpenSIPS/opensips/commit/61829d66321e8c37dbfeff36a25bfb95fcead866 Author: Liviu Chircu Date: 2018-05-11 (Fri, 11 May 2018) Changed paths: M modules/dialog/README M modules/dialog/dialog.c M modules/dialog/dlg_handlers.h M modules/dialog/doc/dialog_admin.xml M modules/script_helper/script_helper.c M modules/topology_hiding/topology_hiding.c Log Message: ----------- dialog: Always match dialogs using dlg_match_mode This patch changes the default behavior of match_dialog() and topology_hiding_match(), where they would both forcibly use DID_FALLBACK matching, regardless of the value of the "dlg_match_mode" modparam. Starting with 2.4, we change this behavior such that they default to simply playing along with "dlg_match_mode", which is a lot more intuitive from a script writing perspective. If need be, a specific dialog matching behavior may be enforced for certain types of traffic using the newly added optional parameters of match_dialog() and topology_hiding_match(). **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 11 06:14:45 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 11 May 2018 03:14:45 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bfac3e: dialog: Always match dialogs using dlg_match_mode Message-ID: <5af56d155efb8_68022b15871c1c1498786@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: bfac3e8543a90c3cbda21683015355927ab2f0a9 https://github.com/OpenSIPS/opensips/commit/bfac3e8543a90c3cbda21683015355927ab2f0a9 Author: Liviu Chircu Date: 2018-05-11 (Fri, 11 May 2018) Changed paths: M modules/dialog/README M modules/dialog/dialog.c M modules/dialog/dlg_handlers.h M modules/dialog/doc/dialog_admin.xml M modules/script_helper/script_helper.c M modules/topology_hiding/topology_hiding.c Log Message: ----------- dialog: Always match dialogs using dlg_match_mode This patch changes the default behavior of match_dialog() and topology_hiding_match(), where they would both forcibly use DID_FALLBACK matching, regardless of the value of the "dlg_match_mode" modparam. Starting with 2.4, we change this behavior such that they default to simply playing along with "dlg_match_mode", which is a lot more intuitive from a script writing perspective. If need be, a specific dialog matching behavior may be enforced for certain types of traffic using the newly added optional parameters of match_dialog() and topology_hiding_match(). (cherry picked from commit 61829d66321e8c37dbfeff36a25bfb95fcead866) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Fri May 11 08:49:14 2018 From: razvan at opensips.org (Razvan Crainea) Date: Fri, 11 May 2018 05:49:14 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a20b3d: rtpproxy: allow more relaxed lookup Message-ID: <5af5914a6650b_400e2ac7ccd2bc0c5858f@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: a20b3d052bcf1c0ae5789f1de2af7579b840e367 https://github.com/OpenSIPS/opensips/commit/a20b3d052bcf1c0ae5789f1de2af7579b840e367 Author: Razvan Crainea Date: 2018-05-11 (Fri, 11 May 2018) Changed paths: M modules/rtpproxy/rtpproxy.c Log Message: ----------- rtpproxy: allow more relaxed lookup **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Mon May 14 10:37:15 2018 From: razvan at opensips.org (Razvan Crainea) Date: Mon, 14 May 2018 07:37:15 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 890431: proto_hep: prevent memleak when using correlation Message-ID: <5af99f1bf0fc7_4a4a2b01b55edbfc103538@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 8904319909cd6618d4ce06148a25937738a90a37 https://github.com/OpenSIPS/opensips/commit/8904319909cd6618d4ce06148a25937738a90a37 Author: Razvan Crainea Date: 2018-05-14 (Mon, 14 May 2018) Changed paths: M modules/proto_hep/hep.c Log Message: ----------- proto_hep: prevent memleak when using correlation when not using homer5 and adding correlation to rest and xlog queries, the correlation string was never freed, generating a memory leak. also prevent opensips from crashing when running out of pkg memory. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Mon May 14 10:37:45 2018 From: razvan at opensips.org (Razvan Crainea) Date: Mon, 14 May 2018 07:37:45 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 467df1: proto_hep: prevent memleak when using correlation Message-ID: <5af99f399d9e9_b502ac7d88ffc08780d7@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 467df134fd3700ac794640244888757ecb27308d https://github.com/OpenSIPS/opensips/commit/467df134fd3700ac794640244888757ecb27308d Author: Razvan Crainea Date: 2018-05-14 (Mon, 14 May 2018) Changed paths: M modules/proto_hep/hep.c Log Message: ----------- proto_hep: prevent memleak when using correlation when not using homer5 and adding correlation to rest and xlog queries, the correlation string was never freed, generating a memory leak. also prevent opensips from crashing when running out of pkg memory. (cherry picked from commit 8904319909cd6618d4ce06148a25937738a90a37) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Mon May 14 10:38:12 2018 From: razvan at opensips.org (Razvan Crainea) Date: Mon, 14 May 2018 07:38:12 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a0bed9: proto_hep: prevent memleak when using correlation Message-ID: <5af99f54c75e0_77e2ab025b97c10419ac@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: a0bed9db6cf4d5d4a1577bdd84677d3b2971e5c5 https://github.com/OpenSIPS/opensips/commit/a0bed9db6cf4d5d4a1577bdd84677d3b2971e5c5 Author: Razvan Crainea Date: 2018-05-14 (Mon, 14 May 2018) Changed paths: M modules/proto_hep/hep.c Log Message: ----------- proto_hep: prevent memleak when using correlation when not using homer5 and adding correlation to rest and xlog queries, the correlation string was never freed, generating a memory leak. also prevent opensips from crashing when running out of pkg memory. (cherry picked from commit 8904319909cd6618d4ce06148a25937738a90a37) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Mon May 14 12:39:14 2018 From: liviu at opensips.org (Liviu Chircu) Date: Mon, 14 May 2018 09:39:14 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f757ce: acc: Eat leading whitespace in "extra_fields" Message-ID: <5af9bbb284676_79172b2a7fbb7c0c96474@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: f757ce4143cc7943adc872e6a7fc0bd3b3cc2a38 https://github.com/OpenSIPS/opensips/commit/f757ce4143cc7943adc872e6a7fc0bd3b3cc2a38 Author: Liviu Chircu Date: 2018-05-14 (Mon, 14 May 2018) Changed paths: M modules/acc/acc_extra.c Log Message: ----------- acc: Eat leading whitespace in "extra_fields" This allows readable formatting such as: modparam("acc", "extra_fields", " db: account_id; provider_id; account_card_id; ") **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 15 11:47:20 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 15 May 2018 08:47:20 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 94b024: Add a new pvar: $hdr_name that returns the name of... Message-ID: <5afb01083fca0_49fb2ac3983b3c0c4463@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 94b0244ab3d7701f7d061b96c2d7d549aa3fed9f https://github.com/OpenSIPS/opensips/commit/94b0244ab3d7701f7d061b96c2d7d549aa3fed9f Author: Vlad Patrascu Date: 2018-05-15 (Tue, 15 May 2018) Changed paths: M pvar.c M pvar.h Log Message: ----------- Add a new pvar: $hdr_name that returns the name of SIP header **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 16 09:51:47 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 16 May 2018 06:51:47 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 61dec8: transformations: Fix parsing of nested transformat... Message-ID: <5afc37731cfa1_7a122ad1c3479c0c4317c@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 61dec8937bd65f0848413e988b0f77cd924b362f https://github.com/OpenSIPS/opensips/commit/61dec8937bd65f0848413e988b0f77cd924b362f Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M transformations.c Log Message: ----------- transformations: Fix parsing of nested transformations We once again allow multiple levels of nested transformations, e.g.: $(var(tu){s.substr,$(var(tu){s.substr,$(var(idx){s.int}),1}{s.int}),0}) (example of three-level nesting of tranformations) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 16 09:52:13 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 16 May 2018 06:52:13 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c0bf5a: acc: Eat leading whitespace in "extra_fields" Message-ID: <5afc378df10de_7ef2acbf827bc14974f9@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: c0bf5a05923c65fa53f5d5cc1eb3fef24474980d https://github.com/OpenSIPS/opensips/commit/c0bf5a05923c65fa53f5d5cc1eb3fef24474980d Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M modules/acc/acc_extra.c Log Message: ----------- acc: Eat leading whitespace in "extra_fields" This allows readable formatting such as: modparam("acc", "extra_fields", " db: account_id; provider_id; account_card_id; ") (cherry picked from commit f757ce4143cc7943adc872e6a7fc0bd3b3cc2a38) Commit: a8ee28c466350fa79836f870361a7c8ee444babe https://github.com/OpenSIPS/opensips/commit/a8ee28c466350fa79836f870361a7c8ee444babe Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M transformations.c Log Message: ----------- transformations: Fix parsing of nested transformations We once again allow multiple levels of nested transformations, e.g.: $(var(tu){s.substr,$(var(tu){s.substr,$(var(idx){s.int}),1}{s.int}),0}) (example of three-level nesting of tranformations) (cherry picked from commit 61dec8937bd65f0848413e988b0f77cd924b362f) Compare: https://github.com/OpenSIPS/opensips/compare/467df134fd37...a8ee28c46635 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 16 10:52:44 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 16 May 2018 07:52:44 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1c07c9: siptrace: Fix broken trace tests during startup_ro... Message-ID: <5afc45bce1eb8_5d752b288aac1c0479363@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 1c07c9254d6840e4d8a10226bd196661b6a667b4 https://github.com/OpenSIPS/opensips/commit/1c07c9254d6840e4d8a10226bd196661b6a667b4 Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M modules/siptrace/siptrace.c Log Message: ----------- siptrace: Fix broken trace tests during startup_route Commit: 5f83153c6eac1042221e9b2bc48d11f8be148ea8 https://github.com/OpenSIPS/opensips/commit/5f83153c6eac1042221e9b2bc48d11f8be148ea8 Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M modules/rest_client/rest_methods.c Log Message: ----------- rest_client: Improve tracing robustness at startup Even if we're somehow called from startup route with a fake SIP message, deal with it and do not segfault. Compare: https://github.com/OpenSIPS/opensips/compare/61dec8937bd6...5f83153c6eac **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 16 11:39:05 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 16 May 2018 08:39:05 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 436c68: siptrace: Fix broken trace tests during startup_ro... Message-ID: <5afc50995271d_6e802aafc35fdc084616d@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 436c68957886512d1fcd21c8a76c1bf3af3c83cc https://github.com/OpenSIPS/opensips/commit/436c68957886512d1fcd21c8a76c1bf3af3c83cc Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M modules/siptrace/siptrace.c Log Message: ----------- siptrace: Fix broken trace tests during startup_route (cherry picked from commit 1c07c9254d6840e4d8a10226bd196661b6a667b4) Commit: e7c4de7096814dd4119229a4e5b62c7dd662db70 https://github.com/OpenSIPS/opensips/commit/e7c4de7096814dd4119229a4e5b62c7dd662db70 Author: Liviu Chircu Date: 2018-05-16 (Wed, 16 May 2018) Changed paths: M modules/rest_client/rest_methods.c Log Message: ----------- rest_client: Improve tracing robustness at startup Even if we're somehow called from startup route with a fake SIP message, deal with it and do not segfault. (cherry picked from commit 5f83153c6eac1042221e9b2bc48d11f8be148ea8) Compare: https://github.com/OpenSIPS/opensips/compare/a8ee28c46635...e7c4de709681 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 17 06:39:57 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 17 May 2018 13:39:57 +0300 Subject: [OpenSIPS-Devel] [RELEASE] OpenSIPS 2.2.7, 2.3.4 and 2.4.1 minor releases Message-ID: <0d13275a-96b2-e802-33e1-ce2ca72dfd67@opensips.org> Greetings! A new cycle is about to be complete: OpenSIPS is tortured all over the worlds; this produces feedback and reports; and this translates into more fix, in a better stability of the released OpenSIPS versions. Shortly, it's time for a new set of minor releases, to officially incorporate all the fixes in the last months/weeks: OpenSIPS 2.2.7, 2.3.4 and 2.4.1 The new releases are due next week, on Wednesday, May 24th 2018. If you have any pending GitHub issues/mailing list bug threads concerning the mentioned branches, this would be a good time to bump them! Thank you for your contributions to this project! Best regards, -- Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com OpenSIPS Summit 2018 http://www.opensips.org/events/Summit-2018Amsterdam From vladp at opensips.org Thu May 17 10:32:36 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Thu, 17 May 2018 07:32:36 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b10f0e: clusterer: allow spaces in the format of "current_... Message-ID: <5afd9284e09ce_39682ac982a0fc144399a@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: b10f0e3f96a2173a868b395b6267646ef7c3f13c https://github.com/OpenSIPS/opensips/commit/b10f0e3f96a2173a868b395b6267646ef7c3f13c Author: Vlad Patrascu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/clusterer/clusterer_mod.c Log Message: ----------- clusterer: allow spaces in the format of "current_info" and "neighbor_info" **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Thu May 17 10:33:22 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Thu, 17 May 2018 07:33:22 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] d2c626: clusterer: allow spaces in the format of "current_... Message-ID: <5afd92b257812_2e4d2aed0ec0fc08153a9@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: d2c626166d78bfbb2784a7687ef9b43bda79c015 https://github.com/OpenSIPS/opensips/commit/d2c626166d78bfbb2784a7687ef9b43bda79c015 Author: Vlad Patrascu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/clusterer/clusterer_mod.c Log Message: ----------- clusterer: allow spaces in the format of "current_info" and "neighbor_info" (cherry picked from commit b10f0e3f96a2173a868b395b6267646ef7c3f13c) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 17 11:29:16 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 17 May 2018 08:29:16 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e35595: dialog: reset locked process only if you locked it Message-ID: <5afd9fccd2cc6_1f972acb41239c0427020@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: e35595e8596e6dd0bedb0b96cadd226c52417243 https://github.com/OpenSIPS/opensips/commit/e35595e8596e6dd0bedb0b96cadd226c52417243 Author: Razvan Crainea Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/dialog/dlg_cb.c Log Message: ----------- dialog: reset locked process only if you locked it Make sure that when callbacks are run only the proces that has the callbacks locked resets the locked_by field - if someone else does it, it might run into a deadlock. Thanks go to 46Labs for reporting this! **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 17 11:29:43 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 17 May 2018 08:29:43 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c19f0f: dialog: reset locked process only if you locked it Message-ID: <5afd9fe7f288f_101c2b074a96fc1810956@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: c19f0f0c6144a65769c7693cf6d4791d8736f225 https://github.com/OpenSIPS/opensips/commit/c19f0f0c6144a65769c7693cf6d4791d8736f225 Author: Razvan Crainea Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/dialog/dlg_cb.c Log Message: ----------- dialog: reset locked process only if you locked it Make sure that when callbacks are run only the proces that has the callbacks locked resets the locked_by field - if someone else does it, it might run into a deadlock. Thanks go to 46Labs for reporting this! (cherry picked from commit e35595e8596e6dd0bedb0b96cadd226c52417243) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 17 11:30:07 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 17 May 2018 08:30:07 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7c7a4f: dialog: reset locked process only if you locked it Message-ID: <5afd9fffd5569_2d4e2acc753adc0440951@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 7c7a4fbf5d5510c783af2eb4dee70e38b61adb14 https://github.com/OpenSIPS/opensips/commit/7c7a4fbf5d5510c783af2eb4dee70e38b61adb14 Author: Razvan Crainea Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/dialog/dlg_cb.c Log Message: ----------- dialog: reset locked process only if you locked it Make sure that when callbacks are run only the proces that has the callbacks locked resets the locked_by field - if someone else does it, it might run into a deadlock. Thanks go to 46Labs for reporting this! (cherry picked from commit e35595e8596e6dd0bedb0b96cadd226c52417243) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 17 11:34:41 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 17 May 2018 08:34:41 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bd6044: dialog: do not force profiles and vars dump Message-ID: <5afda11162b1_140b2b152981dc1067795@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: bd60440422ac061c95f575b2262575793b617c4f https://github.com/OpenSIPS/opensips/commit/bd60440422ac061c95f575b2262575793b617c4f Author: Razvan Crainea Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/dialog/dlg_db_handler.c Log Message: ----------- dialog: do not force profiles and vars dump Now that we have a special flag to force pushing vars and profiles in the database (db_flush_vals_profiles), we don't need to force them every time we make a query. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 17 16:47:11 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 17 May 2018 13:47:11 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bcad20: Fixed wrong DB result free in case of error. Message-ID: <5afdea4f40f96_2f572b28506a3c10211f3@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: bcad20098f92587ef465e3c634bd362ae3908522 https://github.com/OpenSIPS/opensips/commit/bcad20098f92587ef465e3c634bd362ae3908522 Author: Bogdan-Andrei Iancu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/presence/presentity.c Log Message: ----------- Fixed wrong DB result free in case of error. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 17 16:47:46 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 17 May 2018 13:47:46 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8ab552: Fixed wrong DB result free in case of error. Message-ID: <5afdea726e6a0_33b52adb91685c083629@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 8ab55259f368bf5e815511269cbac019bf804f97 https://github.com/OpenSIPS/opensips/commit/8ab55259f368bf5e815511269cbac019bf804f97 Author: Bogdan-Andrei Iancu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/presence/presentity.c Log Message: ----------- Fixed wrong DB result free in case of error. (cherry picked from commit bcad20098f92587ef465e3c634bd362ae3908522) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 17 16:48:27 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 17 May 2018 13:48:27 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f2429a: Fix memory leak when ping-failed contacts unregist... Message-ID: <5afdea9bc4eb8_359b2b20f4addc0820563@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: f2429ac736d437b248eebcd85999e7217ea82b23 https://github.com/OpenSIPS/opensips/commit/f2429ac736d437b248eebcd85999e7217ea82b23 Author: Bogdan-Andrei Iancu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/nathelper/nathelper.c M modules/nathelper/nh_table.c M modules/nathelper/nh_table.h M modules/nathelper/sip_pinger.h Log Message: ----------- Fix memory leak when ping-failed contacts unregister. As for the contacts with failed ping we keep the ping_cell into hash (in order to count the failures), we need a second timer list to be sure that the ping_cellis actually removed from hash as some point. Without this second list, as the ping_cell exists only in hash, if the contact is unregistered, it will never be removed. (cherry picked from commit 8532f9ed50aef1dbbf06668dcd9cfed1702c5a7d) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 17 16:51:13 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 17 May 2018 13:51:13 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c49cb0: Fixed wrong DB result free in case of error. Message-ID: <5afdeb41bab4d_4ffb2aba9e227bfc750e4@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: c49cb09910ae70489b8f2f8d84a7fae8a59ea349 https://github.com/OpenSIPS/opensips/commit/c49cb09910ae70489b8f2f8d84a7fae8a59ea349 Author: Bogdan-Andrei Iancu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/presence/presentity.c Log Message: ----------- Fixed wrong DB result free in case of error. (cherry picked from commit bcad20098f92587ef465e3c634bd362ae3908522) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 17 16:52:10 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 17 May 2018 13:52:10 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] eabb4a: Fixed wrong DB result free in case of error. Message-ID: <5afdeb7a21497_1dd42ab493e55c141952a@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: eabb4a87252ea42f8a22c0f6a9ecad9224ef2b70 https://github.com/OpenSIPS/opensips/commit/eabb4a87252ea42f8a22c0f6a9ecad9224ef2b70 Author: Bogdan-Andrei Iancu Date: 2018-05-17 (Thu, 17 May 2018) Changed paths: M modules/presence/presentity.c Log Message: ----------- Fixed wrong DB result free in case of error. (cherry picked from commit bcad20098f92587ef465e3c634bd362ae3908522) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 17 19:47:44 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 17 May 2018 16:47:44 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5f4281: acc: Fix $acc_extra so it accepts integer constant... Message-ID: <5afe14a0539c7_5f272ac6b0639c0414943@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 5f42814228cf52414a65bf859dffe10fb45ff94f https://github.com/OpenSIPS/opensips/commit/5f42814228cf52414a65bf859dffe10fb45ff94f Author: Liviu Chircu Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M modules/acc/acc_vars.c Log Message: ----------- acc: Fix $acc_extra so it accepts integer constants **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 17 19:48:02 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 17 May 2018 16:48:02 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2020d6: acc: Fix $acc_extra so it accepts integer constant... Message-ID: <5afe14b273842_4b7e2b1cab069c10102550@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 2020d6078a1907244d18aca0a4c89a26ca4951e5 https://github.com/OpenSIPS/opensips/commit/2020d6078a1907244d18aca0a4c89a26ca4951e5 Author: Liviu Chircu Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M modules/acc/acc_vars.c Log Message: ----------- acc: Fix $acc_extra so it accepts integer constants (cherry picked from commit 5f42814228cf52414a65bf859dffe10fb45ff94f) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 17 19:49:09 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 17 May 2018 16:49:09 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0ee949: acc: Fix $acc_extra so it accepts integer constant... Message-ID: <5afe14f5657c5_62942ada3e509c0c837a5@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 0ee949ea6c41a070019b95bbf0f6419627a2fb45 https://github.com/OpenSIPS/opensips/commit/0ee949ea6c41a070019b95bbf0f6419627a2fb45 Author: Liviu Chircu Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M modules/acc/acc_vars.c Log Message: ----------- acc: Fix $acc_extra so it accepts integer constants (cherry picked from commit 5f42814228cf52414a65bf859dffe10fb45ff94f) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Fri May 18 09:57:17 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Fri, 18 May 2018 06:57:17 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 8073d4: Avoid signal "leaking" and use KILL instead of TER... Message-ID: <5afedbbdb8dd4_53782aee8085dc0442533@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 8073d4de8edfab88a60c869b24df0cd3e74342d6 https://github.com/OpenSIPS/opensips/commit/8073d4de8edfab88a60c869b24df0cd3e74342d6 Author: Bogdan-Andrei Iancu Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M main.c Log Message: ----------- Avoid signal "leaking" and use KILL instead of TERM. When we want to force the termination of the unresponsive processes, better use Kill than TERM - TERM, if previosly delivered may be queued and lost. Commit: f39174c6bed6f636e658dc254d7457062ddff291 https://github.com/OpenSIPS/opensips/commit/f39174c6bed6f636e658dc254d7457062ddff291 Author: Bogdan-Andrei Iancu Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M main.c Log Message: ----------- Downgrade log from INFO to DBG Commit: 41f3fd580b86dea700185b76f7c60ad4590e1e02 https://github.com/OpenSIPS/opensips/commit/41f3fd580b86dea700185b76f7c60ad4590e1e02 Author: Bogdan-Andrei Iancu Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M main.c Log Message: ----------- A worker process wil ignore any SIGTERM if not in shutdwon sequance. Compare: https://github.com/OpenSIPS/opensips/compare/5f42814228cf...41f3fd580b86 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvancrainea at users.noreply.github.com Mon May 21 02:58:42 2018 From: razvancrainea at users.noreply.github.com (=?UTF-8?B?UsSDenZhbg==?= Crainea) Date: Sun, 20 May 2018 23:58:42 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] fd1124: added rtcp-mux-require maybe Message-ID: <5b026e229fea5_5ad72aec714b3c04280f2@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: fd1124a2cca4d61c1b6493a13b5911e8441c835f https://github.com/OpenSIPS/opensips/commit/fd1124a2cca4d61c1b6493a13b5911e8441c835f Author: ryan-esty Date: 2018-05-18 (Fri, 18 May 2018) Changed paths: M modules/rtpengine/README M modules/rtpengine/doc/rtpengine_admin.xml M modules/rtpengine/rtpengine.c Log Message: ----------- added rtcp-mux-require maybe Commit: c9a7552ce3c9f0dfd9b80c242a03ce27a744cfe5 https://github.com/OpenSIPS/opensips/commit/c9a7552ce3c9f0dfd9b80c242a03ce27a744cfe5 Author: Răzvan Crainea Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/rtpengine/README M modules/rtpengine/doc/rtpengine_admin.xml M modules/rtpengine/rtpengine.c Log Message: ----------- Merge pull request #1366 from ryan-esty/2.3 added rtcp-mux-require Close #1364 Compare: https://github.com/OpenSIPS/opensips/compare/0ee949ea6c41...c9a7552ce3c9 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvancrainea at users.noreply.github.com Mon May 21 03:00:43 2018 From: razvancrainea at users.noreply.github.com (=?UTF-8?B?UsSDenZhbg==?= Crainea) Date: Mon, 21 May 2018 00:00:43 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 13489b: Merge pull request #1366 from ryan-esty/2.3 Message-ID: <5b026e9bd38b3_14f92ad00775dc10723f@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 13489b996c8025a982d0ca42fdf68ebc4d169f57 https://github.com/OpenSIPS/opensips/commit/13489b996c8025a982d0ca42fdf68ebc4d169f57 Author: Răzvan Crainea Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/rtpengine/README M modules/rtpengine/doc/rtpengine_admin.xml M modules/rtpengine/rtpengine.c Log Message: ----------- Merge pull request #1366 from ryan-esty/2.3 added rtcp-mux-require Close #1364 (cherry picked from commit c9a7552ce3c9f0dfd9b80c242a03ce27a744cfe5) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvancrainea at users.noreply.github.com Mon May 21 03:00:57 2018 From: razvancrainea at users.noreply.github.com (=?UTF-8?B?UsSDenZhbg==?= Crainea) Date: Mon, 21 May 2018 00:00:57 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 804218: Merge pull request #1366 from ryan-esty/2.3 Message-ID: <5b026ea9e5677_1a232aaeb6a53c0c94051@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 804218d16eb7dc6caff5dce553f4e97e31f74632 https://github.com/OpenSIPS/opensips/commit/804218d16eb7dc6caff5dce553f4e97e31f74632 Author: Răzvan Crainea Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/rtpengine/README M modules/rtpengine/doc/rtpengine_admin.xml M modules/rtpengine/rtpengine.c Log Message: ----------- Merge pull request #1366 from ryan-esty/2.3 added rtcp-mux-require Close #1364 (cherry picked from commit c9a7552ce3c9f0dfd9b80c242a03ce27a744cfe5) (cherry picked from commit 13489b996c8025a982d0ca42fdf68ebc4d169f57) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvancrainea at users.noreply.github.com Mon May 21 03:02:18 2018 From: razvancrainea at users.noreply.github.com (=?UTF-8?B?UsSDenZhbg==?= Crainea) Date: Mon, 21 May 2018 00:02:18 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c26cab: Merge pull request #1366 from ryan-esty/2.3 Message-ID: <5b026efa8c4fa_3d952b0fe8cb1c04711c8@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: c26cab4c6c9b4491ab7047c7bc66d64ee38c69b0 https://github.com/OpenSIPS/opensips/commit/c26cab4c6c9b4491ab7047c7bc66d64ee38c69b0 Author: Răzvan Crainea Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/rtpengine/README M modules/rtpengine/doc/rtpengine_admin.xml M modules/rtpengine/rtpengine.c Log Message: ----------- Merge pull request #1366 from ryan-esty/2.3 added rtcp-mux-require Close #1364 (cherry picked from commit c9a7552ce3c9f0dfd9b80c242a03ce27a744cfe5) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Mon May 21 11:17:45 2018 From: razvan at opensips.org (Razvan Crainea) Date: Mon, 21 May 2018 08:17:45 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b44cdb: refactor get_callid in a single place Message-ID: <5b02e3197a369_7db52b26ddf47c0034085@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: b44cdb51190ce8aab2047e318ead0bc4c37c1cc1 https://github.com/OpenSIPS/opensips/commit/b44cdb51190ce8aab2047e318ead0bc4c37c1cc1 Author: Razvan Crainea Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/mediaproxy/mediaproxy.c M modules/rtpengine/rtpengine_funcs.c M modules/rtpengine/rtpengine_funcs.h M modules/rtpproxy/nhelpr_funcs.c M modules/rtpproxy/nhelpr_funcs.h M parser/msg_parser.h Log Message: ----------- refactor get_callid in a single place **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Mon May 21 11:24:16 2018 From: razvan at opensips.org (Razvan Crainea) Date: Mon, 21 May 2018 08:24:16 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7bcbcd: tm: use global common get_callid() Message-ID: <5b02e4a09eddf_68902aeb77601c0029174@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 7bcbcdc4981c52b29a5f841b62c55f8c94c10b50 https://github.com/OpenSIPS/opensips/commit/7bcbcdc4981c52b29a5f841b62c55f8c94c10b50 Author: Razvan Crainea Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/tm/dlg.c Log Message: ----------- tm: use global common get_callid() **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 21 12:06:52 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 21 May 2018 09:06:52 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] dab6f7: mi_xmlrpc_ng: fix system memory leaks when parsing... Message-ID: <5b02ee9ca9629_2b002b073951dc0c29761@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: dab6f7a2f59e3bf5df5d59d6fcc3f85dce4d2357 https://github.com/OpenSIPS/opensips/commit/dab6f7a2f59e3bf5df5d59d6fcc3f85dce4d2357 Author: Vlad Patrascu Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/mi_xmlrpc_ng/http_fnc.c Log Message: ----------- mi_xmlrpc_ng: fix system memory leaks when parsing xml Closes #1359 (cherry picked from commit 06a1b186c9d8eba35e3f7bbff83f41325c60ac24) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 21 12:07:32 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 21 May 2018 09:07:32 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0d1580: mi_xmlrpc_ng: fix system memory leaks when parsing... Message-ID: <5b02eec4277d5_39fb2ac096b6dc0489676@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 0d158070215fad2c23545973fb754e28e5f5b32e https://github.com/OpenSIPS/opensips/commit/0d158070215fad2c23545973fb754e28e5f5b32e Author: Vlad Patrascu Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/mi_xmlrpc_ng/http_fnc.c Log Message: ----------- mi_xmlrpc_ng: fix system memory leaks when parsing xml Closes #1359 (cherry picked from commit 06a1b186c9d8eba35e3f7bbff83f41325c60ac24) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 21 12:07:56 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 21 May 2018 09:07:56 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 06a1b1: mi_xmlrpc_ng: fix system memory leaks when parsing... Message-ID: <5b02eedc903db_7e092ab98ed6fc00248da@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 06a1b186c9d8eba35e3f7bbff83f41325c60ac24 https://github.com/OpenSIPS/opensips/commit/06a1b186c9d8eba35e3f7bbff83f41325c60ac24 Author: Vlad Patrascu Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/mi_xmlrpc_ng/http_fnc.c Log Message: ----------- mi_xmlrpc_ng: fix system memory leaks when parsing xml Closes #1359 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Mon May 21 12:08:25 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Mon, 21 May 2018 09:08:25 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ef6da2: mi_xmlrpc_ng: fix system memory leaks when parsing... Message-ID: <5b02eef992299_6bd42af8de4d7c0c679f9@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: ef6da267a0bbfaebb0cc18d7d6a1a581660074ca https://github.com/OpenSIPS/opensips/commit/ef6da267a0bbfaebb0cc18d7d6a1a581660074ca Author: Vlad Patrascu Date: 2018-05-21 (Mon, 21 May 2018) Changed paths: M modules/mi_xmlrpc_ng/http_fnc.c Log Message: ----------- mi_xmlrpc_ng: fix system memory leaks when parsing xml Closes #1359 (cherry picked from commit 06a1b186c9d8eba35e3f7bbff83f41325c60ac24) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 04:49:13 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 01:49:13 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 4e4f5b: Use MI cmds (versus signals) to trgger mem dumps. Message-ID: <5b03d989852eb_63512b0e950a9c084775e@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 4e4f5ba07dd08d1e150c7e3d6789c7e304062e40 https://github.com/OpenSIPS/opensips/commit/4e4f5ba07dd08d1e150c7e3d6789c7e304062e40 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M main.c M mi/mi_core.c Log Message: ----------- Use MI cmds (versus signals) to trgger mem dumps. The olg approach of triggering memory dumps by sending signals to the processes is replaced with MI commands triggering combinated with RPC/IPC. New MI commands exposed: * mem_pkg_dump pid [log_level] * mem_shm_dump [log_level] **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 04:52:13 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 01:52:13 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ad825e: Replaced signal based inter proc communication for... Message-ID: <5b03da3db8b6e_759c2ace691d1c14101258@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: ad825e4ee93ab9bcc003f92ada7d8aed613df944 https://github.com/OpenSIPS/opensips/commit/ad825e4ee93ab9bcc003f92ada7d8aed613df944 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M core_stats.c M core_stats.h Log Message: ----------- Replaced signal based inter proc communication for PKG stats with RPC/IPC The old signal (SIGUSR2) based inter process triggering of the PKG memory statistics is replaced with RPC/IPC triggering. Note: processes without a reactor (and no RPC/IPC) will not be able to provide pkg statistics. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 05:48:31 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 02:48:31 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 602089: Avoid signal "leaking" and use KILL instead of TER... Message-ID: <5b03e76fb0f0d_5e9c2b06d2a27c1455167@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 602089bbc6423055f04beb4e0cff2d36aa90dbdc https://github.com/OpenSIPS/opensips/commit/602089bbc6423055f04beb4e0cff2d36aa90dbdc Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M main.c Log Message: ----------- Avoid signal "leaking" and use KILL instead of TERM. When we want to force the termination of the unresponsive processes, better use Kill than TERM - TERM, if previosly delivered may be queued and lost. (cherry picked from commit 8073d4de8edfab88a60c869b24df0cd3e74342d6) Commit: c00e9282f5df90abee8e34538e056817b21075bf https://github.com/OpenSIPS/opensips/commit/c00e9282f5df90abee8e34538e056817b21075bf Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M main.c Log Message: ----------- Downgrade log from INFO to DBG (cherry picked from commit f39174c6bed6f636e658dc254d7457062ddff291) Commit: 4ee26e32554b9ebc149b432efbf3c6d7818840b5 https://github.com/OpenSIPS/opensips/commit/4ee26e32554b9ebc149b432efbf3c6d7818840b5 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M main.c Log Message: ----------- A worker process wil ignore any SIGTERM if not in shutdwon sequance. (cherry picked from commit 41f3fd580b86dea700185b76f7c60ad4590e1e02) Compare: https://github.com/OpenSIPS/opensips/compare/0d158070215f...4ee26e32554b **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Tue May 22 08:30:46 2018 From: liviu at opensips.org (Liviu Chircu) Date: Tue, 22 May 2018 05:30:46 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] fa4bf3: usrloc: Make the timer cleanup routine cluster-awa... Message-ID: <5b040d761adff_10782b0ebab43c0c5075e@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: fa4bf3c67fe7d8f3fcf88bcca12fa5fa09a4ebe0 https://github.com/OpenSIPS/opensips/commit/fa4bf3c67fe7d8f3fcf88bcca12fa5fa09a4ebe0 Author: Liviu Chircu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M modules/usrloc/udomain.c Log Message: ----------- usrloc: Make the timer cleanup routine cluster-aware Reported by Xiao Huang Fixes #1367 Commit: 45ea9087d74cd8db5f8d27829296ede1d8b74e09 https://github.com/OpenSIPS/opensips/commit/45ea9087d74cd8db5f8d27829296ede1d8b74e09 Author: Liviu Chircu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M modules/nathelper/nathelper.c M modules/usrloc/dlist.c M modules/usrloc/udomain.c M modules/usrloc/ul_mod.c Log Message: ----------- usrloc/nathelper: Improve function naming/docs Compare: https://github.com/OpenSIPS/opensips/compare/ad825e4ee93a...45ea9087d74c **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Tue May 22 08:31:06 2018 From: liviu at opensips.org (Liviu Chircu) Date: Tue, 22 May 2018 05:31:06 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 213019: usrloc: Make the timer cleanup routine cluster-awa... Message-ID: <5b040d8acd768_19082b19b0e79c1877866@hookshot-fe-6e9b612.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 21301982e573b8eb11dcd1b4d531b563227aa0e7 https://github.com/OpenSIPS/opensips/commit/21301982e573b8eb11dcd1b4d531b563227aa0e7 Author: Liviu Chircu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M modules/usrloc/udomain.c Log Message: ----------- usrloc: Make the timer cleanup routine cluster-aware Reported by Xiao Huang Fixes #1367 (cherry picked from commit fa4bf3c67fe7d8f3fcf88bcca12fa5fa09a4ebe0) Commit: 15fb59f8a2aa979f6a7c2a415c03ff5f2fc50063 https://github.com/OpenSIPS/opensips/commit/15fb59f8a2aa979f6a7c2a415c03ff5f2fc50063 Author: Liviu Chircu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M modules/nathelper/nathelper.c M modules/usrloc/dlist.c M modules/usrloc/udomain.c M modules/usrloc/ul_mod.c Log Message: ----------- usrloc/nathelper: Improve function naming/docs (cherry picked from commit 45ea9087d74cd8db5f8d27829296ede1d8b74e09) Compare: https://github.com/OpenSIPS/opensips/compare/4ee26e32554b...15fb59f8a2aa **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 13:07:40 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 10:07:40 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] a69c85: Fixed URI comparing when usernames are empty Message-ID: <5b044e5c9a84b_5ab72ad86f8c7c0c261c3@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: a69c8541b08eb171f24eca55444e777a3b527509 https://github.com/OpenSIPS/opensips/commit/a69c8541b08eb171f24eca55444e777a3b527509 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M strcommon.c Log Message: ----------- Fixed URI comparing when usernames are empty **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 13:08:03 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 10:08:03 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] cd3134: Fixed URI comparing when usernames are empty Message-ID: <5b044e737def_7a682ac6a149dc10101645@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: cd313418753ea8f23a1033f446db0ac1c02f73e0 https://github.com/OpenSIPS/opensips/commit/cd313418753ea8f23a1033f446db0ac1c02f73e0 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M strcommon.c Log Message: ----------- Fixed URI comparing when usernames are empty (cherry picked from commit a69c8541b08eb171f24eca55444e777a3b527509) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 13:08:41 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 10:08:41 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 4c2d9a: Fixed URI comparing when usernames are empty Message-ID: <5b044e99a4950_255a2ad1566f5c141087f@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 4c2d9ad3c3c128270d90a028dcb0a14a212656e2 https://github.com/OpenSIPS/opensips/commit/4c2d9ad3c3c128270d90a028dcb0a14a212656e2 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M strcommon.c Log Message: ----------- Fixed URI comparing when usernames are empty (cherry picked from commit a69c8541b08eb171f24eca55444e777a3b527509) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Tue May 22 13:10:25 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Tue, 22 May 2018 10:10:25 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e125b4: Fixed URI comparing when usernames are empty Message-ID: <5b044f01453e6_c8e2abe915dbc0c1080c8@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: e125b4080966a019486a183fb184641ae1158828 https://github.com/OpenSIPS/opensips/commit/e125b4080966a019486a183fb184641ae1158828 Author: Bogdan-Andrei Iancu Date: 2018-05-22 (Tue, 22 May 2018) Changed paths: M strcommon.c Log Message: ----------- Fixed URI comparing when usernames are empty (cherry picked from commit a69c8541b08eb171f24eca55444e777a3b527509) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Wed May 23 05:44:10 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Wed, 23 May 2018 02:44:10 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 2b28b2: Fix delete query in watchers table. Message-ID: <5b0537ea5b5ac_1d232ac9d173bc147432c@hookshot-fe-32b5f5b.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 2b28b213167dcfa132d1a3045a3a1b532874e4d9 https://github.com/OpenSIPS/opensips/commit/2b28b213167dcfa132d1a3045a3a1b532874e4d9 Author: Bogdan-Andrei Iancu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/presence/subscribe.c Log Message: ----------- Fix delete query in watchers table. The watcher's table has no sharing tags. Reported by Ognjen Seslija (sekil on IRC) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Wed May 23 05:44:38 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Wed, 23 May 2018 02:44:38 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] e5f3b7: Fix delete query in watchers table. Message-ID: <5b053806538c0_14632b26fbd61c1091373@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: e5f3b79cda8c5a346bed193f4758339626513c33 https://github.com/OpenSIPS/opensips/commit/e5f3b79cda8c5a346bed193f4758339626513c33 Author: Bogdan-Andrei Iancu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/presence/subscribe.c Log Message: ----------- Fix delete query in watchers table. The watcher's table has no sharing tags. Reported by Ognjen Seslija (sekil on IRC) (cherry picked from commit 2b28b213167dcfa132d1a3045a3a1b532874e4d9) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 23 05:52:08 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 23 May 2018 02:52:08 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] c7cae9: clusterer: Do not log errors when broadcasting to ... Message-ID: <5b0539c8fd1e_72002af95817fc10294df@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: c7cae9be6ad812f1a686e7529275f92194515ab1 https://github.com/OpenSIPS/opensips/commit/c7cae9be6ad812f1a686e7529275f92194515ab1 Author: Liviu Chircu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/clusterer/clusterer.c Log Message: ----------- clusterer: Do not log errors when broadcasting to 0 nodes Reported by Xiao Huang Fixes #1369 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 23 05:52:23 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 23 May 2018 02:52:23 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 98de68: clusterer: Do not log errors when broadcasting to ... Message-ID: <5b0539d76a66c_5d592aae6fb01c18154fe@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 98de68dac60602d2465e685b3d355603dd504317 https://github.com/OpenSIPS/opensips/commit/98de68dac60602d2465e685b3d355603dd504317 Author: Liviu Chircu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/clusterer/clusterer.c Log Message: ----------- clusterer: Do not log errors when broadcasting to 0 nodes Reported by Xiao Huang Fixes #1369 (cherry picked from commit c7cae9be6ad812f1a686e7529275f92194515ab1) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 23 06:11:42 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 23 May 2018 03:11:42 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f8f46f: clusterer: Do not log errors when broadcasting to ... Message-ID: <5b053e5ee7ed0_70bd2ac4aad23c0c925bc@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: f8f46f17e538c5f30356f869774637c77787c755 https://github.com/OpenSIPS/opensips/commit/f8f46f17e538c5f30356f869774637c77787c755 Author: Liviu Chircu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/clusterer/clusterer.c Log Message: ----------- clusterer: Do not log errors when broadcasting to 0 nodes Reported by Xiao Huang Fixes #1369 (cherry picked from commit c7cae9be6ad812f1a686e7529275f92194515ab1) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 23 11:58:01 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 23 May 2018 08:58:01 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 62bf36: registrar: Fix pkg leak / broken logic in remove() Message-ID: <5b058f89b252c_f992b1f6e31fc14934c@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 62bf36dac2f0f90ad58b60f6fc1036934276fc9c https://github.com/OpenSIPS/opensips/commit/62bf36dac2f0f90ad58b60f6fc1036934276fc9c Author: Liviu Chircu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/registrar/README M modules/registrar/doc/registrar_admin.xml M modules/registrar/reg_mod.c M modules/registrar/save.c M modules/registrar/save.h Log Message: ----------- registrar: Fix pkg leak / broken logic in remove() Also enhance its documentation **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Wed May 23 12:04:51 2018 From: liviu at opensips.org (Liviu Chircu) Date: Wed, 23 May 2018 09:04:51 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 65647b: registrar: Add "+sip_instance" filtering for remov... Message-ID: <5b059123cb1e3_be22b06721adc108642f@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 65647b547688b5eb889072b2ec9184e623ecfd7b https://github.com/OpenSIPS/opensips/commit/65647b547688b5eb889072b2ec9184e623ecfd7b Author: Liviu Chircu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/registrar/README M modules/registrar/doc/registrar_admin.xml M modules/registrar/reg_mod.c M modules/registrar/save.c M modules/registrar/save.h Log Message: ----------- registrar: Add "+sip_instance" filtering for remove() **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Wed May 23 16:57:36 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Wed, 23 May 2018 13:57:36 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 19305d: Fix memory leak in using extra accounting. Message-ID: <5b05d5c02f5e0_54672b0696ab5c08257f5@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 19305deaa6f89d3c3030f67e68f79c69116501f2 https://github.com/OpenSIPS/opensips/commit/19305deaa6f89d3c3030f67e68f79c69116501f2 Author: Bogdan-Andrei Iancu Date: 2018-05-23 (Wed, 23 May 2018) Changed paths: M modules/acc/acc_logic.c Log Message: ----------- Fix memory leak in using extra accounting. If setting $acc_extra() for a sequential request, before being matched against the dialog, the values will result in a leak. Ideally, the acc_extra set in the processing context should be merged with the acc_extra fetched after dialog matching. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 24 04:26:50 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 24 May 2018 01:26:50 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6c5b6e: registrar: Fix pkg leak / broken logic in remove() Message-ID: <5b06774a8c7_30082ab6dda8fc14345ab@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 6c5b6e44d2edfc5dbc7a7e9792cea5f58819f6a4 https://github.com/OpenSIPS/opensips/commit/6c5b6e44d2edfc5dbc7a7e9792cea5f58819f6a4 Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/registrar/README M modules/registrar/doc/registrar_admin.xml M modules/registrar/reg_mod.c M modules/registrar/save.c M modules/registrar/save.h Log Message: ----------- registrar: Fix pkg leak / broken logic in remove() Also enhance its documentation (cherry picked from commit 62bf36dac2f0f90ad58b60f6fc1036934276fc9c) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Thu May 24 07:45:38 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Thu, 24 May 2018 04:45:38 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 72289e: clusterer: several doc fixes and improvements Message-ID: <5b06a5e21b870_fcb2ac93c7e5c04494ea@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 72289e2cbce596e205b61a6fbaceb140a61c9777 https://github.com/OpenSIPS/opensips/commit/72289e2cbce596e205b61a6fbaceb140a61c9777 Author: Vlad Patrascu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/clusterer/README M modules/clusterer/doc/clusterer_admin.xml Log Message: ----------- clusterer: several doc fixes and improvements **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Thu May 24 07:45:48 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Thu, 24 May 2018 04:45:48 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 40222f: clusterer: several doc fixes and improvements Message-ID: <5b06a5eca4a06_6592b1cb4599c047526f@hookshot-fe-d2afb11.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 40222f493d82959f284c74ec308cb97ea31987c4 https://github.com/OpenSIPS/opensips/commit/40222f493d82959f284c74ec308cb97ea31987c4 Author: Vlad Patrascu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/clusterer/README M modules/clusterer/doc/clusterer_admin.xml Log Message: ----------- clusterer: several doc fixes and improvements **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 24 10:21:58 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 24 May 2018 07:21:58 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 60b1e7: Fix consistency of extra/leg values in acc module. Message-ID: <5b06ca8625d60_75a12ac60e2c1c04460e7@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 60b1e7005b22eedd1ed604ffc21054e91b7f404b https://github.com/OpenSIPS/opensips/commit/60b1e7005b22eedd1ed604ffc21054e91b7f404b Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/acc/acc_logic.c M modules/acc/acc_vars.c M modules/acc/acc_vars.h Log Message: ----------- Fix consistency of extra/leg values in acc module. If values are set before the dialog is matched, rather than simply discarding the setings done on the extra/leg values, better migrate the changes over the acc set stored in dialog. **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 24 10:26:45 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 24 May 2018 07:26:45 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] bdac5e: Fix memory leak in using extra accounting. Message-ID: <5b06cba589159_761a2aace2eb1c0c354ec@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: bdac5e61a2829bd6867ce2ffb90a7beb3b2d73b2 https://github.com/OpenSIPS/opensips/commit/bdac5e61a2829bd6867ce2ffb90a7beb3b2d73b2 Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/acc/acc_logic.c Log Message: ----------- Fix memory leak in using extra accounting. If setting $acc_extra() for a sequential request, before being matched against the dialog, the values will result in a leak. Ideally, the acc_extra set in the processing context should be merged with the acc_extra fetched after dialog matching. (cherry picked from commit 19305deaa6f89d3c3030f67e68f79c69116501f2) Commit: 93c2cea6c3b3f3d1c0dc9530f36ccb074a337469 https://github.com/OpenSIPS/opensips/commit/93c2cea6c3b3f3d1c0dc9530f36ccb074a337469 Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/acc/acc_logic.c M modules/acc/acc_vars.c M modules/acc/acc_vars.h Log Message: ----------- Fix consistency of extra/leg values in acc module. If values are set before the dialog is matched, rather than simply discarding the setings done on the extra/leg values, better migrate the changes over the acc set stored in dialog. (cherry picked from commit 60b1e7005b22eedd1ed604ffc21054e91b7f404b) Compare: https://github.com/OpenSIPS/opensips/compare/40222f493d82...93c2cea6c3b3 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 24 10:31:30 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 24 May 2018 07:31:30 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 789b0e: Fix memory leak in using extra accounting. Message-ID: <5b06ccc2b1529_5f7a2abbed50bc10734cf@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 789b0e6fec218126bc7547c2a40805ceb0d0ba15 https://github.com/OpenSIPS/opensips/commit/789b0e6fec218126bc7547c2a40805ceb0d0ba15 Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/acc/acc_logic.c Log Message: ----------- Fix memory leak in using extra accounting. If setting $acc_extra() for a sequential request, before being matched against the dialog, the values will result in a leak. Ideally, the acc_extra set in the processing context should be merged with the acc_extra fetched after dialog matching. (cherry picked from commit 19305deaa6f89d3c3030f67e68f79c69116501f2) Commit: 29f3059307240bc5a17f985979a202fbfebb32df https://github.com/OpenSIPS/opensips/commit/29f3059307240bc5a17f985979a202fbfebb32df Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/acc/acc_logic.c M modules/acc/acc_vars.c M modules/acc/acc_vars.h Log Message: ----------- Fix consistency of extra/leg values in acc module. If values are set before the dialog is matched, rather than simply discarding the setings done on the extra/leg values, better migrate the changes over the acc set stored in dialog. (cherry picked from commit 60b1e7005b22eedd1ed604ffc21054e91b7f404b) Compare: https://github.com/OpenSIPS/opensips/compare/f8f46f17e538...29f305930724 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 24 11:58:50 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 24 May 2018 08:58:50 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b3bf15: path: Add escaping logic for add_path_received() Message-ID: <5b06e13add158_2fc42b1fecbcdc0c877f6@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: b3bf15646affe981d4b266381d59f210e6e882fd https://github.com/OpenSIPS/opensips/commit/b3bf15646affe981d4b266381d59f210e6e882fd Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M lib/path.c M lib/path.h M lib/reg/path.c M modules/path/path.c Log Message: ----------- path: Add escaping logic for add_path_received() Simply dumping a SIP URI as a ";received=" Path header field parameter value is problematic and leads to two kinds of issues: a. invalid SIP URIs, where the ";transport=" is specified twice: Path: b. in double Path scenarios (e.g. when switching protocols from, say, TCP -> UDP), since the ";received=" is inserted as the inbound Path header field value, this can lead to a strange "protocol conversion" effect: Path: Path: ^ notice how the inbound Path intended to advertise an UDP URI, but the add_path_received() managed to "convert" it into a TCP URI because of its inability to escape its token. nathelper is an easy first victim of this conversion, as it will attempt to send pings using the incorrect transport after reading the topmost Path (Route) header. This patch adds escaping/unescaping logic for the ";received=" feature of add_path_received() along with any code that makes use of this feature. Example resulting URI for the above example: Path: Commit: 71c7d75f66c8f0dc4ce411fd97d2dc867b39ce8d https://github.com/OpenSIPS/opensips/commit/71c7d75f66c8f0dc4ce411fd97d2dc867b39ce8d Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M lib/path.c M lib/reg/path.c Log Message: ----------- path: Fix "use_path_received" in double-Path scenarios Due to the fact that run_rr_callbacks() returns the 2nd Route (Path) header field value when previously having done protocol switching (thus having inserted two Path headers), the "use_path_received" feature of the path module would not work -- it wouldn't set the $du at all. The reason for this is that add_path_received() appends its ";received=" to inside Path #1 (the outbound path of the registration / the inbound path of future requests) when doing double-Path recording. This patch simply moves the ";received=" append operation performed by add_path_received() into Path #2 (inbound path of registration / outbound path of future requests), and adapts other code that needs it (e.g. save("location", "p1v")) to properly be able to fetch it. Reported by @futsystems Fixes #1358 Compare: https://github.com/OpenSIPS/opensips/compare/60b1e7005b22...71c7d75f66c8 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 24 12:01:42 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 24 May 2018 09:01:42 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 7911d6: path: Fix leak-on-error Message-ID: <5b06e1e62e59a_5b2d2ab113669c048784c@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 7911d636171f251b18a7d735d8baa9e15474b696 https://github.com/OpenSIPS/opensips/commit/7911d636171f251b18a7d735d8baa9e15474b696 Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M lib/reg/path.c Log Message: ----------- path: Fix leak-on-error **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 24 12:03:10 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 24 May 2018 09:03:10 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 905932: Fixed replication of sharing TAGS. Message-ID: <5b06e23e7a400_720d2ab7eb791c1023244@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 9059325241658c56cb759f17160c869b4e9def2b https://github.com/OpenSIPS/opensips/commit/9059325241658c56cb759f17160c869b4e9def2b Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/presence/clustering.c M modules/presence/sharing_tags.c M modules/presence/sharing_tags.h Log Message: ----------- Fixed replication of sharing TAGS. Reported by Ognjen Seslija (sekil on IRC) Thanks to Vlad Patrascu in troubleshooting **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 24 12:03:59 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 24 May 2018 09:03:59 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9a4643: Fixed replication of sharing TAGS. Message-ID: <5b06e26f9fc84_59562b271275fc101010b4@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 9a46432a05e3b7178bd1a7d9c31139dd5e295d2b https://github.com/OpenSIPS/opensips/commit/9a46432a05e3b7178bd1a7d9c31139dd5e295d2b Author: Bogdan-Andrei Iancu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/presence/clustering.c M modules/presence/sharing_tags.c M modules/presence/sharing_tags.h Log Message: ----------- Fixed replication of sharing TAGS. Reported by Ognjen Seslija (sekil on IRC) Thanks to Vlad Patrascu in troubleshooting (cherry picked from commit 9059325241658c56cb759f17160c869b4e9def2b) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Thu May 24 12:05:23 2018 From: liviu at opensips.org (Liviu Chircu) Date: Thu, 24 May 2018 09:05:23 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0e6044: path: Add escaping logic for add_path_received() Message-ID: <5b06e2c350a30_bc452acf275a9c104238@hookshot-fe-dfcc362.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 0e60448cb59b1bb4b6365da11fd187ad729bf52d https://github.com/OpenSIPS/opensips/commit/0e60448cb59b1bb4b6365da11fd187ad729bf52d Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M lib/path.c M lib/path.h M lib/reg/path.c M modules/path/path.c Log Message: ----------- path: Add escaping logic for add_path_received() Simply dumping a SIP URI as a ";received=" Path header field parameter value is problematic and leads to two kinds of issues: a. invalid SIP URIs, where the ";transport=" is specified twice: Path: b. in double Path scenarios (e.g. when switching protocols from, say, TCP -> UDP), since the ";received=" is inserted as the inbound Path header field value, this can lead to a strange "protocol conversion" effect: Path: Path: ^ notice how the inbound Path intended to advertise an UDP URI, but the add_path_received() managed to "convert" it into a TCP URI because of its inability to escape its token. nathelper is an easy first victim of this conversion, as it will attempt to send pings using the incorrect transport after reading the topmost Path (Route) header. This patch adds escaping/unescaping logic for the ";received=" feature of add_path_received() along with any code that makes use of this feature. Example resulting URI for the above example: Path: (cherry picked from commit b3bf15646affe981d4b266381d59f210e6e882fd) Commit: 045eea09bfb294f5a615d508bd3fc70317389563 https://github.com/OpenSIPS/opensips/commit/045eea09bfb294f5a615d508bd3fc70317389563 Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M lib/path.c M lib/reg/path.c Log Message: ----------- path: Fix "use_path_received" in double-Path scenarios Due to the fact that run_rr_callbacks() returns the 2nd Route (Path) header field value when previously having done protocol switching (thus having inserted two Path headers), the "use_path_received" feature of the path module would not work -- it wouldn't set the $du at all. The reason for this is that add_path_received() appends its ";received=" to inside Path #1 (the outbound path of the registration / the inbound path of future requests) when doing double-Path recording. This patch simply moves the ";received=" append operation performed by add_path_received() into Path #2 (inbound path of registration / outbound path of future requests), and adapts other code that needs it (e.g. save("location", "p1v")) to properly be able to fetch it. Reported by @futsystems Fixes #1358 (cherry picked from commit 71c7d75f66c8f0dc4ce411fd97d2dc867b39ce8d) Commit: 0d75d93ed7f5a5e8ba079e79eb437ecd5f99487c https://github.com/OpenSIPS/opensips/commit/0d75d93ed7f5a5e8ba079e79eb437ecd5f99487c Author: Liviu Chircu Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M lib/reg/path.c Log Message: ----------- path: Fix leak-on-error (cherry picked from commit 7911d636171f251b18a7d735d8baa9e15474b696) Compare: https://github.com/OpenSIPS/opensips/compare/9a46432a05e3...0d75d93ed7f5 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:23:21 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 24 May 2018 09:23:21 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] adc937: Bump version to 2.4.1 Message-ID: <5b06e6f9cca89_6cc12b16f1ec3c088228@hookshot-fe-6b2eebc.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: adc93740e39ee59b0fc3863563d264b32cd51c22 https://github.com/OpenSIPS/opensips/commit/adc93740e39ee59b0fc3863563d264b32cd51c22 Author: Razvan Crainea Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M Makefile.defs M packaging/debian/changelog M packaging/redhat_fedora/opensips.spec M packaging/solaris/base-pkginfo M packaging/solaris/berkeley-pkginfo M packaging/solaris/carrierroute-pkginfo M packaging/solaris/identity-pkginfo M packaging/solaris/ldap-pkginfo M packaging/solaris/mmgeoip-pkginfo M packaging/solaris/mysql-pkginfo M packaging/solaris/perl-pkginfo M packaging/solaris/pgsql-pkginfo M packaging/solaris/regex-pkginfo M packaging/solaris/snmp-pkginfo M packaging/solaris/tls-pkginfo M packaging/solaris/xmlrpc-pkginfo Log Message: ----------- Bump version to 2.4.1 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:23:24 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 24 May 2018 09:23:24 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6a0904: Bump version to 2.3.4 Message-ID: <5b06e6fc77441_70bd2ac4aad23c0c10192@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 6a09047f39258824130c6522a98b2076714a7fff https://github.com/OpenSIPS/opensips/commit/6a09047f39258824130c6522a98b2076714a7fff Author: Razvan Crainea Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M Makefile.defs M packaging/debian/changelog M packaging/solaris/base-pkginfo M packaging/solaris/berkeley-pkginfo M packaging/solaris/carrierroute-pkginfo M packaging/solaris/identity-pkginfo M packaging/solaris/ldap-pkginfo M packaging/solaris/mmgeoip-pkginfo M packaging/solaris/mysql-pkginfo M packaging/solaris/perl-pkginfo M packaging/solaris/pgsql-pkginfo M packaging/solaris/regex-pkginfo M packaging/solaris/snmp-pkginfo M packaging/solaris/tls-pkginfo M packaging/solaris/xmlrpc-pkginfo Log Message: ----------- Bump version to 2.3.4 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:23:26 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 24 May 2018 09:23:26 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 798e9e: Bump version to 2.2.7 Message-ID: <5b06e6fe15ba4_5b172ad87a97dc047872e@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: 798e9edf4266b61c3256604d404c962e74491e4e https://github.com/OpenSIPS/opensips/commit/798e9edf4266b61c3256604d404c962e74491e4e Author: Razvan Crainea Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M Makefile.defs M packaging/debian/changelog M packaging/freebsd/Makefile R packaging/gentoo/opensips-2.2.6.ebuild A packaging/gentoo/opensips-2.3.7.ebuild M packaging/netbsd/Makefile M packaging/openbsd/Makefile M packaging/redhat_fedora/opensips.spec M packaging/solaris/base-pkginfo M packaging/solaris/berkeley-pkginfo M packaging/solaris/carrierroute-pkginfo M packaging/solaris/identity-pkginfo M packaging/solaris/ldap-pkginfo M packaging/solaris/mmgeoip-pkginfo M packaging/solaris/mysql-pkginfo M packaging/solaris/perl-pkginfo M packaging/solaris/pgsql-pkginfo M packaging/solaris/regex-pkginfo M packaging/solaris/snmp-pkginfo M packaging/solaris/tls-pkginfo M packaging/solaris/xmlrpc-pkginfo Log Message: ----------- Bump version to 2.2.7 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From ionutionita at opensips.org Thu May 24 12:37:05 2018 From: ionutionita at opensips.org (ionutrazvanionita) Date: Thu, 24 May 2018 09:37:05 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0d4823: [siptrace] use bitwise and instead of logical end Message-ID: <5b06ea318bc88_11672af9cbee1c00613e6@hookshot-fe-5a11256.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: 0d4823fef6fdee6befc8a9c915be24d293bcf905 https://github.com/OpenSIPS/opensips/commit/0d4823fef6fdee6befc8a9c915be24d293bcf905 Author: ionutrazvanionita Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M modules/siptrace/siptrace.c Log Message: ----------- [siptrace] use bitwise and instead of logical end (cherry picked from commit 0e8baf4a602af76d30ea5084529f660aaf298fc3) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:38:54 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 24 May 2018 09:38:54 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 1df719: Update changelog for 2.2.7 Message-ID: <5b06ea9e3b37c_649e2aea5a633c14723bf@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: 1df7195a14ec2db9501deec3ec71b6280e3dba83 https://github.com/OpenSIPS/opensips/commit/1df7195a14ec2db9501deec3ec71b6280e3dba83 Author: Razvan Crainea Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M ChangeLog Log Message: ----------- Update changelog for 2.2.7 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:40:38 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 24 May 2018 09:40:38 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] dc2b36: Update ChangeLog for 2.3.4 Message-ID: <5b06eb06adaf7_48002ad454cffc1c11323@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: dc2b360941d355090babf1127b69e31c867f71eb https://github.com/OpenSIPS/opensips/commit/dc2b360941d355090babf1127b69e31c867f71eb Author: Razvan Crainea Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M ChangeLog Log Message: ----------- Update ChangeLog for 2.3.4 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:41:00 2018 From: razvan at opensips.org (Razvan Crainea) Date: Thu, 24 May 2018 09:41:00 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 5d042c: Update ChangeLog for 2.4.1 Message-ID: <5b06eb1cad95a_7882ac741a89c141217b3@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 5d042cffcfa9715d72ac91348905df3dfc9222ef https://github.com/OpenSIPS/opensips/commit/5d042cffcfa9715d72ac91348905df3dfc9222ef Author: Razvan Crainea Date: 2018-05-24 (Thu, 24 May 2018) Changed paths: M ChangeLog Log Message: ----------- Update ChangeLog for 2.4.1 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:41:40 2018 From: razvan at opensips.org (razvancrainea) Date: Thu, 24 May 2018 09:41:40 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] Message-ID: <5b06eb44a53d2_75872ac917b6fc0010845c@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/tags/2.2.7 Home: https://github.com/OpenSIPS/opensips **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:41:51 2018 From: razvan at opensips.org (razvancrainea) Date: Thu, 24 May 2018 09:41:51 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] Message-ID: <5b06eb4fcf0f_1e472af5831b1c0c594cc@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/tags/2.3.4 Home: https://github.com/OpenSIPS/opensips **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Thu May 24 12:42:00 2018 From: razvan at opensips.org (razvancrainea) Date: Thu, 24 May 2018 09:42:00 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] Message-ID: <5b06eb589f42d_64b42b16db1e9c14623f0@hookshot-fe-cace476.cp1-iad.github.net.mail> Branch: refs/tags/2.4.1 Home: https://github.com/OpenSIPS/opensips **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From bogdan at opensips.org Thu May 24 13:17:29 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Thu, 24 May 2018 20:17:29 +0300 Subject: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASE] OpenSIPS 2.2.7, 2.3.4 and 2.4.1 minor releases In-Reply-To: <0d13275a-96b2-e802-33e1-ce2ca72dfd67@opensips.org> References: <0d13275a-96b2-e802-33e1-ce2ca72dfd67@opensips.org> Message-ID: Greetings again! I am glad to announce that our plan was successfully completed : the OpenSIPS minor releases 2.4.1, 2.3.4 and 2.2.7 are now out! After more time of spinning OpenSIPS in production environments we managed to track down and fix various bugs. You can find a full list of changes here: * OpenSIPS 2.4.1 ChangeLog: http://opensips.org/pub/opensips/2.4.1/ChangeLog * OpenSIPS 2.3.4 ChangeLog: http://opensips.org/pub/opensips/2.3.4/ChangeLog * OpenSIPS 2.2.7 ChangeLog: http://opensips.org/pub/opensips/2.2.7/ChangeLog All of these were made possible by with the OpenSIPS community's help, for which we would like to thank you very much! Enjoy riding OpenSIPS! Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com OpenSIPS Summit 2018 http://www.opensips.org/events/Summit-2018Amsterdam On 05/17/2018 01:39 PM, Bogdan-Andrei Iancu wrote: > Greetings! > > A new cycle is about to be complete: OpenSIPS is tortured all over the > worlds; this produces feedback and reports; and this translates into > more fix, in a better stability of the released OpenSIPS versions. > > Shortly, it's time for a new set of minor releases, to officially > incorporate all the fixes in the last months/weeks: OpenSIPS 2.2.7, > 2.3.4 and 2.4.1 > > The new releases are due next week, on Wednesday, May 24th 2018. > > If you have any pending GitHub issues/mailing list bug threads > concerning the mentioned branches, this would be a good time to bump > them! > > Thank you for your contributions to this project! > > Best regards, > -------------- next part -------------- An HTML attachment was scrubbed... URL: From basit.engg at gmail.com Thu May 24 18:33:03 2018 From: basit.engg at gmail.com (Abdul Basit) Date: Fri, 25 May 2018 03:33:03 +0500 Subject: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASE] OpenSIPS 2.2.7, 2.3.4 and 2.4.1 minor releases In-Reply-To: References: <0d13275a-96b2-e802-33e1-ce2ca72dfd67@opensips.org> Message-ID: Congratulations! On Thu, 24 May 2018 10:20 pm Bogdan-Andrei Iancu, wrote: > Greetings again! > > I am glad to announce that our plan was successfully completed : the > OpenSIPS minor releases 2.4.1, 2.3.4 and 2.2.7 are now out! > > After more time of spinning OpenSIPS in production environments we managed > to track down and fix various bugs. You can find a full list of changes > here: > > * OpenSIPS 2.4.1 ChangeLog: > http://opensips.org/pub/opensips/2.4.1/ChangeLog > > * OpenSIPS 2.3.4 ChangeLog: > http://opensips.org/pub/opensips/2.3.4/ChangeLog > > * OpenSIPS 2.2.7 ChangeLog: > http://opensips.org/pub/opensips/2.2.7/ChangeLog > > > All of these were made possible by with the OpenSIPS community's help, for > which we would like to thank you very much! > > Enjoy riding OpenSIPS! > > Bogdan-Andrei Iancu > > OpenSIPS Founder and Developer > http://www.opensips-solutions.com > OpenSIPS Summit 2018 > http://www.opensips.org/events/Summit-2018Amsterdam > > On 05/17/2018 01:39 PM, Bogdan-Andrei Iancu wrote: > > Greetings! > > A new cycle is about to be complete: OpenSIPS is tortured all over the > worlds; this produces feedback and reports; and this translates into more > fix, in a better stability of the released OpenSIPS versions. > > Shortly, it's time for a new set of minor releases, to officially > incorporate all the fixes in the last months/weeks: OpenSIPS 2.2.7, 2.3.4 > and 2.4.1 > > The new releases are due next week, on Wednesday, May 24th 2018. > > If you have any pending GitHub issues/mailing list bug threads concerning > the mentioned branches, this would be a good time to bump them! > > Thank you for your contributions to this project! > > Best regards, > > > _______________________________________________ > Users mailing list > Users at lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sobomax at sippysoft.com Thu May 24 22:12:42 2018 From: sobomax at sippysoft.com (Maxim Sobolev) Date: Thu, 24 May 2018 19:12:42 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASE] OpenSIPS 2.2.7, 2.3.4 and 2.4.1 minor releases In-Reply-To: <779088130.1029375.1527213384735@mail.yahoo.com> References: <0d13275a-96b2-e802-33e1-ce2ca72dfd67@opensips.org> <779088130.1029375.1527213384735@mail.yahoo.com> Message-ID: Good job, OpenSIPS team! -Max On Thu, May 24, 2018 at 6:56 PM, Pasan Meemaduma via Users < users at lists.opensips.org> wrote: > Congratz :) > > > On Thursday, 24 May 2018, 10:48:24 PM GMT+5:30, Bogdan-Andrei Iancu < > bogdan at opensips.org> wrote: > > > Greetings again! > > I am glad to announce that our plan was successfully completed : the > OpenSIPS minor releases 2.4.1, 2.3.4 and 2.2.7 are now out! > > After more time of spinning OpenSIPS in production environments we managed > to track down and fix various bugs. You can find a full list of changes > here: > > * OpenSIPS 2.4.1 ChangeLog: http://opensips.org/pub/ > opensips/2.4.1/ChangeLog > > * OpenSIPS 2.3.4 ChangeLog: http://opensips.org/pub/ > opensips/2.3.4/ChangeLog > > * OpenSIPS 2.2.7 ChangeLog: http://opensips.org/pub/ > opensips/2.2.7/ChangeLog > > > All of these were made possible by with the OpenSIPS community's help, for > which we would like to thank you very much! > > Enjoy riding OpenSIPS! > > Bogdan-Andrei Iancu > > OpenSIPS Founder and Developer > http://www.opensips-solutions.com > OpenSIPS Summit 2018 > http://www.opensips.org/events/Summit-2018Amsterdam > > On 05/17/2018 01:39 PM, Bogdan-Andrei Iancu wrote: > > Greetings! > > A new cycle is about to be complete: OpenSIPS is tortured all over the > worlds; this produces feedback and reports; and this translates into more > fix, in a better stability of the released OpenSIPS versions. > > Shortly, it's time for a new set of minor releases, to officially > incorporate all the fixes in the last months/weeks: OpenSIPS 2.2.7, 2.3.4 > and 2.4.1 > > The new releases are due next week, on Wednesday, May 24th 2018. > > If you have any pending GitHub issues/mailing list bug threads concerning > the mentioned branches, this would be a good time to bump them! > > Thank you for your contributions to this project! > > Best regards, > > > _______________________________________________ > Users mailing list > Users at lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > _______________________________________________ > Users mailing list > Users at lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users > > -- Maksym Sobolyev Sippy Software, Inc. Internet Telephony (VoIP) Experts Tel (Canada): +1-778-783-0474 Tel (Toll-Free): +1-855-747-7779 Fax: +1-866-857-6942 Web: http://www.sippysoft.com MSN: sales at sippysoft.com Skype: SippySoft -------------- next part -------------- An HTML attachment was scrubbed... URL: From bogdan at opensips.org Fri May 25 03:42:34 2018 From: bogdan at opensips.org (Bogdan-Andrei Iancu) Date: Fri, 25 May 2018 10:42:34 +0300 Subject: [OpenSIPS-Devel] [OpenSIPS-Users] [RELEASE] OpenSIPS 2.2.7, 2.3.4 and 2.4.1 minor releases In-Reply-To: References: <0d13275a-96b2-e802-33e1-ce2ca72dfd67@opensips.org> Message-ID: <07849697-be7d-5085-947a-20ea653bae43@opensips.org> It seems I'm not doing such a good job in writing email....I prefer code, to be honest ;) There is a an error, a copy paste error (of course), in the Changelog links. The correct ones are : * OpenSIPS 2.4.1 ChangeLog: http://opensips.org/pub/opensips/2.4.1/ChangeLog * OpenSIPS 2.3.4 ChangeLog: http://opensips.org/pub/opensips/2.3.4/ChangeLog * OpenSIPS 2.2.7 ChangeLog: http://opensips.org/pub/opensips/2.2.7/ChangeLog Regards, Bogdan-Andrei Iancu OpenSIPS Founder and Developer http://www.opensips-solutions.com OpenSIPS Summit 2018 http://www.opensips.org/events/Summit-2018Amsterdam On 05/24/2018 08:17 PM, Bogdan-Andrei Iancu wrote: > Greetings again! > > I am glad to announce that our plan was successfully completed : the > OpenSIPS minor releases 2.4.1, 2.3.4 and 2.2.7 are now out! > > After more time of spinning OpenSIPS in production environments we > managed to track down and fix various bugs. You can find a full list > of changes here: > > * OpenSIPS 2.4.1 ChangeLog: > http://opensips.org/pub/opensips/2.4.1/ChangeLog > * OpenSIPS 2.3.4 ChangeLog: > http://opensips.org/pub/opensips/2.3.4/ChangeLog > * OpenSIPS 2.2.7 ChangeLog: > http://opensips.org/pub/opensips/2.2.7/ChangeLog > > All of these were made possible by with the OpenSIPS community's help, > for which we would like to thank you very much! > > Enjoy riding OpenSIPS! > Bogdan-Andrei Iancu > > OpenSIPS Founder and Developer > http://www.opensips-solutions.com > OpenSIPS Summit 2018 > http://www.opensips.org/events/Summit-2018Amsterdam > On 05/17/2018 01:39 PM, Bogdan-Andrei Iancu wrote: >> Greetings! >> >> A new cycle is about to be complete: OpenSIPS is tortured all over >> the worlds; this produces feedback and reports; and this translates >> into more fix, in a better stability of the released OpenSIPS versions. >> >> Shortly, it's time for a new set of minor releases, to officially >> incorporate all the fixes in the last months/weeks: OpenSIPS 2.2.7, >> 2.3.4 and 2.4.1 >> >> The new releases are due next week, on Wednesday, May 24th 2018. >> >> If you have any pending GitHub issues/mailing list bug threads >> concerning the mentioned branches, this would be a good time to bump >> them! >> >> Thank you for your contributions to this project! >> >> Best regards, >> > > > > _______________________________________________ > Users mailing list > Users at lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/users -------------- next part -------------- An HTML attachment was scrubbed... URL: From liviu at opensips.org Fri May 25 04:20:12 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 25 May 2018 01:20:12 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 6e0ec1: path: Add escaping logic for add_path_received() Message-ID: <5b07c73c6f7f0_ac72ac1daaffc145542f@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 6e0ec1f7bae4b5a5076fce445d28ba1cbf790feb https://github.com/OpenSIPS/opensips/commit/6e0ec1f7bae4b5a5076fce445d28ba1cbf790feb Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/path.c M lib/path.h M lib/reg/path.c M modules/path/path.c Log Message: ----------- path: Add escaping logic for add_path_received() Simply dumping a SIP URI as a ";received=" Path header field parameter value is problematic and leads to two kinds of issues: a. invalid SIP URIs, where the ";transport=" is specified twice: Path: b. in double Path scenarios (e.g. when switching protocols from, say, TCP -> UDP), since the ";received=" is inserted as the inbound Path header field value, this can lead to a strange "protocol conversion" effect: Path: Path: ^ notice how the inbound Path intended to advertise an UDP URI, but the add_path_received() managed to "convert" it into a TCP URI because of its inability to escape its token. nathelper is an easy first victim of this conversion, as it will attempt to send pings using the incorrect transport after reading the topmost Path (Route) header. This patch adds escaping/unescaping logic for the ";received=" feature of add_path_received() along with any code that makes use of this feature. Example resulting URI for the above example: Path: (cherry picked from commit b3bf15646affe981d4b266381d59f210e6e882fd) Commit: 109f7dace65d8e0c87c9a025e8f434768fd52b5f https://github.com/OpenSIPS/opensips/commit/109f7dace65d8e0c87c9a025e8f434768fd52b5f Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/path.c M lib/reg/path.c Log Message: ----------- path: Fix "use_path_received" in double-Path scenarios Due to the fact that run_rr_callbacks() returns the 2nd Route (Path) header field value when previously having done protocol switching (thus having inserted two Path headers), the "use_path_received" feature of the path module would not work -- it wouldn't set the $du at all. The reason for this is that add_path_received() appends its ";received=" to inside Path #1 (the outbound path of the registration / the inbound path of future requests) when doing double-Path recording. This patch simply moves the ";received=" append operation performed by add_path_received() into Path #2 (inbound path of registration / outbound path of future requests), and adapts other code that needs it (e.g. save("location", "p1v")) to properly be able to fetch it. Reported by @futsystems Fixes #1358 (cherry picked from commit 71c7d75f66c8f0dc4ce411fd97d2dc867b39ce8d) Compare: https://github.com/OpenSIPS/opensips/compare/dc2b360941d3...109f7dace65d **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 25 04:41:33 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 25 May 2018 01:41:33 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] eed7a5: path: Add escaping logic for add_path_received() Message-ID: <5b07cc3d5a4d9_44c32acee2de1c106355@hookshot-fe-da92815.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: eed7a5019411b5061325488d6026ada77e45997b https://github.com/OpenSIPS/opensips/commit/eed7a5019411b5061325488d6026ada77e45997b Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/path/path.c M modules/registrar/path.c Log Message: ----------- path: Add escaping logic for add_path_received() Simply dumping a SIP URI as a ";received=" Path header field parameter value is problematic and leads to two kinds of issues: a. invalid SIP URIs, where the ";transport=" is specified twice: Path: b. in double Path scenarios (e.g. when switching protocols from, say, TCP -> UDP), since the ";received=" is inserted as the inbound Path header field value, this can lead to a strange "protocol conversion" effect: Path: Path: ^ notice how the inbound Path intended to advertise an UDP URI, but the add_path_received() managed to "convert" it into a TCP URI because of its inability to escape its token. nathelper is an easy first victim of this conversion, as it will attempt to send pings using the incorrect transport after reading the topmost Path (Route) header. This patch adds escaping/unescaping logic for the ";received=" feature of add_path_received() along with any code that makes use of this feature. Example resulting URI for the above example: Path: (cherry picked from commit b3bf15646affe981d4b266381d59f210e6e882fd) (cherry picked from commit 6e0ec1f7bae4b5a5076fce445d28ba1cbf790feb) Commit: 34751fecf17a67da5626ea1cc8c58b345b350df9 https://github.com/OpenSIPS/opensips/commit/34751fecf17a67da5626ea1cc8c58b345b350df9 Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/path/path.c M modules/registrar/path.c Log Message: ----------- path: Fix "use_path_received" in double-Path scenarios Due to the fact that run_rr_callbacks() returns the 2nd Route (Path) header field value when previously having done protocol switching (thus having inserted two Path headers), the "use_path_received" feature of the path module would not work -- it wouldn't set the $du at all. The reason for this is that add_path_received() appends its ";received=" to inside Path #1 (the outbound path of the registration / the inbound path of future requests) when doing double-Path recording. This patch simply moves the ";received=" append operation performed by add_path_received() into Path #2 (inbound path of registration / outbound path of future requests), and adapts other code that needs it (e.g. save("location", "p1v")) to properly be able to fetch it. Reported by @futsystems Fixes #1358 (cherry picked from commit 71c7d75f66c8f0dc4ce411fd97d2dc867b39ce8d) (cherry picked from commit 109f7dace65d8e0c87c9a025e8f434768fd52b5f) Compare: https://github.com/OpenSIPS/opensips/compare/1df7195a14ec...34751fecf17a **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 25 04:53:29 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 25 May 2018 01:53:29 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 636a74: path: Fix buffer overflow with use_path_received +... Message-ID: <5b07cf0912634_5d5e2b162684dc1442398@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 636a7420072b90c21bd3073b2c2bad6b375284ea https://github.com/OpenSIPS/opensips/commit/636a7420072b90c21bd3073b2c2bad6b375284ea Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/path.c Log Message: ----------- path: Fix buffer overflow with use_path_received + IPv6 Introduced in commit b3bf15646a **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 25 04:54:10 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 25 May 2018 01:54:10 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 9ea5dd: path: Fix buffer overflow with use_path_received +... Message-ID: <5b07cf3268098_68872addcf49bc04637f9@hookshot-fe-265448d.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 9ea5ddbada4f6fd8e32dbdb296af6e42f72d802a https://github.com/OpenSIPS/opensips/commit/9ea5ddbada4f6fd8e32dbdb296af6e42f72d802a Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/path.c Log Message: ----------- path: Fix buffer overflow with use_path_received + IPv6 Introduced in commit b3bf15646a (cherry picked from commit 636a7420072b90c21bd3073b2c2bad6b375284ea) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 25 04:54:53 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 25 May 2018 01:54:53 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0ea6f1: path: Fix buffer overflow with use_path_received +... Message-ID: <5b07cf5d4c083_2d62ae245c7dc0479053@hookshot-fe-88eb02d.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 0ea6f10905bdba186e56c666cc27551f6b2109d0 https://github.com/OpenSIPS/opensips/commit/0ea6f10905bdba186e56c666cc27551f6b2109d0 Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M lib/path.c Log Message: ----------- path: Fix buffer overflow with use_path_received + IPv6 Introduced in commit b3bf15646a (cherry picked from commit 636a7420072b90c21bd3073b2c2bad6b375284ea) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From liviu at opensips.org Fri May 25 04:55:52 2018 From: liviu at opensips.org (Liviu Chircu) Date: Fri, 25 May 2018 01:55:52 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] f07dc2: path: Fix buffer overflow with use_path_received +... Message-ID: <5b07cf98d0d65_17132ab7ce151c004966@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/2.2 Home: https://github.com/OpenSIPS/opensips Commit: f07dc2a6515c3f922532667679302c5332920d2d https://github.com/OpenSIPS/opensips/commit/f07dc2a6515c3f922532667679302c5332920d2d Author: Liviu Chircu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/path/path.c Log Message: ----------- path: Fix buffer overflow with use_path_received + IPv6 Introduced in commit b3bf15646a (cherry picked from commit 636a7420072b90c21bd3073b2c2bad6b375284ea) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 29 13:03:53 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 29 May 2018 10:03:53 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 0e96be: clusterer docs: reorder module parameters Message-ID: <5b0d87f985d3b_bcd2ab9103bfc10759ba@hookshot-fe-b0febf1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 0e96bedc9ea890c2e529ee2c6b14081488a67c06 https://github.com/OpenSIPS/opensips/commit/0e96bedc9ea890c2e529ee2c6b14081488a67c06 Author: Vlad Patrascu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/clusterer/README M modules/clusterer/doc/clusterer_admin.xml Log Message: ----------- clusterer docs: reorder module parameters Commit: ea3745a7fd2e9ff068b7110c431948a26be068ab https://github.com/OpenSIPS/opensips/commit/ea3745a7fd2e9ff068b7110c431948a26be068ab Author: Vlad Patrascu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/clusterer/clusterer_mod.c M modules/clusterer/node_info.c Log Message: ----------- clusterer: decrease risk of bogus provisioning of your own node ID Setting your own node ID is now possible in both current_info and current_id parameters. Also throw more errors on inconsistent provisioning of these parameters. Commit: b7a2765e3e1eabcce3487be3b06a12ba14d7f7ab https://github.com/OpenSIPS/opensips/commit/b7a2765e3e1eabcce3487be3b06a12ba14d7f7ab Author: Vlad Patrascu Date: 2018-05-29 (Tue, 29 May 2018) Changed paths: M modules/clusterer/README M modules/clusterer/clusterer.c M modules/clusterer/clusterer_mod.c M modules/clusterer/doc/clusterer_admin.xml M modules/clusterer/node_info.c Log Message: ----------- clusterer: rename node specification module parameters "current_id", "current_info" and "neigbor_info" parameters are renamed to "my_node_id", "my_node_info" and "neighbor_node_info". Compare: https://github.com/OpenSIPS/opensips/compare/636a7420072b...b7a2765e3e1e **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From vladp at opensips.org Tue May 29 13:04:58 2018 From: vladp at opensips.org (Vlad Patrascu) Date: Tue, 29 May 2018 10:04:58 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 600748: clusterer docs: reorder module parameters Message-ID: <5b0d883a33b26_3b3e2ac5fd8efc18951a4@hookshot-fe-7191cb1.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: 600748bb09bcac0fc33c2b1e14b11ab495ea9954 https://github.com/OpenSIPS/opensips/commit/600748bb09bcac0fc33c2b1e14b11ab495ea9954 Author: Vlad Patrascu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/clusterer/README M modules/clusterer/doc/clusterer_admin.xml Log Message: ----------- clusterer docs: reorder module parameters (cherry picked from commit 0e96bedc9ea890c2e529ee2c6b14081488a67c06) Commit: 2304d33f317249cabaa17f7ad6ac42bb3b03beb0 https://github.com/OpenSIPS/opensips/commit/2304d33f317249cabaa17f7ad6ac42bb3b03beb0 Author: Vlad Patrascu Date: 2018-05-25 (Fri, 25 May 2018) Changed paths: M modules/clusterer/clusterer_mod.c M modules/clusterer/node_info.c Log Message: ----------- clusterer: decrease risk of bogus provisioning of your own node ID Setting your own node ID is now possible in both current_info and current_id parameters. Also throw more errors on inconsistent provisioning of these parameters. (cherry picked from commit ea3745a7fd2e9ff068b7110c431948a26be068ab) Compare: https://github.com/OpenSIPS/opensips/compare/9ea5ddbada4f...2304d33f3172 **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From Adam.Overbeeke at genesys.com Tue May 29 17:35:43 2018 From: Adam.Overbeeke at genesys.com (Adam Overbeeke) Date: Tue, 29 May 2018 21:35:43 +0000 Subject: [OpenSIPS-Devel] ACC - CDR creation - 1.11 vs 2.3 Message-ID: Hi, I would like to request an update to the acc’s module documentation and database schema. I just found out that the database keys for cdr changed between opensisp versions 1.11 and 2.3. Keys are as followed: setuptime, created, duration, ms_duration. Only in the source code did I find the difference. I suggest that the order be updated in the documentation to match the code. Please add a statement in the upgrade doc too. Thanks, Adam -------------- next part -------------- An HTML attachment was scrubbed... URL: From razvan at opensips.org Wed May 30 03:41:42 2018 From: razvan at opensips.org (=?UTF-8?Q?R=c4=83zvan_Crainea?=) Date: Wed, 30 May 2018 10:41:42 +0300 Subject: [OpenSIPS-Devel] ACC - CDR creation - 1.11 vs 2.3 In-Reply-To: References: Message-ID: <69d131e3-73f6-ce0e-f50c-b529e6dc380c@opensips.org> Hi, Adam! Did you take a look at the database schemas between the two versions[1][2]? I don't think these changes should be in the documentation, they should probably be in the migration tutorial[3]. However, we recommend you to use the official/supported tool for migrating the database: the 'opensipsdbctl migration' tool which should take care of this automatically for you. [1] http://www.opensips.org/Documentation/Install-DBSchema-1-11#AEN21 [2] http://www.opensips.org/Documentation/Install-DBSchema-2-4#AEN21 [3] http://www.opensips.org/Documentation/Migration Best regards, Răzvan On 05/30/2018 12:35 AM, Adam Overbeeke wrote: > Hi, > > I would like to request an update to the acc’s module documentation and > database schema. I just found out that the database keys for cdr changed > between opensisp versions 1.11 and 2.3. Keys are as followed: setuptime, > created, duration, ms_duration. Only in the source code did I find the > difference. I suggest that the order be updated in the documentation to > match the code. Please add a statement in the upgrade doc too. > > Thanks, > > Adam > > > > _______________________________________________ > Devel mailing list > Devel at lists.opensips.org > http://lists.opensips.org/cgi-bin/mailman/listinfo/devel > -- Răzvan Crainea OpenSIPS Core Developer http://www.opensips-solutions.com From razvan at opensips.org Wed May 30 06:01:08 2018 From: razvan at opensips.org (Razvan Crainea) Date: Wed, 30 May 2018 03:01:08 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] b044f1: acc: fix possible deadlock when evi set is faulty Message-ID: <5b0e7664a7284_da32abe83d9dc0012232@hookshot-fe-d252ca1.cp1-iad.github.net.mail> Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: b044f11ee1a45d2696c5d03ece4a524b1e9861c9 https://github.com/OpenSIPS/opensips/commit/b044f11ee1a45d2696c5d03ece4a524b1e9861c9 Author: Razvan Crainea Date: 2018-05-30 (Wed, 30 May 2018) Changed paths: M modules/acc/acc.c Log Message: ----------- acc: fix possible deadlock when evi set is faulty this error is very unlikely to trigger **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Wed May 30 06:01:25 2018 From: razvan at opensips.org (Razvan Crainea) Date: Wed, 30 May 2018 03:01:25 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] ae78b1: acc: fix possible deadlock when evi set is faulty Message-ID: <5b0e767561de0_1b632ac3e046dc186982f@hookshot-fe-2cc8887.cp1-iad.github.net.mail> Branch: refs/heads/2.4 Home: https://github.com/OpenSIPS/opensips Commit: ae78b129d04ceee05a9b15f6267de04a367c8cea https://github.com/OpenSIPS/opensips/commit/ae78b129d04ceee05a9b15f6267de04a367c8cea Author: Razvan Crainea Date: 2018-05-30 (Wed, 30 May 2018) Changed paths: M modules/acc/acc.c Log Message: ----------- acc: fix possible deadlock when evi set is faulty this error is very unlikely to trigger (cherry picked from commit b044f11ee1a45d2696c5d03ece4a524b1e9861c9) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From razvan at opensips.org Wed May 30 06:01:45 2018 From: razvan at opensips.org (Razvan Crainea) Date: Wed, 30 May 2018 03:01:45 -0700 Subject: [OpenSIPS-Devel] [OpenSIPS/opensips] 4e09e5: acc: fix possible deadlock when evi set is faulty Message-ID: <5b0e76896a91c_6c102af4aa285c0c996f0@hookshot-fe-31feec6.cp1-iad.github.net.mail> Branch: refs/heads/2.3 Home: https://github.com/OpenSIPS/opensips Commit: 4e09e5f81bc251f71a6c88200026901f3b57fae7 https://github.com/OpenSIPS/opensips/commit/4e09e5f81bc251f71a6c88200026901f3b57fae7 Author: Razvan Crainea Date: 2018-05-30 (Wed, 30 May 2018) Changed paths: M modules/acc/acc.c Log Message: ----------- acc: fix possible deadlock when evi set is faulty this error is very unlikely to trigger (cherry picked from commit b044f11ee1a45d2696c5d03ece4a524b1e9861c9) **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019. From Adam.Overbeeke at genesys.com Wed May 30 08:08:00 2018 From: Adam.Overbeeke at genesys.com (Adam Overbeeke) Date: Wed, 30 May 2018 12:08:00 +0000 Subject: [OpenSIPS-Devel] ACC - CDR creation - 1.11 vs 2.3 Message-ID: <532D9227-589A-47D8-8EA8-192F1E5B1DB6@contoso.com> Hi Răzvan, Thank you for the reply. The issues is the lack of documentation for a specific commit. Here is the current `List of DB changes` for version 1.11 – 2.1: * acc, missed_calls table - NEW columns: "created" and "setuptime" (94cf5dd) This commit (94cf5dd) has a ‘breaking change’ / ‘undocumented change’ in it. Someone changed the order of acc_duration_col in the db_keys array. Here is the actual commit and line. https://github.com/OpenSIPS/opensips/commit/94cf5dd41ce01e9b1d05cb8634dd5cec5fdf0af6#diff-1394446c130358846c82519a3990ad36L479 This switching of the order was not documented and caused errors in our account system. Thanks, Adam -------------- next part -------------- An HTML attachment was scrubbed... URL: From Adam.Overbeeke at genesys.com Wed May 30 08:11:38 2018 From: Adam.Overbeeke at genesys.com (Adam Overbeeke) Date: Wed, 30 May 2018 12:11:38 +0000 Subject: [OpenSIPS-Devel] ACC - CDR creation - 1.11 vs 2.3 Message-ID: <105CDAD5-230F-4D0F-9672-1DC46474309F@genesys.com> Hi Răzvan, Thank you for the reply. The issues is the lack of documentation for a specific commit. Here is the current `List of DB changes` for version 1.11 – 2.1: * acc, missed_calls table - NEW columns: "created" and "setuptime" (94cf5dd) This commit (94cf5dd) has a ‘breaking change’ / ‘undocumented change’ in it. Someone changed the order of acc_duration_col in the db_keys array. Here is the actual commit and line. https://github.com/OpenSIPS/opensips/commit/94cf5dd41ce01e9b1d05cb8634dd5cec5fdf0af6#diff-1394446c130358846c82519a3990ad36L479 This switching of the order was not documented and caused errors in our account system. Thanks, Adam PS. What is the best way to reply to these mailing lists? Should I just send the reply back to the devel list or should I send them directly to the responder? -------------- next part -------------- An HTML attachment was scrubbed... URL: From razvan at opensips.org Thu May 31 03:23:16 2018 From: razvan at opensips.org (=?UTF-8?Q?R=c4=83zvan_Crainea?=) Date: Thu, 31 May 2018 10:23:16 +0300 Subject: [OpenSIPS-Devel] ACC - CDR creation - 1.11 vs 2.3 In-Reply-To: <105CDAD5-230F-4D0F-9672-1DC46474309F@genesys.com> References: <105CDAD5-230F-4D0F-9672-1DC46474309F@genesys.com> Message-ID: Hi, Adam! I agree we should have better documented the fields change, and the commit you pointed out is one of the changes that have impact to the structure of the records: i.e. if you are using db_flatstore, than the order of the fields will change. Thank you for pointing this out, we will try to pay more attention when things like this happen, and document them properly. Best regards, Răzvan On 05/30/2018 03:11 PM, Adam Overbeeke wrote: > Hi Răzvan, > > /Thank you for the reply. The issues is the lack of documentation for a > specific commit. Here is the current `List of DB changes` for version > 1.11 – 2.1: / > > * /acc/,*missed_calls*table - NEW columns: "created" and "setuptime" > (*94cf5dd* ) > > This commit (*94cf5dd* > )has a ‘breaking > change’ / ‘undocumented change’ in it. Someone changed the order of > acc_duration_col in the db_keys array. Here is the actual commit and line. > > https://github.com/OpenSIPS/opensips/commit/94cf5dd41ce01e9b1d05cb8634dd5cec5fdf0af6#diff-1394446c130358846c82519a3990ad36L479 > > This switching of the order was not documented and caused errors in our > account system. > > Thanks, > > Adam > > PS. What is the best way to reply to these mailing lists? Should I just > send the reply back to the devel list or should I send them directly to > the responder? > -- Răzvan Crainea OpenSIPS Core Developer http://www.opensips-solutions.com