[OpenSIPS-Devel] [OpenSIPS/opensips] c38edd: dialog: Refactor dlg_leg.sdp and dlg_leg.th_sent_c...

[Liviu Chircu]

  Branch: refs/heads/2.3
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c38eddac973a193c9d99bca229393c35cbe2bb42
      https://github.com/OpenSIPS/opensips/commit/c38eddac973a193c9d99bca229393c35cbe2bb42
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_timer.c

  Log Message:
  -----------
  dialog: Refactor dlg_leg.sdp and dlg_leg.th_sent_contact

These fields are only relevant for dialog pinging and they behave
similarly, so their naming should reflect this.

(cherry picked from commit 287ce6f545e342d9239359eb78834c9272b80e26)
(cherry picked from commit 816cf6e0778d3669ca5c7ddcaec62888d3631298)


  Commit: 9ef7e1d5b5d384559fb175e6e73756009d49a202
      https://github.com/OpenSIPS/opensips/commit/9ef7e1d5b5d384559fb175e6e73756009d49a202
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_hash.c
    M modules/dialog/dlg_hash.h
    M modules/dialog/dlg_timer.c

  Log Message:
  -----------
  dialog: Properly store all downstream forked legs

Commit a03ed4e1a36 over-simplified the downstream leg identification,
assuming that there is a 1:1 correspondence between outgoing branches
and unique replies to them.  This is not the case: as a proxy, we may
receive multiple responses (read: "To" tags) for each individual branch
we fork out.  This misconception would also cause SHM to leak.

We fix the above limitation by cloning a new dialog leg each time we
detect downstream forking of our outgoing branches.

Thanks to Bogdan for pointing out this problem

(cherry picked from commit 67b29011127a53fe53c8bd19efc2373b2978f4f2)


  Commit: 837e0dda2ae1633d5a924542a77857f959305283
      https://github.com/OpenSIPS/opensips/commit/837e0dda2ae1633d5a924542a77857f959305283
  Author: Liviu Chircu <liviu at opensips.org>
  Date:   2018-06-22 (Fri, 22 Jun 2018)

  Changed paths:
    M modules/dialog/dlg_db_handler.c
    M modules/dialog/dlg_handlers.c

  Log Message:
  -----------
  dialog: Do some code maintenance

    * add macro for reinvite pinging detection
    * fix clang compile warnings

(cherry picked from commit cabac7d4add383114176fd9581a01177fd20e7e8)
(cherry picked from commit d63ce297892254ccbc04ca253ca3c6d993144938)


Compare: https://github.com/OpenSIPS/opensips/compare/423d6907c90d...837e0dda2ae1
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.