[OpenSIPS-Devel] [OpenSIPS/opensips] c58471: Fix reverse_hex2int() prototype

Bogdan-Andrei Iancu bogdan at opensips.org
Mon Feb 5 04:35:27 EST 2018


  Branch: refs/heads/2.2
  Home:   https://github.com/OpenSIPS/opensips
  Commit: c584715b5de30fd975e34f20939ba34e21dff228
      https://github.com/OpenSIPS/opensips/commit/c584715b5de30fd975e34f20939ba34e21dff228
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-02-05 (Mon, 05 Feb 2018)

  Changed paths:
    M forward.c
    M modules/dialog/dlg_handlers.c
    M modules/dialog/dlg_handlers.h
    M modules/nathelper/sip_pinger.h
    M modules/tm/t_lookup.c
    M ut.h

  Log Message:
  -----------
  Fix reverse_hex2int() prototype

As the computed value is an unsigned (as data size), it cannot be returned as int as it will overflow and get converted to a negative value. This will colide with the negative error ret code -1
Reported by Daniel Zanutti.

(cherry picked from commit 095dc57300b9665b090e999a540db8b391f8d22e)


  Commit: 1004b73bba32cbdcf527ca790fd555bb7b90869d
      https://github.com/OpenSIPS/opensips/commit/1004b73bba32cbdcf527ca790fd555bb7b90869d
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-02-05 (Mon, 05 Feb 2018)

  Changed paths:
    M forward.c

  Log Message:
  -----------
  Explicit reset of conn ID on error

if reverse_hex2int fails, be sure the conn id stays 0.

(cherry picked from commit a61fa8646e6f865b347b3e725c6362dc15d4e57b)


  Commit: bfec5afe2df72fe4bab213d5ea0f4d1b59fd9e69
      https://github.com/OpenSIPS/opensips/commit/bfec5afe2df72fe4bab213d5ea0f4d1b59fd9e69
  Author: Bogdan-Andrei Iancu <bogdan at opensips.org>
  Date:   2018-02-05 (Mon, 05 Feb 2018)

  Changed paths:
    M modules/nathelper/sip_pinger.h
    M ut.h

  Log Message:
  -----------
  Fix reverse_hex2int64() prototype

As the computed value is an unsigned (as data size), it cannot be returned as int as it will overflow and get converted to a negative value. This will colide with the negative error ret code -1

(cherry picked from commit ed12eb97c06a23491c8b831124600361b0b63f2f)


Compare: https://github.com/OpenSIPS/opensips/compare/2a3c1c8b25c1...bfec5afe2df7


More information about the Devel mailing list